BlueGit

timfa bluegit

Releases en release-assets verwijderen (API, bg, UI met eigen modal, i18n, docs, tests)

timfa Tim Falken · pushed by timfa

Authored 2026-10-25 · 3 weeks ago

Hash
45e04e7ceffb9c9ee55d6489406dc82ba5403d3c
Parent
e8b73e16
Pipeline
Passed
10 files changed +362 −3
docs/agents.md +10 −0
@@ -146,6 +146,16 @@ bg admin grant bob
146 146 bg admin revoke bob
147 147 ```
148 148
149 ## Releases en assets verwijderen
150
151 ```sh
152 bg release delete-asset timfa/app v1.2.0 app-linux.tar.gz # één bestand; release, tag en broncode blijven
153 bg release delete timfa/app v1.2.0 # release met alle bestanden; git-tag blijft
154 bg release delete timfa/app v1.2.0 --delete-tag # ook de git-tag weg
155 ```
156
157 API: `DELETE /api/v1/projects/{owner}/{repo}/releases/{tag}/assets/{naam}` en `DELETE /api/v1/projects/{owner}/{repo}/releases/{tag}[?delete_tag=true]`, beide `204`. Alleen eigenaar, maintainer of instance-admin; zonder token `401`, niet zichtbaar `404`, te weinig rechten `403`, onbekende release of asset `404`. De bestanden gaan ook van schijf. In de UI staan de knoppen op de Releases-pagina, met een bevestiging.
158
149 159 ## Zichtbaarheid van releases
150 160
151 161 Releases hebben een eigen zichtbaarheid naast die van de repo: `inherit` (zelfde als de repo, standaard), `private` of `public`. Instellen kan via Instellingen van de repo, of via:
@@ -146,6 +146,16 @@ bg admin grant bob
146bg admin revoke bob
146bg admin revoke bob
147```
147```
148
148
149## Releases en assets verwijderen
150
151```sh
152bg release delete-asset timfa/app v1.2.0 app-linux.tar.gz # één bestand; release, tag en broncode blijven
153bg release delete timfa/app v1.2.0 # release met alle bestanden; git-tag blijft
154bg release delete timfa/app v1.2.0 --delete-tag # ook de git-tag weg
155```
156
157API: `DELETE /api/v1/projects/{owner}/{repo}/releases/{tag}/assets/{naam}` en `DELETE /api/v1/projects/{owner}/{repo}/releases/{tag}[?delete_tag=true]`, beide `204`. Alleen eigenaar, maintainer of instance-admin; zonder token `401`, niet zichtbaar `404`, te weinig rechten `403`, onbekende release of asset `404`. De bestanden gaan ook van schijf. In de UI staan de knoppen op de Releases-pagina, met een bevestiging.
158
149## Zichtbaarheid van releases
159## Zichtbaarheid van releases
150
160
151Releases hebben een eigen zichtbaarheid naast die van de repo: `inherit` (zelfde als de repo, standaard), `private` of `public`. Instellen kan via Instellingen van de repo, of via:
161Releases hebben een eigen zichtbaarheid naast die van de repo: `inherit` (zelfde als de repo, standaard), `private` of `public`. Instellen kan via Instellingen van de repo, of via:
internal/i18n/catalog.go +11 −2
@@ -284,8 +284,17 @@ var en = map[string]string{
284 284 "mail.fail.jobs": "Failed jobs",
285 285 "mail.fail.open": "Open the pipeline",
286 286
287 "rel.none": "No releases yet.",
288 "rel.bytes": "bytes",
287 "rel.none": "No releases yet.",
288 "rel.delete": "Delete release",
289 "rel.deleteAsset": "Delete",
290 "rel.deleteAsk": "Delete release %s and all its files? The source code stays.",
291 "rel.deleteAssetAsk": "Delete file %s from this release? The tag and source code stay.",
292 "rel.deleteTag": "Also delete the git tag",
293 "rel.deleted": "Release deleted.",
294 "rel.assetDeleted": "File deleted.",
295 "rel.tip.delete": "Removes the release and its files from the server. The git tag stays unless you tick the box.",
296 "rel.tip.deleteAsset": "Removes only this file. The release, tag and source code stay.",
297 "rel.bytes": "bytes",
289 298
290 299 "set.onlyAdmin": "Only a maintainer changes settings, secrets and webhooks. Your role: %s.",
291 300 "set.general": "General",
@@ -284,8 +284,17 @@ var en = map[string]string{
284 "mail.fail.jobs": "Failed jobs",
284 "mail.fail.jobs": "Failed jobs",
285 "mail.fail.open": "Open the pipeline",
285 "mail.fail.open": "Open the pipeline",
286
286
287 "rel.none": "No releases yet.",
287 "rel.none": "No releases yet.",
288 "rel.bytes": "bytes",
288 "rel.delete": "Delete release",
289 "rel.deleteAsset": "Delete",
290 "rel.deleteAsk": "Delete release %s and all its files? The source code stays.",
291 "rel.deleteAssetAsk": "Delete file %s from this release? The tag and source code stay.",
292 "rel.deleteTag": "Also delete the git tag",
293 "rel.deleted": "Release deleted.",
294 "rel.assetDeleted": "File deleted.",
295 "rel.tip.delete": "Removes the release and its files from the server. The git tag stays unless you tick the box.",
296 "rel.tip.deleteAsset": "Removes only this file. The release, tag and source code stay.",
297 "rel.bytes": "bytes",
289
298
290 "set.onlyAdmin": "Only a maintainer changes settings, secrets and webhooks. Your role: %s.",
299 "set.onlyAdmin": "Only a maintainer changes settings, secrets and webhooks. Your role: %s.",
291 "set.general": "General",
300 "set.general": "General",
internal/i18n/catalog_lang.go +27 −0
@@ -290,6 +290,15 @@ var nl = map[string]string{
290 290 "mail.fail.jobs": "Mislukte jobs",
291 291 "mail.fail.open": "Open de pipeline",
292 292 "rel.none": "Nog geen releases.",
293 "rel.delete": "Release verwijderen",
294 "rel.deleteAsset": "Verwijderen",
295 "rel.deleteAsk": "Release %s met alle bestanden verwijderen? De broncode blijft.",
296 "rel.deleteAssetAsk": "Bestand %s uit deze release verwijderen? Tag en broncode blijven.",
297 "rel.deleteTag": "Ook de git-tag verwijderen",
298 "rel.deleted": "Release verwijderd.",
299 "rel.assetDeleted": "Bestand verwijderd.",
300 "rel.tip.delete": "Haalt de release en zijn bestanden van de server. De git-tag blijft, tenzij je het vakje aanvinkt.",
301 "rel.tip.deleteAsset": "Haalt alleen dit bestand weg. Release, tag en broncode blijven.",
293 302 "rel.bytes": "bytes",
294 303 "set.onlyAdmin": "Alleen een beheerder wijzigt instellingen, geheimen en webhooks. Jouw rol: %s.",
295 304 "set.general": "Algemeen",
@@ -912,6 +921,15 @@ var de = map[string]string{
912 921 "mail.fail.jobs": "Fehlgeschlagene Jobs",
913 922 "mail.fail.open": "Pipeline öffnen",
914 923 "rel.none": "Noch keine Releases.",
924 "rel.delete": "Release löschen",
925 "rel.deleteAsset": "Löschen",
926 "rel.deleteAsk": "Release %s mit allen Dateien löschen? Der Quellcode bleibt.",
927 "rel.deleteAssetAsk": "Datei %s aus diesem Release löschen? Tag und Quellcode bleiben.",
928 "rel.deleteTag": "Auch den Git-Tag löschen",
929 "rel.deleted": "Release gelöscht.",
930 "rel.assetDeleted": "Datei gelöscht.",
931 "rel.tip.delete": "Entfernt das Release und seine Dateien vom Server. Der Git-Tag bleibt, außer du setzt das Häkchen.",
932 "rel.tip.deleteAsset": "Entfernt nur diese Datei. Release, Tag und Quellcode bleiben.",
915 933 "rel.bytes": "Bytes",
916 934 "set.onlyAdmin": "Nur ein Betreuer ändert Einstellungen, Geheimnisse und Webhooks. Deine Rolle: %s.",
917 935 "set.general": "Allgemein",
@@ -1534,6 +1552,15 @@ var fr = map[string]string{
1534 1552 "mail.fail.jobs": "Jobs échoués",
1535 1553 "mail.fail.open": "Ouvrir le pipeline",
1536 1554 "rel.none": "Pas encore de versions.",
1555 "rel.delete": "Supprimer la version",
1556 "rel.deleteAsset": "Supprimer",
1557 "rel.deleteAsk": "Supprimer la version %s et tous ses fichiers ? Le code source reste.",
1558 "rel.deleteAssetAsk": "Supprimer le fichier %s de cette version ? Le tag et le code source restent.",
1559 "rel.deleteTag": "Supprimer aussi le tag git",
1560 "rel.deleted": "Version supprimée.",
1561 "rel.assetDeleted": "Fichier supprimé.",
1562 "rel.tip.delete": "Retire la version et ses fichiers du serveur. Le tag git reste, sauf si tu coches la case.",
1563 "rel.tip.deleteAsset": "Retire seulement ce fichier. La version, le tag et le code source restent.",
1537 1564 "rel.bytes": "octets",
1538 1565 "set.onlyAdmin": "Seul un mainteneur modifie les paramètres, les secrets et les webhooks. Ton rôle : %s.",
1539 1566 "set.general": "Général",
@@ -290,6 +290,15 @@ var nl = map[string]string{
290 "mail.fail.jobs": "Mislukte jobs",
290 "mail.fail.jobs": "Mislukte jobs",
291 "mail.fail.open": "Open de pipeline",
291 "mail.fail.open": "Open de pipeline",
292 "rel.none": "Nog geen releases.",
292 "rel.none": "Nog geen releases.",
293 "rel.delete": "Release verwijderen",
294 "rel.deleteAsset": "Verwijderen",
295 "rel.deleteAsk": "Release %s met alle bestanden verwijderen? De broncode blijft.",
296 "rel.deleteAssetAsk": "Bestand %s uit deze release verwijderen? Tag en broncode blijven.",
297 "rel.deleteTag": "Ook de git-tag verwijderen",
298 "rel.deleted": "Release verwijderd.",
299 "rel.assetDeleted": "Bestand verwijderd.",
300 "rel.tip.delete": "Haalt de release en zijn bestanden van de server. De git-tag blijft, tenzij je het vakje aanvinkt.",
301 "rel.tip.deleteAsset": "Haalt alleen dit bestand weg. Release, tag en broncode blijven.",
293 "rel.bytes": "bytes",
302 "rel.bytes": "bytes",
294 "set.onlyAdmin": "Alleen een beheerder wijzigt instellingen, geheimen en webhooks. Jouw rol: %s.",
303 "set.onlyAdmin": "Alleen een beheerder wijzigt instellingen, geheimen en webhooks. Jouw rol: %s.",
295 "set.general": "Algemeen",
304 "set.general": "Algemeen",
@@ -912,6 +921,15 @@ var de = map[string]string{
912 "mail.fail.jobs": "Fehlgeschlagene Jobs",
921 "mail.fail.jobs": "Fehlgeschlagene Jobs",
913 "mail.fail.open": "Pipeline öffnen",
922 "mail.fail.open": "Pipeline öffnen",
914 "rel.none": "Noch keine Releases.",
923 "rel.none": "Noch keine Releases.",
924 "rel.delete": "Release löschen",
925 "rel.deleteAsset": "Löschen",
926 "rel.deleteAsk": "Release %s mit allen Dateien löschen? Der Quellcode bleibt.",
927 "rel.deleteAssetAsk": "Datei %s aus diesem Release löschen? Tag und Quellcode bleiben.",
928 "rel.deleteTag": "Auch den Git-Tag löschen",
929 "rel.deleted": "Release gelöscht.",
930 "rel.assetDeleted": "Datei gelöscht.",
931 "rel.tip.delete": "Entfernt das Release und seine Dateien vom Server. Der Git-Tag bleibt, außer du setzt das Häkchen.",
932 "rel.tip.deleteAsset": "Entfernt nur diese Datei. Release, Tag und Quellcode bleiben.",
915 "rel.bytes": "Bytes",
933 "rel.bytes": "Bytes",
916 "set.onlyAdmin": "Nur ein Betreuer ändert Einstellungen, Geheimnisse und Webhooks. Deine Rolle: %s.",
934 "set.onlyAdmin": "Nur ein Betreuer ändert Einstellungen, Geheimnisse und Webhooks. Deine Rolle: %s.",
917 "set.general": "Allgemein",
935 "set.general": "Allgemein",
@@ -1534,6 +1552,15 @@ var fr = map[string]string{
1534 "mail.fail.jobs": "Jobs échoués",
1552 "mail.fail.jobs": "Jobs échoués",
1535 "mail.fail.open": "Ouvrir le pipeline",
1553 "mail.fail.open": "Ouvrir le pipeline",
1536 "rel.none": "Pas encore de versions.",
1554 "rel.none": "Pas encore de versions.",
1555 "rel.delete": "Supprimer la version",
1556 "rel.deleteAsset": "Supprimer",
1557 "rel.deleteAsk": "Supprimer la version %s et tous ses fichiers ? Le code source reste.",
1558 "rel.deleteAssetAsk": "Supprimer le fichier %s de cette version ? Le tag et le code source restent.",
1559 "rel.deleteTag": "Supprimer aussi le tag git",
1560 "rel.deleted": "Version supprimée.",
1561 "rel.assetDeleted": "Fichier supprimé.",
1562 "rel.tip.delete": "Retire la version et ses fichiers du serveur. Le tag git reste, sauf si tu coches la case.",
1563 "rel.tip.deleteAsset": "Retire seulement ce fichier. La version, le tag et le code source restent.",
1537 "rel.bytes": "octets",
1564 "rel.bytes": "octets",
1538 "set.onlyAdmin": "Seul un mainteneur modifie les paramètres, les secrets et les webhooks. Ton rôle : %s.",
1565 "set.onlyAdmin": "Seul un mainteneur modifie les paramètres, les secrets et les webhooks. Ton rôle : %s.",
1539 "set.general": "Général",
1566 "set.general": "Général",
internal/server/api_routes.go +2 −0
@@ -153,6 +153,8 @@ var apiCatalog = []apiRoute{
153 153 {http.MethodGet, "/api/v1/projects/{owner}/{repo}/releases", access.ScopeRead, authOptional, "List releases", (*Server).apiReleases},
154 154 {http.MethodPost, "/api/v1/projects/{owner}/{repo}/releases", access.ScopeWrite, authUser, "Publish release", (*Server).createRelease},
155 155 {http.MethodGet, "/api/v1/projects/{owner}/{repo}/releases/{tag}/assets/{name}", access.ScopeRead, authOptional, "Download release asset", (*Server).apiReleaseAsset},
156 {http.MethodDelete, "/api/v1/projects/{owner}/{repo}/releases/{tag}", access.ScopeWrite, authUser, "Delete release (assets included). Query delete_tag=true also deletes the git tag.", (*Server).apiDeleteRelease},
157 {http.MethodDelete, "/api/v1/projects/{owner}/{repo}/releases/{tag}/assets/{name}", access.ScopeWrite, authUser, "Delete one release asset (tag and source stay)", (*Server).apiDeleteReleaseAsset},
156 158 {http.MethodPost, "/api/v1/repos/{owner}/{repo}/releases", access.ScopeWrite, authRelease, "Publish release from a job or user token", (*Server).createRelease},
157 159
158 160 {http.MethodGet, "/api/v1/admin/storage", access.ScopeAdmin, authUser, "Read instance storage", (*Server).apiAdminStorage},
@@ -153,6 +153,8 @@ var apiCatalog = []apiRoute{
153 {http.MethodGet, "/api/v1/projects/{owner}/{repo}/releases", access.ScopeRead, authOptional, "List releases", (*Server).apiReleases},
153 {http.MethodGet, "/api/v1/projects/{owner}/{repo}/releases", access.ScopeRead, authOptional, "List releases", (*Server).apiReleases},
154 {http.MethodPost, "/api/v1/projects/{owner}/{repo}/releases", access.ScopeWrite, authUser, "Publish release", (*Server).createRelease},
154 {http.MethodPost, "/api/v1/projects/{owner}/{repo}/releases", access.ScopeWrite, authUser, "Publish release", (*Server).createRelease},
155 {http.MethodGet, "/api/v1/projects/{owner}/{repo}/releases/{tag}/assets/{name}", access.ScopeRead, authOptional, "Download release asset", (*Server).apiReleaseAsset},
155 {http.MethodGet, "/api/v1/projects/{owner}/{repo}/releases/{tag}/assets/{name}", access.ScopeRead, authOptional, "Download release asset", (*Server).apiReleaseAsset},
156 {http.MethodDelete, "/api/v1/projects/{owner}/{repo}/releases/{tag}", access.ScopeWrite, authUser, "Delete release (assets included). Query delete_tag=true also deletes the git tag.", (*Server).apiDeleteRelease},
157 {http.MethodDelete, "/api/v1/projects/{owner}/{repo}/releases/{tag}/assets/{name}", access.ScopeWrite, authUser, "Delete one release asset (tag and source stay)", (*Server).apiDeleteReleaseAsset},
156 {http.MethodPost, "/api/v1/repos/{owner}/{repo}/releases", access.ScopeWrite, authRelease, "Publish release from a job or user token", (*Server).createRelease},
158 {http.MethodPost, "/api/v1/repos/{owner}/{repo}/releases", access.ScopeWrite, authRelease, "Publish release from a job or user token", (*Server).createRelease},
157
159
158 {http.MethodGet, "/api/v1/admin/storage", access.ScopeAdmin, authUser, "Read instance storage", (*Server).apiAdminStorage},
160 {http.MethodGet, "/api/v1/admin/storage", access.ScopeAdmin, authUser, "Read instance storage", (*Server).apiAdminStorage},
internal/server/release_delete.go added +149 −0
@@ -0,0 +1,149 @@
1 package server
2
3 import (
4 "context"
5 "net/http"
6 "net/url"
7 "os"
8 "path/filepath"
9 "strings"
10
11 "gitlab.com/Timfa/bluegit/internal/access"
12 "gitlab.com/Timfa/bluegit/internal/i18n"
13 "gitlab.com/Timfa/bluegit/internal/store"
14 )
15
16 // releaseAdmin: alleen eigenaar/maintainer van de repo of een instance-admin
17 // mag releases en assets verwijderen.
18 func (s *Server) releaseAdmin(ctx context.Context, user store.User, repo store.Repo) error {
19 if user.ID == 0 {
20 return fail(401, i18n.E("err.apiAuth"))
21 }
22 if user.InstanceAdmin {
23 return nil
24 }
25 role, err := s.repoRole(ctx, user, repo)
26 if err != nil {
27 return err
28 }
29 if !canSeeReleases(repo, role) {
30 return fail(404, i18n.E("err.notFound"))
31 }
32 if !role.AtLeast(access.RoleMaintainer) {
33 return fail(403, i18n.E("err.forbidden"))
34 }
35 return nil
36 }
37
38 // removeAssetFile ruimt een assetbestand op, alleen binnen de opslag, en
39 // daarna de lege map erboven.
40 func (s *Server) removeAssetFile(path string) {
41 root := s.StoragePath()
42 if path == "" || root == "" {
43 return
44 }
45 abs, err := filepath.Abs(path)
46 if err != nil {
47 return
48 }
49 rootAbs, _ := filepath.Abs(root)
50 if !strings.HasPrefix(abs, rootAbs+string(os.PathSeparator)) {
51 return
52 }
53 _ = os.Remove(abs)
54 _ = os.Remove(filepath.Dir(abs)) // alleen als leeg
55 }
56
57 func (s *Server) opDeleteReleaseAsset(ctx context.Context, user store.User, repo store.Repo, tag, name string) error {
58 if err := s.releaseAdmin(ctx, user, repo); err != nil {
59 return err
60 }
61 rel, err := s.Store.ReleaseByTag(ctx, repo.ID, tag)
62 if err != nil {
63 return notFound(err)
64 }
65 path, err := s.Store.DeleteReleaseAsset(ctx, rel.ID, name)
66 if err != nil {
67 return notFound(err)
68 }
69 s.removeAssetFile(path)
70 return nil
71 }
72
73 func (s *Server) opDeleteRelease(ctx context.Context, user store.User, repo store.Repo, tag string, deleteTag bool) error {
74 if err := s.releaseAdmin(ctx, user, repo); err != nil {
75 return err
76 }
77 rel, err := s.Store.ReleaseByTag(ctx, repo.ID, tag)
78 if err != nil {
79 return notFound(err)
80 }
81 paths, err := s.Store.DeleteRelease(ctx, rel.ID)
82 if err != nil {
83 return fail(500, err)
84 }
85 for _, p := range paths {
86 s.removeAssetFile(p)
87 }
88 if deleteTag {
89 return s.opDeleteTag(ctx, user, repo, tag)
90 }
91 return nil
92 }
93
94 func (s *Server) apiRepoForDelete(w http.ResponseWriter, r *http.Request) (store.Repo, bool) {
95 repo, err := s.Store.RepoByPath(r.Context(), r.PathValue("owner"), r.PathValue("repo"))
96 if err != nil {
97 s.writeAPIErr(w, r, fail(404, i18n.E("err.notFound")))
98 return store.Repo{}, false
99 }
100 return repo, true
101 }
102
103 func (s *Server) apiDeleteReleaseAsset(w http.ResponseWriter, r *http.Request) {
104 repo, ok := s.apiRepoForDelete(w, r)
105 if !ok {
106 return
107 }
108 if !s.apiOK(w, r, s.opDeleteReleaseAsset(r.Context(), apiUser(r), repo, r.PathValue("tag"), r.PathValue("name"))) {
109 return
110 }
111 writeJSON(w, http.StatusNoContent, nil)
112 }
113
114 func (s *Server) apiDeleteRelease(w http.ResponseWriter, r *http.Request) {
115 repo, ok := s.apiRepoForDelete(w, r)
116 if !ok {
117 return
118 }
119 del := r.URL.Query().Get("delete_tag") == "true"
120 if !s.apiOK(w, r, s.opDeleteRelease(r.Context(), apiUser(r), repo, r.PathValue("tag"), del)) {
121 return
122 }
123 writeJSON(w, http.StatusNoContent, nil)
124 }
125
126 // UI: POST-formulieren met eigen bevestigingsmodal (data-confirm).
127 func (s *Server) uiDeleteReleaseAsset(w http.ResponseWriter, r *http.Request) {
128 u, repo, _, ok := s.guardReleases(w, r)
129 if !ok || !s.csrfOK(w, r) {
130 return
131 }
132 back := repoURL(repo) + "/-/releases"
133 if !s.uiOK(w, r, back, s.opDeleteReleaseAsset(r.Context(), u, repo, r.PathValue("tag"), r.PathValue("name"))) {
134 return
135 }
136 s.redirect(w, r, back+"#"+url.PathEscape(r.PathValue("tag")), s.tr(r, "rel.assetDeleted"), "")
137 }
138
139 func (s *Server) uiDeleteRelease(w http.ResponseWriter, r *http.Request) {
140 u, repo, _, ok := s.guardReleases(w, r)
141 if !ok || !s.csrfOK(w, r) {
142 return
143 }
144 back := repoURL(repo) + "/-/releases"
145 if !s.uiOK(w, r, back, s.opDeleteRelease(r.Context(), u, repo, r.PathValue("tag"), r.FormValue("delete_tag") == "1")) {
146 return
147 }
148 s.redirect(w, r, back, s.tr(r, "rel.deleted"), "")
149 }
@@ -0,0 +1,149 @@
1package server
2
3import (
4 "context"
5 "net/http"
6 "net/url"
7 "os"
8 "path/filepath"
9 "strings"
10
11 "gitlab.com/Timfa/bluegit/internal/access"
12 "gitlab.com/Timfa/bluegit/internal/i18n"
13 "gitlab.com/Timfa/bluegit/internal/store"
14)
15
16// releaseAdmin: alleen eigenaar/maintainer van de repo of een instance-admin
17// mag releases en assets verwijderen.
18func (s *Server) releaseAdmin(ctx context.Context, user store.User, repo store.Repo) error {
19 if user.ID == 0 {
20 return fail(401, i18n.E("err.apiAuth"))
21 }
22 if user.InstanceAdmin {
23 return nil
24 }
25 role, err := s.repoRole(ctx, user, repo)
26 if err != nil {
27 return err
28 }
29 if !canSeeReleases(repo, role) {
30 return fail(404, i18n.E("err.notFound"))
31 }
32 if !role.AtLeast(access.RoleMaintainer) {
33 return fail(403, i18n.E("err.forbidden"))
34 }
35 return nil
36}
37
38// removeAssetFile ruimt een assetbestand op, alleen binnen de opslag, en
39// daarna de lege map erboven.
40func (s *Server) removeAssetFile(path string) {
41 root := s.StoragePath()
42 if path == "" || root == "" {
43 return
44 }
45 abs, err := filepath.Abs(path)
46 if err != nil {
47 return
48 }
49 rootAbs, _ := filepath.Abs(root)
50 if !strings.HasPrefix(abs, rootAbs+string(os.PathSeparator)) {
51 return
52 }
53 _ = os.Remove(abs)
54 _ = os.Remove(filepath.Dir(abs)) // alleen als leeg
55}
56
57func (s *Server) opDeleteReleaseAsset(ctx context.Context, user store.User, repo store.Repo, tag, name string) error {
58 if err := s.releaseAdmin(ctx, user, repo); err != nil {
59 return err
60 }
61 rel, err := s.Store.ReleaseByTag(ctx, repo.ID, tag)
62 if err != nil {
63 return notFound(err)
64 }
65 path, err := s.Store.DeleteReleaseAsset(ctx, rel.ID, name)
66 if err != nil {
67 return notFound(err)
68 }
69 s.removeAssetFile(path)
70 return nil
71}
72
73func (s *Server) opDeleteRelease(ctx context.Context, user store.User, repo store.Repo, tag string, deleteTag bool) error {
74 if err := s.releaseAdmin(ctx, user, repo); err != nil {
75 return err
76 }
77 rel, err := s.Store.ReleaseByTag(ctx, repo.ID, tag)
78 if err != nil {
79 return notFound(err)
80 }
81 paths, err := s.Store.DeleteRelease(ctx, rel.ID)
82 if err != nil {
83 return fail(500, err)
84 }
85 for _, p := range paths {
86 s.removeAssetFile(p)
87 }
88 if deleteTag {
89 return s.opDeleteTag(ctx, user, repo, tag)
90 }
91 return nil
92}
93
94func (s *Server) apiRepoForDelete(w http.ResponseWriter, r *http.Request) (store.Repo, bool) {
95 repo, err := s.Store.RepoByPath(r.Context(), r.PathValue("owner"), r.PathValue("repo"))
96 if err != nil {
97 s.writeAPIErr(w, r, fail(404, i18n.E("err.notFound")))
98 return store.Repo{}, false
99 }
100 return repo, true
101}
102
103func (s *Server) apiDeleteReleaseAsset(w http.ResponseWriter, r *http.Request) {
104 repo, ok := s.apiRepoForDelete(w, r)
105 if !ok {
106 return
107 }
108 if !s.apiOK(w, r, s.opDeleteReleaseAsset(r.Context(), apiUser(r), repo, r.PathValue("tag"), r.PathValue("name"))) {
109 return
110 }
111 writeJSON(w, http.StatusNoContent, nil)
112}
113
114func (s *Server) apiDeleteRelease(w http.ResponseWriter, r *http.Request) {
115 repo, ok := s.apiRepoForDelete(w, r)
116 if !ok {
117 return
118 }
119 del := r.URL.Query().Get("delete_tag") == "true"
120 if !s.apiOK(w, r, s.opDeleteRelease(r.Context(), apiUser(r), repo, r.PathValue("tag"), del)) {
121 return
122 }
123 writeJSON(w, http.StatusNoContent, nil)
124}
125
126// UI: POST-formulieren met eigen bevestigingsmodal (data-confirm).
127func (s *Server) uiDeleteReleaseAsset(w http.ResponseWriter, r *http.Request) {
128 u, repo, _, ok := s.guardReleases(w, r)
129 if !ok || !s.csrfOK(w, r) {
130 return
131 }
132 back := repoURL(repo) + "/-/releases"
133 if !s.uiOK(w, r, back, s.opDeleteReleaseAsset(r.Context(), u, repo, r.PathValue("tag"), r.PathValue("name"))) {
134 return
135 }
136 s.redirect(w, r, back+"#"+url.PathEscape(r.PathValue("tag")), s.tr(r, "rel.assetDeleted"), "")
137}
138
139func (s *Server) uiDeleteRelease(w http.ResponseWriter, r *http.Request) {
140 u, repo, _, ok := s.guardReleases(w, r)
141 if !ok || !s.csrfOK(w, r) {
142 return
143 }
144 back := repoURL(repo) + "/-/releases"
145 if !s.uiOK(w, r, back, s.opDeleteRelease(r.Context(), u, repo, r.PathValue("tag"), r.FormValue("delete_tag") == "1")) {
146 return
147 }
148 s.redirect(w, r, back, s.tr(r, "rel.deleted"), "")
149}
internal/server/release_delete_test.go added +103 −0
@@ -0,0 +1,103 @@
1 package server
2
3 import (
4 "context"
5 "net/http"
6 "os"
7 "path/filepath"
8 "testing"
9
10 "gitlab.com/Timfa/bluegit/internal/access"
11 "gitlab.com/Timfa/bluegit/internal/gitrepo"
12 "gitlab.com/Timfa/bluegit/internal/store"
13 )
14
15 func TestReleaseDelete(t *testing.T) {
16 e := newCIEnv(t)
17 ctx := context.Background()
18 st, base := e.st, e.ts.URL
19 dir := filepath.Join(e.srv.StoragePath(), "releases", "app", "v1")
20 _ = os.MkdirAll(dir, 0o755)
21 mk := func(n string) store.ReleaseAsset {
22 p := filepath.Join(dir, n)
23 _ = os.WriteFile(p, []byte("x"), 0o644)
24 return store.ReleaseAsset{Name: n, StoragePath: p, Size: 1}
25 }
26 a, b := mk("a.tar.gz"), mk("b.zip")
27 if _, err := st.CreateRelease(ctx, e.repo.ID, "v1", e.sha, "v1", "", e.user.ID, 0, []store.ReleaseAsset{a, b}); err != nil {
28 t.Fatal(err)
29 }
30 bare := gitrepo.Dir(e.srv.StoragePath(), e.repo.OwnerPath, e.repo.Name)
31 if err := gitrepo.CreateTag(ctx, "git", bare, "v1", e.sha, "", "t", "t@x"); err != nil {
32 t.Skip("tag: ", err)
33 }
34 dev, _ := st.UpsertUser(ctx, 20, "dev", "", false)
35 _ = st.SetMember(ctx, "repo", e.repo.ID, "dev", access.RoleDeveloper)
36 out, _ := st.UpsertUser(ctx, 21, "out", "", false)
37 tim := issue(t, st, e.user.ID, "api")
38 devTok := issue(t, st, dev.ID, "api")
39 outTok := issue(t, st, out.ID, "api")
40 del := func(tok, path string) int {
41 req, _ := http.NewRequest("DELETE", base+"/api/v1/projects/tim/app/releases"+path, nil)
42 if tok != "" {
43 req.Header.Set("Authorization", "Bearer "+tok)
44 }
45 res, err := http.DefaultClient.Do(req)
46 if err != nil {
47 t.Fatal(err)
48 }
49 res.Body.Close()
50 return res.StatusCode
51 }
52 for _, c := range []struct {
53 tok string
54 want int
55 }{{"", 401}, {outTok, 404}, {devTok, 403}} {
56 if got := del(c.tok, "/v1/assets/a.tar.gz"); got != c.want {
57 t.Fatalf("asset delete %q: %d want %d", c.tok, got, c.want)
58 }
59 }
60 if got := del(tim, "/v1/assets/nope"); got != 404 {
61 t.Fatalf("missing asset: %d", got)
62 }
63 if got := del(tim, "/v9/assets/a.tar.gz"); got != 404 {
64 t.Fatalf("missing release: %d", got)
65 }
66 if got := del(tim, "/v1/assets/a.tar.gz"); got != 204 {
67 t.Fatalf("asset delete: %d", got)
68 }
69 if _, err := os.Stat(a.StoragePath); !os.IsNotExist(err) {
70 t.Fatal("asset file still on disk")
71 }
72 rel, err := st.ReleaseByTag(ctx, e.repo.ID, "v1")
73 if err != nil || len(rel.Assets) != 1 || rel.Assets[0].Name != "b.zip" {
74 t.Fatalf("after asset delete: %+v %v", rel, err)
75 }
76 if got := del(devTok, "/v1"); got != 403 {
77 t.Fatalf("dev release delete: %d", got)
78 }
79 if got := del(tim, "/v1"); got != 204 {
80 t.Fatalf("release delete: %d", got)
81 }
82 if _, err := st.ReleaseByTag(ctx, e.repo.ID, "v1"); err == nil {
83 t.Fatal("release still there")
84 }
85 if _, err := os.Stat(dir); !os.IsNotExist(err) {
86 t.Fatal("asset dir still on disk")
87 }
88 refs, _ := gitrepo.Refs(ctx, "git", bare)
89 if _, ok := refs["refs/tags/v1"]; !ok {
90 t.Fatalf("tag must stay: %v", refs)
91 }
92 // Met delete_tag=true gaat de tag ook weg.
93 if _, err := st.CreateRelease(ctx, e.repo.ID, "v1", e.sha, "v1", "", e.user.ID, 0, nil); err != nil {
94 t.Fatal(err)
95 }
96 if got := del(tim, "/v1?delete_tag=true"); got != 204 {
97 t.Fatalf("release+tag delete: %d", got)
98 }
99 refs, _ = gitrepo.Refs(ctx, "git", bare)
100 if _, ok := refs["refs/tags/v1"]; ok {
101 t.Fatal("tag should be gone")
102 }
103 }
@@ -0,0 +1,103 @@
1package server
2
3import (
4 "context"
5 "net/http"
6 "os"
7 "path/filepath"
8 "testing"
9
10 "gitlab.com/Timfa/bluegit/internal/access"
11 "gitlab.com/Timfa/bluegit/internal/gitrepo"
12 "gitlab.com/Timfa/bluegit/internal/store"
13)
14
15func TestReleaseDelete(t *testing.T) {
16 e := newCIEnv(t)
17 ctx := context.Background()
18 st, base := e.st, e.ts.URL
19 dir := filepath.Join(e.srv.StoragePath(), "releases", "app", "v1")
20 _ = os.MkdirAll(dir, 0o755)
21 mk := func(n string) store.ReleaseAsset {
22 p := filepath.Join(dir, n)
23 _ = os.WriteFile(p, []byte("x"), 0o644)
24 return store.ReleaseAsset{Name: n, StoragePath: p, Size: 1}
25 }
26 a, b := mk("a.tar.gz"), mk("b.zip")
27 if _, err := st.CreateRelease(ctx, e.repo.ID, "v1", e.sha, "v1", "", e.user.ID, 0, []store.ReleaseAsset{a, b}); err != nil {
28 t.Fatal(err)
29 }
30 bare := gitrepo.Dir(e.srv.StoragePath(), e.repo.OwnerPath, e.repo.Name)
31 if err := gitrepo.CreateTag(ctx, "git", bare, "v1", e.sha, "", "t", "t@x"); err != nil {
32 t.Skip("tag: ", err)
33 }
34 dev, _ := st.UpsertUser(ctx, 20, "dev", "", false)
35 _ = st.SetMember(ctx, "repo", e.repo.ID, "dev", access.RoleDeveloper)
36 out, _ := st.UpsertUser(ctx, 21, "out", "", false)
37 tim := issue(t, st, e.user.ID, "api")
38 devTok := issue(t, st, dev.ID, "api")
39 outTok := issue(t, st, out.ID, "api")
40 del := func(tok, path string) int {
41 req, _ := http.NewRequest("DELETE", base+"/api/v1/projects/tim/app/releases"+path, nil)
42 if tok != "" {
43 req.Header.Set("Authorization", "Bearer "+tok)
44 }
45 res, err := http.DefaultClient.Do(req)
46 if err != nil {
47 t.Fatal(err)
48 }
49 res.Body.Close()
50 return res.StatusCode
51 }
52 for _, c := range []struct {
53 tok string
54 want int
55 }{{"", 401}, {outTok, 404}, {devTok, 403}} {
56 if got := del(c.tok, "/v1/assets/a.tar.gz"); got != c.want {
57 t.Fatalf("asset delete %q: %d want %d", c.tok, got, c.want)
58 }
59 }
60 if got := del(tim, "/v1/assets/nope"); got != 404 {
61 t.Fatalf("missing asset: %d", got)
62 }
63 if got := del(tim, "/v9/assets/a.tar.gz"); got != 404 {
64 t.Fatalf("missing release: %d", got)
65 }
66 if got := del(tim, "/v1/assets/a.tar.gz"); got != 204 {
67 t.Fatalf("asset delete: %d", got)
68 }
69 if _, err := os.Stat(a.StoragePath); !os.IsNotExist(err) {
70 t.Fatal("asset file still on disk")
71 }
72 rel, err := st.ReleaseByTag(ctx, e.repo.ID, "v1")
73 if err != nil || len(rel.Assets) != 1 || rel.Assets[0].Name != "b.zip" {
74 t.Fatalf("after asset delete: %+v %v", rel, err)
75 }
76 if got := del(devTok, "/v1"); got != 403 {
77 t.Fatalf("dev release delete: %d", got)
78 }
79 if got := del(tim, "/v1"); got != 204 {
80 t.Fatalf("release delete: %d", got)
81 }
82 if _, err := st.ReleaseByTag(ctx, e.repo.ID, "v1"); err == nil {
83 t.Fatal("release still there")
84 }
85 if _, err := os.Stat(dir); !os.IsNotExist(err) {
86 t.Fatal("asset dir still on disk")
87 }
88 refs, _ := gitrepo.Refs(ctx, "git", bare)
89 if _, ok := refs["refs/tags/v1"]; !ok {
90 t.Fatalf("tag must stay: %v", refs)
91 }
92 // Met delete_tag=true gaat de tag ook weg.
93 if _, err := st.CreateRelease(ctx, e.repo.ID, "v1", e.sha, "v1", "", e.user.ID, 0, nil); err != nil {
94 t.Fatal(err)
95 }
96 if got := del(tim, "/v1?delete_tag=true"); got != 204 {
97 t.Fatalf("release+tag delete: %d", got)
98 }
99 refs, _ = gitrepo.Refs(ctx, "git", bare)
100 if _, ok := refs["refs/tags/v1"]; ok {
101 t.Fatal("tag should be gone")
102 }
103}
internal/server/server.go +2 −0
@@ -224,6 +224,8 @@ func (s *Server) Handler() http.Handler {
224 224 mux.HandleFunc("POST /{owner}/{repo}/-/ci/lint", s.lintCI)
225 225 mux.HandleFunc("GET /{owner}/{repo}/-/releases", s.releases)
226 226 mux.HandleFunc("GET /{owner}/{repo}/-/releases/{tag}/assets/{name}", s.releaseAsset)
227 mux.HandleFunc("POST /{owner}/{repo}/-/releases/{tag}/assets/{name}/delete", s.uiDeleteReleaseAsset)
228 mux.HandleFunc("POST /{owner}/{repo}/-/releases/{tag}/delete", s.uiDeleteRelease)
227 229 mux.HandleFunc("GET /{owner}/{repo}/-/logo", s.repoLogo)
228 230 mux.HandleFunc("POST /{owner}/{repo}/-/logo", s.uploadRepoLogo)
229 231 mux.HandleFunc("POST /{owner}/{repo}/-/star", s.toggleStar)
@@ -224,6 +224,8 @@ func (s *Server) Handler() http.Handler {
224 mux.HandleFunc("POST /{owner}/{repo}/-/ci/lint", s.lintCI)
224 mux.HandleFunc("POST /{owner}/{repo}/-/ci/lint", s.lintCI)
225 mux.HandleFunc("GET /{owner}/{repo}/-/releases", s.releases)
225 mux.HandleFunc("GET /{owner}/{repo}/-/releases", s.releases)
226 mux.HandleFunc("GET /{owner}/{repo}/-/releases/{tag}/assets/{name}", s.releaseAsset)
226 mux.HandleFunc("GET /{owner}/{repo}/-/releases/{tag}/assets/{name}", s.releaseAsset)
227 mux.HandleFunc("POST /{owner}/{repo}/-/releases/{tag}/assets/{name}/delete", s.uiDeleteReleaseAsset)
228 mux.HandleFunc("POST /{owner}/{repo}/-/releases/{tag}/delete", s.uiDeleteRelease)
227 mux.HandleFunc("GET /{owner}/{repo}/-/logo", s.repoLogo)
229 mux.HandleFunc("GET /{owner}/{repo}/-/logo", s.repoLogo)
228 mux.HandleFunc("POST /{owner}/{repo}/-/logo", s.uploadRepoLogo)
230 mux.HandleFunc("POST /{owner}/{repo}/-/logo", s.uploadRepoLogo)
229 mux.HandleFunc("POST /{owner}/{repo}/-/star", s.toggleStar)
231 mux.HandleFunc("POST /{owner}/{repo}/-/star", s.toggleStar)
internal/server/templates/collab.html +2 −1
@@ -545,8 +545,9 @@
545 545 {{if .Body}}<pre>{{.Body}}</pre>{{end}}
546 546 <ul>
547 547 {{$tag := .Tag}}{{$path := $.Repo.FullPath}}
548 {{range .Assets}}<li><a href="/{{$path}}/-/releases/{{$tag}}/assets/{{.Name}}">{{.Name}}</a> <span class="muted">{{.Size}} {{t "rel.bytes"}}</span></li>{{end}}
548 {{range .Assets}}<li><a href="/{{$path}}/-/releases/{{$tag}}/assets/{{.Name}}">{{.Name}}</a> <span class="muted">{{.Size}} {{t "rel.bytes"}}</span>{{if $.CanAdmin}} <form class="inline tiphost" method="post" action="/{{$path}}/-/releases/{{$tag}}/assets/{{.Name}}/delete" data-confirm="{{t "rel.deleteAssetAsk" .Name}}"><input type="hidden" name="csrf" value="{{$.CSRF}}"><button type="submit" class="ghost danger small">{{t "rel.deleteAsset"}}</button> {{tip "rel.tip.deleteAsset"}}</form>{{end}}</li>{{end}}
549 549 </ul>
550 {{if $.CanAdmin}}<form class="tiphost" method="post" action="/{{$path}}/-/releases/{{.Tag}}/delete" data-confirm="{{t "rel.deleteAsk" .Tag}}"><input type="hidden" name="csrf" value="{{$.CSRF}}"><label class="row"><input type="checkbox" name="delete_tag" value="1"> {{t "rel.deleteTag"}}</label> <button type="submit" class="danger">{{t "rel.delete"}}</button> {{tip "rel.tip.delete"}}</form>{{end}}
550 551 </article>
551 552 {{else}}<p class="muted">{{t "rel.none"}}</p>{{end}}
552 553 {{template "layout-end" .}}
@@ -545,8 +545,9 @@
545 {{if .Body}}<pre>{{.Body}}</pre>{{end}}
545 {{if .Body}}<pre>{{.Body}}</pre>{{end}}
546 <ul>
546 <ul>
547 {{$tag := .Tag}}{{$path := $.Repo.FullPath}}
547 {{$tag := .Tag}}{{$path := $.Repo.FullPath}}
548 {{range .Assets}}<li><a href="/{{$path}}/-/releases/{{$tag}}/assets/{{.Name}}">{{.Name}}</a> <span class="muted">{{.Size}} {{t "rel.bytes"}}</span></li>{{end}}
548 {{range .Assets}}<li><a href="/{{$path}}/-/releases/{{$tag}}/assets/{{.Name}}">{{.Name}}</a> <span class="muted">{{.Size}} {{t "rel.bytes"}}</span>{{if $.CanAdmin}} <form class="inline tiphost" method="post" action="/{{$path}}/-/releases/{{$tag}}/assets/{{.Name}}/delete" data-confirm="{{t "rel.deleteAssetAsk" .Name}}"><input type="hidden" name="csrf" value="{{$.CSRF}}"><button type="submit" class="ghost danger small">{{t "rel.deleteAsset"}}</button> {{tip "rel.tip.deleteAsset"}}</form>{{end}}</li>{{end}}
549 </ul>
549 </ul>
550 {{if $.CanAdmin}}<form class="tiphost" method="post" action="/{{$path}}/-/releases/{{.Tag}}/delete" data-confirm="{{t "rel.deleteAsk" .Tag}}"><input type="hidden" name="csrf" value="{{$.CSRF}}"><label class="row"><input type="checkbox" name="delete_tag" value="1"> {{t "rel.deleteTag"}}</label> <button type="submit" class="danger">{{t "rel.delete"}}</button> {{tip "rel.tip.delete"}}</form>{{end}}
550</article>
551</article>
551{{else}}<p class="muted">{{t "rel.none"}}</p>{{end}}
552{{else}}<p class="muted">{{t "rel.none"}}</p>{{end}}
552{{template "layout-end" .}}
553{{template "layout-end" .}}
internal/store/flow.go +43 −0
@@ -1446,3 +1446,46 @@ func indexOf(s, sub string) int {
1446 1446 }
1447 1447 return -1
1448 1448 }
1449
1450 // DeleteReleaseAsset haalt één asset van een release weg en geeft het pad
1451 // op schijf terug (om op te ruimen). errNotFound als de naam niet bestaat.
1452 func (s *Store) DeleteReleaseAsset(ctx context.Context, releaseID int64, name string) (string, error) {
1453 var path string
1454 err := s.db.QueryRowContext(ctx, `SELECT storage_path FROM release_assets WHERE release_id = ? AND name = ?`, releaseID, name).Scan(&path)
1455 if errors.Is(err, sql.ErrNoRows) {
1456 return "", errNotFound
1457 }
1458 if err != nil {
1459 return "", err
1460 }
1461 _, err = s.db.ExecContext(ctx, `DELETE FROM release_assets WHERE release_id = ? AND name = ?`, releaseID, name)
1462 return path, err
1463 }
1464
1465 // DeleteRelease verwijdert de release met zijn assets en geeft de paden op
1466 // schijf terug. De git-tag blijft staan.
1467 func (s *Store) DeleteRelease(ctx context.Context, releaseID int64) ([]string, error) {
1468 assets, err := s.releaseAssets(ctx, releaseID)
1469 if err != nil {
1470 return nil, err
1471 }
1472 tx, err := s.db.BeginTx(ctx, nil)
1473 if err != nil {
1474 return nil, err
1475 }
1476 defer func() { _ = tx.Rollback() }()
1477 if _, err := tx.ExecContext(ctx, `DELETE FROM release_assets WHERE release_id = ?`, releaseID); err != nil {
1478 return nil, err
1479 }
1480 if _, err := tx.ExecContext(ctx, `DELETE FROM releases WHERE id = ?`, releaseID); err != nil {
1481 return nil, err
1482 }
1483 if err := tx.Commit(); err != nil {
1484 return nil, err
1485 }
1486 var paths []string
1487 for _, a := range assets {
1488 paths = append(paths, a.StoragePath)
1489 }
1490 return paths, nil
1491 }
@@ -1446,3 +1446,46 @@ func indexOf(s, sub string) int {
1446 }
1446 }
1447 return -1
1447 return -1
1448}
1448}
1449
1450// DeleteReleaseAsset haalt één asset van een release weg en geeft het pad
1451// op schijf terug (om op te ruimen). errNotFound als de naam niet bestaat.
1452func (s *Store) DeleteReleaseAsset(ctx context.Context, releaseID int64, name string) (string, error) {
1453 var path string
1454 err := s.db.QueryRowContext(ctx, `SELECT storage_path FROM release_assets WHERE release_id = ? AND name = ?`, releaseID, name).Scan(&path)
1455 if errors.Is(err, sql.ErrNoRows) {
1456 return "", errNotFound
1457 }
1458 if err != nil {
1459 return "", err
1460 }
1461 _, err = s.db.ExecContext(ctx, `DELETE FROM release_assets WHERE release_id = ? AND name = ?`, releaseID, name)
1462 return path, err
1463}
1464
1465// DeleteRelease verwijdert de release met zijn assets en geeft de paden op
1466// schijf terug. De git-tag blijft staan.
1467func (s *Store) DeleteRelease(ctx context.Context, releaseID int64) ([]string, error) {
1468 assets, err := s.releaseAssets(ctx, releaseID)
1469 if err != nil {
1470 return nil, err
1471 }
1472 tx, err := s.db.BeginTx(ctx, nil)
1473 if err != nil {
1474 return nil, err
1475 }
1476 defer func() { _ = tx.Rollback() }()
1477 if _, err := tx.ExecContext(ctx, `DELETE FROM release_assets WHERE release_id = ?`, releaseID); err != nil {
1478 return nil, err
1479 }
1480 if _, err := tx.ExecContext(ctx, `DELETE FROM releases WHERE id = ?`, releaseID); err != nil {
1481 return nil, err
1482 }
1483 if err := tx.Commit(); err != nil {
1484 return nil, err
1485 }
1486 var paths []string
1487 for _, a := range assets {
1488 paths = append(paths, a.StoragePath)
1489 }
1490 return paths, nil
1491}
scripts/bg +13 −0
@@ -241,6 +241,17 @@ cmd_release() {
241 241 req PUT "$(proj "$p")" "$(json --arg v "$v" '{release_visibility:$v}')" | jq -r '"\(.path) releases=\(.release_visibility) repo=\(.visibility)"'
242 242 return
243 243 fi
244 if [[ ${1:-} == delete-asset ]]; then
245 local p=${2:?project} tag=${3:?tag} name=${4:?naam}
246 req DELETE "$(proj "$p")/releases/$(enc "$tag")/assets/$(enc "$name")" >/dev/null && echo "verwijderd: $tag/$name"
247 return
248 fi
249 if [[ ${1:-} == delete ]]; then
250 local p=${2:?project} tag=${3:?tag} q=""
251 [[ ${4:-} == --delete-tag ]] && q="?delete_tag=true"
252 req DELETE "$(proj "$p")/releases/$(enc "$tag")$q" >/dev/null && echo "verwijderd: release $tag${q:+ (met tag)}"
253 return
254 fi
244 255 [[ ${1:-} == create ]] || die "release create PROJECT TAG [--commit SHA] [--name N] [--body B] [--asset JOB:PAD[:NAAM]]... | release visibility PROJECT [inherit|private|public]"
245 256 local p=${2:?project} tag=${3:?tag}; shift 3
246 257 local commit="" name="" body="" assets="[]"
@@ -273,6 +284,8 @@ usage() {
273 284 bg issue list|show|create|comment|close|reopen ...
274 285 bg branch create PROJECT NAAM [--from REF]
275 286 bg release create PROJECT TAG [--commit SHA] [--asset JOB:PAD[:NAAM]]
287 bg release delete-asset PROJECT TAG NAAM één asset verwijderen (tag en broncode blijven)
288 bg release delete PROJECT TAG [--delete-tag] release met assets verwijderen
276 289 bg release visibility PROJECT [inherit|private|public] zichtbaarheid releases tonen of zetten
277 290 bg file get PROJECT PAD [--ref REF]
278 291 bg runner list|show ID|jobs ID [N] [--group PAD] (account-runners zonder --group)
@@ -241,6 +241,17 @@ cmd_release() {
241 req PUT "$(proj "$p")" "$(json --arg v "$v" '{release_visibility:$v}')" | jq -r '"\(.path) releases=\(.release_visibility) repo=\(.visibility)"'
241 req PUT "$(proj "$p")" "$(json --arg v "$v" '{release_visibility:$v}')" | jq -r '"\(.path) releases=\(.release_visibility) repo=\(.visibility)"'
242 return
242 return
243 fi
243 fi
244 if [[ ${1:-} == delete-asset ]]; then
245 local p=${2:?project} tag=${3:?tag} name=${4:?naam}
246 req DELETE "$(proj "$p")/releases/$(enc "$tag")/assets/$(enc "$name")" >/dev/null && echo "verwijderd: $tag/$name"
247 return
248 fi
249 if [[ ${1:-} == delete ]]; then
250 local p=${2:?project} tag=${3:?tag} q=""
251 [[ ${4:-} == --delete-tag ]] && q="?delete_tag=true"
252 req DELETE "$(proj "$p")/releases/$(enc "$tag")$q" >/dev/null && echo "verwijderd: release $tag${q:+ (met tag)}"
253 return
254 fi
244 [[ ${1:-} == create ]] || die "release create PROJECT TAG [--commit SHA] [--name N] [--body B] [--asset JOB:PAD[:NAAM]]... | release visibility PROJECT [inherit|private|public]"
255 [[ ${1:-} == create ]] || die "release create PROJECT TAG [--commit SHA] [--name N] [--body B] [--asset JOB:PAD[:NAAM]]... | release visibility PROJECT [inherit|private|public]"
245 local p=${2:?project} tag=${3:?tag}; shift 3
256 local p=${2:?project} tag=${3:?tag}; shift 3
246 local commit="" name="" body="" assets="[]"
257 local commit="" name="" body="" assets="[]"
@@ -273,6 +284,8 @@ usage() {
273 bg issue list|show|create|comment|close|reopen ...
284 bg issue list|show|create|comment|close|reopen ...
274 bg branch create PROJECT NAAM [--from REF]
285 bg branch create PROJECT NAAM [--from REF]
275 bg release create PROJECT TAG [--commit SHA] [--asset JOB:PAD[:NAAM]]
286 bg release create PROJECT TAG [--commit SHA] [--asset JOB:PAD[:NAAM]]
287 bg release delete-asset PROJECT TAG NAAM één asset verwijderen (tag en broncode blijven)
288 bg release delete PROJECT TAG [--delete-tag] release met assets verwijderen
276 bg release visibility PROJECT [inherit|private|public] zichtbaarheid releases tonen of zetten
289 bg release visibility PROJECT [inherit|private|public] zichtbaarheid releases tonen of zetten
277 bg file get PROJECT PAD [--ref REF]
290 bg file get PROJECT PAD [--ref REF]
278 bg runner list|show ID|jobs ID [N] [--group PAD] (account-runners zonder --group)
291 bg runner list|show ID|jobs ID [N] [--group PAD] (account-runners zonder --group)