package ci import "testing" // Pipeline #26: test faalde, build werd overgeslagen, release (needs: [build]) // hoort zelf overgeslagen te worden. publish_aur met needs: [] start wel. func TestGateSkipsWhenNeedFailedOrSkipped(t *testing.T) { jobs := []Job{ {Name: "test", Stage: "test"}, {Name: "soft", Stage: "test", AllowFailure: true}, {Name: "build", Stage: "build", Needs: []string{"test"}, NeedsSet: true}, {Name: "after_soft", Stage: "build", Needs: []string{"soft"}, NeedsSet: true}, {Name: "release", Stage: "release", Needs: []string{"build"}, NeedsSet: true}, {Name: "deploy", Stage: "deploy", Needs: []string{"build", "release"}, NeedsSet: true}, {Name: "publish_aur", Stage: "deploy", NeedsSet: true, AllowFailure: true}, {Name: "later", Stage: "deploy"}, {Name: "anyway", Stage: "deploy", Needs: []string{"build"}, NeedsSet: true, When: "always"}, {Name: "onfail", Stage: "deploy", Needs: []string{"build"}, NeedsSet: true, When: "on_failure"}, } by := map[string]Job{} for _, j := range jobs { by[j.Name] = j } // test is gefaald en build daardoor overgeslagen; release staat nog queued. mid := map[string]string{ "test": "failed", "soft": "failed", "build": "skipped", "after_soft": "success", "release": "queued", "deploy": "queued", "publish_aur": "queued", "later": "queued", "anyway": "queued", "onfail": "queued", } assertGate(t, jobs, by, mid, map[string]string{ "build": "skip", "release": "skip", "deploy": "wait", "publish_aur": "ready", "later": "wait", "anyway": "ready", "onfail": "skip", "after_soft": "ready", }) // Nadat de keten is overgeslagen blijft publish_aur staan en valt de // latere stage zonder needs alsnog weg. settled := map[string]string{ "test": "failed", "soft": "failed", "build": "skipped", "after_soft": "success", "release": "skipped", "deploy": "queued", "publish_aur": "queued", "later": "queued", "anyway": "queued", "onfail": "queued", } assertGate(t, jobs, by, settled, map[string]string{ "release": "skip", "deploy": "skip", "later": "skip", "publish_aur": "ready", "anyway": "ready", }) onlySkip := map[string]string{ "test": "skipped", "soft": "success", "build": "skipped", "after_soft": "success", "release": "skipped", "deploy": "queued", "publish_aur": "queued", "later": "queued", "anyway": "queued", "onfail": "queued", } assertGate(t, jobs, by, onlySkip, map[string]string{ "later": "ready", "build": "skip", "publish_aur": "ready", "onfail": "skip", }) failedNeed := map[string]string{ "test": "success", "soft": "success", "build": "failed", "after_soft": "success", "release": "queued", "deploy": "queued", "publish_aur": "queued", "later": "queued", "anyway": "queued", "onfail": "queued", } assertGate(t, jobs, by, failedNeed, map[string]string{ "release": "skip", "onfail": "ready", "anyway": "ready", "publish_aur": "ready", "later": "wait", }) running := map[string]string{ "test": "success", "soft": "success", "build": "running", "after_soft": "success", "release": "queued", "deploy": "queued", "publish_aur": "queued", "later": "queued", "anyway": "queued", "onfail": "queued", } assertGate(t, jobs, by, running, map[string]string{ "release": "wait", "anyway": "wait", "publish_aur": "ready", }) // Een overgeslagen need met allow_failure houdt de afhankelijke job toch tegen. softSkipped := []Job{ {Name: "soft", Stage: "test", AllowFailure: true}, {Name: "next", Stage: "build", Needs: []string{"soft"}, NeedsSet: true}, } if got := Gate(softSkipped, map[string]string{"soft": "skipped", "next": "queued"}, softSkipped[1]); got != "skip" { t.Errorf("overgeslagen need met allow_failure: %s", got) } } // Een latere stage die in het bestand bóven de eerdere stage staat, mag // niet ready zijn zolang die eerdere stage queued of running is. // needs: [] blijft wel meteen ready. Dat is de fix uit !37, plus de // stagevolgorde uit stages: in plaats van de volgorde in het bestand. func TestLaterStageWaitsWhileEarlierIsQueued(t *testing.T) { p, err := Parse([]byte(` stages: [test, release] jobs: release: stage: release image: alpine script: ["echo release"] early: stage: release image: alpine needs: [] script: ["echo early"] test: stage: test image: alpine script: ["echo test"] `)) if err != nil { t.Fatal(err) } if p.Jobs[0].Name != "release" { t.Fatalf("parse houdt de bestandsvolgorde: %s", p.Jobs[0].Name) } jobs, err := p.ActiveJobs(map[string]string{}) if err != nil { t.Fatal(err) } if len(jobs) != 3 || jobs[0].Name != "test" || jobs[0].Stage != "test" { t.Fatalf("stages: hoort test eerst te zetten: %v", names(jobs)) } by := map[string]Job{} for _, j := range jobs { by[j.Name] = j } queued := map[string]string{"test": "queued", "release": "queued", "early": "queued"} if got := Gate(jobs, queued, by["release"]); got != "wait" { t.Fatalf("release terwijl test nog queued is: %s", got) } running := map[string]string{"test": "running", "release": "queued", "early": "queued"} if got := Gate(jobs, running, by["release"]); got != "wait" { t.Fatalf("release terwijl test nog loopt: %s", got) } if got := Gate(jobs, queued, by["early"]); got != "ready" { t.Fatalf("needs: [] start meteen: %s", got) } if got := Gate(jobs, queued, by["test"]); got != "ready" { t.Fatalf("eerste stage start meteen: %s", got) } done := map[string]string{"test": "success", "release": "queued", "early": "queued"} if got := Gate(jobs, done, by["release"]); got != "ready" { t.Fatalf("release na test: %s", got) } } func names(jobs []Job) []string { out := make([]string, len(jobs)) for i, j := range jobs { out[i] = j.Name } return out } func assertGate(t *testing.T, jobs []Job, by map[string]Job, status, want map[string]string) { t.Helper() for name, decision := range want { if got := Gate(jobs, status, by[name]); got != decision { t.Errorf("%s: got %s, want %s", name, got, decision) } } }