package server import ( "encoding/json" "net/http" "net/url" "os" "path/filepath" "strings" "testing" "gitlab.com/Timfa/bluegit/internal/config" ) func TestAdminSettingsRequiresAdminAndHidesSecret(t *testing.T) { e := newCIEnv(t) state := t.TempDir() e.srv.StateDir = state e.srv.Cfg.StatePath = state e.srv.Cfg.Auth.ClientSecret = "supergeheim" e.srv.Cfg.Auth.ClientID = "git.example.test" e.srv.ConfigPath = "/etc/bluegit/config.yml" ctx := e.st bob, _ := ctx.UpsertUser(t.Context(), 2, "bob", "", false) bc, _ := sessionClient(t, ctx, e.ts.URL, bob.ID) res, _ := bc.Get(e.ts.URL + "/admin/settings") if res.StatusCode != http.StatusForbidden { t.Fatalf("bob ui: %d", res.StatusCode) } res.Body.Close() bobTok := issue(t, ctx, bob.ID, "api") if code, _ := rapi(t, e.ts.URL, bobTok, "GET", "/admin/settings", nil); code != http.StatusForbidden { t.Fatalf("bob api: %d", code) } tc, tcsrf := sessionClient(t, ctx, e.ts.URL, e.user.ID) res, _ = tc.Get(e.ts.URL + "/admin/settings") page := body(t, res) if res.StatusCode != 200 { t.Fatalf("admin page %d: %.300s", res.StatusCode, page) } if !strings.Contains(page, `name="base_url"`) || !strings.Contains(page, `name="auth.client_secret"`) { t.Fatalf("form ontbreekt: %.400s", page) } if strings.Contains(page, "supergeheim") { t.Fatal("clientgeheim stond in de HTML") } if !strings.Contains(page, "admin.tab.settings") && !strings.Contains(page, "Instellingen") && !strings.Contains(page, "Settings") { // tab label is vertaald if !strings.Contains(page, `href="/admin/settings"`) { t.Fatal("tab instellingen ontbreekt") } } adminTok := issue(t, ctx, e.user.ID, "api") code, raw := rapi(t, e.ts.URL, adminTok, "GET", "/admin/settings", nil) if code != 200 { t.Fatalf("GET settings %d %s", code, raw) } if strings.Contains(string(raw), "supergeheim") { t.Fatal("geheim in de API") } var got map[string]any if err := json.Unmarshal([]byte(raw), &got); err != nil { t.Fatal(err) } auth := got["auth"].(map[string]any) if auth["client_secret_set"] != true { t.Fatalf("secret_set: %v", auth) } if _, ok := auth["client_secret"]; ok { t.Fatal("client_secret-veld hoort niet in de JSON") } // Leeg geheim houdt het oude; andere velden wijzigen. code, raw = rapi(t, e.ts.URL, adminTok, "PUT", "/admin/settings", map[string]any{ "listen": "127.0.0.1:9199", "auth": map[string]any{"client_secret": ""}, }) if code != 200 { t.Fatalf("PUT %d %s", code, raw) } if e.srv.Cfg.Auth.ClientSecret != "supergeheim" { t.Fatalf("geheim gewist: %q", e.srv.Cfg.Auth.ClientSecret) } if e.srv.Cfg.Listen != "127.0.0.1:9199" { t.Fatalf("listen: %s", e.srv.Cfg.Listen) } saved, err := os.ReadFile(filepath.Join(state, config.SettingsFile)) if err != nil { t.Fatal(err) } if !strings.Contains(string(saved), "supergeheim") { t.Fatal("settings.yml mist het geheim") } if strings.Contains(string(raw), "supergeheim") { t.Fatal("PUT-antwoord lekte het geheim") } // CSRF: POST zonder token wordt geweigerd. res, _ = tc.PostForm(e.ts.URL+"/admin/settings", url.Values{"base_url": {e.srv.Cfg.BaseURL}}) if res.StatusCode != http.StatusBadRequest && res.StatusCode != http.StatusForbidden { t.Fatalf("zonder csrf: %d", res.StatusCode) } res.Body.Close() res, _ = tc.PostForm(e.ts.URL+"/admin/settings", url.Values{ "csrf": {tcsrf}, "base_url": {e.srv.Cfg.BaseURL}, "listen": {"127.0.0.1:9200"}, "auth.mode": {"dev"}, "auth.client_id": {"git.example.test"}, "auth.client_secret": {""}, }) loc := res.Header.Get("Location") res.Body.Close() if res.StatusCode/100 != 3 { t.Fatalf("POST settings %d %s", res.StatusCode, loc) } if e.srv.Cfg.Listen != "127.0.0.1:9200" { t.Fatalf("na POST listen %s", e.srv.Cfg.Listen) } } func TestAdminCreatesUserTokenOnce(t *testing.T) { e := newCIEnv(t) bob, _ := e.st.UpsertUser(t.Context(), 2, "bob", "", false) tc, tcsrf := sessionClient(t, e.st, e.ts.URL, e.user.ID) res, _ := tc.PostForm(e.ts.URL+"/admin/users/token", url.Values{ "csrf": {tcsrf}, "id": {itoa(bob.ID)}, "name": {"laptop"}, }) res.Body.Close() if res.StatusCode/100 != 3 { t.Fatalf("token post %d", res.StatusCode) } res, _ = tc.Get(e.ts.URL + "/admin/users") page := body(t, res) if !strings.Contains(page, "class=\"code\"") && !strings.Contains(page, "bgpat_") && !strings.Contains(page, "bgt_") { // token prefix may vary; at least the once-block or a long token-like string if !strings.Contains(page, "token") && !strings.Contains(page, "Token") && !strings.Contains(page, "een keer") && !strings.Contains(page, "only once") && !strings.Contains(page, "einmal") { t.Fatalf("token niet getoond: %.500s", page) } } adminTok := issue(t, e.st, e.user.ID, "api") code, raw := rapi(t, e.ts.URL, adminTok, "POST", "/admin/users/bob/tokens", map[string]any{"name": "ci"}) if code != http.StatusCreated { t.Fatalf("api token %d %s", code, raw) } var out map[string]any if err := json.Unmarshal([]byte(raw), &out); err != nil { t.Fatal(err) } tok, _ := out["token"].(string) if tok == "" { t.Fatalf("geen token in antwoord: %s", raw) } bobTok := issue(t, e.st, bob.ID, "nope") if code, _ = rapi(t, e.ts.URL, bobTok, "POST", "/admin/users/tim/tokens", map[string]any{"name": "x"}); code != http.StatusForbidden { t.Fatalf("bob maakt token: %d", code) } } func TestDevModeRejectedForProductionHost(t *testing.T) { e := newCIEnv(t) e.srv.StateDir = t.TempDir() e.srv.Cfg.StatePath = e.srv.StateDir e.srv.Cfg.BaseURL = "https://git.timfalken.com" adminTok := issue(t, e.st, e.user.ID, "api") code, raw := rapi(t, e.ts.URL, adminTok, "PUT", "/admin/settings", map[string]any{ "auth": map[string]any{"mode": "dev"}, }) if code == 200 { t.Fatalf("dev op git.timfalken.com moest falen: %s", raw) } }