package server import ( "context" "net/http" "os" "path/filepath" "testing" "gitlab.com/Timfa/bluegit/internal/access" "gitlab.com/Timfa/bluegit/internal/gitrepo" "gitlab.com/Timfa/bluegit/internal/store" ) func TestReleaseDelete(t *testing.T) { e := newCIEnv(t) ctx := context.Background() st, base := e.st, e.ts.URL dir := filepath.Join(e.srv.StoragePath(), "releases", "app", "v1") _ = os.MkdirAll(dir, 0o755) mk := func(n string) store.ReleaseAsset { p := filepath.Join(dir, n) _ = os.WriteFile(p, []byte("x"), 0o644) return store.ReleaseAsset{Name: n, StoragePath: p, Size: 1} } a, b := mk("a.tar.gz"), mk("b.zip") if _, err := st.CreateRelease(ctx, e.repo.ID, "v1", e.sha, "v1", "", e.user.ID, 0, []store.ReleaseAsset{a, b}); err != nil { t.Fatal(err) } bare := gitrepo.Dir(e.srv.StoragePath(), e.repo.OwnerPath, e.repo.Name) if err := gitrepo.CreateTag(ctx, "git", bare, "v1", e.sha, "", "t", "t@x"); err != nil { t.Skip("tag: ", err) } dev, _ := st.UpsertUser(ctx, 20, "dev", "", false) _ = st.SetMember(ctx, "repo", e.repo.ID, "dev", access.RoleDeveloper) out, _ := st.UpsertUser(ctx, 21, "out", "", false) tim := issue(t, st, e.user.ID, "api") devTok := issue(t, st, dev.ID, "api") outTok := issue(t, st, out.ID, "api") del := func(tok, path string) int { req, _ := http.NewRequest("DELETE", base+"/api/v1/projects/tim/app/releases"+path, nil) if tok != "" { req.Header.Set("Authorization", "Bearer "+tok) } res, err := http.DefaultClient.Do(req) if err != nil { t.Fatal(err) } res.Body.Close() return res.StatusCode } for _, c := range []struct { tok string want int }{{"", 401}, {outTok, 404}, {devTok, 403}} { if got := del(c.tok, "/v1/assets/a.tar.gz"); got != c.want { t.Fatalf("asset delete %q: %d want %d", c.tok, got, c.want) } } if got := del(tim, "/v1/assets/nope"); got != 404 { t.Fatalf("missing asset: %d", got) } if got := del(tim, "/v9/assets/a.tar.gz"); got != 404 { t.Fatalf("missing release: %d", got) } if got := del(tim, "/v1/assets/a.tar.gz"); got != 204 { t.Fatalf("asset delete: %d", got) } if _, err := os.Stat(a.StoragePath); !os.IsNotExist(err) { t.Fatal("asset file still on disk") } rel, err := st.ReleaseByTag(ctx, e.repo.ID, "v1") if err != nil || len(rel.Assets) != 1 || rel.Assets[0].Name != "b.zip" { t.Fatalf("after asset delete: %+v %v", rel, err) } if got := del(devTok, "/v1"); got != 403 { t.Fatalf("dev release delete: %d", got) } if got := del(tim, "/v1"); got != 204 { t.Fatalf("release delete: %d", got) } if _, err := st.ReleaseByTag(ctx, e.repo.ID, "v1"); err == nil { t.Fatal("release still there") } if _, err := os.Stat(dir); !os.IsNotExist(err) { t.Fatal("asset dir still on disk") } refs, _ := gitrepo.Refs(ctx, "git", bare) if _, ok := refs["refs/tags/v1"]; !ok { t.Fatalf("tag must stay: %v", refs) } // Met delete_tag=true gaat de tag ook weg. if _, err := st.CreateRelease(ctx, e.repo.ID, "v1", e.sha, "v1", "", e.user.ID, 0, nil); err != nil { t.Fatal(err) } if got := del(tim, "/v1?delete_tag=true"); got != 204 { t.Fatalf("release+tag delete: %d", got) } refs, _ = gitrepo.Refs(ctx, "git", bare) if _, ok := refs["refs/tags/v1"]; ok { t.Fatal("tag should be gone") } }