package server import ( "context" "encoding/json" "net/http" "net/http/cookiejar" "net/http/httptest" "net/url" "os/exec" "path/filepath" "strconv" "strings" "testing" "time" "gitlab.com/Timfa/bluegit/internal/access" "gitlab.com/Timfa/bluegit/internal/auth" "gitlab.com/Timfa/bluegit/internal/config" "gitlab.com/Timfa/bluegit/internal/store" ) func TestSecretEditShowAndInvisible(t *testing.T) { if _, err := exec.LookPath("git"); err != nil { t.Skip("git ontbreekt") } storage := t.TempDir() st, err := store.Open(filepath.Join(storage, "bluegit.db"), bytes32()) if err != nil { t.Fatal(err) } t.Cleanup(func() { _ = st.Close() }) cfg := config.Config{ BaseURL: "http://127.0.0.1:9", Listen: "127.0.0.1:0", StoragePath: storage, Auth: config.Auth{Mode: "dev", DevUser: "tim", DevAuthID: 1, UserAgent: "test"}, Git: config.Git{Binary: "git", DefaultBranch: "master"}, } srv := &Server{Cfg: cfg, Store: st, Auth: auth.Dev{Username: "tim", AuthID: 1}, Dev: true, Git: "git", HookBin: "/bin/true"} ts := httptest.NewServer(srv.Handler()) t.Cleanup(ts.Close) jar, _ := cookiejar.New(nil) client := &http.Client{Jar: jar} res, err := client.Get(ts.URL + "/login") if err != nil { t.Fatal(err) } page := read(t, res) res, err = client.PostForm(ts.URL+"/new/repo", url.Values{ "csrf": {csrfOf(t, page)}, "name": {"secrets"}, "visibility": {"private"}, }) if err != nil { t.Fatal(err) } _ = read(t, res) res, err = client.Get(ts.URL + "/tim/secrets/-/settings?tab=secrets") if err != nil { t.Fatal(err) } page = read(t, res) for _, needle := range []string{`name="invisible"`, "evgrid", "/assets/secrets.js", "An invisible secret"} { if !strings.Contains(page, needle) { t.Fatalf("formulier mist %q", needle) } } post := func(values url.Values) string { t.Helper() values.Set("csrf", csrfOf(t, page)) res, err := client.PostForm(ts.URL+"/tim/secrets/-/secrets", values) if err != nil { t.Fatal(err) } page = read(t, res) return page } post(url.Values{"name": {"SHOWN"}, "value": {"zichtbaar-waarde"}, "protected": {"1"}}) post(url.Values{"name": {"HIDDEN"}, "value": {"onzichtbare-waarde"}, "invisible": {"1"}}) if strings.Contains(page, "zichtbaar-waarde") || strings.Contains(page, "onzichtbare-waarde") { t.Fatal("waarde staat in de eerste html") } if !strings.Contains(page, `data-reveal="SHOWN"`) || strings.Contains(page, `data-reveal="HIDDEN"`) { t.Fatalf("toonknop:\n%s", page) } if !strings.Contains(page, `value="replace"`) || !strings.Contains(page, ">Show<") || !strings.Contains(page, ">Edit<") || !strings.Contains(page, ">Replace<") { t.Fatalf("knoppen:\n%s", page) } res, err = client.PostForm(ts.URL+"/tim/secrets/-/secrets/reveal", url.Values{ "csrf": {csrfOf(t, page)}, "name": {"SHOWN"}, }) if err != nil { t.Fatal(err) } shown := read(t, res) if res.StatusCode != http.StatusOK || !strings.Contains(shown, "zichtbaar-waarde") { t.Fatalf("toon %d %s", res.StatusCode, shown) } res, err = client.PostForm(ts.URL+"/tim/secrets/-/secrets/reveal", url.Values{ "csrf": {csrfOf(t, page)}, "name": {"HIDDEN"}, }) if err != nil { t.Fatal(err) } hidden := read(t, res) if res.StatusCode != http.StatusForbidden || strings.Contains(hidden, "onzichtbare-waarde") { t.Fatalf("verborgen toon %d %s", res.StatusCode, hidden) } post(url.Values{"mode": {"update"}, "name": {"SHOWN"}, "value": {"nieuwe-waarde"}}) if !strings.Contains(page, "Secret saved") { t.Fatalf("bewerken:\n%s", page) } post(url.Values{"mode": {"update"}, "name": {"HIDDEN"}, "value": {"mag-niet"}}) if !strings.Contains(page, "invisible") || strings.Contains(page, "mag-niet") { t.Fatalf("bewerken van onzichtbaar:\n%s", page) } post(url.Values{"mode": {"replace"}, "name": {"HIDDEN"}, "value": {"vervangen-waarde"}, "protected": {"1"}}) if !strings.Contains(page, "Secret replaced") || strings.Contains(page, "vervangen-waarde") || strings.Contains(page, "onzichtbare-waarde") { t.Fatalf("vervangen:\n%s", page) } ctx := context.Background() tim, err := st.UserByUsername(ctx, "tim") if err != nil { t.Fatal(err) } repo, err := st.RepoByPath(ctx, "tim", "secrets") if err != nil { t.Fatal(err) } vals, err := st.SecretValues(ctx, "repo", repo.ID, true) if err != nil || vals["SHOWN"] != "nieuwe-waarde" || vals["HIDDEN"] != "vervangen-waarde" { t.Fatalf("opgeslagen %#v %v", vals, err) } list, err := st.ListSecrets(ctx, "repo", repo.ID) if err != nil { t.Fatal(err) } for _, m := range list { if m.Name == "HIDDEN" && (!m.Invisible || !m.Protected) { t.Fatalf("vlaggen %+v", m) } if m.Name == "SHOWN" && (m.Invisible || m.Protected) { t.Fatalf("zichtbaar werd %+v", m) } } token, err := st.CreateToken(ctx, tim.ID, "laptop") if err != nil { t.Fatal(err) } call := func(method, path, body string) (int, string) { t.Helper() req, err := http.NewRequest(method, ts.URL+path, strings.NewReader(body)) if err != nil { t.Fatal(err) } req.Header.Set("Authorization", "Bearer "+token) req.Header.Set("Content-Type", "application/json") res, err := client.Do(req) if err != nil { t.Fatal(err) } return res.StatusCode, read(t, res) } code, body := call(http.MethodGet, "/api/v1/repos/tim/secrets/secrets", "") if code != http.StatusOK || strings.Contains(body, "nieuwe-waarde") || strings.Contains(body, "vervangen-waarde") || !strings.Contains(body, `"invisible":true`) { t.Fatalf("lijst %d %s", code, body) } code, body = call(http.MethodGet, "/api/v1/repos/tim/secrets/secrets/SHOWN", "") if code != http.StatusOK || !strings.Contains(body, "nieuwe-waarde") { t.Fatalf("api toon %d %s", code, body) } code, body = call(http.MethodGet, "/api/v1/repos/tim/secrets/secrets/HIDDEN", "") if code != http.StatusForbidden || strings.Contains(body, "vervangen-waarde") { t.Fatalf("api verborgen %d %s", code, body) } code, body = call(http.MethodPut, "/api/v1/repos/tim/secrets/secrets/HIDDEN", `{"value":"nee","protected":false}`) if code != http.StatusForbidden || strings.Contains(body, "nee") { t.Fatalf("api bewerken %d %s", code, body) } code, body = call(http.MethodPost, "/api/v1/repos/tim/secrets/secrets/HIDDEN/replace", `{"value":"api-nieuw","protected":false}`) if code != http.StatusOK || strings.Contains(body, "api-nieuw") || !strings.Contains(body, `"invisible":true`) { t.Fatalf("api vervangen %d %s", code, body) } code, body = call(http.MethodPut, "/api/v1/repos/tim/secrets/secrets/SHOWN", `{"value":"api-zichtbaar","protected":true}`) if code != http.StatusOK || strings.Contains(body, "api-zichtbaar") || !strings.Contains(body, `"protected":true`) { t.Fatalf("api update %d %s", code, body) } code, body = call(http.MethodPost, "/api/v1/repos/tim/secrets/secrets", `{"name":"GROUPLESS","value":"x"}`) if code != http.StatusCreated || strings.Contains(body, `"value"`) { t.Fatalf("api aanmaken %d %s", code, body) } code, body = call(http.MethodPost, "/api/v1/repos/tim/secrets/secrets", `{"name":"SHOWN","value":"x","invisible":true}`) if code != http.StatusConflict { t.Fatalf("api dubbel %d %s", code, body) } code, body = call(http.MethodDelete, "/api/v1/repos/tim/secrets/secrets/HIDDEN", "") if code != http.StatusNoContent { t.Fatalf("api weg %d %s", code, body) } var listed struct { Secrets []struct { Name string `json:"name"` Invisible bool `json:"invisible"` } `json:"secrets"` } code, body = call(http.MethodGet, "/api/v1/repos/tim/secrets/secrets", "") if err := json.Unmarshal([]byte(body), &listed); err != nil { t.Fatal(err) } for _, m := range listed.Secrets { if m.Name == "HIDDEN" { t.Fatalf("verwijderd blijft in de lijst %s", body) } } _ = code g, err := st.CreateGroup(ctx, tim.ID, "Team", "team", "", "developer") if err != nil { t.Fatal(err) } if err := st.CreateSecret(ctx, "group", g.ID, "GROUP_HIDDEN", "groep-geheim", false, true); err != nil { t.Fatal(err) } res, err = client.Get(ts.URL + "/groups/team?tab=settings") if err != nil { t.Fatal(err) } groupPage := read(t, res) if strings.Contains(groupPage, "groep-geheim") || !strings.Contains(groupPage, "GROUP_HIDDEN") || !strings.Contains(groupPage, ">Replace<") || strings.Contains(groupPage, `data-reveal="GROUP_HIDDEN"`) { t.Fatalf("groepsgeheim:\n%s", groupPage) } code, body = call(http.MethodGet, "/api/v1/groups/team/secrets/GROUP_HIDDEN", "") if code != http.StatusForbidden || strings.Contains(body, "groep-geheim") { t.Fatalf("groep api %d %s", code, body) } } func TestWebhookTableAndEdit(t *testing.T) { if _, err := exec.LookPath("git"); err != nil { t.Skip("git ontbreekt") } storage := t.TempDir() st, err := store.Open(filepath.Join(storage, "bluegit.db"), bytes32()) if err != nil { t.Fatal(err) } t.Cleanup(func() { _ = st.Close() }) cfg := config.Config{ BaseURL: "http://127.0.0.1:9", Listen: "127.0.0.1:0", StoragePath: storage, Auth: config.Auth{Mode: "dev", DevUser: "tim", DevAuthID: 1, UserAgent: "test"}, Git: config.Git{Binary: "git", DefaultBranch: "master"}, } srv := &Server{Cfg: cfg, Store: st, Auth: auth.Dev{Username: "tim", AuthID: 1}, Dev: true, Git: "git", HookBin: "/bin/true"} ts := httptest.NewServer(srv.Handler()) t.Cleanup(ts.Close) jar, _ := cookiejar.New(nil) client := &http.Client{Jar: jar} res, err := client.Get(ts.URL + "/login") if err != nil { t.Fatal(err) } page := read(t, res) res, err = client.PostForm(ts.URL+"/new/repo", url.Values{ "csrf": {csrfOf(t, page)}, "name": {"hooks"}, "visibility": {"private"}, }) if err != nil { t.Fatal(err) } _ = read(t, res) res, err = client.Get(ts.URL + "/tim/hooks/-/settings?tab=webhooks") if err != nil { t.Fatal(err) } page = read(t, res) if !strings.Contains(page, "evgrid") || !strings.Contains(page, `data-preset="custom"`) { t.Fatalf("compact formulier:\n%s", page) } res, err = client.PostForm(ts.URL+"/tim/hooks/-/webhooks", url.Values{ "csrf": {csrfOf(t, page)}, "name": {"ada"}, "preset": {"telegram"}, "token": {"BOT_TOKEN"}, "chat": {"100"}, "event_push": {"1"}, "event_pipeline_success": {"1"}, }) if err != nil { t.Fatal(err) } page = read(t, res) for _, needle := range []string{"hooktable", "urlclip", "data-tip=", ">Edit<", ">Remove<", "pipeline succeeded"} { if !strings.Contains(page, needle) { t.Fatalf("tabel mist %q\n%s", needle, page) } } ctx := context.Background() repo, err := st.RepoByPath(ctx, "tim", "hooks") if err != nil { t.Fatal(err) } hooks, err := st.ListWebhooks(ctx, "repo", repo.ID) if err != nil || len(hooks) != 1 || !strings.Contains(hooks[0].Fields, `"chat":"100"`) { t.Fatalf("velden %#v %v", hooks, err) } res, err = client.Get(ts.URL + "/tim/hooks/-/settings?tab=webhooks&hook=" + strconv.FormatInt(hooks[0].ID, 10)) if err != nil { t.Fatal(err) } edit := read(t, res) for _, needle := range []string{ `name="id"`, `value="ada"`, `value="100"`, `value="telegram" selected`, "Edit webhook", `name="event_push" value="1" checked`, } { if !strings.Contains(edit, needle) { t.Fatalf("bewerken mist %q\n%s", needle, edit) } } res, err = client.PostForm(ts.URL+"/tim/hooks/-/webhooks", url.Values{ "csrf": {csrfOf(t, edit)}, "id": {strconv.FormatInt(hooks[0].ID, 10)}, "name": {"ada"}, "preset": {"telegram"}, "token": {"BOT_TOKEN"}, "chat": {"200"}, "event_push": {"1"}, }) if err != nil { t.Fatal(err) } _ = read(t, res) hooks, err = st.ListWebhooks(ctx, "repo", repo.ID) if err != nil || len(hooks) != 1 || !strings.Contains(hooks[0].BodyTemplate, `"chat_id":"200"`) || strings.Contains(hooks[0].Fields, `"chat":"100"`) { t.Fatalf("bijgewerkt %#v %v", hooks, err) } tim, err := st.UserByUsername(ctx, "tim") if err != nil { t.Fatal(err) } token, err := st.CreateToken(ctx, tim.ID, "laptop") if err != nil { t.Fatal(err) } raw, _ := json.Marshal(map[string]any{ "name": "ada", "preset": "telegram", "token": "BOT_TOKEN", "chat": "300", "events": []string{"push"}, }) req, err := http.NewRequest(http.MethodPut, ts.URL+"/api/v1/repos/tim/hooks/webhooks/"+strconv.FormatInt(hooks[0].ID, 10), strings.NewReader(string(raw))) if err != nil { t.Fatal(err) } req.Header.Set("Authorization", "Bearer "+token) req.Header.Set("Content-Type", "application/json") res, err = client.Do(req) if err != nil { t.Fatal(err) } body := read(t, res) if res.StatusCode != http.StatusOK { t.Fatalf("api %d %s", res.StatusCode, body) } hooks, err = st.ListWebhooks(ctx, "repo", repo.ID) if err != nil || len(hooks) != 1 || !strings.Contains(hooks[0].BodyTemplate, `"chat_id":"300"`) { t.Fatalf("api bijgewerkt %#v %v", hooks, err) } } func TestProtectedSecretRequiresMaintainer(t *testing.T) { if _, err := exec.LookPath("git"); err != nil { t.Skip("git ontbreekt") } storage := t.TempDir() st, err := store.Open(filepath.Join(storage, "bluegit.db"), bytes32()) if err != nil { t.Fatal(err) } t.Cleanup(func() { _ = st.Close() }) cfg := config.Config{ BaseURL: "http://127.0.0.1:9", Listen: "127.0.0.1:0", StoragePath: storage, Auth: config.Auth{Mode: "dev", DevUser: "tim", DevAuthID: 1, UserAgent: "test"}, Git: config.Git{Binary: "git", DefaultBranch: "master"}, } srv := &Server{Cfg: cfg, Store: st, Auth: auth.Dev{Username: "tim", AuthID: 1}, Dev: true, Git: "git", HookBin: "/bin/true"} ts := httptest.NewServer(srv.Handler()) t.Cleanup(ts.Close) jar, _ := cookiejar.New(nil) client := &http.Client{Jar: jar} res, err := client.Get(ts.URL + "/login") if err != nil { t.Fatal(err) } _ = read(t, res) ctx := context.Background() tim, err := st.UserByUsername(ctx, "tim") if err != nil { t.Fatal(err) } res, err = client.PostForm(ts.URL+"/new/repo", url.Values{ "csrf": {csrfOf(t, readBody(t, client, ts.URL+"/new"))}, "name": {"locked"}, "visibility": {"private"}, }) if err != nil { t.Fatal(err) } _ = read(t, res) repo, err := st.RepoByPath(ctx, "tim", "locked") if err != nil { t.Fatal(err) } const secretValue = "protected-waarde-99" if err := st.CreateSecret(ctx, "repo", repo.ID, "DEPLOY_KEY", secretValue, true, false); err != nil { t.Fatal(err) } ada, err := st.UpsertUser(ctx, 2, "ada", "", false) if err != nil { t.Fatal(err) } if err := st.SetMember(ctx, "repo", repo.ID, "ada", access.RoleDeveloper); err != nil { t.Fatal(err) } adaSess, err := st.CreateSession(ctx, ada.ID, "dev", time.Now().Add(time.Hour)) if err != nil { t.Fatal(err) } adaJar, _ := cookiejar.New(nil) adaClient := &http.Client{Jar: adaJar} u, _ := url.Parse(ts.URL) adaJar.SetCookies(u, []*http.Cookie{{Name: "bluegit_session", Value: adaSess.ID, Path: "/"}}) page := readBody(t, adaClient, ts.URL+"/tim/locked/-/settings?tab=secrets") if strings.Contains(page, secretValue) || strings.Contains(page, `data-reveal="DEPLOY_KEY"`) || strings.Contains(page, `value="update"`) { t.Fatalf("ontwikkelaar ziet een protected secret:\n%s", page) } res, err = adaClient.PostForm(ts.URL+"/tim/locked/-/secrets/reveal", url.Values{ "csrf": {adaSess.CSRF}, "name": {"DEPLOY_KEY"}, }) if err != nil { t.Fatal(err) } revealed := read(t, res) if res.StatusCode != http.StatusForbidden || strings.Contains(revealed, secretValue) { t.Fatalf("ui toon %d %s", res.StatusCode, revealed) } res, err = adaClient.PostForm(ts.URL+"/tim/locked/-/secrets", url.Values{ "csrf": {adaSess.CSRF}, "mode": {"update"}, "name": {"DEPLOY_KEY"}, "value": {"gekraakt"}, }) if err != nil { t.Fatal(err) } edited := read(t, res) if res.StatusCode != http.StatusForbidden || strings.Contains(edited, secretValue) || strings.Contains(edited, "gekraakt") { t.Fatalf("ui bewerken %d %s", res.StatusCode, edited) } adaTok, err := st.CreateToken(ctx, ada.ID, "ada") if err != nil { t.Fatal(err) } timTok, err := st.CreateToken(ctx, tim.ID, "tim") if err != nil { t.Fatal(err) } call := func(tok, method, path, body string) (int, string) { t.Helper() req, err := http.NewRequest(method, ts.URL+path, strings.NewReader(body)) if err != nil { t.Fatal(err) } req.Header.Set("Authorization", "Bearer "+tok) req.Header.Set("Content-Type", "application/json") res, err := client.Do(req) if err != nil { t.Fatal(err) } return res.StatusCode, read(t, res) } for _, tc := range []struct{ method, path, body string }{ {http.MethodGet, "/api/v1/repos/tim/locked/secrets", ""}, {http.MethodGet, "/api/v1/repos/tim/locked/secrets/DEPLOY_KEY", ""}, {http.MethodPut, "/api/v1/repos/tim/locked/secrets/DEPLOY_KEY", `{"value":"gekraakt","protected":false}`}, {http.MethodPost, "/api/v1/repos/tim/locked/secrets/DEPLOY_KEY/replace", `{"value":"gekraakt","protected":true}`}, } { code, body := call(adaTok, tc.method, tc.path, tc.body) if code != http.StatusForbidden || strings.Contains(body, secretValue) || strings.Contains(body, "gekraakt") { t.Fatalf("api %s %s %d %s", tc.method, tc.path, code, body) } } vals, err := st.SecretValues(ctx, "repo", repo.ID, true) if err != nil || vals["DEPLOY_KEY"] != secretValue { t.Fatalf("waarde veranderde: %#v %v", vals, err) } code, body := call(timTok, http.MethodGet, "/api/v1/repos/tim/locked/secrets/DEPLOY_KEY", "") if code != http.StatusOK || !strings.Contains(body, secretValue) { t.Fatalf("maintainer toon %d %s", code, body) } g, err := st.CreateGroup(ctx, tim.ID, "Team", "team", "", "developer") if err != nil { t.Fatal(err) } if err := st.SetMember(ctx, "group", g.ID, "ada", access.RoleDeveloper); err != nil { t.Fatal(err) } const groupValue = "groep-protected-waarde" if err := st.CreateSecret(ctx, "group", g.ID, "GROUP_KEY", groupValue, true, false); err != nil { t.Fatal(err) } groupPage := readBody(t, adaClient, ts.URL+"/groups/team?tab=settings") if strings.Contains(groupPage, groupValue) || strings.Contains(groupPage, `data-reveal="GROUP_KEY"`) { t.Fatalf("groepsontwikkelaar ziet het secret:\n%s", groupPage) } code, body = call(adaTok, http.MethodGet, "/api/v1/groups/team/secrets/GROUP_KEY", "") if code != http.StatusForbidden || strings.Contains(body, groupValue) { t.Fatalf("groep api toon %d %s", code, body) } code, body = call(adaTok, http.MethodPut, "/api/v1/groups/team/secrets/GROUP_KEY", `{"value":"gekraakt","protected":false}`) if code != http.StatusForbidden || strings.Contains(body, groupValue) { t.Fatalf("groep api bewerken %d %s", code, body) } code, body = call(timTok, http.MethodGet, "/api/v1/groups/team/secrets/GROUP_KEY", "") if code != http.StatusOK || !strings.Contains(body, groupValue) { t.Fatalf("groepseigenaar toon %d %s", code, body) } } func readBody(t *testing.T, client *http.Client, rawURL string) string { t.Helper() res, err := client.Get(rawURL) if err != nil { t.Fatal(err) } return read(t, res) }