package server import ( "context" "encoding/json" "fmt" "net/http" "net/http/cookiejar" "net/http/httptest" "net/url" "os/exec" "path/filepath" "strings" "testing" "time" "gitlab.com/Timfa/bluegit/internal/auth" "gitlab.com/Timfa/bluegit/internal/config" "gitlab.com/Timfa/bluegit/internal/store" ) func TestWebhookPatchCopyKeepsSecretsServerSide(t *testing.T) { if _, err := exec.LookPath("git"); err != nil { t.Skip("git ontbreekt") } storage := t.TempDir() st, err := store.Open(filepath.Join(storage, "bluegit.db"), bytes32()) if err != nil { t.Fatal(err) } t.Cleanup(func() { _ = st.Close() }) ctx := context.Background() ada, err := st.UpsertUser(ctx, 1, "ada", "", false) if err != nil { t.Fatal(err) } dev, err := st.UpsertUser(ctx, 2, "dev", "", false) if err != nil { t.Fatal(err) } issue := func(u store.User) string { plain, _, err := st.IssueToken(ctx, u.ID, store.TokenRequest{Name: u.Username, Scopes: "api", ExpiresAt: time.Time{}}) if err != nil { t.Fatal(err) } return plain } adaTok, devTok := issue(ada), issue(dev) cfg := config.Config{ BaseURL: "http://127.0.0.1:9", StoragePath: storage, Auth: config.Auth{Mode: "dev", DevUser: "ada", DevAuthID: 1}, Git: config.Git{Binary: "git", DefaultBranch: "master"}, } srv := &Server{Cfg: cfg, Store: st, Auth: auth.Dev{Username: "ada", AuthID: 1}, Dev: true, Git: "git", HookBin: "/bin/true", StateDir: t.TempDir()} ts := httptest.NewServer(srv.Handler()) t.Cleanup(ts.Close) const secretVal = "geheim-waarde-1234567890" var all strings.Builder call := func(method, path, token, body string) (int, string) { t.Helper() req, _ := http.NewRequest(method, ts.URL+path, strings.NewReader(body)) if body != "" { req.Header.Set("Content-Type", "application/json") } req.Header.Set("Authorization", "Bearer "+token) res, err := http.DefaultClient.Do(req) if err != nil { t.Fatal(err) } out := read(t, res) all.WriteString(out) return res.StatusCode, out } want := func(code int, body string, label string, status int, contains string) { t.Helper() if code != status || (contains != "" && !strings.Contains(body, contains)) { t.Fatalf("%s: status %d body %s", label, code, body) } } for _, n := range []string{"Src", "Dst"} { code, body := call(http.MethodPost, "/api/v1/projects", adaTok, `{"name":"`+n+`","visibility":"private"}`) want(code, body, "project "+n, 201, "") } code, body := call(http.MethodPost, "/api/v1/groups", adaTok, `{"name":"Team"}`) want(code, body, "groep", 201, `"path":"team"`) src, _ := st.RepoByPath(ctx, "ada", "src") dst, _ := st.RepoByPath(ctx, "ada", "dst") team, _ := st.GroupByPath(ctx, "team") if err := st.PutSecret(ctx, "repo", src.ID, "GROK_TOKEN", secretVal, false); err != nil { t.Fatal(err) } code, body = call(http.MethodPost, "/api/v1/projects/ada/src/webhooks", adaTok, `{"name":"Ada","preset":"custom","url":"https://example.test/hook","events":["push"],"headers":"Authorization: Bearer {{secret.GROK_TOKEN}}\nX-Missing: {{secret.NOPE}}"}`) want(code, body, "maken", 201, `"id"`) var made struct{ ID int64 } _ = json.Unmarshal([]byte(body), &made) base := fmt.Sprintf("/api/v1/projects/ada/src/webhooks/%d", made.ID) code, body = call(http.MethodPatch, base, adaTok, `{"name":"Ada 2","token":"","events":["push","pipeline_success"]}`) want(code, body, "patch", 200, `"name":"Ada 2"`) h, err := st.Webhook(ctx, "repo", src.ID, made.ID) if err != nil || !strings.Contains(h.Headers["Authorization"], "{{secret.GROK_TOKEN}}") || len(h.Events) != 2 { t.Fatalf("patch verloor velden: %+v %v", h, err) } code, body = call(http.MethodPatch, base, adaTok, `{"active":false}`) want(code, body, "uit", 200, `"active":false`) code, body = call(http.MethodPatch, base, adaTok, `{"active":true}`) want(code, body, "aan", 200, `"active":true`) code, body = call(http.MethodPatch, base, devTok, `{"name":"x"}`) if code != 403 && code != 404 { t.Fatalf("dev mag niet patchen: %d %s", code, body) } code, body = call(http.MethodPost, base+"/copy", adaTok, `{"target_type":"project","target":"ada/dst","name":"Kopie"}`) want(code, body, "kopie project", 201, `"copied_secrets":["GROK_TOKEN"]`) want(code, body, "ontbrekend", 201, `"missing_secrets":["NOPE"]`) vals, err := st.SecretValues(ctx, "repo", dst.ID, true) if err != nil || vals["GROK_TOKEN"] != secretVal { t.Fatalf("geheim niet server-side gekopieerd: %v", err) } used, err := srv.hookSecrets(ctx, "repo", dst.ID, true, dst) if err != nil || used["GROK_TOKEN"] != secretVal { t.Fatalf("kopie gebruikt het geheim niet: %v", err) } hooks, _ := st.ListWebhooks(ctx, "repo", dst.ID) if len(hooks) != 1 || hooks[0].Name != "Kopie" || !strings.Contains(hooks[0].Headers["Authorization"], "{{secret.GROK_TOKEN}}") { t.Fatalf("kopie klopt niet: %+v", hooks) } code, body = call(http.MethodPost, base+"/copy", adaTok, `{"target_type":"project","target":"ada/dst"}`) want(code, body, "tweede kopie", 201, `"copied_secrets":[]`) code, body = call(http.MethodPost, base+"/copy", adaTok, `{"target_type":"group","target":"team","events":["release_published"]}`) want(code, body, "kopie groep", 201, `"scope":"group"`) gv, _ := st.SecretValues(ctx, "group", team.ID, true) if gv["GROK_TOKEN"] != secretVal { t.Fatal("groepsgeheim ontbreekt") } code, body = call(http.MethodPost, base+"/copy", devTok, `{"target_type":"group","target":"team"}`) if code != 403 && code != 404 { t.Fatalf("dev mag niet kopiƫren: %d %s", code, body) } code, body = call(http.MethodPost, base+"/copy", adaTok, `{"target_type":"project","target":"ada/bestaatniet"}`) want(code, body, "onbekend doel", 404, "") code, body = call(http.MethodGet, "/api/v1/projects/ada/dst/webhooks", adaTok, "") want(code, body, "lijst", 200, "Kopie") code, body = call(http.MethodDelete, fmt.Sprintf("/api/v1/projects/ada/dst/webhooks/%d", hooks[0].ID), adaTok, "") want(code, body, "verwijderen", 204, "") code, body = call(http.MethodGet, "/api/v1/openapi.json", "", "") want(code, body, "openapi", 200, "/webhooks/{id}/copy") jar, _ := cookiejar.New(nil) client := &http.Client{Jar: jar} res, err := client.Get(ts.URL + "/login") if err != nil { t.Fatal(err) } _ = read(t, res) res, err = client.Get(ts.URL + "/ada/src/-/settings?tab=webhooks") if err != nil { t.Fatal(err) } page := read(t, res) all.WriteString(page) if !strings.Contains(page, "data-hookcopy-open") || !strings.Contains(page, `value="group:team"`) || !strings.Contains(page, `value="project:ada/dst"`) { t.Fatalf("kopieerknop of doelen ontbreken") } res, err = client.PostForm(ts.URL+"/ada/src/-/webhooks/copy", url.Values{ "csrf": {csrfOf(t, page)}, "id": {fmt.Sprint(made.ID)}, "target": {"project:ada/dst"}, "name": {"Via UI"}, }) if err != nil { t.Fatal(err) } all.WriteString(read(t, res)) hooks, _ = st.ListWebhooks(ctx, "repo", dst.ID) found := false for _, h := range hooks { found = found || h.Name == "Via UI" } if !found { t.Fatalf("UI-kopie ontbreekt: %+v", hooks) } if strings.Contains(all.String(), secretVal) { t.Fatal("geheime waarde in een API-respons") } }