BlueGit

timfa filemanager

Adjust subtitle overlay max-height from 35% to 50%

The previous fix removed max-height constraints entirely to allow upscaling
of downscaled subtitle frames (rendered at 0.5 scale). However, this caused
subtitles to become excessively large, filling up to 100% of the overlay
height and falling off screen edges.

Revised approach: keep max-width and max-height constraints but increase
max-height from 35% to 50% of the overlay container. This allows server-side
downscaled frames (0.5 scale) to upscale sufficiently for visibility while
maintaining reasonable bounds that prevent overflow in both normal and
fullscreen modes.

timfa Tim Falken · pushed by timfa

Authored 2026-05-20 · 6 months ago

Hash
61a618ba75c789fd5b25f61fa3ccf0b9620d5568
Parent
505c187a
1 file changed +2 −2
public/app.js +2 −2
@@ -755,8 +755,8 @@ function bindImageSubtitleOverlay (player, videojs, prefs, session, item)
755 755 overlayImgEl = document.createElement('img');
756 756 overlayImgEl.alt = 'Image subtitles';
757 757 overlayImgEl.style.display = 'none';
758 overlayImgEl.style.width = '100%';
759 overlayImgEl.style.height = 'auto';
758 overlayImgEl.style.maxWidth = '100%';
759 overlayImgEl.style.maxHeight = '50%';
760 760 overlayImgEl.style.margin = '0 auto';
761 761 overlayImgEl.style.objectFit = 'contain';
762 762 overlayImgEl.style.filter = 'drop-shadow(0 2px 2px rgba(0, 0, 0, 0.7))';
@@ -755,8 +755,8 @@ function bindImageSubtitleOverlay (player, videojs, prefs, session, item)
755 overlayImgEl = document.createElement('img');
755 overlayImgEl = document.createElement('img');
756 overlayImgEl.alt = 'Image subtitles';
756 overlayImgEl.alt = 'Image subtitles';
757 overlayImgEl.style.display = 'none';
757 overlayImgEl.style.display = 'none';
758 overlayImgEl.style.width = '100%';
758 overlayImgEl.style.maxWidth = '100%';
759 overlayImgEl.style.height = 'auto';
759 overlayImgEl.style.maxHeight = '50%';
760 overlayImgEl.style.margin = '0 auto';
760 overlayImgEl.style.margin = '0 auto';
761 overlayImgEl.style.objectFit = 'contain';
761 overlayImgEl.style.objectFit = 'contain';
762 overlayImgEl.style.filter = 'drop-shadow(0 2px 2px rgba(0, 0, 0, 0.7))';
762 overlayImgEl.style.filter = 'drop-shadow(0 2px 2px rgba(0, 0, 0, 0.7))';