BlueGit

timfa minecart-trains

Make minecart coupling work regardless of click order.

Co-authored-by: Cursor <cursoragent@cursor.com>

timfa Tim Falken · pushed by timfa

Authored 2026-08-22 · 2 months ago

Hash
cc8a6c9d53492d56ef853fa2d9be306646329f78
Parent
de50f551
5 files changed +267 −63
README.md +1 −2
@@ -27,7 +27,7 @@ Introducing Minecart Trains! Experience a whole new level of immersion as you co
27 27 ### How it works:
28 28 **Coupling:**
29 29
30 The standard coupling tool is the chain. With this you click on two minecarts one after the other. The second one will follow the first one. With a train you work your way through from front to back. (I am working on making the order irrelevant).
30 The standard coupling tool is the chain. Click two minecarts one after the other to couple them. The click order does not matter: free carts, train ends, and whole trains are connected at the carts you click. Furnace minecarts become the front of a new pair when present.
31 31
32 32 **Coal Carts:**
33 33
@@ -36,7 +36,6 @@ Furnace minecarts will, if already going, refuel from a coal cart nearby. Coal c
36 36 ### What is planned:
37 37 - safe chunk unloading
38 38 - auto. chunk loading
39 - making the linking order irrelevant
40 39 - some kind of fuel gauge
41 40
42 41 ### What is not (yet) possible:
@@ -27,7 +27,7 @@ Introducing Minecart Trains! Experience a whole new level of immersion as you co
27### How it works:
27### How it works:
28**Coupling:**
28**Coupling:**
29
29
30The standard coupling tool is the chain. With this you click on two minecarts one after the other. The second one will follow the first one. With a train you work your way through from front to back. (I am working on making the order irrelevant).
30The standard coupling tool is the chain. Click two minecarts one after the other to couple them. The click order does not matter: free carts, train ends, and whole trains are connected at the carts you click. Furnace minecarts become the front of a new pair when present.
31
31
32**Coal Carts:**
32**Coal Carts:**
33
33
@@ -36,7 +36,6 @@ Furnace minecarts will, if already going, refuel from a coal cart nearby. Coal c
36### What is planned:
36### What is planned:
37- safe chunk unloading
37- safe chunk unloading
38- auto. chunk loading
38- auto. chunk loading
39- making the linking order irrelevant
40- some kind of fuel gauge
39- some kind of fuel gauge
41
40
42### What is not (yet) possible:
41### What is not (yet) possible:
src/main/java/me/fridtjof/minecarttrains/events/OnPlayerInteractEntityEvent.java +44 −53
@@ -1,7 +1,7 @@
1 1 package me.fridtjof.minecarttrains.events;
2 2
3 import me.fridtjof.minecarttrains.managers.LinkageManager;
4 3 import me.fridtjof.minecarttrains.MinecartTrains;
4 import me.fridtjof.minecarttrains.managers.LinkageManager;
5 5 import org.bukkit.Bukkit;
6 6 import org.bukkit.Material;
7 7 import org.bukkit.entity.Entity;
@@ -19,96 +19,87 @@ import java.util.UUID;
19 19 public class OnPlayerInteractEntityEvent implements Listener
20 20 {
21 21
22 // --> coupling tool
23 22 static MinecartTrains plugin = MinecartTrains.getInstance();
24 23
24 private final Map<UUID, UUID> firstCarts = new HashMap<>();
25 private final Map<UUID, Long> lastCouplings = new HashMap<>();
25 26
26 // minecart storage
27 Map<String, Integer> selectedCarts = new HashMap<String, Integer>();
28 Map<String, UUID> firstCarts = new HashMap<String, UUID>();
29 Map<String, UUID> secondCarts = new HashMap<String, UUID>();
30 Map<String, Long> lastCouplings = new HashMap<String, Long>();
31
32 // get config vars
33 27 Material couplingTool = Material.getMaterial(plugin.configManager.mainConfig.getConfig().getString("trains.coupling.tool"));
34 28 double maxDistance = plugin.configManager.physicsConfig.getConfig().getDouble("coupling.max_distance");
35 29
36 LinkageManager linkageManager = new LinkageManager();
30 LinkageManager linkageManager = plugin.linkageManager;
37 31
38 32 @EventHandler
39 33 public void onPlayerInteractEntityEvent(PlayerInteractEntityEvent event)
40 34 {
41
42 if(event.getHand() != EquipmentSlot.HAND)
35 if (event.getHand() != EquipmentSlot.HAND)
43 36 {
44 37 return;
45 38 }
46 39
47 40 Player player = event.getPlayer();
48 String playerId = player.getUniqueId() + "";
41 UUID playerId = player.getUniqueId();
49 42 Material material = player.getInventory().getItemInMainHand().getType();
50 43 Entity target = event.getRightClicked();
51 Minecart minecart;
52 44
53 if(material != couplingTool)
45 if (material != couplingTool)
54 46 {
55 47 return;
56 48 }
57 49
58 if(!(target instanceof Minecart))
50 if (!(target instanceof Minecart minecart))
59 51 {
60 52 return;
61 53 }
62 minecart = (Minecart) target;
63 54
64 55 event.setCancelled(true);
65 56
66 //forget first selection
67 if(selectedCarts.get(playerId) == null)
57 Long lastCoupling = lastCouplings.get(playerId);
58 if (lastCoupling != null && lastCoupling < System.currentTimeMillis() - 10000)
68 59 {
69 selectedCarts.put(playerId, 1);
70 lastCouplings.put(playerId, System.currentTimeMillis());
60 firstCarts.remove(playerId);
71 61 }
72 else if(lastCouplings.get(playerId) < System.currentTimeMillis() - 10000)
62
63 if (!firstCarts.containsKey(playerId))
73 64 {
74 selectedCarts.put(playerId, 1);
65 firstCarts.put(playerId, minecart.getUniqueId());
75 66 lastCouplings.put(playerId, System.currentTimeMillis());
67 player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_1-2") + minecart.getName());
68 return;
76 69 }
77 70
78 int selectedCart = selectedCarts.get(playerId);
71 UUID firstId = firstCarts.remove(playerId);
72 lastCouplings.put(playerId, System.currentTimeMillis());
73 player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_2-2") + minecart.getName());
79 74
80 if(selectedCart == 1)
75 Entity firstEntity = Bukkit.getEntity(firstId);
76 if (!(firstEntity instanceof Minecart firstCart))
81 77 {
82 firstCarts.put(playerId, minecart.getUniqueId());
83 selectedCarts.put(player.getUniqueId() + "", 2);
84 player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_1-2") + minecart.getName());
78 player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_failed_missing"));
79 return;
80 }
81
82 if (firstCart.getUniqueId().equals(minecart.getUniqueId()))
83 {
84 player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_failed_self"));
85 return;
85 86 }
86 else if(selectedCart == 2)
87
88 if (firstCart.getWorld() != minecart.getWorld()
89 || firstCart.getLocation().distanceSquared(minecart.getLocation()) > maxDistance * maxDistance)
90 {
91 player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_failed_distance"));
92 return;
93 }
94
95 LinkageManager.CoupleResult result = linkageManager.couple(firstCart, minecart);
96 switch (result)
87 97 {
88 secondCarts.put(playerId, minecart.getUniqueId());
89 selectedCarts.put(player.getUniqueId() + "", 1);
90 player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_2-2") + minecart.getName());
91
92 Entity firstCart = Bukkit.getEntity(firstCarts.get(playerId));
93 Entity secondCart = Bukkit.getEntity(secondCarts.get(playerId));
94
95 // check distance
96 if(firstCart.getLocation().distance(secondCart.getLocation()) > maxDistance)
97 {
98 player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_failed_distance"));
99 return;
100 }
101
102 // check trying to couple with itself
103 if(firstCart == secondCart)
104 {
105 player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_failed_self"));
106 return;
107 }
108
109 linkageManager.setLink((Minecart) secondCart, firstCarts.get(playerId) + "");
110
111 player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_successful"));
98 case SUCCESS -> player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_successful"));
99 case SELF -> player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_failed_self"));
100 case SAME_TRAIN -> player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_failed_same_train"));
101 case NOT_AN_END -> player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_failed_not_end"));
102 default -> player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_failed_invalid"));
112 103 }
113 104 }
114 105 }
@@ -1,7 +1,7 @@
1package me.fridtjof.minecarttrains.events;
1package me.fridtjof.minecarttrains.events;
2
2
3import me.fridtjof.minecarttrains.managers.LinkageManager;
4import me.fridtjof.minecarttrains.MinecartTrains;
3import me.fridtjof.minecarttrains.MinecartTrains;
4import me.fridtjof.minecarttrains.managers.LinkageManager;
5import org.bukkit.Bukkit;
5import org.bukkit.Bukkit;
6import org.bukkit.Material;
6import org.bukkit.Material;
7import org.bukkit.entity.Entity;
7import org.bukkit.entity.Entity;
@@ -19,96 +19,87 @@ import java.util.UUID;
19public class OnPlayerInteractEntityEvent implements Listener
19public class OnPlayerInteractEntityEvent implements Listener
20{
20{
21
21
22 // --> coupling tool
23 static MinecartTrains plugin = MinecartTrains.getInstance();
22 static MinecartTrains plugin = MinecartTrains.getInstance();
24
23
24 private final Map<UUID, UUID> firstCarts = new HashMap<>();
25 private final Map<UUID, Long> lastCouplings = new HashMap<>();
25
26
26 // minecart storage
27 Map<String, Integer> selectedCarts = new HashMap<String, Integer>();
28 Map<String, UUID> firstCarts = new HashMap<String, UUID>();
29 Map<String, UUID> secondCarts = new HashMap<String, UUID>();
30 Map<String, Long> lastCouplings = new HashMap<String, Long>();
31
32 // get config vars
33 Material couplingTool = Material.getMaterial(plugin.configManager.mainConfig.getConfig().getString("trains.coupling.tool"));
27 Material couplingTool = Material.getMaterial(plugin.configManager.mainConfig.getConfig().getString("trains.coupling.tool"));
34 double maxDistance = plugin.configManager.physicsConfig.getConfig().getDouble("coupling.max_distance");
28 double maxDistance = plugin.configManager.physicsConfig.getConfig().getDouble("coupling.max_distance");
35
29
36 LinkageManager linkageManager = new LinkageManager();
30 LinkageManager linkageManager = plugin.linkageManager;
37
31
38 @EventHandler
32 @EventHandler
39 public void onPlayerInteractEntityEvent(PlayerInteractEntityEvent event)
33 public void onPlayerInteractEntityEvent(PlayerInteractEntityEvent event)
40 {
34 {
41
35 if (event.getHand() != EquipmentSlot.HAND)
42 if(event.getHand() != EquipmentSlot.HAND)
43 {
36 {
44 return;
37 return;
45 }
38 }
46
39
47 Player player = event.getPlayer();
40 Player player = event.getPlayer();
48 String playerId = player.getUniqueId() + "";
41 UUID playerId = player.getUniqueId();
49 Material material = player.getInventory().getItemInMainHand().getType();
42 Material material = player.getInventory().getItemInMainHand().getType();
50 Entity target = event.getRightClicked();
43 Entity target = event.getRightClicked();
51 Minecart minecart;
52
44
53 if(material != couplingTool)
45 if (material != couplingTool)
54 {
46 {
55 return;
47 return;
56 }
48 }
57
49
58 if(!(target instanceof Minecart))
50 if (!(target instanceof Minecart minecart))
59 {
51 {
60 return;
52 return;
61 }
53 }
62 minecart = (Minecart) target;
63
54
64 event.setCancelled(true);
55 event.setCancelled(true);
65
56
66 //forget first selection
57 Long lastCoupling = lastCouplings.get(playerId);
67 if(selectedCarts.get(playerId) == null)
58 if (lastCoupling != null && lastCoupling < System.currentTimeMillis() - 10000)
68 {
59 {
69 selectedCarts.put(playerId, 1);
60 firstCarts.remove(playerId);
70 lastCouplings.put(playerId, System.currentTimeMillis());
71 }
61 }
72 else if(lastCouplings.get(playerId) < System.currentTimeMillis() - 10000)
62
63 if (!firstCarts.containsKey(playerId))
73 {
64 {
74 selectedCarts.put(playerId, 1);
65 firstCarts.put(playerId, minecart.getUniqueId());
75 lastCouplings.put(playerId, System.currentTimeMillis());
66 lastCouplings.put(playerId, System.currentTimeMillis());
67 player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_1-2") + minecart.getName());
68 return;
76 }
69 }
77
70
78 int selectedCart = selectedCarts.get(playerId);
71 UUID firstId = firstCarts.remove(playerId);
72 lastCouplings.put(playerId, System.currentTimeMillis());
73 player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_2-2") + minecart.getName());
79
74
80 if(selectedCart == 1)
75 Entity firstEntity = Bukkit.getEntity(firstId);
76 if (!(firstEntity instanceof Minecart firstCart))
81 {
77 {
82 firstCarts.put(playerId, minecart.getUniqueId());
78 player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_failed_missing"));
83 selectedCarts.put(player.getUniqueId() + "", 2);
79 return;
84 player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_1-2") + minecart.getName());
80 }
81
82 if (firstCart.getUniqueId().equals(minecart.getUniqueId()))
83 {
84 player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_failed_self"));
85 return;
85 }
86 }
86 else if(selectedCart == 2)
87
88 if (firstCart.getWorld() != minecart.getWorld()
89 || firstCart.getLocation().distanceSquared(minecart.getLocation()) > maxDistance * maxDistance)
90 {
91 player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_failed_distance"));
92 return;
93 }
94
95 LinkageManager.CoupleResult result = linkageManager.couple(firstCart, minecart);
96 switch (result)
87 {
97 {
88 secondCarts.put(playerId, minecart.getUniqueId());
98 case SUCCESS -> player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_successful"));
89 selectedCarts.put(player.getUniqueId() + "", 1);
99 case SELF -> player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_failed_self"));
90 player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_2-2") + minecart.getName());
100 case SAME_TRAIN -> player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_failed_same_train"));
91
101 case NOT_AN_END -> player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_failed_not_end"));
92 Entity firstCart = Bukkit.getEntity(firstCarts.get(playerId));
102 default -> player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_failed_invalid"));
93 Entity secondCart = Bukkit.getEntity(secondCarts.get(playerId));
94
95 // check distance
96 if(firstCart.getLocation().distance(secondCart.getLocation()) > maxDistance)
97 {
98 player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_failed_distance"));
99 return;
100 }
101
102 // check trying to couple with itself
103 if(firstCart == secondCart)
104 {
105 player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_failed_self"));
106 return;
107 }
108
109 linkageManager.setLink((Minecart) secondCart, firstCarts.get(playerId) + "");
110
111 player.sendMessage(plugin.configManager.messagesFile.getConfig().getString("trains.coupling_successful"));
112 }
103 }
113 }
104 }
114}
105}
src/main/java/me/fridtjof/minecarttrains/events/OnVehicleUpdateEvent.java +3 −1
@@ -68,6 +68,8 @@ public class OnVehicleUpdateEvent implements Listener
68 68 }
69 69 }*/
70 70
71 linkageManager.remember(minecart);
72
71 73 // ensures the below function only works on trains, not on single minecarts
72 74 if(!linkageManager.hasLink((minecart)))
73 75 {
@@ -104,7 +106,7 @@ public class OnVehicleUpdateEvent implements Listener
104 106 return;
105 107 }
106 108
107 parent = Bukkit.getEntity(linkageManager.getLinkUniqueId(minecart));
109 parent = linkageManager.getParent(minecart);
108 110
109 111 // breaks link if parent cart is broken
110 112 if(parent == null)
@@ -68,6 +68,8 @@ public class OnVehicleUpdateEvent implements Listener
68 }
68 }
69 }*/
69 }*/
70
70
71 linkageManager.remember(minecart);
72
71 // ensures the below function only works on trains, not on single minecarts
73 // ensures the below function only works on trains, not on single minecarts
72 if(!linkageManager.hasLink((minecart)))
74 if(!linkageManager.hasLink((minecart)))
73 {
75 {
@@ -104,7 +106,7 @@ public class OnVehicleUpdateEvent implements Listener
104 return;
106 return;
105 }
107 }
106
108
107 parent = Bukkit.getEntity(linkageManager.getLinkUniqueId(minecart));
109 parent = linkageManager.getParent(minecart);
108
110
109 // breaks link if parent cart is broken
111 // breaks link if parent cart is broken
110 if(parent == null)
112 if(parent == null)
src/main/java/me/fridtjof/minecarttrains/managers/ConfigManager.java +4 −0
@@ -144,6 +144,10 @@ public class ConfigManager
144 144 messagesFile.getConfig().addDefault("trains.coupling_successful", "Coupling successful!");
145 145 messagesFile.getConfig().addDefault("trains.coupling_failed_distance", "Coupling failed! - The minecarts are too far apart!");
146 146 messagesFile.getConfig().addDefault("trains.coupling_failed_self", "Coupling failed! - Can't be coupled with itself!");
147 messagesFile.getConfig().addDefault("trains.coupling_failed_same_train", "Coupling failed! - Those minecarts are already part of the same train!");
148 messagesFile.getConfig().addDefault("trains.coupling_failed_not_end", "Coupling failed! - You can only couple the ends of a train!");
149 messagesFile.getConfig().addDefault("trains.coupling_failed_missing", "Coupling failed! - The first minecart is no longer loaded!");
150 messagesFile.getConfig().addDefault("trains.coupling_failed_invalid", "Coupling failed!");
147 151 messagesFile.getConfig().addDefault("trains.coupling_already_coupled_with_itself", "Minecart is coupled with itself! - this shouldn't be possible!");
148 152
149 153 messagesFile.getConfig().addDefault("trains.coupling_1-2", "Coupling (1/2) activated for ");
@@ -144,6 +144,10 @@ public class ConfigManager
144 messagesFile.getConfig().addDefault("trains.coupling_successful", "Coupling successful!");
144 messagesFile.getConfig().addDefault("trains.coupling_successful", "Coupling successful!");
145 messagesFile.getConfig().addDefault("trains.coupling_failed_distance", "Coupling failed! - The minecarts are too far apart!");
145 messagesFile.getConfig().addDefault("trains.coupling_failed_distance", "Coupling failed! - The minecarts are too far apart!");
146 messagesFile.getConfig().addDefault("trains.coupling_failed_self", "Coupling failed! - Can't be coupled with itself!");
146 messagesFile.getConfig().addDefault("trains.coupling_failed_self", "Coupling failed! - Can't be coupled with itself!");
147 messagesFile.getConfig().addDefault("trains.coupling_failed_same_train", "Coupling failed! - Those minecarts are already part of the same train!");
148 messagesFile.getConfig().addDefault("trains.coupling_failed_not_end", "Coupling failed! - You can only couple the ends of a train!");
149 messagesFile.getConfig().addDefault("trains.coupling_failed_missing", "Coupling failed! - The first minecart is no longer loaded!");
150 messagesFile.getConfig().addDefault("trains.coupling_failed_invalid", "Coupling failed!");
147 messagesFile.getConfig().addDefault("trains.coupling_already_coupled_with_itself", "Minecart is coupled with itself! - this shouldn't be possible!");
151 messagesFile.getConfig().addDefault("trains.coupling_already_coupled_with_itself", "Minecart is coupled with itself! - this shouldn't be possible!");
148
152
149 messagesFile.getConfig().addDefault("trains.coupling_1-2", "Coupling (1/2) activated for ");
153 messagesFile.getConfig().addDefault("trains.coupling_1-2", "Coupling (1/2) activated for ");
src/main/java/me/fridtjof/minecarttrains/managers/LinkageManager.java +215 −7
@@ -1,27 +1,44 @@
1 1 package me.fridtjof.minecarttrains.managers;
2 2
3 3 import me.fridtjof.minecarttrains.MinecartTrains;
4 import org.bukkit.Bukkit;
4 5 import org.bukkit.NamespacedKey;
6 import org.bukkit.entity.Entity;
5 7 import org.bukkit.entity.Minecart;
6 import org.bukkit.persistence.PersistentDataContainer;
8 import org.bukkit.entity.minecart.PoweredMinecart;
7 9 import org.bukkit.persistence.PersistentDataType;
8 10
11 import java.util.ArrayList;
12 import java.util.HashMap;
13 import java.util.HashSet;
14 import java.util.List;
15 import java.util.Map;
16 import java.util.Set;
9 17 import java.util.UUID;
10 18
11 19 public class LinkageManager
12 20 {
13 21
14 static MinecartTrains plugin = MinecartTrains.getInstance();
15
16 NamespacedKey key = new NamespacedKey(plugin, "coupler");
17
18 public LinkageManager()
22 public enum CoupleResult
19 23 {
20
24 SUCCESS,
25 SELF,
26 SAME_TRAIN,
27 NOT_AN_END,
28 INVALID
21 29 }
22 30
31 static MinecartTrains plugin = MinecartTrains.getInstance();
32
33 private final NamespacedKey key = new NamespacedKey(plugin, "coupler");
34 private final Map<UUID, UUID> childByParent = new HashMap<>();
35
23 36 public void removeLink(Minecart cart)
24 37 {
38 if (hasLink(cart))
39 {
40 childByParent.remove(getLinkUniqueId(cart), cart.getUniqueId());
41 }
25 42 cart.getPersistentDataContainer().remove(key);
26 43 }
27 44
@@ -37,11 +54,202 @@ public class LinkageManager
37 54
38 55 public void setLink(Minecart cart, String linkedCartUniqueId)
39 56 {
57 if (hasLink(cart))
58 {
59 childByParent.remove(getLinkUniqueId(cart), cart.getUniqueId());
60 }
40 61 cart.getPersistentDataContainer().set(key, PersistentDataType.STRING, linkedCartUniqueId);
62 childByParent.put(UUID.fromString(linkedCartUniqueId), cart.getUniqueId());
41 63 }
42 64
43 65 public boolean hasLink(Minecart cart)
44 66 {
45 67 return cart.getPersistentDataContainer().has(key, PersistentDataType.STRING);
46 68 }
69
70 public void remember(Minecart cart)
71 {
72 if (hasLink(cart))
73 {
74 childByParent.put(getLinkUniqueId(cart), cart.getUniqueId());
75 }
76 }
77
78 public Minecart getParent(Minecart cart)
79 {
80 if (!hasLink(cart))
81 {
82 return null;
83 }
84 Entity parent = Bukkit.getEntity(getLinkUniqueId(cart));
85 return parent instanceof Minecart minecart ? minecart : null;
86 }
87
88 public Minecart getChild(Minecart parent)
89 {
90 UUID childId = childByParent.get(parent.getUniqueId());
91 if (childId != null)
92 {
93 Entity child = Bukkit.getEntity(childId);
94 if (child instanceof Minecart minecart)
95 {
96 return minecart;
97 }
98 }
99
100 for (Entity entity : parent.getNearbyEntities(24, 6, 24))
101 {
102 if (entity instanceof Minecart cart && hasLink(cart)
103 && getLinkUniqueId(cart).equals(parent.getUniqueId()))
104 {
105 childByParent.put(parent.getUniqueId(), cart.getUniqueId());
106 return cart;
107 }
108 }
109 return null;
110 }
111
112 public Minecart findHead(Minecart cart)
113 {
114 Minecart current = cart;
115 Set<UUID> seen = new HashSet<>();
116 while (hasLink(current) && seen.add(current.getUniqueId()))
117 {
118 Minecart parent = getParent(current);
119 if (parent == null)
120 {
121 break;
122 }
123 current = parent;
124 }
125 return current;
126 }
127
128 public boolean isSameTrain(Minecart first, Minecart second)
129 {
130 return findHead(first).getUniqueId().equals(findHead(second).getUniqueId());
131 }
132
133 public List<Minecart> getTrain(Minecart cart)
134 {
135 List<Minecart> chain = new ArrayList<>();
136 Minecart current = findHead(cart);
137 Set<UUID> seen = new HashSet<>();
138 while (current != null && seen.add(current.getUniqueId()))
139 {
140 chain.add(current);
141 current = getChild(current);
142 }
143 return chain;
144 }
145
146 public CoupleResult couple(Minecart first, Minecart second)
147 {
148 remember(first);
149 remember(second);
150
151 if (first.getUniqueId().equals(second.getUniqueId()))
152 {
153 return CoupleResult.SELF;
154 }
155 if (isSameTrain(first, second))
156 {
157 return CoupleResult.SAME_TRAIN;
158 }
159
160 boolean firstIsHead = !hasLink(first);
161 boolean secondIsHead = !hasLink(second);
162 boolean firstIsTail = getChild(first) == null;
163 boolean secondIsTail = getChild(second) == null;
164
165 if (!(firstIsHead || firstIsTail) || !(secondIsHead || secondIsTail))
166 {
167 return CoupleResult.NOT_AN_END;
168 }
169
170 if (firstIsHead && firstIsTail && secondIsHead && secondIsTail)
171 {
172 Minecart parent = preferredParent(first, second);
173 Minecart child = parent.getUniqueId().equals(first.getUniqueId()) ? second : first;
174 setLink(child, parent.getUniqueId().toString());
175 return CoupleResult.SUCCESS;
176 }
177
178 if (firstIsHead && firstIsTail)
179 {
180 attachSingleToEnd(first, second, secondIsHead, secondIsTail);
181 return CoupleResult.SUCCESS;
182 }
183 if (secondIsHead && secondIsTail)
184 {
185 attachSingleToEnd(second, first, firstIsHead, firstIsTail);
186 return CoupleResult.SUCCESS;
187 }
188
189 if (firstIsTail && secondIsHead)
190 {
191 setLink(second, first.getUniqueId().toString());
192 return CoupleResult.SUCCESS;
193 }
194 if (secondIsTail && firstIsHead)
195 {
196 setLink(first, second.getUniqueId().toString());
197 return CoupleResult.SUCCESS;
198 }
199 if (firstIsHead && secondIsHead)
200 {
201 reverseTrain(first);
202 setLink(second, first.getUniqueId().toString());
203 return CoupleResult.SUCCESS;
204 }
205 if (firstIsTail && secondIsTail)
206 {
207 reverseTrain(second);
208 setLink(second, first.getUniqueId().toString());
209 return CoupleResult.SUCCESS;
210 }
211
212 return CoupleResult.INVALID;
213 }
214
215 private void attachSingleToEnd(Minecart single, Minecart end, boolean endIsHead, boolean endIsTail)
216 {
217 if (endIsTail && !endIsHead)
218 {
219 setLink(single, end.getUniqueId().toString());
220 return;
221 }
222 if (endIsHead && !endIsTail)
223 {
224 setLink(end, single.getUniqueId().toString());
225 return;
226 }
227 setLink(single, end.getUniqueId().toString());
228 }
229
230 private Minecart preferredParent(Minecart first, Minecart second)
231 {
232 if (first instanceof PoweredMinecart && !(second instanceof PoweredMinecart))
233 {
234 return first;
235 }
236 if (second instanceof PoweredMinecart && !(first instanceof PoweredMinecart))
237 {
238 return second;
239 }
240 return first;
241 }
242
243 public void reverseTrain(Minecart cart)
244 {
245 List<Minecart> chain = getTrain(cart);
246 for (Minecart linked : chain)
247 {
248 removeLink(linked);
249 }
250 for (int i = 0; i < chain.size() - 1; i++)
251 {
252 setLink(chain.get(i), chain.get(i + 1).getUniqueId().toString());
253 }
254 }
47 255 }
@@ -1,27 +1,44 @@
1package me.fridtjof.minecarttrains.managers;
1package me.fridtjof.minecarttrains.managers;
2
2
3import me.fridtjof.minecarttrains.MinecartTrains;
3import me.fridtjof.minecarttrains.MinecartTrains;
4import org.bukkit.Bukkit;
4import org.bukkit.NamespacedKey;
5import org.bukkit.NamespacedKey;
6import org.bukkit.entity.Entity;
5import org.bukkit.entity.Minecart;
7import org.bukkit.entity.Minecart;
6import org.bukkit.persistence.PersistentDataContainer;
8import org.bukkit.entity.minecart.PoweredMinecart;
7import org.bukkit.persistence.PersistentDataType;
9import org.bukkit.persistence.PersistentDataType;
8
10
11import java.util.ArrayList;
12import java.util.HashMap;
13import java.util.HashSet;
14import java.util.List;
15import java.util.Map;
16import java.util.Set;
9import java.util.UUID;
17import java.util.UUID;
10
18
11public class LinkageManager
19public class LinkageManager
12{
20{
13
21
14 static MinecartTrains plugin = MinecartTrains.getInstance();
22 public enum CoupleResult
15
16 NamespacedKey key = new NamespacedKey(plugin, "coupler");
17
18 public LinkageManager()
19 {
23 {
20
24 SUCCESS,
25 SELF,
26 SAME_TRAIN,
27 NOT_AN_END,
28 INVALID
21 }
29 }
22
30
31 static MinecartTrains plugin = MinecartTrains.getInstance();
32
33 private final NamespacedKey key = new NamespacedKey(plugin, "coupler");
34 private final Map<UUID, UUID> childByParent = new HashMap<>();
35
23 public void removeLink(Minecart cart)
36 public void removeLink(Minecart cart)
24 {
37 {
38 if (hasLink(cart))
39 {
40 childByParent.remove(getLinkUniqueId(cart), cart.getUniqueId());
41 }
25 cart.getPersistentDataContainer().remove(key);
42 cart.getPersistentDataContainer().remove(key);
26 }
43 }
27
44
@@ -37,11 +54,202 @@ public class LinkageManager
37
54
38 public void setLink(Minecart cart, String linkedCartUniqueId)
55 public void setLink(Minecart cart, String linkedCartUniqueId)
39 {
56 {
57 if (hasLink(cart))
58 {
59 childByParent.remove(getLinkUniqueId(cart), cart.getUniqueId());
60 }
40 cart.getPersistentDataContainer().set(key, PersistentDataType.STRING, linkedCartUniqueId);
61 cart.getPersistentDataContainer().set(key, PersistentDataType.STRING, linkedCartUniqueId);
62 childByParent.put(UUID.fromString(linkedCartUniqueId), cart.getUniqueId());
41 }
63 }
42
64
43 public boolean hasLink(Minecart cart)
65 public boolean hasLink(Minecart cart)
44 {
66 {
45 return cart.getPersistentDataContainer().has(key, PersistentDataType.STRING);
67 return cart.getPersistentDataContainer().has(key, PersistentDataType.STRING);
46 }
68 }
69
70 public void remember(Minecart cart)
71 {
72 if (hasLink(cart))
73 {
74 childByParent.put(getLinkUniqueId(cart), cart.getUniqueId());
75 }
76 }
77
78 public Minecart getParent(Minecart cart)
79 {
80 if (!hasLink(cart))
81 {
82 return null;
83 }
84 Entity parent = Bukkit.getEntity(getLinkUniqueId(cart));
85 return parent instanceof Minecart minecart ? minecart : null;
86 }
87
88 public Minecart getChild(Minecart parent)
89 {
90 UUID childId = childByParent.get(parent.getUniqueId());
91 if (childId != null)
92 {
93 Entity child = Bukkit.getEntity(childId);
94 if (child instanceof Minecart minecart)
95 {
96 return minecart;
97 }
98 }
99
100 for (Entity entity : parent.getNearbyEntities(24, 6, 24))
101 {
102 if (entity instanceof Minecart cart && hasLink(cart)
103 && getLinkUniqueId(cart).equals(parent.getUniqueId()))
104 {
105 childByParent.put(parent.getUniqueId(), cart.getUniqueId());
106 return cart;
107 }
108 }
109 return null;
110 }
111
112 public Minecart findHead(Minecart cart)
113 {
114 Minecart current = cart;
115 Set<UUID> seen = new HashSet<>();
116 while (hasLink(current) && seen.add(current.getUniqueId()))
117 {
118 Minecart parent = getParent(current);
119 if (parent == null)
120 {
121 break;
122 }
123 current = parent;
124 }
125 return current;
126 }
127
128 public boolean isSameTrain(Minecart first, Minecart second)
129 {
130 return findHead(first).getUniqueId().equals(findHead(second).getUniqueId());
131 }
132
133 public List<Minecart> getTrain(Minecart cart)
134 {
135 List<Minecart> chain = new ArrayList<>();
136 Minecart current = findHead(cart);
137 Set<UUID> seen = new HashSet<>();
138 while (current != null && seen.add(current.getUniqueId()))
139 {
140 chain.add(current);
141 current = getChild(current);
142 }
143 return chain;
144 }
145
146 public CoupleResult couple(Minecart first, Minecart second)
147 {
148 remember(first);
149 remember(second);
150
151 if (first.getUniqueId().equals(second.getUniqueId()))
152 {
153 return CoupleResult.SELF;
154 }
155 if (isSameTrain(first, second))
156 {
157 return CoupleResult.SAME_TRAIN;
158 }
159
160 boolean firstIsHead = !hasLink(first);
161 boolean secondIsHead = !hasLink(second);
162 boolean firstIsTail = getChild(first) == null;
163 boolean secondIsTail = getChild(second) == null;
164
165 if (!(firstIsHead || firstIsTail) || !(secondIsHead || secondIsTail))
166 {
167 return CoupleResult.NOT_AN_END;
168 }
169
170 if (firstIsHead && firstIsTail && secondIsHead && secondIsTail)
171 {
172 Minecart parent = preferredParent(first, second);
173 Minecart child = parent.getUniqueId().equals(first.getUniqueId()) ? second : first;
174 setLink(child, parent.getUniqueId().toString());
175 return CoupleResult.SUCCESS;
176 }
177
178 if (firstIsHead && firstIsTail)
179 {
180 attachSingleToEnd(first, second, secondIsHead, secondIsTail);
181 return CoupleResult.SUCCESS;
182 }
183 if (secondIsHead && secondIsTail)
184 {
185 attachSingleToEnd(second, first, firstIsHead, firstIsTail);
186 return CoupleResult.SUCCESS;
187 }
188
189 if (firstIsTail && secondIsHead)
190 {
191 setLink(second, first.getUniqueId().toString());
192 return CoupleResult.SUCCESS;
193 }
194 if (secondIsTail && firstIsHead)
195 {
196 setLink(first, second.getUniqueId().toString());
197 return CoupleResult.SUCCESS;
198 }
199 if (firstIsHead && secondIsHead)
200 {
201 reverseTrain(first);
202 setLink(second, first.getUniqueId().toString());
203 return CoupleResult.SUCCESS;
204 }
205 if (firstIsTail && secondIsTail)
206 {
207 reverseTrain(second);
208 setLink(second, first.getUniqueId().toString());
209 return CoupleResult.SUCCESS;
210 }
211
212 return CoupleResult.INVALID;
213 }
214
215 private void attachSingleToEnd(Minecart single, Minecart end, boolean endIsHead, boolean endIsTail)
216 {
217 if (endIsTail && !endIsHead)
218 {
219 setLink(single, end.getUniqueId().toString());
220 return;
221 }
222 if (endIsHead && !endIsTail)
223 {
224 setLink(end, single.getUniqueId().toString());
225 return;
226 }
227 setLink(single, end.getUniqueId().toString());
228 }
229
230 private Minecart preferredParent(Minecart first, Minecart second)
231 {
232 if (first instanceof PoweredMinecart && !(second instanceof PoweredMinecart))
233 {
234 return first;
235 }
236 if (second instanceof PoweredMinecart && !(first instanceof PoweredMinecart))
237 {
238 return second;
239 }
240 return first;
241 }
242
243 public void reverseTrain(Minecart cart)
244 {
245 List<Minecart> chain = getTrain(cart);
246 for (Minecart linked : chain)
247 {
248 removeLink(linked);
249 }
250 for (int i = 0; i < chain.size() - 1; i++)
251 {
252 setLink(chain.get(i), chain.get(i + 1).getUniqueId().toString());
253 }
254 }
47}
255}