BlueGit

timfa questward

Skip redundant entity placement and reuse place size vectors.

Avoid layer writes and vector allocations when a pivoted sprite has not moved, scaled, or changed draw priority.

timfa Tim Falken · pushed by timfa

Authored 2026-09-06 · 2 months ago

Hash
fafe9b6f784bff167b32b26149703891cb9b05a8
Parent
ef116599
1 file changed +22 −2
client/src/render/worldView.js +22 −2
@@ -1051,6 +1051,8 @@ export class WorldView
1051 1051 #playerChunkY = null;
1052 1052 #playerMoveChunkDx = 0;
1053 1053 #playerMoveChunkDy = 0;
1054 /** Reused by {@link #placePivoted} to avoid per-call `new vector()`. */
1055 #placeSizeScratch = new vector(0, 0);
1054 1056
1055 1057 constructor(game, scene, catalog = { grounds: {}, blocks: {} })
1056 1058 {
@@ -5271,11 +5273,29 @@ export class WorldView
5271 5273 const zoom = this.zoom;
5272 5274 const draw = spriteDrawSize(sprite.width, sprite.height, zoom);
5273 5275 const factor = Math.max(0.1, Number(scale) || 1);
5276 const w = draw.w * factor;
5277 const h = draw.h * factor;
5274 5278 const center = spriteCenterFromPivot(pivotX, pivotY, sprite.height * factor, zoom);
5279 const layer = this.#depthLayer(sortY, subOrder, flight);
5280 if (
5281 object._placeX === center.x
5282 && object._placeY === center.y
5283 && object._placeW === w
5284 && object._placeH === h
5285 && object.layer === layer
5286 )
5287 { return; }
5288 object._placeX = center.x;
5289 object._placeY = center.y;
5290 object._placeW = w;
5291 object._placeH = h;
5275 5292 object.transform.position.x = center.x;
5276 5293 object.transform.position.y = center.y;
5277 object.transform.size = new vector(draw.w * factor, draw.h * factor);
5278 this.#setLayer(object, this.#depthLayer(sortY, subOrder, flight));
5294 const size = this.#placeSizeScratch;
5295 size.x = w;
5296 size.y = h;
5297 object.transform.size = size;
5298 this.#setLayer(object, layer);
5279 5299 }
5280 5300
5281 5301 #ensureSprite (existing, name, layer)
@@ -1051,6 +1051,8 @@ export class WorldView
1051 #playerChunkY = null;
1051 #playerChunkY = null;
1052 #playerMoveChunkDx = 0;
1052 #playerMoveChunkDx = 0;
1053 #playerMoveChunkDy = 0;
1053 #playerMoveChunkDy = 0;
1054 /** Reused by {@link #placePivoted} to avoid per-call `new vector()`. */
1055 #placeSizeScratch = new vector(0, 0);
1054
1056
1055 constructor(game, scene, catalog = { grounds: {}, blocks: {} })
1057 constructor(game, scene, catalog = { grounds: {}, blocks: {} })
1056 {
1058 {
@@ -5271,11 +5273,29 @@ export class WorldView
5271 const zoom = this.zoom;
5273 const zoom = this.zoom;
5272 const draw = spriteDrawSize(sprite.width, sprite.height, zoom);
5274 const draw = spriteDrawSize(sprite.width, sprite.height, zoom);
5273 const factor = Math.max(0.1, Number(scale) || 1);
5275 const factor = Math.max(0.1, Number(scale) || 1);
5276 const w = draw.w * factor;
5277 const h = draw.h * factor;
5274 const center = spriteCenterFromPivot(pivotX, pivotY, sprite.height * factor, zoom);
5278 const center = spriteCenterFromPivot(pivotX, pivotY, sprite.height * factor, zoom);
5279 const layer = this.#depthLayer(sortY, subOrder, flight);
5280 if (
5281 object._placeX === center.x
5282 && object._placeY === center.y
5283 && object._placeW === w
5284 && object._placeH === h
5285 && object.layer === layer
5286 )
5287 { return; }
5288 object._placeX = center.x;
5289 object._placeY = center.y;
5290 object._placeW = w;
5291 object._placeH = h;
5275 object.transform.position.x = center.x;
5292 object.transform.position.x = center.x;
5276 object.transform.position.y = center.y;
5293 object.transform.position.y = center.y;
5277 object.transform.size = new vector(draw.w * factor, draw.h * factor);
5294 const size = this.#placeSizeScratch;
5278 this.#setLayer(object, this.#depthLayer(sortY, subOrder, flight));
5295 size.x = w;
5296 size.y = h;
5297 object.transform.size = size;
5298 this.#setLayer(object, layer);
5279 }
5299 }
5280
5300
5281 #ensureSprite (existing, name, layer)
5301 #ensureSprite (existing, name, layer)