BlueGit

timfa bluegit

Files

bluegit / internal / ci / gate_test.go

gate_test.go

fix: laat go-tests in Steve slagen zonder namespaces of smart HTTP
timfa project_87923614_bot_3aff574f6f98414b945a8799374f9092 · pushed by timfa · 3 weeks ago
4bb9fce0 History
gate_test.go 6.0 KiB Download Raw
1package ci
2
3import "testing"
4
5// Pipeline #26: test faalde, build werd overgeslagen, release (needs: [build])
6// hoort zelf overgeslagen te worden. publish_aur met needs: [] start wel.
7func TestGateSkipsWhenNeedFailedOrSkipped(t *testing.T) {
8 jobs := []Job{
9 {Name: "test", Stage: "test"},
10 {Name: "soft", Stage: "test", AllowFailure: true},
11 {Name: "build", Stage: "build", Needs: []string{"test"}, NeedsSet: true},
12 {Name: "after_soft", Stage: "build", Needs: []string{"soft"}, NeedsSet: true},
13 {Name: "release", Stage: "release", Needs: []string{"build"}, NeedsSet: true},
14 {Name: "deploy", Stage: "deploy", Needs: []string{"build", "release"}, NeedsSet: true},
15 {Name: "publish_aur", Stage: "deploy", NeedsSet: true, AllowFailure: true},
16 {Name: "later", Stage: "deploy"},
17 {Name: "anyway", Stage: "deploy", Needs: []string{"build"}, NeedsSet: true, When: "always"},
18 {Name: "onfail", Stage: "deploy", Needs: []string{"build"}, NeedsSet: true, When: "on_failure"},
19 }
20 by := map[string]Job{}
21 for _, j := range jobs {
22 by[j.Name] = j
23 }
24
25 // test is gefaald en build daardoor overgeslagen; release staat nog queued.
26 mid := map[string]string{
27 "test": "failed", "soft": "failed", "build": "skipped", "after_soft": "success",
28 "release": "queued", "deploy": "queued", "publish_aur": "queued", "later": "queued",
29 "anyway": "queued", "onfail": "queued",
30 }
31 assertGate(t, jobs, by, mid, map[string]string{
32 "build": "skip",
33 "release": "skip",
34 "deploy": "wait",
35 "publish_aur": "ready",
36 "later": "wait",
37 "anyway": "ready",
38 "onfail": "skip",
39 "after_soft": "ready",
40 })
41
42 // Nadat de keten is overgeslagen blijft publish_aur staan en valt de
43 // latere stage zonder needs alsnog weg.
44 settled := map[string]string{
45 "test": "failed", "soft": "failed", "build": "skipped", "after_soft": "success",
46 "release": "skipped", "deploy": "queued", "publish_aur": "queued", "later": "queued",
47 "anyway": "queued", "onfail": "queued",
48 }
49 assertGate(t, jobs, by, settled, map[string]string{
50 "release": "skip",
51 "deploy": "skip",
52 "later": "skip",
53 "publish_aur": "ready",
54 "anyway": "ready",
55 })
56
57 onlySkip := map[string]string{
58 "test": "skipped", "soft": "success", "build": "skipped", "after_soft": "success",
59 "release": "skipped", "deploy": "queued", "publish_aur": "queued", "later": "queued",
60 "anyway": "queued", "onfail": "queued",
61 }
62 assertGate(t, jobs, by, onlySkip, map[string]string{
63 "later": "ready",
64 "build": "skip",
65 "publish_aur": "ready",
66 "onfail": "skip",
67 })
68
69 failedNeed := map[string]string{
70 "test": "success", "soft": "success", "build": "failed", "after_soft": "success",
71 "release": "queued", "deploy": "queued", "publish_aur": "queued", "later": "queued",
72 "anyway": "queued", "onfail": "queued",
73 }
74 assertGate(t, jobs, by, failedNeed, map[string]string{
75 "release": "skip",
76 "onfail": "ready",
77 "anyway": "ready",
78 "publish_aur": "ready",
79 "later": "wait",
80 })
81
82 running := map[string]string{
83 "test": "success", "soft": "success", "build": "running", "after_soft": "success",
84 "release": "queued", "deploy": "queued", "publish_aur": "queued", "later": "queued",
85 "anyway": "queued", "onfail": "queued",
86 }
87 assertGate(t, jobs, by, running, map[string]string{
88 "release": "wait",
89 "anyway": "wait",
90 "publish_aur": "ready",
91 })
92
93 // Een overgeslagen need met allow_failure houdt de afhankelijke job toch tegen.
94 softSkipped := []Job{
95 {Name: "soft", Stage: "test", AllowFailure: true},
96 {Name: "next", Stage: "build", Needs: []string{"soft"}, NeedsSet: true},
97 }
98 if got := Gate(softSkipped, map[string]string{"soft": "skipped", "next": "queued"}, softSkipped[1]); got != "skip" {
99 t.Errorf("overgeslagen need met allow_failure: %s", got)
100 }
101}
102
103// Een latere stage die in het bestand bóven de eerdere stage staat, mag
104// niet ready zijn zolang die eerdere stage queued of running is.
105// needs: [] blijft wel meteen ready. Dat is de fix uit !37, plus de
106// stagevolgorde uit stages: in plaats van de volgorde in het bestand.
107func TestLaterStageWaitsWhileEarlierIsQueued(t *testing.T) {
108 p, err := Parse([]byte(`
109stages: [test, release]
110jobs:
111 release:
112 stage: release
113 image: alpine
114 script: ["echo release"]
115 early:
116 stage: release
117 image: alpine
118 needs: []
119 script: ["echo early"]
120 test:
121 stage: test
122 image: alpine
123 script: ["echo test"]
124`))
125 if err != nil {
126 t.Fatal(err)
127 }
128 if p.Jobs[0].Name != "release" {
129 t.Fatalf("parse houdt de bestandsvolgorde: %s", p.Jobs[0].Name)
130 }
131 jobs, err := p.ActiveJobs(map[string]string{})
132 if err != nil {
133 t.Fatal(err)
134 }
135 if len(jobs) != 3 || jobs[0].Name != "test" || jobs[0].Stage != "test" {
136 t.Fatalf("stages: hoort test eerst te zetten: %v", names(jobs))
137 }
138 by := map[string]Job{}
139 for _, j := range jobs {
140 by[j.Name] = j
141 }
142 queued := map[string]string{"test": "queued", "release": "queued", "early": "queued"}
143 if got := Gate(jobs, queued, by["release"]); got != "wait" {
144 t.Fatalf("release terwijl test nog queued is: %s", got)
145 }
146 running := map[string]string{"test": "running", "release": "queued", "early": "queued"}
147 if got := Gate(jobs, running, by["release"]); got != "wait" {
148 t.Fatalf("release terwijl test nog loopt: %s", got)
149 }
150 if got := Gate(jobs, queued, by["early"]); got != "ready" {
151 t.Fatalf("needs: [] start meteen: %s", got)
152 }
153 if got := Gate(jobs, queued, by["test"]); got != "ready" {
154 t.Fatalf("eerste stage start meteen: %s", got)
155 }
156 done := map[string]string{"test": "success", "release": "queued", "early": "queued"}
157 if got := Gate(jobs, done, by["release"]); got != "ready" {
158 t.Fatalf("release na test: %s", got)
159 }
160}
161
162func names(jobs []Job) []string {
163 out := make([]string, len(jobs))
164 for i, j := range jobs {
165 out[i] = j.Name
166 }
167 return out
168}
169
170func assertGate(t *testing.T, jobs []Job, by map[string]Job, status, want map[string]string) {
171 t.Helper()
172 for name, decision := range want {
173 if got := Gate(jobs, status, by[name]); got != decision {
174 t.Errorf("%s: got %s, want %s", name, got, decision)
175 }
176 }
177}