BlueGit

timfa bluegit

Files

bluegit / internal / gitgraph / svg_test.go

svg_test.go

svg_test.go 6.5 KiB Download Raw
1package gitgraph
2
3import (
4 "regexp"
5 "strconv"
6 "strings"
7 "testing"
8)
9
10func TestSVGUsesRoundedOrthogonalBends(t *testing.T) {
11 refs := []Ref{
12 {Name: "master", SHA: "m", Kind: "branch"},
13 {Name: "feature", SHA: "f", Kind: "branch"},
14 }
15 g := Layout(commits("m:c,f", "f:b", "c:b", "b:"), refs, "master")
16 svg := g.SVG()
17 if svg == "" {
18 t.Fatal("lege svg")
19 }
20 if strings.Contains(svg, " C ") || strings.Contains(svg, `"C `) || strings.Contains(svg, " C") {
21 // cubische beziers geven diagonale lijnen; we willen knikken
22 if strings.Contains(svg, " C ") {
23 t.Fatalf("svg gebruikt nog een diagonale bezier: %s", svg)
24 }
25 }
26 if !strings.Contains(svg, " Q ") {
27 t.Fatalf("verwacht afgeronde bochten (Q) in %s", svg)
28 }
29 if !strings.Contains(svg, " V ") && !strings.Contains(svg, "V ") {
30 t.Fatalf("verwacht verticale stukken in %s", svg)
31 }
32 if !strings.Contains(svg, " H ") {
33 t.Fatalf("verwacht horizontale stukken in %s", svg)
34 }
35 if strings.Contains(svg, ` style=`) || strings.Contains(svg, " style=") {
36 t.Fatalf("svg mag geen style-attribuut hebben (CSP style-src 'self'): %s", svg)
37 }
38 if !strings.Contains(svg, `<a class="commitgraph-node`) {
39 t.Fatalf("verwacht svg-knopen (a.commitgraph-node): %s", svg)
40 }
41 if !strings.Contains(svg, "<circle") {
42 t.Fatalf("verwacht een cirkel per commitknoop: %s", svg)
43 }
44 if !strings.Contains(svg, `data-branch="master"`) {
45 t.Fatalf("gloed-attribuut voor master ontbreekt: %s", svg)
46 }
47 if !strings.Contains(svg, `data-branch="feature"`) {
48 t.Fatalf("gloed-attribuut voor feature ontbreekt: %s", svg)
49 }
50 if !strings.Contains(svg, `stroke="var(--blue)"`) {
51 t.Fatalf("blauwe hoofdlijn ontbreekt: %s", svg)
52 }
53}
54
55func TestOrthogonalPathShape(t *testing.T) {
56 // zelfde lane: alleen verticaal
57 d := orthogonalPath(12, 14, 12, 70, 7)
58 if d != "M 12.0 14.0 V 70.0" {
59 t.Fatalf("verticaal: %s", d)
60 }
61 // andere lane: V, Q, H, Q, V
62 d = orthogonalPath(12, 14, 36, 70, 7)
63 if !strings.Contains(d, " Q ") || !strings.Contains(d, " H ") || !strings.Contains(d, " V ") {
64 t.Fatalf("bocht mist commando's: %s", d)
65 }
66 if strings.Contains(d, " C ") {
67 t.Fatalf("geen bezier: %s", d)
68 }
69 // de bocht gaat eerst naar beneden, dan opzij, dan weer naar beneden
70 if !strings.HasPrefix(d, "M 12.0 14.0 V ") {
71 t.Fatalf("start niet verticaal: %s", d)
72 }
73 if !strings.HasSuffix(d, " V 70.0") {
74 t.Fatalf("eindigt niet verticaal op het doel: %s", d)
75 }
76}
77
78func TestSVGHasNoViewBoxAndIsOneToOne(t *testing.T) {
79 refs := []Ref{
80 {Name: "master", SHA: "m", Kind: "branch"},
81 {Name: "feature", SHA: "f", Kind: "branch"},
82 }
83 g := Layout(commits("m:c,f", "f:b", "c:b", "b:"), refs, "master")
84 svg := g.SVG()
85 if strings.Contains(svg, "viewBox") {
86 t.Fatalf("viewBox schaalt de tekening, dat mag niet: %s", svg)
87 }
88 if strings.Contains(svg, "style=") {
89 t.Fatalf("geen style-attribuut (CSP): %s", svg)
90 }
91 want := `width="` + itoa(g.Width) + `" height="` + itoa(g.Height) + `"`
92 if !strings.Contains(svg, want) {
93 t.Fatalf("verwacht 1:1 attributen %s in %s", want, svg)
94 }
95}
96
97func itoa(n int) string { return strconv.Itoa(n) }
98
99var pathDRe = regexp.MustCompile(`d="([^"]+)"`)
100
101// svgPathXs leest de x-coördinaten uit de padcommando's van onze SVG
102// (M x y, V y, H x, Q cx cy, x y).
103func svgPathXs(svg string) []float64 {
104 var xs []float64
105 for _, m := range pathDRe.FindAllStringSubmatch(svg, -1) {
106 xs = append(xs, pathXs(m[1])...)
107 }
108 return xs
109}
110
111func pathXs(d string) []float64 {
112 var xs []float64
113 tokens := strings.FieldsFunc(d, func(r rune) bool {
114 return r == ',' || r == ' ' || r == '\t'
115 })
116 cmd := ""
117 arg := 0
118 for _, tok := range tokens {
119 if tok == "" {
120 continue
121 }
122 if strings.ContainsAny(tok[:1], "MLHVCSQTAZmlhvcsqtaz") {
123 cmd = tok[:1]
124 arg = 0
125 tok = tok[1:]
126 if tok == "" {
127 continue
128 }
129 }
130 n, err := strconv.ParseFloat(tok, 64)
131 if err != nil {
132 continue
133 }
134 switch cmd {
135 case "M", "L", "Q", "T", "S", "C", "A":
136 // even args are x
137 if arg%2 == 0 {
138 xs = append(xs, n)
139 }
140 arg++
141 case "H":
142 xs = append(xs, n)
143 arg++
144 case "V":
145 arg++
146 }
147 }
148 return xs
149}
150
151func TestSVGPathXsStayLeftOfText(t *testing.T) {
152 refs := []Ref{
153 {Name: "master", SHA: "m", Kind: "branch"},
154 {Name: "feature", SHA: "e", Kind: "branch"},
155 {Name: "docs", SHA: "d", Kind: "branch"},
156 }
157 g := Layout(commits("d:m", "m:c,e", "e:b", "c:b", "b:a", "a:"), refs, "master")
158 xs := svgPathXs(g.SVG())
159 if len(xs) == 0 {
160 t.Fatal("geen pad-x gevonden")
161 }
162 limit := float64(g.TextX - TextPad)
163 for _, x := range xs {
164 if x > limit {
165 t.Fatalf("pad-x %.1f ligt rechts van TextX-pad %.1f", x, limit)
166 }
167 }
168}
169
170func TestSVGNodesSitOnLanes(t *testing.T) {
171 refs := []Ref{
172 {Name: "master", SHA: "m", Kind: "branch"},
173 {Name: "feature", SHA: "f", Kind: "branch"},
174 }
175 g := Layout(commits("m:c,f", "f:b", "c:b", "b:"), refs, "master")
176 g.Rows[0].Initial = "M"
177 for i := range g.Rows {
178 if g.Rows[i].SHA == "f" {
179 g.Rows[i].Avatar = "https://auth.timfalken.com/avatar/1?v=1"
180 g.Rows[i].Initial = "F"
181 }
182 }
183 g.CommitBase = "/tim/grafiek/-/commit/"
184 svg := g.SVG()
185 if strings.Contains(svg, "style=") {
186 t.Fatalf("style-attribuut in svg: %s", svg)
187 }
188 if !strings.Contains(svg, `href="https://auth.timfalken.com/avatar/1?v=1"`) {
189 t.Fatalf("avatar-image ontbreekt: %s", svg)
190 }
191 if !strings.Contains(svg, `clip-path="url(#cg-a-`) {
192 t.Fatalf("clipPath voor ronde avatar ontbreekt: %s", svg)
193 }
194 if !strings.Contains(svg, `href="/tim/grafiek/-/commit/m"`) {
195 t.Fatalf("commitlink ontbreekt: %s", svg)
196 }
197 seenOffMain := false
198 for i, r := range g.Rows {
199 cx := laneX(r.Lane)
200 want := sprintfCx(cx)
201 if !strings.Contains(svg, want) {
202 t.Fatalf("rij %d lane %d: knoop-cx %s ontbreekt in %s", i, r.Lane, want, svg)
203 }
204 if r.Lane != 0 {
205 seenOffMain = true
206 if cx <= laneX(0) {
207 t.Fatalf("zijtak %s staat niet rechts van de hoofdlane", r.SHA)
208 }
209 }
210 }
211 if !seenOffMain {
212 t.Fatal("verwacht een zijtak-knoop rechts van de hoofdlane")
213 }
214}
215
216func sprintfCx(x float64) string {
217 return `cx="` + strconv.FormatFloat(x, 'f', 1, 64) + `"`
218}
219
220func TestSVGNodeHasTitleTooltip(t *testing.T) {
221 refs := []Ref{{Name: "master", SHA: "m", Kind: "branch"}}
222 g := Layout(commits("m:"), refs, "master")
223 if g.Rows[0].Tip == "" {
224 g.Rows[0].Tip = CommitTip(g.Rows[0])
225 }
226 svg := g.SVG()
227 if !strings.Contains(svg, "<title>") {
228 t.Fatalf("svg-knoop mist <title> voor de tooltip: %s", svg)
229 }
230 if !strings.Contains(svg, htmlEscapeCheck(g.Rows[0].Tip)) && !strings.Contains(svg, g.Rows[0].Subject) && !strings.Contains(svg, "msg-m") {
231 t.Fatalf("tip-tekst ontbreekt in <title>: %s", svg)
232 }
233}
234
235func htmlEscapeCheck(s string) string { return s }