BlueGit

timfa bluegit

Files

bluegit / internal / server / admin_users_test.go

admin_users_test.go

admin_users_test.go 5.9 KiB Download Raw
1package server
2
3import (
4 "context"
5 "net/http"
6 "net/url"
7 "os"
8 "path/filepath"
9 "regexp"
10 "strings"
11 "testing"
12)
13
14func TestAdminUsersRoles(t *testing.T) {
15 e := newCIEnv(t)
16 ctx := context.Background()
17 st, base := e.st, e.ts.URL
18 tim, _ := st.UserByID(ctx, e.user.ID)
19 if !tim.InstanceAdmin {
20 t.Skip("eerste gebruiker is geen beheerder")
21 }
22 bob, _ := st.UpsertUser(ctx, 2, "bob", "", false)
23
24 // Niet-beheerder: geen Beheer-link, UI en API 403.
25 bc, bcsrf := sessionClient(t, st, base, bob.ID)
26 res, _ := bc.Get(base + "/")
27 if strings.Contains(body(t, res), `href="/admin"`) {
28 t.Fatal("bob ziet Beheer-link")
29 }
30 for _, p := range []string{"/admin/users", "/admin/storage"} {
31 res, _ = bc.Get(base + p)
32 if res.StatusCode != http.StatusForbidden {
33 t.Fatalf("bob %s: %d", p, res.StatusCode)
34 }
35 res.Body.Close()
36 }
37 res, _ = bc.PostForm(base+"/admin/users/role", url.Values{"csrf": {bcsrf}, "id": {itoa(bob.ID)}, "admin": {"1"}})
38 if res.StatusCode != http.StatusForbidden {
39 t.Fatalf("bob maakt zichzelf admin: %d", res.StatusCode)
40 }
41 res.Body.Close()
42 bobTok := issue(t, st, bob.ID, "api")
43 if code, _ := rapi(t, base, bobTok, "GET", "/admin/users", nil); code != http.StatusForbidden {
44 t.Fatalf("bob api list: %d", code)
45 }
46 if code, _ := rapi(t, base, bobTok, "PUT", "/admin/users/bob/admin", map[string]any{"admin": true}); code != http.StatusForbidden {
47 t.Fatalf("bob api grant: %d", code)
48 }
49
50 // Beheerder: nav, redirect, pagina met eigen knop uitgeschakeld.
51 tc, tcsrf := sessionClient(t, st, base, tim.ID)
52 res, _ = tc.Get(base + "/admin")
53 if res.StatusCode/100 != 3 || res.Header.Get("Location") != "/admin/users" {
54 t.Fatalf("/admin: %d %s", res.StatusCode, res.Header.Get("Location"))
55 }
56 res.Body.Close()
57 res, _ = tc.Get(base + "/admin/users")
58 page := body(t, res)
59 if res.StatusCode != 200 || !strings.Contains(page, `href="/admin"`) || !strings.Contains(page, `class="admintabs"`) || !strings.Contains(page, `disabled aria-describedby="why-self"`) || !strings.Contains(page, `data-confirm=`) {
60 t.Fatalf("beheerpagina %d: %.400s", res.StatusCode, page)
61 }
62 // Zelf afnemen geweigerd (UI en API).
63 res, _ = tc.PostForm(base+"/admin/users/role", url.Values{"csrf": {tcsrf}, "id": {itoa(tim.ID)}, "admin": {"0"}})
64 res.Body.Close()
65 if u, _ := st.UserByID(ctx, tim.ID); !u.InstanceAdmin {
66 t.Fatal("zelf afnemen via UI gelukt")
67 }
68 adminTok := issue(t, st, tim.ID, "api")
69 if code, _ := rapi(t, base, adminTok, "PUT", "/admin/users/"+tim.Username+"/admin", map[string]any{"admin": false}); code != http.StatusForbidden {
70 t.Fatalf("zelf afnemen api: %d", code)
71 }
72 // Toekennen en afnemen via UI en API.
73 res, _ = tc.PostForm(base+"/admin/users/role", url.Values{"csrf": {tcsrf}, "id": {itoa(bob.ID)}, "admin": {"1"}})
74 res.Body.Close()
75 if u, _ := st.UserByID(ctx, bob.ID); !u.InstanceAdmin {
76 t.Fatal("bob geen admin na UI")
77 }
78 if code, b := rapi(t, base, adminTok, "PUT", "/admin/users/bob/admin", map[string]any{"admin": false}); code != 200 {
79 t.Fatalf("api revoke %d %s", code, b)
80 }
81 if u, _ := st.UserByID(ctx, bob.ID); u.InstanceAdmin {
82 t.Fatal("bob nog admin")
83 }
84 if code, _ := rapi(t, base, adminTok, "PUT", "/admin/users/nobody/admin", map[string]any{"admin": true}); code != 404 {
85 t.Fatalf("onbekend: %d", code)
86 }
87 if code, _ := rapi(t, base, adminTok, "PUT", "/admin/users/bob/admin", map[string]any{}); code != 400 {
88 t.Fatalf("lege body: %d", code)
89 }
90 if code, b := rapi(t, base, adminTok, "GET", "/admin/users", nil); code != 200 || !strings.Contains(string(b), `"bob"`) {
91 t.Fatalf("list %d %s", code, b)
92 }
93 // Laatste beheerder blijft: store-niveau.
94 if n, _ := st.CountAdmins(ctx); n != 1 {
95 t.Fatalf("admins %d", n)
96 }
97 if _, err := st.SetInstanceAdmin(ctx, bob.ID, tim.ID, false); err == nil {
98 t.Fatal("laatste beheerder verwijderd")
99 }
100}
101
102func TestLangSwitch(t *testing.T) {
103 e := newCIEnv(t)
104 c := &http.Client{CheckRedirect: func(*http.Request, []*http.Request) error { return http.ErrUseLastResponse }}
105 res, _ := c.PostForm(e.ts.URL+"/-/lang", url.Values{"lang": {"de"}, "back": {"//evil.example/x"}})
106 if res.StatusCode != http.StatusSeeOther || res.Header.Get("Location") != "/" {
107 t.Fatalf("anoniem: %d %s", res.StatusCode, res.Header.Get("Location"))
108 }
109 var ck *http.Cookie
110 for _, k := range res.Cookies() {
111 if k.Name == "bluegit_lang" {
112 ck = k
113 }
114 }
115 if ck == nil || ck.Value != "de" {
116 t.Fatal("geen taalcookie")
117 }
118 req, _ := http.NewRequest("GET", e.ts.URL+"/login", nil)
119 req.AddCookie(ck)
120 res, _ = http.DefaultClient.Do(req)
121 page := body(t, res)
122 if !strings.Contains(page, `lang="de"`) || !strings.Contains(page, `data-langpick`) {
123 t.Fatalf("taal niet toegepast")
124 }
125 tc, csrf := sessionClient(t, e.st, e.ts.URL, e.user.ID)
126 res, _ = tc.PostForm(e.ts.URL+"/-/lang", url.Values{"lang": {"fr"}, "back": {"/help"}, "csrf": {csrf}})
127 res.Body.Close()
128 if u, _ := e.st.UserByID(context.Background(), e.user.ID); u.Language != "fr" || res.Header.Get("Location") != "/help" {
129 t.Fatalf("ingelogd: %s %s", u.Language, res.Header.Get("Location"))
130 }
131}
132
133// Nooit browser-popups: geen alert/confirm/prompt of beforeunload in
134// templates, JS of Go-HTML van BlueGit en de runner. Gebruik BGModal.
135func TestNoBrowserPopups(t *testing.T) {
136 bad := regexp.MustCompile(`(^|[^.\w])(window\.)?(alert|confirm|prompt)\s*\(|window\.(alert|confirm|prompt)|beforeunload`)
137 root := filepath.Join("..", "..")
138 n := 0
139 for _, dir := range []string{"internal", "cmd"} {
140 _ = filepath.Walk(filepath.Join(root, dir), func(p string, fi os.FileInfo, err error) error {
141 if err != nil || fi.IsDir() || strings.HasSuffix(p, "_test.go") {
142 return nil
143 }
144 ext := filepath.Ext(p)
145 if ext != ".html" && ext != ".js" && ext != ".go" {
146 return nil
147 }
148 b, _ := os.ReadFile(p)
149 for i, line := range strings.Split(string(b), "\n") {
150 if bad.MatchString(line) {
151 t.Errorf("%s:%d browser-popup: %s", p, i+1, strings.TrimSpace(line))
152 }
153 }
154 n++
155 return nil
156 })
157 }
158 if n < 20 {
159 t.Fatalf("te weinig bestanden gescand: %d", n)
160 }
161}