BlueGit

timfa bluegit

Files

bluegit / internal / server / branch_mr_test.go

branch_mr_test.go

fix: toon mergeblokkades en markeer een al gepushte merge
timfa project_87923614_bot_3aff574f6f98414b945a8799374f9092 · pushed by timfa · 3 weeks ago
81edde89 History
branch_mr_test.go 7.8 KiB Download Raw
1package server
2
3import (
4 "net/http"
5 "net/http/cookiejar"
6 "net/http/httptest"
7 "net/url"
8 "os/exec"
9 "path/filepath"
10 "strings"
11 "testing"
12
13 "gitlab.com/Timfa/bluegit/internal/auth"
14 "gitlab.com/Timfa/bluegit/internal/config"
15 "gitlab.com/Timfa/bluegit/internal/store"
16)
17
18func TestBranchesAndMergeRequest(t *testing.T) {
19 if _, err := exec.LookPath("git"); err != nil {
20 t.Skip("git ontbreekt")
21 }
22 storage := t.TempDir()
23 st, err := store.Open(filepath.Join(storage, "bluegit.db"), bytes32())
24 if err != nil {
25 t.Fatal(err)
26 }
27 t.Cleanup(func() { _ = st.Close() })
28 cfg := config.Config{
29 BaseURL: "http://127.0.0.1:9", Listen: "127.0.0.1:0", StoragePath: storage,
30 Auth: config.Auth{Mode: "dev", DevUser: "tim", DevAuthID: 1, UserAgent: "test", BaseURL: "https://auth.timfalken.com"},
31 Git: config.Git{Binary: "git", DefaultBranch: "master"},
32 }
33 srv := &Server{Cfg: cfg, Store: st, Auth: auth.Dev{Username: "tim", AuthID: 1}, Dev: true, Git: "git", HookBin: "/bin/true"}
34 ts := httptest.NewServer(srv.Handler())
35 t.Cleanup(ts.Close)
36 jar, _ := cookiejar.New(nil)
37 tim := &http.Client{Jar: jar}
38 page := read(t, mustGet(t, tim, ts.URL+"/login"))
39 page = read(t, mustPost(t, tim, ts.URL+"/new/repo", url.Values{
40 "csrf": {csrfOf(t, page)}, "name": {"takken"}, "visibility": {"public"},
41 }))
42 page = read(t, mustPost(t, tim, ts.URL+"/settings/tokens", url.Values{
43 "csrf": {csrfOf(t, page)}, "name": {"laptop"},
44 }))
45 token := between(page, `<p class="code">`, "</p>")
46 remote := strings.Replace(ts.URL, "http://", "http://tim:"+token+"@", 1) + "/tim/takken.git"
47 work := t.TempDir()
48 git(t, work, "init", "-b", "master")
49 git(t, work, "config", "user.email", "tim@users.git.timfalken.com")
50 git(t, work, "config", "user.name", "tim")
51 writeFile(t, filepath.Join(work, "hello.txt"), "alpha\n")
52 git(t, work, "add", "hello.txt")
53 git(t, work, "commit", "-m", "start")
54 git(t, work, "remote", "add", "origin", remote)
55 git(t, work, "push", "-u", "origin", "master")
56 git(t, work, "checkout", "-b", "topic")
57 writeFile(t, filepath.Join(work, "hello.txt"), "beta\n")
58 git(t, work, "add", "hello.txt")
59 git(t, work, "commit", "-m", "onderwerp-xyz")
60 git(t, work, "push", "-u", "origin", "topic")
61
62 page = read(t, mustGet(t, tim, ts.URL+"/tim/takken/-/branches"))
63 for _, want := range []string{"data-branch-filter", "topic", "default", "1 ahead", "master", "when-short", "rowmenu", "aria-label=\"More actions\""} {
64 if !strings.Contains(page, want) {
65 t.Fatalf("branchpagina mist %q", want)
66 }
67 }
68 if strings.Contains(page, "Create merge request") {
69 t.Fatalf("acties horen compact:\n%s", page)
70 }
71 page = read(t, mustPost(t, tim, ts.URL+"/tim/takken/-/branches/delete", url.Values{
72 "csrf": {csrfOf(t, page)}, "name": {"master"}, "confirm": {"master"},
73 }))
74 if !strings.Contains(page, "cannot be renamed or deleted") || !strings.Contains(page, ">master<") && !strings.Contains(page, ">master</a>") {
75 if !strings.Contains(page, "master") {
76 t.Fatalf("standaardbranch weg:\n%s", page)
77 }
78 }
79 if !strings.Contains(page, "cannot be renamed or deleted") {
80 t.Fatalf("geen blokkade voor master:\n%s", page)
81 }
82
83 page = read(t, mustPost(t, tim, ts.URL+"/tim/takken/-/protected", url.Values{
84 "csrf": {csrfOf(t, page)}, "pattern": {"locked"},
85 }))
86 page = read(t, mustPost(t, tim, ts.URL+"/tim/takken/-/branches", url.Values{
87 "csrf": {csrfOf(t, page)}, "name": {"locked"}, "from": {"master"},
88 }))
89 if !strings.Contains(page, "locked") {
90 t.Fatalf("branch locked ontbreekt:\n%s", page)
91 }
92 page = read(t, mustPost(t, tim, ts.URL+"/tim/takken/-/branches/delete", url.Values{
93 "csrf": {csrfOf(t, page)}, "name": {"locked"}, "confirm": {"locked"},
94 }))
95 if !strings.Contains(page, "cannot be renamed or deleted") || !strings.Contains(page, "locked") {
96 t.Fatalf("beschermde branch verwijderd:\n%s", page)
97 }
98
99 page = read(t, mustPost(t, tim, ts.URL+"/tim/takken/-/branches", url.Values{
100 "csrf": {csrfOf(t, page)}, "name": {"wip"}, "from": {"topic"},
101 }))
102 if !strings.Contains(page, "wip") {
103 t.Fatalf("wip ontbreekt:\n%s", page)
104 }
105 page = read(t, mustPost(t, tim, ts.URL+"/tim/takken/-/branches/rename", url.Values{
106 "csrf": {csrfOf(t, page)}, "name": {"wip"}, "new_name": {"wip2"}, "confirm": {"wip"},
107 }))
108 if !strings.Contains(page, "wip2") || strings.Contains(page, ">wip<") {
109 t.Fatalf("hernoemen:\n%s", page)
110 }
111 page = read(t, mustPost(t, tim, ts.URL+"/tim/takken/-/branches/delete", url.Values{
112 "csrf": {csrfOf(t, page)}, "name": {"wip2"}, "confirm": {"wip2"},
113 }))
114 if strings.Contains(page, "wip2") {
115 t.Fatalf("wip2 bleef staan:\n%s", page)
116 }
117
118 preview := read(t, mustGet(t, tim, ts.URL+"/tim/takken/-/merge-requests/new?source=topic&target=master"))
119 if !strings.Contains(preview, "onderwerp-xyz") || !strings.Contains(preview, "hello.txt") || !strings.Contains(preview, "data-md-box") {
120 t.Fatalf("voorvertoning:\n%s", preview)
121 }
122 md := read(t, mustPost(t, tim, ts.URL+"/tim/takken/-/markdown", url.Values{
123 "csrf": {csrfOf(t, preview)}, "body": {"**vet** <script>alert(1)</script>"},
124 }))
125 if !strings.Contains(md, "<strong>vet</strong>") || !strings.Contains(md, "&lt;script&gt;") || strings.Contains(md, "<script>") {
126 t.Fatalf("markdown:\n%s", md)
127 }
128
129 page = read(t, mustPost(t, tim, ts.URL+"/tim/takken/-/merge-requests", url.Values{
130 "csrf": {csrfOf(t, preview)}, "title": {"Onderwerp"}, "description": {"**vet** <script>alert(1)</script>"},
131 "source": {"topic"}, "target": {"master"}, "draft": {"1"},
132 }))
133 if !strings.Contains(page, "Draft") || !strings.Contains(page, "This merge request is a draft.") || !strings.Contains(page, "<strong>vet</strong>") || strings.Contains(page, "<script>") {
134 t.Fatalf("concept:\n%s", page)
135 }
136 if !strings.Contains(page, "Merge anyway") || !strings.Contains(page, "cannot be merged yet") {
137 t.Fatalf("concept hoort mergen te blokkeren:\n%s", page)
138 }
139 if !strings.Contains(page, "mr.overview") && !strings.Contains(page, "Overview") {
140 t.Fatalf("tabs:\n%s", page)
141 }
142 if !strings.Contains(page, "opened this merge request") {
143 t.Fatalf("tijdlijn:\n%s", page)
144 }
145
146 branches := read(t, mustGet(t, tim, ts.URL+"/tim/takken/-/branches"))
147 if !strings.Contains(branches, "/-/merge-requests/1") || !strings.Contains(branches, ">!1<") {
148 t.Fatalf("mr-link:\n%s", branches)
149 }
150
151 writeFile(t, filepath.Join(work, "hello.txt"), "gamma\n")
152 git(t, work, "add", "hello.txt")
153 git(t, work, "commit", "-m", "tweede-stap")
154 git(t, work, "push", "origin", "topic")
155 page = read(t, mustGet(t, tim, ts.URL+"/tim/takken/-/merge-requests/1"))
156 if !strings.Contains(page, "tweede-stap") || !strings.Contains(page, "pushed") {
157 t.Fatalf("push ververst de tijdlijn niet:\n%s", page)
158 }
159 changes := read(t, mustGet(t, tim, ts.URL+"/tim/takken/-/merge-requests/1?tab=changes"))
160 if !strings.Contains(changes, "hello.txt") || !strings.Contains(changes, `class="gutter"`) {
161 t.Fatalf("wijzigingen:\n%s", changes)
162 }
163
164 page = read(t, mustPost(t, tim, ts.URL+"/tim/takken/-/merge-requests/1/notes", url.Values{
165 "csrf": {csrfOf(t, page)}, "body": {"eerste reactie"},
166 }))
167 noteID := between(page, `data-reply="`, `"`)
168 if noteID == "" || !strings.Contains(page, "eerste reactie") {
169 t.Fatalf("reactie:\n%s", page)
170 }
171 page = read(t, mustPost(t, tim, ts.URL+"/tim/takken/-/merge-requests/1/notes", url.Values{
172 "csrf": {csrfOf(t, page)}, "parent": {noteID}, "body": {"**antwoord**"},
173 }))
174 if !strings.Contains(page, "<strong>antwoord</strong>") {
175 t.Fatalf("antwoord:\n%s", page)
176 }
177 page = read(t, mustPost(t, tim, ts.URL+"/tim/takken/-/merge-requests/1", url.Values{
178 "csrf": {csrfOf(t, page)}, "title": {"Nieuwe titel"}, "description": {"**vet**"}, "labels": {"bug, docs"},
179 }))
180 if !strings.Contains(page, "Nieuwe titel") || !strings.Contains(page, "changed the title") || !strings.Contains(page, "bug") {
181 t.Fatalf("bewerken:\n%s", page)
182 }
183}
184
185func mustPost(t *testing.T, c *http.Client, raw string, form url.Values) *http.Response {
186 t.Helper()
187 res, err := c.PostForm(raw, form)
188 if err != nil {
189 t.Fatal(err)
190 }
191 return res
192}