BlueGit

timfa bluegit

Files

bluegit / internal / server / commitgraph_test.go

commitgraph_test.go

commitgraph_test.go 14.8 KiB Download Raw
1package server
2
3import (
4 "context"
5 "net/http"
6 "net/http/cookiejar"
7 "net/http/httptest"
8 "net/url"
9 "os"
10 "path/filepath"
11 "strings"
12 "testing"
13 "time"
14
15 "gitlab.com/Timfa/bluegit/internal/auth"
16 "gitlab.com/Timfa/bluegit/internal/config"
17 "gitlab.com/Timfa/bluegit/internal/gitgraph"
18 "gitlab.com/Timfa/bluegit/internal/store"
19)
20
21func TestOverviewRendersCommitGraph(t *testing.T) {
22 ts, client, repo := graphTestRepo(t)
23 page := read(t, mustGet(t, client, ts.URL+"/tim/grafiek"))
24 if !strings.Contains(page, `class="commitgraph"`) {
25 t.Fatalf("geen grafiek op het overzicht:\n%s", page)
26 }
27 if !strings.Contains(page, `aria-label="Commit graph"`) && !strings.Contains(page, `aria-label="Commitgrafiek"`) {
28 t.Fatalf("geen toegankelijk label:\n%s", page)
29 }
30 if !strings.Contains(page, "is-default") || !strings.Contains(page, ">master<") {
31 t.Fatalf("hoofdbranch-label ontbreekt:\n%s", page)
32 }
33 if !strings.Contains(page, ">feature<") || !strings.Contains(page, "is-tag") || !strings.Contains(page, ">v1<") {
34 t.Fatalf("feature of tag ontbreekt:\n%s", page)
35 }
36 if !strings.Contains(page, `stroke="var(--blue)"`) {
37 t.Fatalf("hoofdbranch is niet blauw:\n%s", page)
38 }
39 if !strings.Contains(page, " Q ") || !strings.Contains(page, " H ") {
40 t.Fatalf("verwacht afgeronde 90-graden bochten in de svg:\n%s", page)
41 }
42 if !strings.Contains(page, `data-branch="master"`) {
43 t.Fatalf("gloed-attribuut ontbreekt:\n%s", page)
44 }
45 if !strings.Contains(page, `class="commitgraph-slot lanes-`) {
46 t.Fatalf("slot mist lanes-N klasse (CSP-veilige paneelmaten):\n%s", page)
47 }
48 if i := strings.Index(page, `class="commitgraph-slot`); i >= 0 {
49 end := strings.Index(page[i:], `</div>`)
50 chunk := page[i:]
51 if end >= 0 {
52 chunk = page[i : i+end]
53 }
54 if strings.Contains(chunk, "style=") {
55 t.Fatalf("commitgrafiek mag geen style-attribuut hebben (CSP style-src 'self'):\n%s", chunk)
56 }
57 if strings.Contains(chunk, "viewBox") {
58 t.Fatalf("commitgraph-svg mag geen viewBox hebben:\n%s", chunk)
59 }
60 if !strings.Contains(chunk, `<a class="commitgraph-node`) || !strings.Contains(chunk, "<circle") {
61 t.Fatalf("avatars horen in de SVG op de lane-x te staan:\n%s", chunk)
62 }
63 }
64 if strings.Contains(page, "ZgotmplZ") {
65 t.Fatalf("css-kleur werd weggestreept:\n%s", page)
66 }
67 if !strings.Contains(page, "/tim/grafiek/-/commit/") {
68 t.Fatalf("geen commitlinks")
69 }
70 if !strings.Contains(page, "merge feature") && !strings.Contains(page, "feature-work") {
71 t.Fatalf("commitberichten ontbreken")
72 }
73 // Tweede request: nog steeds dezelfde grafiek (cache).
74 page2 := read(t, mustGet(t, client, ts.URL+"/tim/grafiek"))
75 if !strings.Contains(page2, `class="commitgraph"`) {
76 t.Fatal("grafiek verdween bij herladen")
77 }
78 _ = repo
79}
80
81func TestGraphCacheHitSkipsGit(t *testing.T) {
82 ts, client, repo := graphTestRepo(t)
83 // Eerste opbouw via de pagina, daarna git-binary onbruikbaar maken.
84 _ = read(t, mustGet(t, client, ts.URL+"/tim/grafiek"))
85 srv := repo
86 srv.Git = filepath.Join(t.TempDir(), "niet-bestaande-git")
87 g, err := srv.repoGraph(context.Background(), mustStoreRepo(t, srv))
88 if err != nil || g == nil || len(g.Rows) == 0 {
89 t.Fatalf("cache-hit had geen git nodig, kreeg err=%v g=%v", err, g)
90 }
91 hits, misses, _, _ := srv.graphs().Stats()
92 if hits < 1 || misses < 1 {
93 t.Fatalf("verwacht miss+hit, hits=%d misses=%d", hits, misses)
94 }
95}
96
97func TestGraphColdWarmTimes(t *testing.T) {
98 storage := t.TempDir()
99 st, err := store.Open(filepath.Join(storage, "bluegit.db"), bytes32())
100 if err != nil {
101 t.Fatal(err)
102 }
103 t.Cleanup(func() { _ = st.Close() })
104 cfg := config.Config{
105 BaseURL: "http://git.example", Listen: "127.0.0.1:0", StoragePath: storage,
106 Auth: config.Auth{Mode: "dev", DevUser: "tim", DevAuthID: 1, UserAgent: "test", BaseURL: "https://auth.timfalken.com"},
107 Git: config.Git{Binary: "git", DefaultBranch: "master"},
108 }
109 srv := &Server{Cfg: cfg, Store: st, Auth: auth.Dev{Username: "tim", AuthID: 1}, Dev: true, Git: "git", HookBin: "/bin/true"}
110 ts := httptest.NewServer(srv.Handler())
111 t.Cleanup(ts.Close)
112 jar, _ := cookiejar.New(nil)
113 client := &http.Client{Jar: jar}
114 page := read(t, mustGet(t, client, ts.URL+"/login"))
115 page = read(t, mustPost(t, client, ts.URL+"/new/repo", url.Values{"csrf": {csrfOf(t, page)}, "name": {"tijden"}, "visibility": {"public"}}))
116 page = read(t, mustPost(t, client, ts.URL+"/settings/tokens", url.Values{"csrf": {csrfOf(t, page)}, "name": {"tim"}}))
117 token := between(page, `<p class="code">`, "</p>")
118
119 work := t.TempDir()
120 git(t, work, "init", "-b", "master")
121 git(t, work, "config", "user.email", "tim@example")
122 git(t, work, "config", "user.name", "tim")
123 remote := strings.Replace(ts.URL, "http://", "http://tim:"+token+"@", 1) + "/tim/tijden.git"
124 git(t, work, "remote", "add", "origin", remote)
125 for i := 0; i < 24; i++ {
126 writeFile(t, filepath.Join(work, "f"), string(rune('a'+i%26))+"\n")
127 git(t, work, "add", "f")
128 git(t, work, "commit", "-m", "c"+string(rune('a'+i%26)))
129 }
130 git(t, work, "checkout", "-b", "feature")
131 for i := 0; i < 8; i++ {
132 writeFile(t, filepath.Join(work, "g"), "g"+string(rune('a'+i))+"\n")
133 git(t, work, "add", "g")
134 git(t, work, "commit", "-m", "f"+string(rune('a'+i)))
135 }
136 git(t, work, "checkout", "master")
137 git(t, work, "merge", "--no-ff", "-m", "merge feature", "feature")
138 git(t, work, "push", "-u", "origin", "master")
139 git(t, work, "push", "origin", "feature")
140
141 row, err := st.RepoByPath(context.Background(), "tim", "tijden")
142 if err != nil {
143 t.Fatal(err)
144 }
145 ctx := context.Background()
146 // De push heeft de cache al via refsChanged gevuld; eerst legen voor een echte koude meting.
147 time.Sleep(50 * time.Millisecond)
148 srv.dropGraph(row)
149 start := time.Now()
150 g, err := srv.repoGraph(ctx, row)
151 cold := time.Since(start)
152 if err != nil || g == nil || len(g.Rows) == 0 {
153 t.Fatalf("koud: %v", err)
154 }
155 start = time.Now()
156 g2, err := srv.repoGraph(ctx, row)
157 warm := time.Since(start)
158 if err != nil || g2 == nil {
159 t.Fatalf("warm: %v", err)
160 }
161 t.Logf("commitgrafiek koud=%s warm=%s rijen=%d lanes=%d", cold, warm, len(g.Rows), g.Lanes)
162 if warm > cold && warm > 20*time.Millisecond {
163 t.Fatalf("warm (%s) zou ruim onder koud (%s) moeten liggen", warm, cold)
164 }
165 // Alleen rapporteren; een minieme warm-meting kan door ruis iets hoger zijn
166 // als beide sub-milliseconde zijn. Dan is het alsnog een cache-hit.
167 hits, _, _, _ := srv.graphs().Stats()
168 if hits < 1 {
169 t.Fatal("geen cache-hit bij de warme meting")
170 }
171}
172
173func graphTestRepo(t *testing.T) (*httptest.Server, *http.Client, *Server) {
174 t.Helper()
175 storage := t.TempDir()
176 st, err := store.Open(filepath.Join(storage, "bluegit.db"), bytes32())
177 if err != nil {
178 t.Fatal(err)
179 }
180 t.Cleanup(func() { _ = st.Close() })
181 cfg := config.Config{
182 BaseURL: "http://git.example", Listen: "127.0.0.1:0", StoragePath: storage,
183 Auth: config.Auth{Mode: "dev", DevUser: "tim", DevAuthID: 1, UserAgent: "test", BaseURL: "https://auth.timfalken.com"},
184 Git: config.Git{Binary: "git", DefaultBranch: "master"},
185 }
186 srv := &Server{Cfg: cfg, Store: st, Auth: auth.Dev{Username: "tim", AuthID: 1}, Dev: true, Git: "git", HookBin: "/bin/true"}
187 ts := httptest.NewServer(srv.Handler())
188 t.Cleanup(ts.Close)
189 jar, _ := cookiejar.New(nil)
190 client := &http.Client{Jar: jar}
191 page := read(t, mustGet(t, client, ts.URL+"/login"))
192 page = read(t, mustPost(t, client, ts.URL+"/new/repo", url.Values{"csrf": {csrfOf(t, page)}, "name": {"grafiek"}, "visibility": {"public"}}))
193 page = read(t, mustPost(t, client, ts.URL+"/settings/tokens", url.Values{"csrf": {csrfOf(t, page)}, "name": {"tim"}}))
194 token := between(page, `<p class="code">`, "</p>")
195
196 work := t.TempDir()
197 git(t, work, "init", "-b", "master")
198 git(t, work, "config", "user.email", "tim@example")
199 git(t, work, "config", "user.name", "tim")
200 writeFile(t, filepath.Join(work, "README.md"), "start\n")
201 git(t, work, "add", ".")
202 git(t, work, "commit", "-m", "start")
203 git(t, work, "checkout", "-b", "feature")
204 writeFile(t, filepath.Join(work, "extra.txt"), "meer\n")
205 git(t, work, "add", "extra.txt")
206 git(t, work, "commit", "-m", "feature-work")
207 git(t, work, "checkout", "master")
208 writeFile(t, filepath.Join(work, "on-master.txt"), "c\n")
209 git(t, work, "add", "on-master.txt")
210 git(t, work, "commit", "-m", "on-master")
211 git(t, work, "tag", "v1")
212 git(t, work, "merge", "--no-ff", "-m", "merge feature", "feature")
213 remote := strings.Replace(ts.URL, "http://", "http://tim:"+token+"@", 1) + "/tim/grafiek.git"
214 git(t, work, "remote", "add", "origin", remote)
215 git(t, work, "push", "-u", "origin", "master", "--tags")
216 git(t, work, "push", "-u", "origin", "feature")
217 return ts, client, srv
218}
219
220func mustStoreRepo(t *testing.T, s *Server) store.Repo {
221 t.Helper()
222 row, err := s.Store.RepoByPath(context.Background(), "tim", "grafiek")
223 if err != nil {
224 t.Fatal(err)
225 }
226 return row
227}
228
229func TestSVGColorsAreSafe(t *testing.T) {
230 g := gitgraph.Layout(
231 []gitgraph.Commit{
232 {SHA: "m", Subject: `<script>`, Parents: []string{"c", "f"}},
233 {SHA: "f", Subject: "x", Parents: []string{"b"}},
234 {SHA: "c", Subject: "y", Parents: []string{"b"}},
235 {SHA: "b", Subject: "z", Parents: nil},
236 },
237 []gitgraph.Ref{{Name: "master", SHA: "m", Kind: "branch"}, {Name: "feature", SHA: "f", Kind: "branch"}},
238 "master",
239 )
240 svg := g.SVG()
241 if strings.Contains(svg, "<script") || strings.Contains(svg, `subject`) {
242 t.Fatalf("svg lekt tekst: %s", svg)
243 }
244 if !strings.Contains(svg, "var(--blue)") {
245 t.Fatalf("blauw ontbreekt: %s", svg)
246 }
247 if !strings.Contains(svg, "stroke=\"var(--") {
248 t.Fatalf("verwacht stroke in %s", svg)
249 }
250 if strings.Contains(svg, "style=") {
251 t.Fatalf("geen style-attribuut in svg: %s", svg)
252 }
253 if !strings.Contains(svg, "<circle") {
254 t.Fatalf("verwacht knoop-cirkels in svg: %s", svg)
255 }
256 if !strings.Contains(svg, " Q ") {
257 t.Fatalf("verwacht afgeronde bochten in %s", svg)
258 }
259}
260
261func TestGraphCSSDoesNotShrinkLanes(t *testing.T) {
262 css, err := os.ReadFile("static/style.css")
263 if err != nil {
264 t.Fatal(err)
265 }
266 s := string(css)
267 for _, want := range []string{
268 "min-width: var(--graph-w)",
269 "flex: 0 0 var(--graph-w)",
270 "minmax(0, 1fr)",
271 "text-overflow: ellipsis",
272 "--graph-lanes-w",
273 ".commitgraph-slot.lanes-1 {",
274 ".commitgraph-slot.lanes-5 { --lanes: 5; --graph-svg-w: 140px; --graph-lanes-w: 148px; --graph-w: 406px; --graph-narrow-w: 226px; }",
275 "@container maincol (min-width: 1142px)",
276 "@media (min-width: 1400px)",
277 "@media (min-width: 1160px)",
278 "@media (min-width: 721px)",
279 "content: attr(data-tip)",
280 ".commitgraph-ref-short",
281 ".commitgraph-msg { display: none; }",
282 } {
283 if !strings.Contains(s, want) {
284 t.Fatalf("stylesheet mist %q", want)
285 }
286 }
287 svgW, textX, panelW, narrowW := gitgraph.PanelMetrics(5)
288 if svgW != 140 || textX != 148 || panelW != 406 || narrowW != 226 {
289 t.Fatalf("PanelMetrics(5)=%d,%d,%d,%d, wil 140,148,406,226", svgW, textX, panelW, narrowW)
290 }
291 for _, old := range []string{
292 "@media (min-width: 1860px)",
293 "@media (min-width: 1140px)",
294 "@container maincol (min-width: 900px)",
295 "@media (max-width: 1399px)",
296 "@media (max-width: 1159px)",
297 } {
298 if strings.Contains(s, old) {
299 t.Fatalf("oude drempel %q knijpt de hoofdkolom of verbergt de grafiek verkeerd", old)
300 }
301 }
302}
303
304func TestAssetCSSAndJSAreNotCached(t *testing.T) {
305 ts, client, _ := graphTestRepo(t)
306 css := mustGet(t, client, ts.URL+"/assets/style.css")
307 if got := css.Header.Get("Cache-Control"); got != "no-cache" {
308 t.Fatalf("style.css Cache-Control=%q, wil no-cache", got)
309 }
310 _ = css.Body.Close()
311 js := mustGet(t, client, ts.URL+"/assets/repo.js")
312 if got := js.Header.Get("Cache-Control"); got != "no-cache" {
313 t.Fatalf("repo.js Cache-Control=%q, wil no-cache", got)
314 }
315 _ = js.Body.Close()
316}
317
318func TestOverviewGraphFollowsCSP(t *testing.T) {
319 ts, client, _ := graphTestRepo(t)
320 res := mustGet(t, client, ts.URL+"/tim/grafiek")
321 csp := res.Header.Get("Content-Security-Policy")
322 if !strings.Contains(csp, "style-src 'self'") {
323 t.Fatalf("CSP mist style-src 'self': %q", csp)
324 }
325 // style-src mag geen unsafe-inline hebben; anders zouden we
326 // per ongeluk weer op attributen leunen die een strikt beleid blokkeert.
327 if i := strings.Index(csp, "style-src"); i >= 0 {
328 part := csp[i:]
329 if j := strings.Index(part, ";"); j >= 0 {
330 part = part[:j]
331 }
332 if strings.Contains(part, "unsafe-inline") {
333 t.Fatalf("style-src staat unsafe-inline toe, dat maskeert deze bug: %q", csp)
334 }
335 }
336 page := read(t, res)
337 start := strings.Index(page, `class="commitgraph-slot`)
338 if start < 0 {
339 t.Fatal("geen commitgraph-slot")
340 }
341 end := strings.Index(page[start:], "</aside>")
342 if end < 0 {
343 end = len(page) - start
344 }
345 chunk := page[start : start+end]
346 if strings.Contains(chunk, "style=") {
347 t.Fatalf("grafiek-HTML heeft een style-attribuut, CSP negeert die: %s", chunk)
348 }
349 if !strings.Contains(chunk, `<a class="commitgraph-node`) {
350 t.Fatal("svg-knopen ontbreken")
351 }
352}
353
354func TestOverviewNarrowMarkupAndTooltips(t *testing.T) {
355 ts, client, _ := graphTestRepo(t)
356 page := read(t, mustGet(t, client, ts.URL+"/tim/grafiek"))
357 if !strings.Contains(page, `data-tip="`) {
358 t.Fatalf("rijen missen data-tip voor de hovertekst:\n%s", page)
359 }
360 if !strings.Contains(page, `class="commitgraph-ref-short"`) || !strings.Contains(page, `class="commitgraph-ref-full"`) {
361 t.Fatalf("korte en lange branchlabels ontbreken:\n%s", page)
362 }
363 if !strings.Contains(page, "<title>") {
364 t.Fatalf("svg mist <title> als tooltip-basis:\n%s", page)
365 }
366 if !strings.Contains(page, `class="commitgraph-msg"`) {
367 t.Fatal("tekstkolom moet in de markup blijven (CSS verbergt hem in smalle modus)")
368 }
369 start := strings.Index(page, `class="commitgraph-slot`)
370 end := strings.Index(page[start:], "</aside>")
371 chunk := page[start : start+end]
372 if strings.Contains(chunk, "style=") {
373 t.Fatalf("grafiek heeft een style-attribuut: %s", chunk)
374 }
375}
376
377func TestOverviewColumnStaysUsableWhenNarrow(t *testing.T) {
378 css, err := os.ReadFile("static/style.css")
379 if err != nil {
380 t.Fatal(err)
381 }
382 s := string(css)
383 for _, want := range []string{
384 "container-name: overview",
385 "@container overview (max-width: 900px)",
386 "table-layout: fixed",
387 ".commitbar-actions",
388 ".proj .toolbar { flex-wrap: nowrap",
389 } {
390 if !strings.Contains(s, want) {
391 t.Fatalf("style.css mist %q (overzichtskolom moet op smalle breedte bruikbaar blijven)", want)
392 }
393 }
394 if !strings.Contains(s, ".commitbar") || !strings.Contains(s, "flex-wrap: wrap") {
395 t.Fatal("commitbalk moet mogen wrappen in plaats van de tekst te pletten")
396 }
397
398 ts, client, _ := graphTestRepo(t)
399 page := read(t, mustGet(t, client, ts.URL+"/tim/grafiek"))
400 if !strings.Contains(page, `class="commitbar-actions"`) {
401 t.Fatal("commitbalk mist commitbar-actions (pipeline/sha/History horen samen te wrappen)")
402 }
403 start := strings.Index(page, `class="commitbar"`)
404 if start < 0 {
405 t.Fatal("geen commitbar")
406 }
407 endRel := strings.Index(page[start:], `class="hscroll"`)
408 if endRel < 0 {
409 endRel = 2500
410 }
411 end := start + endRel
412 if end > len(page) {
413 end = len(page)
414 }
415 chunk := page[start:end]
416 if strings.Contains(chunk, "style=") {
417 t.Fatalf("commitbar heeft een style-attribuut, CSP negeert die: %s", chunk)
418 }
419}