BlueGit

timfa bluegit

Files

bluegit / internal / server / commitgraph_test.go

commitgraph_test.go

commitgraph_test.go 11.4 KiB Download Raw
1package server
2
3import (
4 "context"
5 "net/http"
6 "net/http/cookiejar"
7 "net/http/httptest"
8 "net/url"
9 "os"
10 "path/filepath"
11 "strings"
12 "testing"
13 "time"
14
15 "gitlab.com/Timfa/bluegit/internal/auth"
16 "gitlab.com/Timfa/bluegit/internal/config"
17 "gitlab.com/Timfa/bluegit/internal/gitgraph"
18 "gitlab.com/Timfa/bluegit/internal/store"
19)
20
21func TestOverviewRendersCommitGraph(t *testing.T) {
22 ts, client, repo := graphTestRepo(t)
23 page := read(t, mustGet(t, client, ts.URL+"/tim/grafiek"))
24 if !strings.Contains(page, `class="commitgraph"`) {
25 t.Fatalf("geen grafiek op het overzicht:\n%s", page)
26 }
27 if !strings.Contains(page, `aria-label="Commit graph"`) && !strings.Contains(page, `aria-label="Commitgrafiek"`) {
28 t.Fatalf("geen toegankelijk label:\n%s", page)
29 }
30 if !strings.Contains(page, "is-default") || !strings.Contains(page, ">master<") {
31 t.Fatalf("hoofdbranch-label ontbreekt:\n%s", page)
32 }
33 if !strings.Contains(page, ">feature<") || !strings.Contains(page, "is-tag") || !strings.Contains(page, ">v1<") {
34 t.Fatalf("feature of tag ontbreekt:\n%s", page)
35 }
36 if !strings.Contains(page, `stroke="var(--blue)"`) {
37 t.Fatalf("hoofdbranch is niet blauw:\n%s", page)
38 }
39 if !strings.Contains(page, " Q ") || !strings.Contains(page, " H ") {
40 t.Fatalf("verwacht afgeronde 90-graden bochten in de svg:\n%s", page)
41 }
42 if i := strings.Index(page, `class="commitgraph-svg"`); i >= 0 {
43 end := strings.Index(page[i:], "</svg>")
44 if end >= 0 && strings.Contains(page[i:i+end], "<circle") {
45 t.Fatalf("svg mag geen cirkels meer tekenen, de avatar is de knoop")
46 }
47 }
48 if !strings.Contains(page, `data-branch="master"`) {
49 t.Fatalf("gloed-attribuut ontbreekt:\n%s", page)
50 }
51 if !strings.Contains(page, `class="commitgraph-slot"`) || !strings.Contains(page, "--graph-w:") || !strings.Contains(page, "--graph-lanes-w:") || !strings.Contains(page, "--graph-svg-w:") {
52 t.Fatalf("inline paneelmaten ontbreken op de slot:\n%s", page)
53 }
54 if !strings.Contains(page, "grid-template-columns:") {
55 t.Fatalf("rijen missen een pixel-grid voor de tekstkolom:\n%s", page)
56 }
57 if !strings.Contains(page, `style="left:`) {
58 t.Fatalf("avatars missen een inline left (moeten op hun lane staan):\n%s", page)
59 }
60 if i := strings.Index(page, `class="commitgraph-svg"`); i >= 0 {
61 end := strings.Index(page[i:], "</svg>")
62 chunk := page[i:]
63 if end >= 0 {
64 chunk = page[i : i+end]
65 }
66 if strings.Contains(chunk, "viewBox") {
67 t.Fatalf("commitgraph-svg mag geen viewBox hebben (schaalt de lanes):\n%s", chunk)
68 }
69 if !strings.Contains(chunk, "style=\"width:") || !strings.Contains(chunk, "left:") {
70 t.Fatalf("commitgraph-svg mist 1:1 inline-maten:\n%s", chunk)
71 }
72 }
73 if strings.Contains(page, "ZgotmplZ") {
74 t.Fatalf("css-kleur werd weggestreept:\n%s", page)
75 }
76 if !strings.Contains(page, "/tim/grafiek/-/commit/") {
77 t.Fatalf("geen commitlinks")
78 }
79 if !strings.Contains(page, "merge feature") && !strings.Contains(page, "feature-work") {
80 t.Fatalf("commitberichten ontbreken")
81 }
82 // Tweede request: nog steeds dezelfde grafiek (cache).
83 page2 := read(t, mustGet(t, client, ts.URL+"/tim/grafiek"))
84 if !strings.Contains(page2, `class="commitgraph"`) {
85 t.Fatal("grafiek verdween bij herladen")
86 }
87 _ = repo
88}
89
90func TestGraphCacheHitSkipsGit(t *testing.T) {
91 ts, client, repo := graphTestRepo(t)
92 // Eerste opbouw via de pagina, daarna git-binary onbruikbaar maken.
93 _ = read(t, mustGet(t, client, ts.URL+"/tim/grafiek"))
94 srv := repo
95 srv.Git = filepath.Join(t.TempDir(), "niet-bestaande-git")
96 g, err := srv.repoGraph(context.Background(), mustStoreRepo(t, srv))
97 if err != nil || g == nil || len(g.Rows) == 0 {
98 t.Fatalf("cache-hit had geen git nodig, kreeg err=%v g=%v", err, g)
99 }
100 hits, misses, _, _ := srv.graphs().Stats()
101 if hits < 1 || misses < 1 {
102 t.Fatalf("verwacht miss+hit, hits=%d misses=%d", hits, misses)
103 }
104}
105
106func TestGraphColdWarmTimes(t *testing.T) {
107 storage := t.TempDir()
108 st, err := store.Open(filepath.Join(storage, "bluegit.db"), bytes32())
109 if err != nil {
110 t.Fatal(err)
111 }
112 t.Cleanup(func() { _ = st.Close() })
113 cfg := config.Config{
114 BaseURL: "http://git.example", Listen: "127.0.0.1:0", StoragePath: storage,
115 Auth: config.Auth{Mode: "dev", DevUser: "tim", DevAuthID: 1, UserAgent: "test", BaseURL: "https://auth.timfalken.com"},
116 Git: config.Git{Binary: "git", DefaultBranch: "master"},
117 }
118 srv := &Server{Cfg: cfg, Store: st, Auth: auth.Dev{Username: "tim", AuthID: 1}, Dev: true, Git: "git", HookBin: "/bin/true"}
119 ts := httptest.NewServer(srv.Handler())
120 t.Cleanup(ts.Close)
121 jar, _ := cookiejar.New(nil)
122 client := &http.Client{Jar: jar}
123 page := read(t, mustGet(t, client, ts.URL+"/login"))
124 page = read(t, mustPost(t, client, ts.URL+"/new/repo", url.Values{"csrf": {csrfOf(t, page)}, "name": {"tijden"}, "visibility": {"public"}}))
125 page = read(t, mustPost(t, client, ts.URL+"/settings/tokens", url.Values{"csrf": {csrfOf(t, page)}, "name": {"tim"}}))
126 token := between(page, `<p class="code">`, "</p>")
127
128 work := t.TempDir()
129 git(t, work, "init", "-b", "master")
130 git(t, work, "config", "user.email", "tim@example")
131 git(t, work, "config", "user.name", "tim")
132 remote := strings.Replace(ts.URL, "http://", "http://tim:"+token+"@", 1) + "/tim/tijden.git"
133 git(t, work, "remote", "add", "origin", remote)
134 for i := 0; i < 24; i++ {
135 writeFile(t, filepath.Join(work, "f"), string(rune('a'+i%26))+"\n")
136 git(t, work, "add", "f")
137 git(t, work, "commit", "-m", "c"+string(rune('a'+i%26)))
138 }
139 git(t, work, "checkout", "-b", "feature")
140 for i := 0; i < 8; i++ {
141 writeFile(t, filepath.Join(work, "g"), "g"+string(rune('a'+i))+"\n")
142 git(t, work, "add", "g")
143 git(t, work, "commit", "-m", "f"+string(rune('a'+i)))
144 }
145 git(t, work, "checkout", "master")
146 git(t, work, "merge", "--no-ff", "-m", "merge feature", "feature")
147 git(t, work, "push", "-u", "origin", "master")
148 git(t, work, "push", "origin", "feature")
149
150 row, err := st.RepoByPath(context.Background(), "tim", "tijden")
151 if err != nil {
152 t.Fatal(err)
153 }
154 ctx := context.Background()
155 // De push heeft de cache al via refsChanged gevuld; eerst legen voor een echte koude meting.
156 time.Sleep(50 * time.Millisecond)
157 srv.dropGraph(row)
158 start := time.Now()
159 g, err := srv.repoGraph(ctx, row)
160 cold := time.Since(start)
161 if err != nil || g == nil || len(g.Rows) == 0 {
162 t.Fatalf("koud: %v", err)
163 }
164 start = time.Now()
165 g2, err := srv.repoGraph(ctx, row)
166 warm := time.Since(start)
167 if err != nil || g2 == nil {
168 t.Fatalf("warm: %v", err)
169 }
170 t.Logf("commitgrafiek koud=%s warm=%s rijen=%d lanes=%d", cold, warm, len(g.Rows), g.Lanes)
171 if warm > cold && warm > 20*time.Millisecond {
172 t.Fatalf("warm (%s) zou ruim onder koud (%s) moeten liggen", warm, cold)
173 }
174 // Alleen rapporteren; een minieme warm-meting kan door ruis iets hoger zijn
175 // als beide sub-milliseconde zijn. Dan is het alsnog een cache-hit.
176 hits, _, _, _ := srv.graphs().Stats()
177 if hits < 1 {
178 t.Fatal("geen cache-hit bij de warme meting")
179 }
180}
181
182func graphTestRepo(t *testing.T) (*httptest.Server, *http.Client, *Server) {
183 t.Helper()
184 storage := t.TempDir()
185 st, err := store.Open(filepath.Join(storage, "bluegit.db"), bytes32())
186 if err != nil {
187 t.Fatal(err)
188 }
189 t.Cleanup(func() { _ = st.Close() })
190 cfg := config.Config{
191 BaseURL: "http://git.example", Listen: "127.0.0.1:0", StoragePath: storage,
192 Auth: config.Auth{Mode: "dev", DevUser: "tim", DevAuthID: 1, UserAgent: "test", BaseURL: "https://auth.timfalken.com"},
193 Git: config.Git{Binary: "git", DefaultBranch: "master"},
194 }
195 srv := &Server{Cfg: cfg, Store: st, Auth: auth.Dev{Username: "tim", AuthID: 1}, Dev: true, Git: "git", HookBin: "/bin/true"}
196 ts := httptest.NewServer(srv.Handler())
197 t.Cleanup(ts.Close)
198 jar, _ := cookiejar.New(nil)
199 client := &http.Client{Jar: jar}
200 page := read(t, mustGet(t, client, ts.URL+"/login"))
201 page = read(t, mustPost(t, client, ts.URL+"/new/repo", url.Values{"csrf": {csrfOf(t, page)}, "name": {"grafiek"}, "visibility": {"public"}}))
202 page = read(t, mustPost(t, client, ts.URL+"/settings/tokens", url.Values{"csrf": {csrfOf(t, page)}, "name": {"tim"}}))
203 token := between(page, `<p class="code">`, "</p>")
204
205 work := t.TempDir()
206 git(t, work, "init", "-b", "master")
207 git(t, work, "config", "user.email", "tim@example")
208 git(t, work, "config", "user.name", "tim")
209 writeFile(t, filepath.Join(work, "README.md"), "start\n")
210 git(t, work, "add", ".")
211 git(t, work, "commit", "-m", "start")
212 git(t, work, "checkout", "-b", "feature")
213 writeFile(t, filepath.Join(work, "extra.txt"), "meer\n")
214 git(t, work, "add", "extra.txt")
215 git(t, work, "commit", "-m", "feature-work")
216 git(t, work, "checkout", "master")
217 writeFile(t, filepath.Join(work, "on-master.txt"), "c\n")
218 git(t, work, "add", "on-master.txt")
219 git(t, work, "commit", "-m", "on-master")
220 git(t, work, "tag", "v1")
221 git(t, work, "merge", "--no-ff", "-m", "merge feature", "feature")
222 remote := strings.Replace(ts.URL, "http://", "http://tim:"+token+"@", 1) + "/tim/grafiek.git"
223 git(t, work, "remote", "add", "origin", remote)
224 git(t, work, "push", "-u", "origin", "master", "--tags")
225 git(t, work, "push", "-u", "origin", "feature")
226 return ts, client, srv
227}
228
229func mustStoreRepo(t *testing.T, s *Server) store.Repo {
230 t.Helper()
231 row, err := s.Store.RepoByPath(context.Background(), "tim", "grafiek")
232 if err != nil {
233 t.Fatal(err)
234 }
235 return row
236}
237
238func TestSVGColorsAreSafe(t *testing.T) {
239 g := gitgraph.Layout(
240 []gitgraph.Commit{
241 {SHA: "m", Subject: `<script>`, Parents: []string{"c", "f"}},
242 {SHA: "f", Subject: "x", Parents: []string{"b"}},
243 {SHA: "c", Subject: "y", Parents: []string{"b"}},
244 {SHA: "b", Subject: "z", Parents: nil},
245 },
246 []gitgraph.Ref{{Name: "master", SHA: "m", Kind: "branch"}, {Name: "feature", SHA: "f", Kind: "branch"}},
247 "master",
248 )
249 svg := g.SVG()
250 if strings.Contains(svg, "<script") || strings.Contains(svg, `subject`) {
251 t.Fatalf("svg lekt tekst: %s", svg)
252 }
253 if !strings.Contains(svg, "var(--blue)") {
254 t.Fatalf("blauw ontbreekt: %s", svg)
255 }
256 if !strings.Contains(svg, "stroke=\"var(--") {
257 t.Fatalf("verwacht stroke in %s", svg)
258 }
259 if strings.Contains(svg, "<circle") {
260 t.Fatalf("geen cirkels in svg: %s", svg)
261 }
262 if !strings.Contains(svg, " Q ") {
263 t.Fatalf("verwacht afgeronde bochten in %s", svg)
264 }
265}
266
267func TestGraphCSSDoesNotShrinkLanes(t *testing.T) {
268 css, err := os.ReadFile("static/style.css")
269 if err != nil {
270 t.Fatal(err)
271 }
272 s := string(css)
273 for _, want := range []string{
274 "min-width: var(--graph-w)",
275 "flex: 0 0 var(--graph-w)",
276 "minmax(0, 1fr)",
277 "text-overflow: ellipsis",
278 "--graph-lanes-w",
279 } {
280 if !strings.Contains(s, want) {
281 t.Fatalf("stylesheet mist %q", want)
282 }
283 }
284 for _, want := range []string{
285 "grid-column: 1 / -1",
286 "@container maincol (min-width: 1142px)",
287 "@media (min-width: 1400px)",
288 "@media (min-width: 1160px)",
289 } {
290 if !strings.Contains(s, want) {
291 t.Fatalf("stylesheet mist %q", want)
292 }
293 }
294 for _, old := range []string{
295 "@media (min-width: 1860px)",
296 "@media (min-width: 1140px)",
297 "@container maincol (min-width: 900px)",
298 } {
299 if strings.Contains(s, old) {
300 t.Fatalf("oude drempel %q knijpt de hoofdkolom of verbergt de grafiek verkeerd", old)
301 }
302 }
303}
304
305func TestAssetCSSAndJSAreNotCached(t *testing.T) {
306 ts, client, _ := graphTestRepo(t)
307 css := mustGet(t, client, ts.URL+"/assets/style.css")
308 if got := css.Header.Get("Cache-Control"); got != "no-cache" {
309 t.Fatalf("style.css Cache-Control=%q, wil no-cache", got)
310 }
311 _ = css.Body.Close()
312 js := mustGet(t, client, ts.URL+"/assets/repo.js")
313 if got := js.Header.Get("Cache-Control"); got != "no-cache" {
314 t.Fatalf("repo.js Cache-Control=%q, wil no-cache", got)
315 }
316 _ = js.Body.Close()
317}