BlueGit

timfa bluegit

Files

bluegit / internal / server / commitgraph_test.go

commitgraph_test.go

commitgraph_test.go 10.3 KiB Download Raw
1package server
2
3import (
4 "context"
5 "net/http"
6 "net/http/cookiejar"
7 "net/http/httptest"
8 "net/url"
9 "os"
10 "path/filepath"
11 "strings"
12 "testing"
13 "time"
14
15 "gitlab.com/Timfa/bluegit/internal/auth"
16 "gitlab.com/Timfa/bluegit/internal/config"
17 "gitlab.com/Timfa/bluegit/internal/gitgraph"
18 "gitlab.com/Timfa/bluegit/internal/store"
19)
20
21func TestOverviewRendersCommitGraph(t *testing.T) {
22 ts, client, repo := graphTestRepo(t)
23 page := read(t, mustGet(t, client, ts.URL+"/tim/grafiek"))
24 if !strings.Contains(page, `class="commitgraph"`) {
25 t.Fatalf("geen grafiek op het overzicht:\n%s", page)
26 }
27 if !strings.Contains(page, `aria-label="Commit graph"`) && !strings.Contains(page, `aria-label="Commitgrafiek"`) {
28 t.Fatalf("geen toegankelijk label:\n%s", page)
29 }
30 if !strings.Contains(page, "is-default") || !strings.Contains(page, ">master<") {
31 t.Fatalf("hoofdbranch-label ontbreekt:\n%s", page)
32 }
33 if !strings.Contains(page, ">feature<") || !strings.Contains(page, "is-tag") || !strings.Contains(page, ">v1<") {
34 t.Fatalf("feature of tag ontbreekt:\n%s", page)
35 }
36 if !strings.Contains(page, `stroke="var(--blue)"`) {
37 t.Fatalf("hoofdbranch is niet blauw:\n%s", page)
38 }
39 if !strings.Contains(page, " Q ") || !strings.Contains(page, " H ") {
40 t.Fatalf("verwacht afgeronde 90-graden bochten in de svg:\n%s", page)
41 }
42 if i := strings.Index(page, `class="commitgraph-svg"`); i >= 0 {
43 end := strings.Index(page[i:], "</svg>")
44 if end >= 0 && strings.Contains(page[i:i+end], "<circle") {
45 t.Fatalf("svg mag geen cirkels meer tekenen, de avatar is de knoop")
46 }
47 }
48 if !strings.Contains(page, `data-branch="master"`) {
49 t.Fatalf("gloed-attribuut ontbreekt:\n%s", page)
50 }
51 if !strings.Contains(page, `class="commitgraph-slot"`) || !strings.Contains(page, "--graph-w:") || !strings.Contains(page, "--graph-lanes-w:") || !strings.Contains(page, "--graph-svg-w:") {
52 t.Fatalf("inline paneelmaten ontbreken op de slot:\n%s", page)
53 }
54 if strings.Contains(page, "ZgotmplZ") {
55 t.Fatalf("css-kleur werd weggestreept:\n%s", page)
56 }
57 if !strings.Contains(page, "/tim/grafiek/-/commit/") {
58 t.Fatalf("geen commitlinks")
59 }
60 if !strings.Contains(page, "merge feature") && !strings.Contains(page, "feature-work") {
61 t.Fatalf("commitberichten ontbreken")
62 }
63 // Tweede request: nog steeds dezelfde grafiek (cache).
64 page2 := read(t, mustGet(t, client, ts.URL+"/tim/grafiek"))
65 if !strings.Contains(page2, `class="commitgraph"`) {
66 t.Fatal("grafiek verdween bij herladen")
67 }
68 _ = repo
69}
70
71func TestGraphCacheHitSkipsGit(t *testing.T) {
72 ts, client, repo := graphTestRepo(t)
73 // Eerste opbouw via de pagina, daarna git-binary onbruikbaar maken.
74 _ = read(t, mustGet(t, client, ts.URL+"/tim/grafiek"))
75 srv := repo
76 srv.Git = filepath.Join(t.TempDir(), "niet-bestaande-git")
77 g, err := srv.repoGraph(context.Background(), mustStoreRepo(t, srv))
78 if err != nil || g == nil || len(g.Rows) == 0 {
79 t.Fatalf("cache-hit had geen git nodig, kreeg err=%v g=%v", err, g)
80 }
81 hits, misses, _, _ := srv.graphs().Stats()
82 if hits < 1 || misses < 1 {
83 t.Fatalf("verwacht miss+hit, hits=%d misses=%d", hits, misses)
84 }
85}
86
87func TestGraphColdWarmTimes(t *testing.T) {
88 storage := t.TempDir()
89 st, err := store.Open(filepath.Join(storage, "bluegit.db"), bytes32())
90 if err != nil {
91 t.Fatal(err)
92 }
93 t.Cleanup(func() { _ = st.Close() })
94 cfg := config.Config{
95 BaseURL: "http://git.example", Listen: "127.0.0.1:0", StoragePath: storage,
96 Auth: config.Auth{Mode: "dev", DevUser: "tim", DevAuthID: 1, UserAgent: "test", BaseURL: "https://auth.timfalken.com"},
97 Git: config.Git{Binary: "git", DefaultBranch: "master"},
98 }
99 srv := &Server{Cfg: cfg, Store: st, Auth: auth.Dev{Username: "tim", AuthID: 1}, Dev: true, Git: "git", HookBin: "/bin/true"}
100 ts := httptest.NewServer(srv.Handler())
101 t.Cleanup(ts.Close)
102 jar, _ := cookiejar.New(nil)
103 client := &http.Client{Jar: jar}
104 page := read(t, mustGet(t, client, ts.URL+"/login"))
105 page = read(t, mustPost(t, client, ts.URL+"/new/repo", url.Values{"csrf": {csrfOf(t, page)}, "name": {"tijden"}, "visibility": {"public"}}))
106 page = read(t, mustPost(t, client, ts.URL+"/settings/tokens", url.Values{"csrf": {csrfOf(t, page)}, "name": {"tim"}}))
107 token := between(page, `<p class="code">`, "</p>")
108
109 work := t.TempDir()
110 git(t, work, "init", "-b", "master")
111 git(t, work, "config", "user.email", "tim@example")
112 git(t, work, "config", "user.name", "tim")
113 remote := strings.Replace(ts.URL, "http://", "http://tim:"+token+"@", 1) + "/tim/tijden.git"
114 git(t, work, "remote", "add", "origin", remote)
115 for i := 0; i < 24; i++ {
116 writeFile(t, filepath.Join(work, "f"), string(rune('a'+i%26))+"\n")
117 git(t, work, "add", "f")
118 git(t, work, "commit", "-m", "c"+string(rune('a'+i%26)))
119 }
120 git(t, work, "checkout", "-b", "feature")
121 for i := 0; i < 8; i++ {
122 writeFile(t, filepath.Join(work, "g"), "g"+string(rune('a'+i))+"\n")
123 git(t, work, "add", "g")
124 git(t, work, "commit", "-m", "f"+string(rune('a'+i)))
125 }
126 git(t, work, "checkout", "master")
127 git(t, work, "merge", "--no-ff", "-m", "merge feature", "feature")
128 git(t, work, "push", "-u", "origin", "master")
129 git(t, work, "push", "origin", "feature")
130
131 row, err := st.RepoByPath(context.Background(), "tim", "tijden")
132 if err != nil {
133 t.Fatal(err)
134 }
135 ctx := context.Background()
136 // De push heeft de cache al via refsChanged gevuld; eerst legen voor een echte koude meting.
137 time.Sleep(50 * time.Millisecond)
138 srv.dropGraph(row)
139 start := time.Now()
140 g, err := srv.repoGraph(ctx, row)
141 cold := time.Since(start)
142 if err != nil || g == nil || len(g.Rows) == 0 {
143 t.Fatalf("koud: %v", err)
144 }
145 start = time.Now()
146 g2, err := srv.repoGraph(ctx, row)
147 warm := time.Since(start)
148 if err != nil || g2 == nil {
149 t.Fatalf("warm: %v", err)
150 }
151 t.Logf("commitgrafiek koud=%s warm=%s rijen=%d lanes=%d", cold, warm, len(g.Rows), g.Lanes)
152 if warm > cold && warm > 20*time.Millisecond {
153 t.Fatalf("warm (%s) zou ruim onder koud (%s) moeten liggen", warm, cold)
154 }
155 // Alleen rapporteren; een minieme warm-meting kan door ruis iets hoger zijn
156 // als beide sub-milliseconde zijn. Dan is het alsnog een cache-hit.
157 hits, _, _, _ := srv.graphs().Stats()
158 if hits < 1 {
159 t.Fatal("geen cache-hit bij de warme meting")
160 }
161}
162
163func graphTestRepo(t *testing.T) (*httptest.Server, *http.Client, *Server) {
164 t.Helper()
165 storage := t.TempDir()
166 st, err := store.Open(filepath.Join(storage, "bluegit.db"), bytes32())
167 if err != nil {
168 t.Fatal(err)
169 }
170 t.Cleanup(func() { _ = st.Close() })
171 cfg := config.Config{
172 BaseURL: "http://git.example", Listen: "127.0.0.1:0", StoragePath: storage,
173 Auth: config.Auth{Mode: "dev", DevUser: "tim", DevAuthID: 1, UserAgent: "test", BaseURL: "https://auth.timfalken.com"},
174 Git: config.Git{Binary: "git", DefaultBranch: "master"},
175 }
176 srv := &Server{Cfg: cfg, Store: st, Auth: auth.Dev{Username: "tim", AuthID: 1}, Dev: true, Git: "git", HookBin: "/bin/true"}
177 ts := httptest.NewServer(srv.Handler())
178 t.Cleanup(ts.Close)
179 jar, _ := cookiejar.New(nil)
180 client := &http.Client{Jar: jar}
181 page := read(t, mustGet(t, client, ts.URL+"/login"))
182 page = read(t, mustPost(t, client, ts.URL+"/new/repo", url.Values{"csrf": {csrfOf(t, page)}, "name": {"grafiek"}, "visibility": {"public"}}))
183 page = read(t, mustPost(t, client, ts.URL+"/settings/tokens", url.Values{"csrf": {csrfOf(t, page)}, "name": {"tim"}}))
184 token := between(page, `<p class="code">`, "</p>")
185
186 work := t.TempDir()
187 git(t, work, "init", "-b", "master")
188 git(t, work, "config", "user.email", "tim@example")
189 git(t, work, "config", "user.name", "tim")
190 writeFile(t, filepath.Join(work, "README.md"), "start\n")
191 git(t, work, "add", ".")
192 git(t, work, "commit", "-m", "start")
193 git(t, work, "checkout", "-b", "feature")
194 writeFile(t, filepath.Join(work, "extra.txt"), "meer\n")
195 git(t, work, "add", "extra.txt")
196 git(t, work, "commit", "-m", "feature-work")
197 git(t, work, "checkout", "master")
198 writeFile(t, filepath.Join(work, "on-master.txt"), "c\n")
199 git(t, work, "add", "on-master.txt")
200 git(t, work, "commit", "-m", "on-master")
201 git(t, work, "tag", "v1")
202 git(t, work, "merge", "--no-ff", "-m", "merge feature", "feature")
203 remote := strings.Replace(ts.URL, "http://", "http://tim:"+token+"@", 1) + "/tim/grafiek.git"
204 git(t, work, "remote", "add", "origin", remote)
205 git(t, work, "push", "-u", "origin", "master", "--tags")
206 git(t, work, "push", "-u", "origin", "feature")
207 return ts, client, srv
208}
209
210func mustStoreRepo(t *testing.T, s *Server) store.Repo {
211 t.Helper()
212 row, err := s.Store.RepoByPath(context.Background(), "tim", "grafiek")
213 if err != nil {
214 t.Fatal(err)
215 }
216 return row
217}
218
219func TestSVGColorsAreSafe(t *testing.T) {
220 g := gitgraph.Layout(
221 []gitgraph.Commit{
222 {SHA: "m", Subject: `<script>`, Parents: []string{"c", "f"}},
223 {SHA: "f", Subject: "x", Parents: []string{"b"}},
224 {SHA: "c", Subject: "y", Parents: []string{"b"}},
225 {SHA: "b", Subject: "z", Parents: nil},
226 },
227 []gitgraph.Ref{{Name: "master", SHA: "m", Kind: "branch"}, {Name: "feature", SHA: "f", Kind: "branch"}},
228 "master",
229 )
230 svg := g.SVG()
231 if strings.Contains(svg, "<script") || strings.Contains(svg, `subject`) {
232 t.Fatalf("svg lekt tekst: %s", svg)
233 }
234 if !strings.Contains(svg, "var(--blue)") {
235 t.Fatalf("blauw ontbreekt: %s", svg)
236 }
237 if !strings.Contains(svg, "stroke=\"var(--") {
238 t.Fatalf("verwacht stroke in %s", svg)
239 }
240 if strings.Contains(svg, "<circle") {
241 t.Fatalf("geen cirkels in svg: %s", svg)
242 }
243 if !strings.Contains(svg, " Q ") {
244 t.Fatalf("verwacht afgeronde bochten in %s", svg)
245 }
246}
247
248func TestGraphCSSDoesNotShrinkLanes(t *testing.T) {
249 css, err := os.ReadFile("static/style.css")
250 if err != nil {
251 t.Fatal(err)
252 }
253 s := string(css)
254 for _, want := range []string{
255 "min-width: var(--graph-w)",
256 "flex: 0 0 var(--graph-w)",
257 "minmax(0, 1fr)",
258 "text-overflow: ellipsis",
259 "--graph-lanes-w",
260 } {
261 if !strings.Contains(s, want) {
262 t.Fatalf("stylesheet mist %q", want)
263 }
264 }
265 if strings.Contains(s, "@media (min-width: 1860px)") {
266 t.Fatal("oude 1860px-drempel verbergt de grafiek nog op 1280/1920")
267 }
268}
269
270func TestAssetCSSAndJSAreNotCached(t *testing.T) {
271 ts, client, _ := graphTestRepo(t)
272 css := mustGet(t, client, ts.URL+"/assets/style.css")
273 if got := css.Header.Get("Cache-Control"); got != "no-cache" {
274 t.Fatalf("style.css Cache-Control=%q, wil no-cache", got)
275 }
276 _ = css.Body.Close()
277 js := mustGet(t, client, ts.URL+"/assets/repo.js")
278 if got := js.Header.Get("Cache-Control"); got != "no-cache" {
279 t.Fatalf("repo.js Cache-Control=%q, wil no-cache", got)
280 }
281 _ = js.Body.Close()
282}