BlueGit

timfa bluegit

Files

bluegit / internal / server / commitgraph_test.go

commitgraph_test.go

commitgraph_test.go 16.0 KiB Download Raw
1package server
2
3import (
4 "context"
5 "net/http"
6 "net/http/cookiejar"
7 "net/http/httptest"
8 "net/url"
9 "os"
10 "path/filepath"
11 "strings"
12 "testing"
13 "time"
14
15 "gitlab.com/Timfa/bluegit/internal/auth"
16 "gitlab.com/Timfa/bluegit/internal/config"
17 "gitlab.com/Timfa/bluegit/internal/gitgraph"
18 "gitlab.com/Timfa/bluegit/internal/store"
19)
20
21func TestOverviewRendersCommitGraph(t *testing.T) {
22 ts, client, repo := graphTestRepo(t)
23 page := read(t, mustGet(t, client, ts.URL+"/tim/grafiek"))
24 if !strings.Contains(page, `class="commitgraph"`) {
25 t.Fatalf("geen grafiek op het overzicht:\n%s", page)
26 }
27 if !strings.Contains(page, `aria-label="Commit graph"`) && !strings.Contains(page, `aria-label="Commitgrafiek"`) {
28 t.Fatalf("geen toegankelijk label:\n%s", page)
29 }
30 if !strings.Contains(page, "is-default") || !strings.Contains(page, ">master<") {
31 t.Fatalf("hoofdbranch-label ontbreekt:\n%s", page)
32 }
33 if !strings.Contains(page, ">feature<") || !strings.Contains(page, "is-tag") || !strings.Contains(page, ">v1<") {
34 t.Fatalf("feature of tag ontbreekt:\n%s", page)
35 }
36 if !strings.Contains(page, `stroke="var(--blue)"`) {
37 t.Fatalf("hoofdbranch is niet blauw:\n%s", page)
38 }
39 if !strings.Contains(page, " Q ") || !strings.Contains(page, " H ") {
40 t.Fatalf("verwacht afgeronde 90-graden bochten in de svg:\n%s", page)
41 }
42 if !strings.Contains(page, `data-branch="master"`) {
43 t.Fatalf("gloed-attribuut ontbreekt:\n%s", page)
44 }
45 if !strings.Contains(page, `class="commitgraph-slot lanes-`) {
46 t.Fatalf("slot mist lanes-N klasse (CSP-veilige paneelmaten):\n%s", page)
47 }
48 if i := strings.Index(page, `class="commitgraph-slot`); i >= 0 {
49 end := strings.Index(page[i:], `</div>`)
50 chunk := page[i:]
51 if end >= 0 {
52 chunk = page[i : i+end]
53 }
54 if strings.Contains(chunk, "style=") {
55 t.Fatalf("commitgrafiek mag geen style-attribuut hebben (CSP style-src 'self'):\n%s", chunk)
56 }
57 if strings.Contains(chunk, "viewBox") {
58 t.Fatalf("commitgraph-svg mag geen viewBox hebben:\n%s", chunk)
59 }
60 if !strings.Contains(chunk, `<a class="commitgraph-node`) || !strings.Contains(chunk, "<circle") {
61 t.Fatalf("avatars horen in de SVG op de lane-x te staan:\n%s", chunk)
62 }
63 }
64 if strings.Contains(page, "ZgotmplZ") {
65 t.Fatalf("css-kleur werd weggestreept:\n%s", page)
66 }
67 if !strings.Contains(page, "/tim/grafiek/-/commit/") {
68 t.Fatalf("geen commitlinks")
69 }
70 if !strings.Contains(page, "merge feature") && !strings.Contains(page, "feature-work") {
71 t.Fatalf("commitberichten ontbreken")
72 }
73 // Tweede request: nog steeds dezelfde grafiek (cache).
74 page2 := read(t, mustGet(t, client, ts.URL+"/tim/grafiek"))
75 if !strings.Contains(page2, `class="commitgraph"`) {
76 t.Fatal("grafiek verdween bij herladen")
77 }
78 _ = repo
79}
80
81func TestGraphCacheHitSkipsGit(t *testing.T) {
82 ts, client, repo := graphTestRepo(t)
83 // Eerste opbouw via de pagina, daarna git-binary onbruikbaar maken.
84 _ = read(t, mustGet(t, client, ts.URL+"/tim/grafiek"))
85 srv := repo
86 srv.Git = filepath.Join(t.TempDir(), "niet-bestaande-git")
87 g, err := srv.repoGraph(context.Background(), mustStoreRepo(t, srv))
88 if err != nil || g == nil || len(g.Rows) == 0 {
89 t.Fatalf("cache-hit had geen git nodig, kreeg err=%v g=%v", err, g)
90 }
91 hits, misses, _, _ := srv.graphs().Stats()
92 if hits < 1 || misses < 1 {
93 t.Fatalf("verwacht miss+hit, hits=%d misses=%d", hits, misses)
94 }
95}
96
97func TestGraphColdWarmTimes(t *testing.T) {
98 storage := t.TempDir()
99 st, err := store.Open(filepath.Join(storage, "bluegit.db"), bytes32())
100 if err != nil {
101 t.Fatal(err)
102 }
103 t.Cleanup(func() { _ = st.Close() })
104 cfg := config.Config{
105 BaseURL: "http://git.example", Listen: "127.0.0.1:0", StoragePath: storage,
106 Auth: config.Auth{Mode: "dev", DevUser: "tim", DevAuthID: 1, UserAgent: "test", BaseURL: "https://auth.timfalken.com"},
107 Git: config.Git{Binary: "git", DefaultBranch: "master"},
108 }
109 srv := &Server{Cfg: cfg, Store: st, Auth: auth.Dev{Username: "tim", AuthID: 1}, Dev: true, Git: "git", HookBin: "/bin/true"}
110 ts := httptest.NewServer(srv.Handler())
111 t.Cleanup(ts.Close)
112 jar, _ := cookiejar.New(nil)
113 client := &http.Client{Jar: jar}
114 page := read(t, mustGet(t, client, ts.URL+"/login"))
115 page = read(t, mustPost(t, client, ts.URL+"/new/repo", url.Values{"csrf": {csrfOf(t, page)}, "name": {"tijden"}, "visibility": {"public"}}))
116 page = read(t, mustPost(t, client, ts.URL+"/settings/tokens", url.Values{"csrf": {csrfOf(t, page)}, "name": {"tim"}}))
117 token := between(page, `<p class="code">`, "</p>")
118
119 work := t.TempDir()
120 git(t, work, "init", "-b", "master")
121 git(t, work, "config", "user.email", "tim@example")
122 git(t, work, "config", "user.name", "tim")
123 remote := strings.Replace(ts.URL, "http://", "http://tim:"+token+"@", 1) + "/tim/tijden.git"
124 git(t, work, "remote", "add", "origin", remote)
125 for i := 0; i < 24; i++ {
126 writeFile(t, filepath.Join(work, "f"), string(rune('a'+i%26))+"\n")
127 git(t, work, "add", "f")
128 git(t, work, "commit", "-m", "c"+string(rune('a'+i%26)))
129 }
130 git(t, work, "checkout", "-b", "feature")
131 for i := 0; i < 8; i++ {
132 writeFile(t, filepath.Join(work, "g"), "g"+string(rune('a'+i))+"\n")
133 git(t, work, "add", "g")
134 git(t, work, "commit", "-m", "f"+string(rune('a'+i)))
135 }
136 git(t, work, "checkout", "master")
137 git(t, work, "merge", "--no-ff", "-m", "merge feature", "feature")
138 git(t, work, "push", "-u", "origin", "master")
139 git(t, work, "push", "origin", "feature")
140
141 row, err := st.RepoByPath(context.Background(), "tim", "tijden")
142 if err != nil {
143 t.Fatal(err)
144 }
145 ctx := context.Background()
146 // De push heeft de cache al via refsChanged gevuld; eerst legen voor een echte koude meting.
147 time.Sleep(50 * time.Millisecond)
148 srv.dropGraph(row)
149 start := time.Now()
150 g, err := srv.repoGraph(ctx, row)
151 cold := time.Since(start)
152 if err != nil || g == nil || len(g.Rows) == 0 {
153 t.Fatalf("koud: %v", err)
154 }
155 start = time.Now()
156 g2, err := srv.repoGraph(ctx, row)
157 warm := time.Since(start)
158 if err != nil || g2 == nil {
159 t.Fatalf("warm: %v", err)
160 }
161 t.Logf("commitgrafiek koud=%s warm=%s rijen=%d lanes=%d", cold, warm, len(g.Rows), g.Lanes)
162 if warm > cold && warm > 20*time.Millisecond {
163 t.Fatalf("warm (%s) zou ruim onder koud (%s) moeten liggen", warm, cold)
164 }
165 // Alleen rapporteren; een minieme warm-meting kan door ruis iets hoger zijn
166 // als beide sub-milliseconde zijn. Dan is het alsnog een cache-hit.
167 hits, _, _, _ := srv.graphs().Stats()
168 if hits < 1 {
169 t.Fatal("geen cache-hit bij de warme meting")
170 }
171}
172
173func graphTestRepo(t *testing.T) (*httptest.Server, *http.Client, *Server) {
174 t.Helper()
175 storage := t.TempDir()
176 st, err := store.Open(filepath.Join(storage, "bluegit.db"), bytes32())
177 if err != nil {
178 t.Fatal(err)
179 }
180 t.Cleanup(func() { _ = st.Close() })
181 cfg := config.Config{
182 BaseURL: "http://git.example", Listen: "127.0.0.1:0", StoragePath: storage,
183 Auth: config.Auth{Mode: "dev", DevUser: "tim", DevAuthID: 1, UserAgent: "test", BaseURL: "https://auth.timfalken.com"},
184 Git: config.Git{Binary: "git", DefaultBranch: "master"},
185 }
186 srv := &Server{Cfg: cfg, Store: st, Auth: auth.Dev{Username: "tim", AuthID: 1}, Dev: true, Git: "git", HookBin: "/bin/true"}
187 ts := httptest.NewServer(srv.Handler())
188 t.Cleanup(ts.Close)
189 jar, _ := cookiejar.New(nil)
190 client := &http.Client{Jar: jar}
191 page := read(t, mustGet(t, client, ts.URL+"/login"))
192 page = read(t, mustPost(t, client, ts.URL+"/new/repo", url.Values{"csrf": {csrfOf(t, page)}, "name": {"grafiek"}, "visibility": {"public"}}))
193 page = read(t, mustPost(t, client, ts.URL+"/settings/tokens", url.Values{"csrf": {csrfOf(t, page)}, "name": {"tim"}}))
194 token := between(page, `<p class="code">`, "</p>")
195
196 work := t.TempDir()
197 git(t, work, "init", "-b", "master")
198 git(t, work, "config", "user.email", "tim@example")
199 git(t, work, "config", "user.name", "tim")
200 writeFile(t, filepath.Join(work, "README.md"), "start\n")
201 git(t, work, "add", ".")
202 git(t, work, "commit", "-m", "start")
203 git(t, work, "checkout", "-b", "feature")
204 writeFile(t, filepath.Join(work, "extra.txt"), "meer\n")
205 git(t, work, "add", "extra.txt")
206 git(t, work, "commit", "-m", "feature-work")
207 git(t, work, "checkout", "master")
208 writeFile(t, filepath.Join(work, "on-master.txt"), "c\n")
209 git(t, work, "add", "on-master.txt")
210 git(t, work, "commit", "-m", "on-master")
211 git(t, work, "tag", "v1")
212 git(t, work, "merge", "--no-ff", "-m", "merge feature", "feature")
213 remote := strings.Replace(ts.URL, "http://", "http://tim:"+token+"@", 1) + "/tim/grafiek.git"
214 git(t, work, "remote", "add", "origin", remote)
215 git(t, work, "push", "-u", "origin", "master", "--tags")
216 git(t, work, "push", "-u", "origin", "feature")
217 return ts, client, srv
218}
219
220func mustStoreRepo(t *testing.T, s *Server) store.Repo {
221 t.Helper()
222 row, err := s.Store.RepoByPath(context.Background(), "tim", "grafiek")
223 if err != nil {
224 t.Fatal(err)
225 }
226 return row
227}
228
229func TestSVGColorsAreSafe(t *testing.T) {
230 g := gitgraph.Layout(
231 []gitgraph.Commit{
232 {SHA: "m", Subject: `<script>`, Parents: []string{"c", "f"}},
233 {SHA: "f", Subject: "x", Parents: []string{"b"}},
234 {SHA: "c", Subject: "y", Parents: []string{"b"}},
235 {SHA: "b", Subject: "z", Parents: nil},
236 },
237 []gitgraph.Ref{{Name: "master", SHA: "m", Kind: "branch"}, {Name: "feature", SHA: "f", Kind: "branch"}},
238 "master",
239 )
240 svg := g.SVG()
241 if strings.Contains(svg, "<script") || strings.Contains(svg, `subject`) {
242 t.Fatalf("svg lekt tekst: %s", svg)
243 }
244 if !strings.Contains(svg, "var(--blue)") {
245 t.Fatalf("blauw ontbreekt: %s", svg)
246 }
247 if !strings.Contains(svg, "stroke=\"var(--") {
248 t.Fatalf("verwacht stroke in %s", svg)
249 }
250 if strings.Contains(svg, "style=") {
251 t.Fatalf("geen style-attribuut in svg: %s", svg)
252 }
253 if !strings.Contains(svg, "<circle") {
254 t.Fatalf("verwacht knoop-cirkels in svg: %s", svg)
255 }
256 if !strings.Contains(svg, " Q ") {
257 t.Fatalf("verwacht afgeronde bochten in %s", svg)
258 }
259}
260
261func TestGraphCSSDoesNotShrinkLanes(t *testing.T) {
262 css, err := os.ReadFile("static/style.css")
263 if err != nil {
264 t.Fatal(err)
265 }
266 s := string(css)
267 for _, want := range []string{
268 "min-width: var(--graph-w)",
269 "flex: 0 0 var(--graph-narrow-w)",
270 "flex: 1 1 auto",
271 "justify-content: flex-start",
272 "minmax(0, 1fr)",
273 "text-overflow: ellipsis",
274 "--graph-lanes-w",
275 ".commitgraph-slot.lanes-1 {",
276 ".commitgraph-slot.lanes-5 { --lanes: 5; --graph-svg-w: 140px; --graph-lanes-w: 148px; --graph-w: 406px; --graph-narrow-w: 226px; }",
277 "@container maincol (min-width: 1142px)",
278 "@media (min-width: 1400px)",
279 "@media (min-width: 1160px)",
280 "@media (min-width: 721px)",
281 ".commitgraph-ref-short",
282 ".commitgraph-msg { display: none; }",
283 "mask-image: linear-gradient(to bottom",
284 "mask-image: linear-gradient(to right",
285 "stroke: var(--c, var(--blue))",
286 } {
287 if !strings.Contains(s, want) {
288 t.Fatalf("stylesheet mist %q", want)
289 }
290 }
291 svgW, textX, panelW, narrowW := gitgraph.PanelMetrics(5)
292 if svgW != 140 || textX != 148 || panelW != 406 || narrowW != 226 {
293 t.Fatalf("PanelMetrics(5)=%d,%d,%d,%d, wil 140,148,406,226", svgW, textX, panelW, narrowW)
294 }
295 for _, old := range []string{
296 "@media (min-width: 1860px)",
297 "@media (min-width: 1140px)",
298 "@container maincol (min-width: 900px)",
299 "@media (max-width: 1399px)",
300 "@media (max-width: 1159px)",
301 "content: attr(data-tip)",
302 ".commitgraph-row[data-tip]",
303 } {
304 if strings.Contains(s, old) {
305 t.Fatalf("verouderde regel %q hoort niet meer in de stylesheet", old)
306 }
307 }
308 if i := strings.Index(s, ".commitgraph {"); i >= 0 {
309 block := s[i:]
310 if j := strings.Index(block, "}"); j >= 0 {
311 block = block[:j]
312 }
313 if strings.Contains(block, "overflow-y: auto") || strings.Contains(block, "overflow-y: scroll") {
314 t.Fatal("de grafiek mag geen eigen verticale scrollbar hebben")
315 }
316 }
317}
318
319func TestAssetCSSAndJSAreNotCached(t *testing.T) {
320 ts, client, _ := graphTestRepo(t)
321 css := mustGet(t, client, ts.URL+"/assets/style.css")
322 if got := css.Header.Get("Cache-Control"); got != "no-cache" {
323 t.Fatalf("style.css Cache-Control=%q, wil no-cache", got)
324 }
325 _ = css.Body.Close()
326 js := mustGet(t, client, ts.URL+"/assets/repo.js")
327 if got := js.Header.Get("Cache-Control"); got != "no-cache" {
328 t.Fatalf("repo.js Cache-Control=%q, wil no-cache", got)
329 }
330 _ = js.Body.Close()
331}
332
333func TestOverviewGraphFollowsCSP(t *testing.T) {
334 ts, client, _ := graphTestRepo(t)
335 res := mustGet(t, client, ts.URL+"/tim/grafiek")
336 csp := res.Header.Get("Content-Security-Policy")
337 if !strings.Contains(csp, "style-src 'self'") {
338 t.Fatalf("CSP mist style-src 'self': %q", csp)
339 }
340 // style-src mag geen unsafe-inline hebben; anders zouden we
341 // per ongeluk weer op attributen leunen die een strikt beleid blokkeert.
342 if i := strings.Index(csp, "style-src"); i >= 0 {
343 part := csp[i:]
344 if j := strings.Index(part, ";"); j >= 0 {
345 part = part[:j]
346 }
347 if strings.Contains(part, "unsafe-inline") {
348 t.Fatalf("style-src staat unsafe-inline toe, dat maskeert deze bug: %q", csp)
349 }
350 }
351 page := read(t, res)
352 start := strings.Index(page, `class="commitgraph-slot`)
353 if start < 0 {
354 t.Fatal("geen commitgraph-slot")
355 }
356 end := strings.Index(page[start:], "</aside>")
357 if end < 0 {
358 end = len(page) - start
359 }
360 chunk := page[start : start+end]
361 if strings.Contains(chunk, "style=") {
362 t.Fatalf("grafiek-HTML heeft een style-attribuut, CSP negeert die: %s", chunk)
363 }
364 if !strings.Contains(chunk, `<a class="commitgraph-node`) {
365 t.Fatal("svg-knopen ontbreken")
366 }
367}
368
369func TestOverviewNarrowMarkupAndTooltips(t *testing.T) {
370 ts, client, _ := graphTestRepo(t)
371 page := read(t, mustGet(t, client, ts.URL+"/tim/grafiek"))
372 start := strings.Index(page, `class="commitgraph-slot`)
373 if start < 0 {
374 t.Fatal("geen commitgraph-slot")
375 }
376 endRel := strings.Index(page[start:], "</aside>")
377 if endRel < 0 {
378 t.Fatal("geen einde van de grafiek")
379 }
380 chunk := page[start : start+endRel]
381 if strings.Contains(chunk, "data-tip=") {
382 t.Fatalf("grafiek gebruikt nog een custom data-tip, alleen native title is gewenst: %s", chunk)
383 }
384 if !strings.Contains(chunk, "<title>") {
385 t.Fatalf("svg mist <title> voor de native tooltip:\n%s", chunk)
386 }
387 if !strings.Contains(chunk, `class="commitgraph-msg"`) || !strings.Contains(chunk, `title="`) {
388 t.Fatal("committekst mist een title-attribuut voor hover in brede modus")
389 }
390 if !strings.Contains(page, `class="commitgraph-ref-short"`) || !strings.Contains(page, `class="commitgraph-ref-full"`) {
391 t.Fatalf("korte en lange branchlabels ontbreken:\n%s", page)
392 }
393 if strings.Contains(chunk, "style=") {
394 t.Fatalf("grafiek heeft een style-attribuut: %s", chunk)
395 }
396 mainEnd := strings.Index(page, "</main>")
397 if mainEnd < 0 || start < mainEnd {
398 t.Fatal("de grafiek moet rechts van de centrale kolom staan (na </main>)")
399 }
400}
401
402func TestOverviewColumnStaysUsableWhenNarrow(t *testing.T) {
403 css, err := os.ReadFile("static/style.css")
404 if err != nil {
405 t.Fatal(err)
406 }
407 s := string(css)
408 for _, want := range []string{
409 "container-name: overview",
410 "@container overview (max-width: 900px)",
411 "table-layout: fixed",
412 ".commitbar-actions",
413 ".proj .toolbar { flex-wrap: nowrap",
414 } {
415 if !strings.Contains(s, want) {
416 t.Fatalf("style.css mist %q (overzichtskolom moet op smalle breedte bruikbaar blijven)", want)
417 }
418 }
419 if !strings.Contains(s, ".commitbar") || !strings.Contains(s, "flex-wrap: wrap") {
420 t.Fatal("commitbalk moet mogen wrappen in plaats van de tekst te pletten")
421 }
422
423 ts, client, _ := graphTestRepo(t)
424 page := read(t, mustGet(t, client, ts.URL+"/tim/grafiek"))
425 if !strings.Contains(page, `class="commitbar-actions"`) {
426 t.Fatal("commitbalk mist commitbar-actions (pipeline/sha/History horen samen te wrappen)")
427 }
428 start := strings.Index(page, `class="commitbar"`)
429 if start < 0 {
430 t.Fatal("geen commitbar")
431 }
432 endRel := strings.Index(page[start:], `class="hscroll"`)
433 if endRel < 0 {
434 endRel = 2500
435 }
436 end := start + endRel
437 if end > len(page) {
438 end = len(page)
439 }
440 chunk := page[start:end]
441 if strings.Contains(chunk, "style=") {
442 t.Fatalf("commitbar heeft een style-attribuut, CSP negeert die: %s", chunk)
443 }
444}
445
446func TestCommitGraphGlowWaitsForDOM(t *testing.T) {
447 js, err := os.ReadFile("static/repo.js")
448 if err != nil {
449 t.Fatal(err)
450 }
451 s := string(js)
452 if !strings.Contains(s, "DOMContentLoaded") || !strings.Contains(s, "startCommitGraph") {
453 t.Fatal("repo.js moet de grafiekgloed pas na DOMContentLoaded zetten, omdat de grafiek na </main> staat")
454 }
455}