| 1 | package server |
| 2 | |
| 3 | import ( |
| 4 | "net/http" |
| 5 | "net/http/cookiejar" |
| 6 | "net/http/httptest" |
| 7 | "net/url" |
| 8 | "os" |
| 9 | "path/filepath" |
| 10 | "strings" |
| 11 | "testing" |
| 12 | |
| 13 | "gitlab.com/Timfa/bluegit/internal/auth" |
| 14 | "gitlab.com/Timfa/bluegit/internal/config" |
| 15 | "gitlab.com/Timfa/bluegit/internal/store" |
| 16 | ) |
| 17 | |
| 18 | // Kleinste geldige PNG (1x1). |
| 19 | var tinyPNG = "\x89PNG\r\n\x1a\n\x00\x00\x00\rIHDR\x00\x00\x00\x01\x00\x00\x00\x01\x08\x06\x00\x00\x00\x1f\x15\xc4\x89\x00\x00\x00\rIDATx\x9cc\xf8\x0f\x00\x00\x01\x01\x00\x05\x18\xd8N\x00\x00\x00\x00IEND\xaeB`\x82" |
| 20 | |
| 21 | func TestReadmeImages(t *testing.T) { |
| 22 | storage := t.TempDir() |
| 23 | st, err := store.Open(filepath.Join(storage, "bluegit.db"), bytes32()) |
| 24 | if err != nil { |
| 25 | t.Fatal(err) |
| 26 | } |
| 27 | t.Cleanup(func() { _ = st.Close() }) |
| 28 | cfg := config.Config{ |
| 29 | BaseURL: "http://git.example", Listen: "127.0.0.1:0", StoragePath: storage, |
| 30 | Auth: config.Auth{Mode: "dev", DevUser: "tim", DevAuthID: 1, UserAgent: "test", BaseURL: "https://auth.timfalken.com"}, |
| 31 | Git: config.Git{Binary: "git", DefaultBranch: "master"}, |
| 32 | } |
| 33 | srv := &Server{Cfg: cfg, Store: st, Auth: auth.Dev{Username: "tim", AuthID: 1}, Dev: true, Git: "git", HookBin: "/bin/true"} |
| 34 | ts := httptest.NewServer(srv.Handler()) |
| 35 | t.Cleanup(ts.Close) |
| 36 | jar, _ := cookiejar.New(nil) |
| 37 | client := &http.Client{Jar: jar} |
| 38 | page := read(t, mustGet(t, client, ts.URL+"/login")) |
| 39 | page = read(t, mustPost(t, client, ts.URL+"/new/repo", url.Values{"csrf": {csrfOf(t, page)}, "name": {"plaatjes"}, "visibility": {"public"}})) |
| 40 | page = read(t, mustPost(t, client, ts.URL+"/settings/tokens", url.Values{"csrf": {csrfOf(t, page)}, "name": {"tim"}})) |
| 41 | token := between(page, `<p class="code">`, "</p>") |
| 42 | |
| 43 | work := t.TempDir() |
| 44 | git(t, work, "init", "-b", "master") |
| 45 | git(t, work, "config", "user.email", "tim@example") |
| 46 | git(t, work, "config", "user.name", "tim") |
| 47 | writeFile(t, filepath.Join(work, "README.md"), "# Plaatjes\n\n\n\n<img src=\"docs/diagram.svg\" alt=\"Diagram\" width=\"200\">\n") |
| 48 | if err := os.MkdirAll(filepath.Join(work, "assets"), 0o755); err != nil { |
| 49 | t.Fatal(err) |
| 50 | } |
| 51 | if err := os.WriteFile(filepath.Join(work, "assets", "logo.png"), []byte(tinyPNG), 0o644); err != nil { |
| 52 | t.Fatal(err) |
| 53 | } |
| 54 | writeFile(t, filepath.Join(work, "docs", "diagram.svg"), `<svg xmlns="http://www.w3.org/2000/svg" width="10" height="10"><script>alert(1)</script><rect width="10" height="10"/></svg>`) |
| 55 | writeFile(t, filepath.Join(work, "docs", "README.md"), "# Docs\n\n \n") |
| 56 | writeFile(t, filepath.Join(work, "docs", "guide.md"), "# Gids\n\n| Stap | Beeld |\n| --- | --- |\n| 1 |  |\n") |
| 57 | git(t, work, "add", ".") |
| 58 | git(t, work, "commit", "-m", "plaatjes") |
| 59 | git(t, work, "checkout", "-b", "feature/x") |
| 60 | remote := strings.Replace(ts.URL, "http://", "http://tim:"+token+"@", 1) + "/tim/plaatjes.git" |
| 61 | git(t, work, "remote", "add", "origin", remote) |
| 62 | git(t, work, "push", "-u", "origin", "master") |
| 63 | git(t, work, "push", "-u", "origin", "feature/x") |
| 64 | |
| 65 | res := mustGet(t, client, ts.URL+"/tim/plaatjes?rev=feature/x") |
| 66 | if csp := res.Header.Get("Content-Security-Policy"); !strings.Contains(csp, "img-src 'self' https: data:") || strings.Contains(csp, "http:") { |
| 67 | t.Fatalf("CSP %q", csp) |
| 68 | } |
| 69 | home := read(t, res) |
| 70 | for _, want := range []string{ |
| 71 | `<img class="mdimg" src="/tim/plaatjes/-/raw/assets/logo.png?rev=feature%2Fx" alt="Logo"`, |
| 72 | `<img class="mdimg" src="/tim/plaatjes/-/raw/docs/diagram.svg?rev=feature%2Fx&as=img" alt="Diagram" width="200"`, |
| 73 | } { |
| 74 | if !strings.Contains(home, want) { |
| 75 | t.Fatalf("overzicht mist %s", want) |
| 76 | } |
| 77 | } |
| 78 | if strings.Contains(home, "<svg xmlns=\"http://www.w3.org/2000/svg\" width=\"10\"") || strings.Contains(home, "alert(1)") { |
| 79 | t.Fatal("SVG inline in de pagina") |
| 80 | } |
| 81 | |
| 82 | png := mustGet(t, client, ts.URL+"/tim/plaatjes/-/raw/assets/logo.png?rev=feature%2Fx") |
| 83 | if png.StatusCode != 200 || png.Header.Get("Content-Type") != "image/png" { |
| 84 | t.Fatalf("png %d %s", png.StatusCode, png.Header.Get("Content-Type")) |
| 85 | } |
| 86 | _ = png.Body.Close() |
| 87 | svg := mustGet(t, client, ts.URL+"/tim/plaatjes/-/raw/docs/diagram.svg?rev=feature%2Fx&as=img") |
| 88 | if svg.Header.Get("Content-Type") != "image/svg+xml" || !strings.Contains(svg.Header.Get("Content-Security-Policy"), "sandbox") || svg.Header.Get("X-Content-Type-Options") != "nosniff" { |
| 89 | t.Fatalf("svg %s %q", svg.Header.Get("Content-Type"), svg.Header.Get("Content-Security-Policy")) |
| 90 | } |
| 91 | _ = svg.Body.Close() |
| 92 | |
| 93 | tree := read(t, mustGet(t, client, ts.URL+"/tim/plaatjes/-/tree/docs?rev=feature/x")) |
| 94 | for _, want := range []string{ |
| 95 | `<article class="readme">`, |
| 96 | `src="/tim/plaatjes/-/raw/assets/logo.png?rev=feature%2Fx"`, |
| 97 | `src="/tim/plaatjes/-/raw/docs/diagram.svg?rev=feature%2Fx&as=img"`, |
| 98 | } { |
| 99 | if !strings.Contains(tree, want) { |
| 100 | t.Fatalf("submap mist %s", want) |
| 101 | } |
| 102 | } |
| 103 | |
| 104 | blob := read(t, mustGet(t, client, ts.URL+"/tim/plaatjes/-/blob/docs/guide.md?rev=feature/x")) |
| 105 | for _, want := range []string{ |
| 106 | `<div class="mdbody mdfile">`, |
| 107 | `<td><img class="mdimg" src="/tim/plaatjes/-/raw/docs/diagram.svg?rev=feature%2Fx&as=img" alt="s"`, |
| 108 | `<details class="mdsource">`, |
| 109 | } { |
| 110 | if !strings.Contains(blob, want) { |
| 111 | t.Fatalf("md-bestand mist %s", want) |
| 112 | } |
| 113 | } |
| 114 | // Een gewoon bestand blijft code. |
| 115 | code := read(t, mustGet(t, client, ts.URL+"/tim/plaatjes/-/blob/docs/diagram.svg?rev=feature/x")) |
| 116 | if strings.Contains(code, "mdfile") { |
| 117 | t.Fatal("svg als markdown") |
| 118 | } |
| 119 | } |