| 1 | package server |
| 2 | |
| 3 | import ( |
| 4 | "context" |
| 5 | "io" |
| 6 | "net/http" |
| 7 | "net/url" |
| 8 | "os" |
| 9 | "os/exec" |
| 10 | "path/filepath" |
| 11 | "strings" |
| 12 | "testing" |
| 13 | |
| 14 | "gitlab.com/Timfa/bluegit/internal/access" |
| 15 | "gitlab.com/Timfa/bluegit/internal/gitrepo" |
| 16 | "gitlab.com/Timfa/bluegit/internal/store" |
| 17 | ) |
| 18 | |
| 19 | type rvActor struct { |
| 20 | name string |
| 21 | client *http.Client |
| 22 | token string |
| 23 | member bool |
| 24 | logged bool |
| 25 | } |
| 26 | |
| 27 | func noRedirect() *http.Client { |
| 28 | return &http.Client{CheckRedirect: func(*http.Request, []*http.Request) error { return http.ErrUseLastResponse }} |
| 29 | } |
| 30 | |
| 31 | func rvGet(t *testing.T, c *http.Client, u, tok string) (int, string, http.Header) { |
| 32 | t.Helper() |
| 33 | req, _ := http.NewRequest("GET", u, nil) |
| 34 | if tok != "" { |
| 35 | req.Header.Set("Authorization", "Bearer "+tok) |
| 36 | } |
| 37 | res, err := c.Do(req) |
| 38 | if err != nil { |
| 39 | t.Fatal(err) |
| 40 | } |
| 41 | defer res.Body.Close() |
| 42 | b, _ := io.ReadAll(res.Body) |
| 43 | return res.StatusCode, string(b), res.Header |
| 44 | } |
| 45 | |
| 46 | // Releasezichtbaarheid: alle drie de keuzes x beide repo-zichtbaarheden x |
| 47 | // anoniem, niet-lid, lid, groepslid, tokens met en zonder rechten. |
| 48 | func TestReleaseVisibilityMatrix(t *testing.T) { |
| 49 | e := newCIEnv(t) |
| 50 | ctx := context.Background() |
| 51 | st, base := e.st, e.ts.URL |
| 52 | tim := e.user |
| 53 | g, err := st.CreateGroup(ctx, tim.ID, "team", "team", "", access.RoleDeveloper) |
| 54 | if err != nil { |
| 55 | t.Fatal(err) |
| 56 | } |
| 57 | repo, err := st.CreateRepo(ctx, "group", g.ID, "lib", "Geheime bibliotheek.\nTweede regel met details", "master", "private") |
| 58 | if err != nil { |
| 59 | t.Fatal(err) |
| 60 | } |
| 61 | bare := gitrepo.Dir(e.srv.StoragePath(), repo.OwnerPath, repo.Name) |
| 62 | if err := gitrepo.Init("git", bare, "master", "/bin/true"); err != nil { |
| 63 | t.Fatal(err) |
| 64 | } |
| 65 | src := gitrepo.Dir(e.srv.StoragePath(), e.repo.OwnerPath, e.repo.Name) |
| 66 | if out, err := exec.Command("git", "--git-dir", src, "push", "-q", bare, "master").CombinedOutput(); err != nil { |
| 67 | t.Fatalf("push %v %s", err, out) |
| 68 | } |
| 69 | asset := filepath.Join(t.TempDir(), "app.bin") |
| 70 | _ = os.WriteFile(asset, []byte("BINARY-RELEASE"), 0o644) |
| 71 | if _, err := st.CreateRelease(ctx, repo.ID, "v1", e.sha, "Eerste", "Release-notes hier", tim.ID, 0, []store.ReleaseAsset{{Name: "app.bin", StoragePath: asset, Size: 14}}); err != nil { |
| 72 | t.Fatal(err) |
| 73 | } |
| 74 | e.srv.StateDir = t.TempDir() |
| 75 | if lp, err := e.srv.logoPath("repo", repo.ID); err == nil { |
| 76 | _ = os.MkdirAll(filepath.Dir(lp), 0o755) |
| 77 | _ = os.WriteFile(lp, []byte("\x89PNG\r\n\x1a\nlogo"), 0o644) |
| 78 | _ = st.SetLogoMIME(ctx, "repo", repo.ID, "image/png") |
| 79 | } else { |
| 80 | t.Fatal(err) |
| 81 | } |
| 82 | pid, _ := st.CreatePipeline(ctx, repo.ID, e.sha, "refs/heads/master", "push", "tim", "init", []store.NewJob{{Name: "build", Stage: "build", Script: "true"}}) |
| 83 | |
| 84 | out, _ := st.UpsertUser(ctx, 10, "outsider", "", false) |
| 85 | mem, _ := st.UpsertUser(ctx, 11, "member", "", false) |
| 86 | gm, _ := st.UpsertUser(ctx, 12, "groupie", "", false) |
| 87 | if err := st.SetMember(ctx, "repo", repo.ID, "member", access.RoleReadonly); err != nil { |
| 88 | t.Fatal(err) |
| 89 | } |
| 90 | if err := st.SetMember(ctx, "group", g.ID, "groupie", access.RoleDeveloper); err != nil { |
| 91 | t.Fatal(err) |
| 92 | } |
| 93 | sc := func(uid int64) *http.Client { |
| 94 | c, _ := sessionClient(t, st, base, uid) |
| 95 | return c |
| 96 | } |
| 97 | actors := []rvActor{ |
| 98 | {name: "anon", client: noRedirect()}, |
| 99 | {name: "outsider", client: sc(out.ID), token: issue(t, st, out.ID, "api"), logged: true}, |
| 100 | {name: "member", client: sc(mem.ID), token: issue(t, st, mem.ID, "api"), member: true, logged: true}, |
| 101 | {name: "groupie", client: sc(gm.ID), token: issue(t, st, gm.ID, "api"), member: true, logged: true}, |
| 102 | } |
| 103 | memberRunnerTok := issue(t, st, mem.ID, "runners") // token zonder lees-API-rechten |
| 104 | |
| 105 | // Warm de leescache als lid, zodat een lek via de cache zou opvallen. |
| 106 | e.srv.SetReadCache(nil) |
| 107 | |
| 108 | code := []string{"/-/tree", "/-/blob/README.md", "/-/commits", "/-/branches", "/-/tags", "/-/issues", "/-/merge-requests", |
| 109 | "/-/pipelines", "/-/pipelines/" + itoa(pid), "/-/archive/master/lib-master.zip", "/-/archive/master/lib-master.tar.gz", |
| 110 | "/-/tags/archive?tag=v1&format=zip", "/-/branches/archive?branch=master&format=tar.gz", "/-/commit/" + e.sha, "/-/settings"} |
| 111 | apiCode := []string{"", "/repository/tree", "/repository/commits", "/repository/files/README.md/raw?ref=master", "/pipelines", "/issues", |
| 112 | "/repository/tags/v1/archive"} |
| 113 | |
| 114 | for _, rv := range []string{"private", "public"} { |
| 115 | for _, relv := range []string{"inherit", "private", "public"} { |
| 116 | if err := st.UpdateRepo(ctx, repo.ID, repo.Description, rv); err != nil { |
| 117 | t.Fatal(err) |
| 118 | } |
| 119 | if err := st.SetReleaseVisibility(ctx, repo.ID, relv); err != nil { |
| 120 | t.Fatal(err) |
| 121 | } |
| 122 | relPublic := relv == "public" || (relv == "inherit" && rv == "public") |
| 123 | label := "repo=" + rv + " releases=" + relv |
| 124 | for _, a := range actors { |
| 125 | canRel := a.member || relPublic |
| 126 | canCode := a.member || rv == "public" |
| 127 | // Releases-pagina en asset (web, ook zoals een PKGBUILD ze haalt). |
| 128 | c, body, _ := rvGet(t, a.client, base+"/team/lib/-/releases", "") |
| 129 | if canRel != (c == 200) { |
| 130 | t.Errorf("%s %s releases-pagina: %d", label, a.name, c) |
| 131 | } |
| 132 | if c == 200 && !strings.Contains(body, "Release-notes hier") { |
| 133 | t.Errorf("%s %s mist notities", label, a.name) |
| 134 | } |
| 135 | if c == 200 && !canCode { |
| 136 | for _, bad := range []string{"/team/lib/-/tree", "/team/lib/-/pipelines", "/team/lib/-/commits", "/-/archive/", e.sha[:8], "Tweede regel", "lib.git"} { |
| 137 | if strings.Contains(body, bad) { |
| 138 | t.Errorf("%s %s releases-pagina lekt %q", label, a.name, bad) |
| 139 | } |
| 140 | } |
| 141 | } |
| 142 | c, body, _ = rvGet(t, a.client, base+"/team/lib/-/releases/v1/assets/app.bin", "") |
| 143 | if canRel != (c == 200 && body == "BINARY-RELEASE") { |
| 144 | t.Errorf("%s %s asset: %d", label, a.name, c) |
| 145 | } |
| 146 | // Release-API, anoniem of met token. |
| 147 | c, body, _ = rvGet(t, http.DefaultClient, base+"/api/v1/projects/team/lib/releases", a.token) |
| 148 | if canRel != (c == 200) { |
| 149 | t.Errorf("%s %s api releases: %d %s", label, a.name, c, body) |
| 150 | } |
| 151 | if c == 200 && !canCode && (strings.Contains(body, e.sha) || strings.Contains(body, "archive")) { |
| 152 | t.Errorf("%s %s api lekt commit/archief: %s", label, a.name, body) |
| 153 | } |
| 154 | c, body, _ = rvGet(t, http.DefaultClient, base+"/api/v1/projects/team/lib/releases/v1/assets/app.bin", a.token) |
| 155 | if canRel != (c == 200 && body == "BINARY-RELEASE") { |
| 156 | t.Errorf("%s %s api asset: %d", label, a.name, c) |
| 157 | } |
| 158 | // Code, archieven, pipelines, instellingen: nooit via releases. |
| 159 | for _, p := range code { |
| 160 | c, _, _ := rvGet(t, a.client, base+"/team/lib"+p, "") |
| 161 | if !canCode && c < 400 { |
| 162 | t.Errorf("%s %s ziet %s: %d", label, a.name, p, c) |
| 163 | } |
| 164 | } |
| 165 | for _, p := range apiCode { |
| 166 | c, _, _ := rvGet(t, http.DefaultClient, base+"/api/v1/projects/team/lib"+p, a.token) |
| 167 | if !canCode && c < 400 { |
| 168 | t.Errorf("%s %s api ziet %s: %d", label, a.name, p, c) |
| 169 | } |
| 170 | } |
| 171 | c, _, _ = rvGet(t, http.DefaultClient, base+"/team/lib.git/info/refs?service=git-upload-pack", a.token) |
| 172 | if !canCode && c < 400 { |
| 173 | t.Errorf("%s %s git clone: %d", label, a.name, c) |
| 174 | } |
| 175 | if a.member && c != 200 { |
| 176 | t.Errorf("%s %s lid kan niet clonen: %d", label, a.name, c) |
| 177 | } |
| 178 | // Projectpagina: release-only gaat naar Releases. |
| 179 | c, _, h := rvGet(t, a.client, base+"/team/lib", "") |
| 180 | if !canCode && relPublic { |
| 181 | if c != http.StatusSeeOther || h.Get("Location") != "/team/lib/-/releases" { |
| 182 | t.Errorf("%s %s projectpagina: %d %s", label, a.name, c, h.Get("Location")) |
| 183 | } |
| 184 | } else if canCode && c != 200 { |
| 185 | t.Errorf("%s %s projectpagina: %d", label, a.name, c) |
| 186 | } |
| 187 | // Varianten van de projectroot (t695u): /, /- en /-/. |
| 188 | for _, suf := range []string{"/", "/-", "/-/"} { |
| 189 | c, _, h := rvGet(t, a.client, base+"/team/lib"+suf, "") |
| 190 | loc := h.Get("Location") |
| 191 | switch { |
| 192 | case !canCode && relPublic: |
| 193 | if c != http.StatusSeeOther || loc != "/team/lib/-/releases" { |
| 194 | t.Errorf("%s %s %s: %d %s", label, a.name, suf, c, loc) |
| 195 | } |
| 196 | case canCode: |
| 197 | if c != http.StatusSeeOther || loc != "/team/lib" { |
| 198 | t.Errorf("%s %s %s: %d %s", label, a.name, suf, c, loc) |
| 199 | } |
| 200 | default: |
| 201 | if c < 400 { |
| 202 | t.Errorf("%s %s %s lekt: %d %s", label, a.name, suf, c, loc) |
| 203 | } |
| 204 | } |
| 205 | } |
| 206 | // /-/releases/ met slash gedraagt zich als zonder. |
| 207 | c, _, h = rvGet(t, a.client, base+"/team/lib/-/releases/", "") |
| 208 | if canRel && (c != http.StatusSeeOther || h.Get("Location") != "/team/lib/-/releases") || !canRel && c < 400 { |
| 209 | t.Errorf("%s %s releases/: %d %s", label, a.name, c, h.Get("Location")) |
| 210 | } |
| 211 | // HEAD (curl -I) gedraagt zich als GET op de projectroot. |
| 212 | for _, suf := range []string{"", "/", "/-"} { |
| 213 | req, _ := http.NewRequest(http.MethodHead, base+"/team/lib"+suf, nil) |
| 214 | if res, err := a.client.Do(req); err == nil { |
| 215 | res.Body.Close() |
| 216 | if !canCode && relPublic && (res.StatusCode != http.StatusSeeOther || res.Header.Get("Location") != "/team/lib/-/releases") { |
| 217 | t.Errorf("%s %s HEAD %s: %d", label, a.name, suf, res.StatusCode) |
| 218 | } |
| 219 | } |
| 220 | } |
| 221 | // Repo-logo volgt de Releases-regel (t701u). |
| 222 | c, _, _ = rvGet(t, a.client, base+"/team/lib/-/logo", "") |
| 223 | if seeLogo := canRel || canCode; seeLogo && c != 200 || !seeLogo && c < 400 { |
| 224 | t.Errorf("%s %s logo: %d", label, a.name, c) |
| 225 | } |
| 226 | // Niet-bestaand blijft 404; open redirect via dubbele slash kan niet. |
| 227 | for _, p := range []string{"/team/nope", "/team/nope/", "/team/nope/-", "//evil.example/x/-"} { |
| 228 | if c, _, h := rvGet(t, a.client, base+p, ""); c != 404 && !strings.HasPrefix(h.Get("Location"), "/") || strings.HasPrefix(h.Get("Location"), "//") { |
| 229 | t.Errorf("%s %s %s: %d %s", label, a.name, p, c, h.Get("Location")) |
| 230 | } |
| 231 | } |
| 232 | // Lid: tabbladen; publieke code met privé releases: geen Releases-tab. |
| 233 | if canCode { |
| 234 | _, body, _ := rvGet(t, a.client, base+"/team/lib/-/tree", "") |
| 235 | if has := strings.Contains(body, `href="/team/lib/-/releases"`); has != canRel { |
| 236 | t.Errorf("%s %s releases-tab zichtbaar=%v", label, a.name, has) |
| 237 | } |
| 238 | } |
| 239 | } |
| 240 | // Token zonder lees-API-rechten krijgt geen privé releases. |
| 241 | if !relPublic { |
| 242 | if c, _, _ := rvGet(t, http.DefaultClient, base+"/api/v1/projects/team/lib/releases", memberRunnerTok); c == 200 { |
| 243 | t.Errorf("%s runners-token leest releases", label) |
| 244 | } |
| 245 | } |
| 246 | // Verkennen: alleen naam en korte beschrijving. |
| 247 | _, home, _ := rvGet(t, noRedirect(), base+"/", "") |
| 248 | listed := strings.Contains(home, `href="/team/lib/-/releases"`) |
| 249 | if listed != (rv == "private" && relv == "public") { |
| 250 | t.Errorf("%s verkennen toont release-only=%v", label, listed) |
| 251 | } |
| 252 | if listed && (strings.Contains(home, "Tweede regel") || !strings.Contains(home, "Geheime bibliotheek.")) { |
| 253 | t.Errorf("%s verkennen beschrijving fout", label) |
| 254 | } |
| 255 | } |
| 256 | } |
| 257 | } |
| 258 | |
| 259 | // Instelling via UI en API; alleen beheerders; ongeldige waarde geweigerd; |
| 260 | // ontbrekende velden blijven ongewijzigd. |
| 261 | func TestReleaseVisibilitySetting(t *testing.T) { |
| 262 | e := newCIEnv(t) |
| 263 | ctx := context.Background() |
| 264 | st, base := e.st, e.ts.URL |
| 265 | tc, csrf := sessionClient(t, st, base, e.user.ID) |
| 266 | _, page, _ := rvGet(t, tc, base+"/tim/app/-/settings", "") |
| 267 | if !strings.Contains(page, `name="release_visibility"`) || !strings.Contains(page, `tip "`) && !strings.Contains(page, `class="tip"`) { |
| 268 | t.Fatalf("instelling of tooltip ontbreekt") |
| 269 | } |
| 270 | res, err := tc.PostForm(base+"/tim/app/-/settings", url.Values{"csrf": {csrf}, "description": {"d"}, "visibility": {"private"}, "release_visibility": {"public"}}) |
| 271 | if err != nil { |
| 272 | t.Fatal(err) |
| 273 | } |
| 274 | res.Body.Close() |
| 275 | if r, _ := st.RepoByID(ctx, e.repo.ID); r.ReleaseVisibility != "public" || r.Visibility != "private" { |
| 276 | t.Fatalf("ui opslaan: %+v", r) |
| 277 | } |
| 278 | tok := issue(t, st, e.user.ID, "api") |
| 279 | c, b := rapi(t, base, tok, "PUT", "/projects/tim/app", map[string]any{"release_visibility": "private"}) |
| 280 | if c != 200 || !strings.Contains(string(b), `"release_visibility":"private"`) || !strings.Contains(string(b), `"visibility":"private"`) || !strings.Contains(string(b), `"description":"d"`) { |
| 281 | t.Fatalf("api %d %s", c, b) |
| 282 | } |
| 283 | if c, _ := rapi(t, base, tok, "PUT", "/projects/tim/app", map[string]any{"release_visibility": "wereld"}); c != 400 { |
| 284 | t.Fatalf("ongeldig %d", c) |
| 285 | } |
| 286 | bob, _ := st.UpsertUser(ctx, 5, "bob", "", false) |
| 287 | _ = st.SetMember(ctx, "repo", e.repo.ID, "bob", access.RoleDeveloper) |
| 288 | if c, _ := rapi(t, base, issue(t, st, bob.ID, "api"), "PUT", "/projects/tim/app", map[string]any{"release_visibility": "public"}); c != 403 { |
| 289 | t.Fatalf("developer mag zetten: %d", c) |
| 290 | } |
| 291 | if r, _ := st.RepoByID(ctx, e.repo.ID); r.ReleaseVisibility != "private" { |
| 292 | t.Fatalf("na weigering: %s", r.ReleaseVisibility) |
| 293 | } |
| 294 | } |
| 295 | |
| 296 | // De sociale kaart van een release-only repo leest nooit code. |
| 297 | func TestReleaseOnlyCard(t *testing.T) { |
| 298 | e := newCIEnv(t) |
| 299 | ctx := context.Background() |
| 300 | _ = e.st.SetReleaseVisibility(ctx, e.repo.ID, "public") |
| 301 | r := e.srv.cardForPath(ctx, "/tim/app/-/releases", "", "") |
| 302 | if r.Meta.Kind != "release" || strings.Contains(r.Meta.Description+strings.Join(r.Meta.Facts, " "), "hello from the repo") { |
| 303 | t.Fatalf("kaart: %+v", r.Meta) |
| 304 | } |
| 305 | if r := e.srv.cardForPath(ctx, "/tim/app/-/tree", "", ""); r.Meta.Kind == "repo" { |
| 306 | t.Fatalf("code-kaart voor release-only: %+v", r.Meta) |
| 307 | } |
| 308 | } |