BlueGit

timfa bluegit

Files

bluegit / internal / server / repo_handlers.go

repo_handlers.go

repo_handlers.go 17.3 KiB Download Raw
1package server
2
3import (
4 "net/http"
5 "strconv"
6 "strings"
7
8 "gitlab.com/Timfa/bluegit/internal/access"
9 "gitlab.com/Timfa/bluegit/internal/gitrepo"
10 "gitlab.com/Timfa/bluegit/internal/i18n"
11 "gitlab.com/Timfa/bluegit/internal/names"
12 "gitlab.com/Timfa/bluegit/internal/store"
13)
14
15func (s *Server) guard(w http.ResponseWriter, r *http.Request, min access.Role) (store.User, store.Repo, access.Role, bool) {
16 owner := r.PathValue("owner")
17 name := strings.TrimSuffix(r.PathValue("repo"), ".git")
18 repo, err := s.Store.RepoByPath(r.Context(), owner, name)
19 if err != nil {
20 http.NotFound(w, r)
21 return store.User{}, store.Repo{}, "", false
22 }
23 p := s.who(r)
24 var role access.Role
25 if p.OK {
26 role, err = s.Store.EffectiveRole(r.Context(), p.User.ID, repo.ID)
27 if err != nil {
28 http.Error(w, s.tr(r, "err.rights"), http.StatusInternalServerError)
29 return store.User{}, store.Repo{}, "", false
30 }
31 }
32 readable := role.CanRead() || repo.Visibility == "public"
33 if !readable {
34 if p.OK {
35 http.Error(w, s.tr(r, "err.forbidden"), http.StatusForbidden)
36 } else {
37 http.NotFound(w, r)
38 }
39 return store.User{}, store.Repo{}, "", false
40 }
41 if min != access.RoleReadonly && !role.AtLeast(min) {
42 http.Error(w, s.tr(r, "err.forbidden"), http.StatusForbidden)
43 return store.User{}, store.Repo{}, "", false
44 }
45 return p.User, repo, role, true
46}
47
48func (s *Server) repoView(w http.ResponseWriter, r *http.Request, repo store.Repo, role access.Role, title string) View {
49 v := s.view(w, r, title)
50 v.Repo = &repo
51 v.Role = role
52 v.CanWrite = role.CanWriteCode()
53 v.CanAdmin = role.CanManageSettings()
54 v.Rev = safeRev(r.URL.Query().Get("rev"), repo.DefaultBranch)
55 v.CloneHTTP = strings.TrimRight(s.Cfg.BaseURL, "/") + "/" + repo.FullPath() + ".git"
56 v.CloneSSH = s.Cfg.CloneSSH(repo.FullPath())
57 return v
58}
59
60func (s *Server) repoHome(w http.ResponseWriter, r *http.Request) {
61 _, repo, role, ok := s.guard(w, r, access.RoleReadonly)
62 if !ok {
63 return
64 }
65 v := s.repoView(w, r, repo, role, repo.Name)
66 v.Wide = true
67 s.fillOverview(r, &v, repo)
68 v.Heat = s.heatmap(r.Context(), 0, []int64{repo.ID}, s.langOf(r))
69 s.render(w, "repo", v)
70}
71
72func (s *Server) treeRoot(w http.ResponseWriter, r *http.Request) {
73 r.SetPathValue("path", "")
74 s.tree(w, r)
75}
76
77func (s *Server) tree(w http.ResponseWriter, r *http.Request) {
78 _, repo, role, ok := s.guard(w, r, access.RoleReadonly)
79 if !ok {
80 return
81 }
82 rel, err := cleanRel(r.PathValue("path"))
83 if err != nil {
84 http.NotFound(w, r)
85 return
86 }
87 v := s.repoView(w, r, repo, role, rel)
88 v.Wide = true
89 dir := gitrepo.Dir(s.StoragePath(), repo.OwnerPath, repo.Name)
90 if _, err := gitrepo.Tree(r.Context(), s.Git, dir, v.Rev, rel); err != nil && rel != "" {
91 http.NotFound(w, r)
92 return
93 }
94 s.fillFiles(r, &v, repo, rel, false)
95 s.render(w, "files", v)
96}
97
98func (s *Server) blob(w http.ResponseWriter, r *http.Request) {
99 _, repo, role, ok := s.guard(w, r, access.RoleReadonly)
100 if !ok {
101 return
102 }
103 rel, err := cleanRel(r.PathValue("path"))
104 if err != nil || rel == "" {
105 http.NotFound(w, r)
106 return
107 }
108 v := s.repoView(w, r, repo, role, rel)
109 v.Wide = true
110 dir := gitrepo.Dir(s.StoragePath(), repo.OwnerPath, repo.Name)
111 if _, _, err := gitrepo.Blob(r.Context(), s.Git, dir, v.Rev, rel, 1); err != nil {
112 http.NotFound(w, r)
113 return
114 }
115 s.fillFiles(r, &v, repo, rel, true)
116 s.render(w, "files", v)
117}
118
119func (s *Server) commits(w http.ResponseWriter, r *http.Request) {
120 _, repo, role, ok := s.guard(w, r, access.RoleReadonly)
121 if !ok {
122 return
123 }
124 v := s.repoView(w, r, repo, role, "title.commits")
125 v.Page = "commits"
126 dir := gitrepo.Dir(s.StoragePath(), repo.OwnerPath, repo.Name)
127 list, _ := gitrepo.Log(r.Context(), s.Git, dir, v.Rev, 50)
128 v.Commits = s.presentCommits(r.Context(), repo.ID, list, i18n.Parse(v.Lang))
129 s.render(w, "commits", v)
130}
131
132func (s *Server) commit(w http.ResponseWriter, r *http.Request) {
133 _, repo, role, ok := s.guard(w, r, access.RoleReadonly)
134 if !ok {
135 return
136 }
137 sha := r.PathValue("sha")
138 if !safeSHA(sha) {
139 http.NotFound(w, r)
140 return
141 }
142 dir := gitrepo.Dir(s.StoragePath(), repo.OwnerPath, repo.Name)
143 c, err := gitrepo.Show(r.Context(), s.Git, dir, sha)
144 if err != nil {
145 http.NotFound(w, r)
146 return
147 }
148 v := s.repoView(w, r, repo, role, c.Subject)
149 v.Page = "commit"
150 rows := s.presentCommits(r.Context(), repo.ID, []gitrepo.Commit{c}, i18n.Parse(v.Lang))
151 v.Commit = &rows[0]
152 s.render(w, "commit", v)
153}
154
155func (s *Server) branches(w http.ResponseWriter, r *http.Request) {
156 _, repo, role, ok := s.guard(w, r, access.RoleReadonly)
157 if !ok {
158 return
159 }
160 v := s.repoView(w, r, repo, role, "title.branches")
161 v.Page = "branches"
162 dir := gitrepo.Dir(s.StoragePath(), repo.OwnerPath, repo.Name)
163 names, _ := gitrepo.Branches(r.Context(), s.Git, dir)
164 patterns, _ := s.Store.ProtectedPatterns(r.Context(), repo.ID)
165 for _, name := range names {
166 v.Branches = append(v.Branches, BranchRow{Name: name, Protected: access.BranchProtected(patterns, name)})
167 }
168 s.render(w, "branches", v)
169}
170
171func (s *Server) mergeRequests(w http.ResponseWriter, r *http.Request) {
172 _, repo, role, ok := s.guard(w, r, access.RoleReadonly)
173 if !ok {
174 return
175 }
176 v := s.repoView(w, r, repo, role, "title.mrs")
177 v.Page = "mrs"
178 v.MRs, _ = s.Store.ListMergeRequests(r.Context(), repo.ID)
179 dir := gitrepo.Dir(s.StoragePath(), repo.OwnerPath, repo.Name)
180 names, _ := gitrepo.Branches(r.Context(), s.Git, dir)
181 for _, name := range names {
182 v.Branches = append(v.Branches, BranchRow{Name: name})
183 }
184 s.render(w, "mrs", v)
185}
186
187func (s *Server) createMR(w http.ResponseWriter, r *http.Request) {
188 u, repo, role, ok := s.guard(w, r, access.RoleDeveloper)
189 if !ok || !s.csrfOK(w, r) {
190 return
191 }
192 if !role.CanWriteCode() {
193 http.Error(w, s.tr(r, "err.forbidden"), http.StatusForbidden)
194 return
195 }
196 source := safeRev(r.FormValue("source"), "")
197 target := safeRev(r.FormValue("target"), repo.DefaultBranch)
198 if source == "" || source == target {
199 s.redirect(w, r, repoURL(repo)+"/-/merge-requests", "", s.tr(r, "err.branches"))
200 return
201 }
202 mr, err := s.Store.CreateMergeRequest(r.Context(), repo.ID, u.ID, r.FormValue("title"), r.FormValue("description"), source, target)
203 if err != nil {
204 s.redirect(w, r, repoURL(repo)+"/-/merge-requests", "", s.trErr(r, err))
205 return
206 }
207 num := strconv.FormatInt(mr.Number, 10)
208 dir := gitrepo.Dir(s.StoragePath(), repo.OwnerPath, repo.Name)
209 if sha := gitOne(r.Context(), s.Git, dir, "rev-parse", "--verify", "refs/heads/"+source); sha != "" {
210 s.startOneMergePipeline(r.Context(), repo, sha, u.Username, "", mr)
211 }
212 s.Dispatch(repo.ID, pushEvent(repo, "merge_request", target, "", u.Username, s.tr(r, "hook.mr", num, mr.Title), repoURL(repo)+"/-/merge-requests/"+num))
213 s.recordContribution(u.ID, repo.ID, "merge_request", mrRef(mr.ID), mr.CreatedAt)
214 s.redirect(w, r, repoURL(repo)+"/-/merge-requests/"+num, s.tr(r, "flash.mrOpened"), "")
215}
216
217func (s *Server) showMR(w http.ResponseWriter, r *http.Request) {
218 u, repo, role, ok := s.guard(w, r, access.RoleReadonly)
219 if !ok {
220 return
221 }
222 n, err := strconv.ParseInt(r.PathValue("number"), 10, 64)
223 if err != nil {
224 http.NotFound(w, r)
225 return
226 }
227 mr, err := s.Store.MergeRequestByNumber(r.Context(), repo.ID, n)
228 if err != nil {
229 http.NotFound(w, r)
230 return
231 }
232 v := s.repoView(w, r, repo, role, mr.Title)
233 v.Page = "mr"
234 v.MR = &mr
235 v.Wide = true
236 patterns, _ := s.Store.ProtectedPatterns(r.Context(), repo.ID)
237 v.CanComment = role.AtLeast(access.RoleReadonly)
238 v.CanMerge = mr.Status == "open" && role.CanMerge(access.BranchProtected(patterns, mr.TargetBranch))
239 v.CanApply = mr.Status == "open" && role.CanPushBranch(access.BranchProtected(patterns, mr.SourceBranch))
240 v.MergeBlocks = s.mergeBlocks(r, repo, mr)
241 s.fillMRPipeline(r, &v, repo, mr)
242 s.fillReviews(r, &v, repo, mr, role)
243 if u.ID != 0 {
244 mine := u.ID == mr.AuthorID || role.CanManageSettings()
245 v.CanClose = mr.Status == "open" && mine
246 v.CanReopen = mr.Status == "closed" && mine
247 }
248 dir := gitrepo.Dir(s.StoragePath(), repo.OwnerPath, repo.Name)
249 diff, err := gitrepo.DiffStat(r.Context(), s.Git, dir, mr.TargetBranch, mr.SourceBranch)
250 if err == nil {
251 v.Diff = diff
252 }
253 files, _ := gitrepo.DiffFiles(r.Context(), s.Git, dir, mr.TargetBranch, mr.SourceBranch)
254 notes, _ := s.Store.ListNotes(r.Context(), mr.ID)
255 v.Notes, v.DiffFiles = arrangeNotes(notes, files, s.langOf(r))
256 s.render(w, "mr", v)
257}
258
259func (s *Server) createNote(w http.ResponseWriter, r *http.Request) {
260 u, repo, role, ok := s.guard(w, r, access.RoleReadonly)
261 if !ok || !s.csrfOK(w, r) {
262 return
263 }
264 if u.ID == 0 || !role.AtLeast(access.RoleReadonly) {
265 http.Error(w, s.tr(r, "err.forbidden"), http.StatusForbidden)
266 return
267 }
268 mr, err := s.mrFromRequest(r, repo.ID)
269 if err != nil {
270 http.NotFound(w, r)
271 return
272 }
273 back := repoURL(repo) + "/-/merge-requests/" + strconv.FormatInt(mr.Number, 10)
274 path, pathOK := repoPath(r.FormValue("path"))
275 if !pathOK {
276 s.redirect(w, r, back, "", s.tr(r, "err.sugFile"))
277 return
278 }
279 if path == "" {
280 if _, err := s.Store.AddNote(r.Context(), repo.ID, mr.ID, u.ID, r.FormValue("body")); err != nil {
281 s.redirect(w, r, back, "", s.trErr(r, err))
282 return
283 }
284 s.redirect(w, r, back, s.tr(r, "flash.note"), "")
285 return
286 }
287 start, _ := strconv.Atoi(r.FormValue("line_start"))
288 end, _ := strconv.Atoi(r.FormValue("line_end"))
289 dir := gitrepo.Dir(s.StoragePath(), repo.OwnerPath, repo.Name)
290 blob, err := gitrepo.BlobText(r.Context(), s.Git, dir, mr.SourceBranch, path)
291 if err != nil {
292 s.redirect(w, r, back, "", s.tr(r, "err.sugFile"))
293 return
294 }
295 lines := gitrepo.SplitLines(blob)
296 if start < 1 || end < start || end > len(lines) {
297 s.redirect(w, r, back, "", s.tr(r, "err.sugLines"))
298 return
299 }
300 base := strings.Join(lines[start-1:end], "\n")
301 suggestion, _ := gitrepo.ParseSuggestion(r.FormValue("body"))
302 if _, err := s.Store.AddLineNote(r.Context(), repo.ID, mr.ID, u.ID, r.FormValue("body"), path, start, end, suggestion, base); err != nil {
303 s.redirect(w, r, back, "", s.trErr(r, err))
304 return
305 }
306 s.noteRequestsChanges(r, repo, mr, u.ID, suggestion)
307 s.redirect(w, r, back, s.tr(r, "flash.note"), "")
308}
309
310func (s *Server) mergeMR(w http.ResponseWriter, r *http.Request) {
311 u, repo, role, ok := s.guard(w, r, access.RoleDeveloper)
312 if !ok || !s.csrfOK(w, r) {
313 return
314 }
315 mr, err := s.mrFromRequest(r, repo.ID)
316 if err != nil || mr.Status != "open" {
317 http.NotFound(w, r)
318 return
319 }
320 patterns, _ := s.Store.ProtectedPatterns(r.Context(), repo.ID)
321 if !role.CanMerge(access.BranchProtected(patterns, mr.TargetBranch)) {
322 http.Error(w, s.tr(r, "err.targetAccess"), http.StatusForbidden)
323 return
324 }
325 if blocks := s.mergeBlocks(r, repo, mr); len(blocks) > 0 {
326 s.redirect(w, r, repoURL(repo)+"/-/merge-requests/"+strconv.FormatInt(mr.Number, 10), "", blocks[0])
327 return
328 }
329 dir := gitrepo.Dir(s.StoragePath(), repo.OwnerPath, repo.Name)
330 before, _ := gitrepo.Refs(r.Context(), s.Git, dir)
331 work := s.StoragePath() + "/tmp/merge-" + strconv.FormatInt(mr.ID, 10)
332 email := u.Username + "@users.git.timfalken.com"
333 msg := "Merge branch '" + mr.SourceBranch + "' into '" + mr.TargetBranch + "'"
334 if err := gitrepo.Merge(r.Context(), s.Git, dir, work, mr.SourceBranch, mr.TargetBranch, u.Username, email, msg, role, patterns); err != nil {
335 s.redirect(w, r, repoURL(repo)+"/-/merge-requests/"+strconv.FormatInt(mr.Number, 10), "", s.trErr(r, err))
336 return
337 }
338 _ = s.Store.SetMergeRequestStatus(r.Context(), mr.ID, "merged")
339 after, _ := gitrepo.Refs(r.Context(), s.Git, dir)
340 s.AfterPush(repo, u, before, after)
341 s.redirect(w, r, repoURL(repo)+"/-/merge-requests/"+strconv.FormatInt(mr.Number, 10), s.tr(r, "flash.merged"), "")
342}
343
344func (s *Server) closeMR(w http.ResponseWriter, r *http.Request) {
345 u, repo, role, ok := s.guard(w, r, access.RoleReadonly)
346 if !ok || !s.csrfOK(w, r) {
347 return
348 }
349 mr, err := s.mrFromRequest(r, repo.ID)
350 if err != nil {
351 http.NotFound(w, r)
352 return
353 }
354 if mr.AuthorID != u.ID && !role.CanManageSettings() {
355 http.Error(w, s.tr(r, "err.forbidden"), http.StatusForbidden)
356 return
357 }
358 _ = s.Store.SetMergeRequestStatus(r.Context(), mr.ID, "closed")
359 s.redirect(w, r, repoURL(repo)+"/-/merge-requests/"+strconv.FormatInt(mr.Number, 10), s.tr(r, "flash.closed"), "")
360}
361
362func (s *Server) mrFromRequest(r *http.Request, repoID int64) (store.MergeRequest, error) {
363 n, err := strconv.ParseInt(r.PathValue("number"), 10, 64)
364 if err != nil {
365 return store.MergeRequest{}, err
366 }
367 return s.Store.MergeRequestByNumber(r.Context(), repoID, n)
368}
369
370func (s *Server) pipelines(w http.ResponseWriter, r *http.Request) {
371 _, repo, role, ok := s.guard(w, r, access.RoleReadonly)
372 if !ok {
373 return
374 }
375 if id := strings.TrimSpace(r.URL.Query().Get("show")); id != "" {
376 if n, err := strconv.ParseInt(id, 10, 64); err == nil && n > 0 {
377 http.Redirect(w, r, repoURL(repo)+"/-/pipelines/"+id, http.StatusSeeOther)
378 return
379 }
380 }
381 v := s.repoView(w, r, repo, role, "title.pipelines")
382 v.Wide = true
383 v.Page = "pipelines"
384 s.fillPipelines(r, &v, repo)
385 s.render(w, "pipelines", v)
386}
387
388func (s *Server) pipeline(w http.ResponseWriter, r *http.Request) {
389 _, repo, role, ok := s.guard(w, r, access.RoleReadonly)
390 if !ok {
391 return
392 }
393 id, err := strconv.ParseInt(r.PathValue("id"), 10, 64)
394 if err != nil {
395 http.NotFound(w, r)
396 return
397 }
398 p, err := s.Store.PipelineByID(r.Context(), repo.ID, id)
399 if err != nil {
400 http.NotFound(w, r)
401 return
402 }
403 v := s.repoView(w, r, repo, role, "title.pipeline")
404 v.Wide = true
405 v.Page = "pipelines"
406 v.Pipe = &p
407 v.Jobs, _ = s.Store.JobsByPipeline(r.Context(), p.ID)
408 s.render(w, "pipeline", v)
409}
410
411func (s *Server) runPipeline(w http.ResponseWriter, r *http.Request) {
412 u, repo, _, ok := s.guard(w, r, access.RoleDeveloper)
413 if !ok || !s.csrfOK(w, r) {
414 return
415 }
416 ref := safeRev(r.FormValue("ref"), repo.DefaultBranch)
417 dir := gitrepo.Dir(s.StoragePath(), repo.OwnerPath, repo.Name)
418 shaOut, err := gitSHA(r, s.Git, dir, ref)
419 if err != nil {
420 s.redirect(w, r, repoURL(repo)+"/-/pipelines", "", s.tr(r, "err.branchMissing"))
421 return
422 }
423 s.startPipeline(r.Context(), repo, shaOut, "refs/heads/"+ref, u.Username, "web", "", nil)
424 s.redirect(w, r, repoURL(repo)+"/-/pipelines", s.tr(r, "flash.pipeline"), "")
425}
426
427func (s *Server) releases(w http.ResponseWriter, r *http.Request) {
428 _, repo, role, ok := s.guard(w, r, access.RoleReadonly)
429 if !ok {
430 return
431 }
432 v := s.repoView(w, r, repo, role, "title.releases")
433 v.Page = "releases"
434 v.Wide = true
435 v.Releases, _ = s.Store.ListReleases(r.Context(), repo.ID)
436 s.render(w, "releases", v)
437}
438
439func (s *Server) createRepo(w http.ResponseWriter, r *http.Request) {
440 u, ok := s.loginRequired(w, r)
441 if !ok || !s.csrfOK(w, r) {
442 return
443 }
444 if s.StoragePath() == "" {
445 msg := s.tr(r, "err.noStorage")
446 if wantsModal(r) {
447 writeModal(w, false, "", msg, http.StatusBadRequest)
448 return
449 }
450 s.redirect(w, r, "/", "", msg)
451 return
452 }
453 name, err := names.Slug("repo", r.FormValue("name"))
454 if err != nil {
455 s.failCreate(w, r, s.tr(r, "slug.bad"))
456 return
457 }
458 ownerKind := "user"
459 ownerID := u.ID
460 if gpath := strings.TrimSpace(r.FormValue("group")); gpath != "" {
461 g, err := s.Store.GroupByPath(r.Context(), gpath)
462 if err != nil {
463 s.failCreate(w, r, s.tr(r, "err.groupMissing"))
464 return
465 }
466 role, err := s.Store.GroupRole(r.Context(), g.ID, u.ID)
467 if err != nil || !role.CanManageSettings() {
468 http.Error(w, s.tr(r, "err.forbidden"), http.StatusForbidden)
469 return
470 }
471 ownerKind, ownerID = "group", g.ID
472 }
473 vis := r.FormValue("visibility")
474 if vis != "public" {
475 vis = "private"
476 }
477 repo, err := s.Store.CreateRepo(r.Context(), ownerKind, ownerID, name, r.FormValue("description"), s.Cfg.Git.DefaultBranch, vis)
478 if err != nil {
479 s.failCreate(w, r, s.trErr(r, err))
480 return
481 }
482 dir := gitrepo.Dir(s.StoragePath(), repo.OwnerPath, repo.Name)
483 if err := gitrepo.Init(s.Git, dir, repo.DefaultBranch, s.HookBin); err != nil {
484 _ = s.Store.DeleteRepo(r.Context(), repo.ID)
485 s.failCreate(w, r, s.tr(r, "err.gitInit", err.Error()))
486 return
487 }
488 s.finishCreate(w, r, repoURL(repo), s.tr(r, "flash.repoCreated"))
489}
490
491func (s *Server) createGroup(w http.ResponseWriter, r *http.Request) {
492 u, ok := s.loginRequired(w, r)
493 if !ok || !s.csrfOK(w, r) {
494 return
495 }
496 display := strings.TrimSpace(r.FormValue("name"))
497 path, err := names.Slug("group", display)
498 if err != nil {
499 s.failCreate(w, r, s.tr(r, "slug.bad"))
500 return
501 }
502 role := access.Role("")
503 if raw := strings.TrimSpace(r.FormValue("default_role")); raw != "" {
504 role, err = access.ParseRole(raw)
505 if err != nil {
506 s.failCreate(w, r, s.trErr(r, err))
507 return
508 }
509 }
510 g, err := s.Store.CreateGroup(r.Context(), u.ID, display, path, r.FormValue("description"), role)
511 if err != nil {
512 s.failCreate(w, r, s.trErr(r, err))
513 return
514 }
515 s.finishCreate(w, r, "/groups/"+g.Path, s.tr(r, "flash.groupCreated"))
516}
517
518func toEntries(base string, in []gitrepo.Entry) []EntryRow {
519 var out []EntryRow
520 for _, e := range in {
521 p := e.Name
522 if base != "" {
523 p = base + "/" + e.Name
524 }
525 out = append(out, EntryRow{Name: e.Name, Type: e.Type, Path: p})
526 }
527 return out
528}
529
530func cleanRel(p string) (string, error) {
531 p = strings.TrimPrefix(p, "/")
532 if p == "" || p == "." {
533 return "", nil
534 }
535 if strings.HasPrefix(p, "/") || strings.Contains(p, "\\") || strings.Contains(p, "..") {
536 return "", errBadID
537 }
538 return p, nil
539}
540
541func safeRev(s, fallback string) string {
542 if s == "" {
543 return fallback
544 }
545 if strings.HasPrefix(s, "-") || strings.Contains(s, "..") || strings.ContainsAny(s, " \t\n~^:?*[\\") {
546 return fallback
547 }
548 return s
549}
550
551func safeSHA(s string) bool {
552 if len(s) < 7 || len(s) > 64 {
553 return false
554 }
555 for _, c := range s {
556 if (c < '0' || c > '9') && (c < 'a' || c > 'f') && (c < 'A' || c > 'F') {
557 return false
558 }
559 }
560 return true
561}