BlueGit

timfa bluegit

Files

bluegit / internal / server / reviews_test.go

reviews_test.go

fix: toon mergeblokkades en markeer een al gepushte merge
timfa project_87923614_bot_3aff574f6f98414b945a8799374f9092 · pushed by timfa · 3 weeks ago
81edde89 History
reviews_test.go 8.6 KiB Download Raw
1package server
2
3import (
4 "context"
5 "net/http"
6 "net/http/cookiejar"
7 "net/http/httptest"
8 "net/url"
9 "os/exec"
10 "path/filepath"
11 "strings"
12 "testing"
13
14 "gitlab.com/Timfa/bluegit/internal/access"
15 "gitlab.com/Timfa/bluegit/internal/auth"
16 "gitlab.com/Timfa/bluegit/internal/config"
17 "gitlab.com/Timfa/bluegit/internal/store"
18)
19
20func TestReviewsApprovalsAndReopen(t *testing.T) {
21 if _, err := exec.LookPath("git"); err != nil {
22 t.Skip("git ontbreekt")
23 }
24 storage := t.TempDir()
25 st, err := store.Open(filepath.Join(storage, "bluegit.db"), bytes32())
26 if err != nil {
27 t.Fatal(err)
28 }
29 t.Cleanup(func() { _ = st.Close() })
30 cfg := config.Config{
31 BaseURL: "http://127.0.0.1:9", Listen: "127.0.0.1:0", StoragePath: storage,
32 Auth: config.Auth{Mode: "dev", DevUser: "tim", DevAuthID: 1, UserAgent: "test", BaseURL: "https://auth.timfalken.com"},
33 Git: config.Git{Binary: "git", DefaultBranch: "master"},
34 }
35 srv := &Server{Cfg: cfg, Store: st, Auth: auth.Dev{Username: "tim", AuthID: 1}, Dev: true, Git: "git", HookBin: "/bin/true"}
36 ts := httptest.NewServer(srv.Handler())
37 t.Cleanup(ts.Close)
38 jar, _ := cookiejar.New(nil)
39 tim := &http.Client{Jar: jar}
40 res, err := tim.Get(ts.URL + "/login")
41 if err != nil {
42 t.Fatal(err)
43 }
44 page := read(t, res)
45 res, err = tim.PostForm(ts.URL+"/new/repo", url.Values{"csrf": {csrfOf(t, page)}, "name": {"gates"}, "visibility": {"public"}})
46 if err != nil {
47 t.Fatal(err)
48 }
49 page = read(t, res)
50 res, err = tim.PostForm(ts.URL+"/settings/tokens", url.Values{"csrf": {csrfOf(t, page)}, "name": {"laptop"}})
51 if err != nil {
52 t.Fatal(err)
53 }
54 token := between(read(t, res), `<p class="code">`, "</p>")
55 remote := strings.Replace(ts.URL, "http://", "http://tim:"+token+"@", 1) + "/tim/gates.git"
56 work := t.TempDir()
57 git(t, work, "init", "-b", "master")
58 git(t, work, "config", "user.email", "tim@users.git.timfalken.com")
59 git(t, work, "config", "user.name", "tim")
60 writeFile(t, filepath.Join(work, "hello.txt"), "alpha\nbeta\ngamma\n")
61 git(t, work, "add", "hello.txt")
62 git(t, work, "commit", "-m", "start")
63 git(t, work, "remote", "add", "origin", remote)
64 git(t, work, "push", "-u", "origin", "master")
65 git(t, work, "checkout", "-b", "feature")
66 writeFile(t, filepath.Join(work, "hello.txt"), "alpha\nBETA\ngamma\n")
67 git(t, work, "add", "hello.txt")
68 git(t, work, "commit", "-m", "hoofdletters")
69 git(t, work, "push", "-u", "origin", "feature")
70
71 res, err = tim.Get(ts.URL + "/tim/gates/-/merge-requests")
72 if err != nil {
73 t.Fatal(err)
74 }
75 page = read(t, res)
76 res, err = tim.PostForm(ts.URL+"/tim/gates/-/merge-requests", url.Values{
77 "csrf": {csrfOf(t, page)}, "title": {"Hoofdletters"}, "source": {"feature"}, "target": {"master"},
78 })
79 if err != nil {
80 t.Fatal(err)
81 }
82 page = read(t, res)
83
84 res, err = tim.Get(ts.URL + "/tim/gates/-/settings?tab=approvals")
85 if err != nil {
86 t.Fatal(err)
87 }
88 page = read(t, res)
89 res, err = tim.PostForm(ts.URL+"/tim/gates/-/approvals", url.Values{
90 "csrf": {csrfOf(t, page)}, "maintainer_required": {"1"}, "required_count": {"3"},
91 })
92 if err != nil {
93 t.Fatal(err)
94 }
95 page = read(t, res)
96 if !strings.Contains(page, "This requires 3 approvals, and there is 1 maintainer.") {
97 t.Fatalf("waarschuwing:\n%s", page)
98 }
99 res, err = tim.PostForm(ts.URL+"/settings/language", url.Values{"csrf": {csrfOf(t, page)}, "language": {"nl"}})
100 if err != nil {
101 t.Fatal(err)
102 }
103 _ = read(t, res)
104 res, err = tim.Get(ts.URL + "/tim/gates/-/settings?tab=approvals")
105 if err != nil {
106 t.Fatal(err)
107 }
108 page = read(t, res)
109 for _, want := range []string{
110 "Dit vraagt 3 goedkeuringen, en er is 1 beheerder.",
111 "Vereiste goedkeuringen",
112 "Goedkeuring van een beheerder vereist",
113 } {
114 if !strings.Contains(page, want) {
115 t.Fatalf("nl mist %q:\n%s", want, page)
116 }
117 }
118 if strings.Contains(page, "Vereiste approvals") || strings.Contains(page, "Maintainer-approval") {
119 t.Fatalf("nl houdt het Engelse woord:\n%s", page)
120 }
121 res, err = tim.PostForm(ts.URL+"/settings/language", url.Values{"csrf": {csrfOf(t, page)}, "language": {"en"}})
122 if err != nil {
123 t.Fatal(err)
124 }
125 page = read(t, res)
126
127 ctx := context.Background()
128 repo, err := st.RepoByPath(ctx, "tim", "gates")
129 if err != nil {
130 t.Fatal(err)
131 }
132 ada, err := st.UpsertUser(ctx, 2, "ada", "", false)
133 if err != nil {
134 t.Fatal(err)
135 }
136 bob, err := st.UpsertUser(ctx, 3, "bob", "", false)
137 if err != nil {
138 t.Fatal(err)
139 }
140 if err := st.SetMember(ctx, "repo", repo.ID, "ada", access.RoleMaintainer); err != nil {
141 t.Fatal(err)
142 }
143 if err := st.SetMember(ctx, "repo", repo.ID, "bob", access.RoleReadonly); err != nil {
144 t.Fatal(err)
145 }
146 if err := st.SaveApproval(ctx, "repo", repo.ID, store.ApprovalPolicy{MaintainerRequired: true, RequiredCount: 1}); err != nil {
147 t.Fatal(err)
148 }
149 if mrPage := read(t, mustGet(t, tim, ts.URL+"/tim/gates/-/merge-requests/1")); !strings.Contains(mrPage, "0 of 1 approval.") {
150 t.Fatalf("enkelvoud:\n%s", mrPage)
151 }
152
153 res, err = tim.PostForm(ts.URL+"/tim/gates/-/merge-requests/1/reviews", url.Values{"csrf": {csrfOf(t, page)}, "status": {"approved"}})
154 if err != nil {
155 t.Fatal(err)
156 }
157 if body := read(t, res); !strings.Contains(body, "You cannot approve your own merge request.") {
158 t.Fatalf("eigen approval:\n%s", body)
159 }
160
161 adaC := clientAs(t, ts.URL, st, ada.ID)
162 res, err = adaC.Get(ts.URL + "/tim/gates/-/merge-requests/1")
163 if err != nil {
164 t.Fatal(err)
165 }
166 adaPage := read(t, res)
167 res, err = adaC.PostForm(ts.URL+"/tim/gates/-/merge-requests/1/reviews", url.Values{"csrf": {csrfOf(t, adaPage)}, "status": {"approved"}})
168 if err != nil {
169 t.Fatal(err)
170 }
171 if body := read(t, res); !strings.Contains(body, "1 of 1 approvals") && strings.Contains(body, "approvals.") {
172 t.Fatalf("na ada:\n%s", body)
173 }
174 body := read(t, mustGet(t, adaC, ts.URL+"/tim/gates/-/merge-requests/1"))
175 if strings.Contains(body, "of 1 approvals") {
176 t.Fatalf("ada's approval hoort te volstaan:\n%s", body)
177 }
178
179 bobC := clientAs(t, ts.URL, st, bob.ID)
180 res, err = bobC.Get(ts.URL + "/tim/gates/-/merge-requests/1")
181 if err != nil {
182 t.Fatal(err)
183 }
184 bobPage := read(t, res)
185 res, err = bobC.PostForm(ts.URL+"/tim/gates/-/merge-requests/1/notes", url.Values{
186 "csrf": {csrfOf(t, bobPage)}, "path": {"hello.txt"}, "line_start": {"2"}, "line_end": {"2"},
187 "body": {"beter\n```suggestion\nbetter\n```"},
188 })
189 if err != nil {
190 t.Fatal(err)
191 }
192 body = read(t, res)
193 if !strings.Contains(body, "bob requested changes.") {
194 t.Fatalf("suggestie blokkeert:\n%s", body)
195 }
196 res, err = tim.Get(ts.URL + "/tim/gates/-/merge-requests/1")
197 if err != nil {
198 t.Fatal(err)
199 }
200 page = read(t, res)
201 if !strings.Contains(page, "Merge anyway") || !strings.Contains(page, "cannot be merged yet") {
202 t.Fatalf("mergeknop hoort uit:\n%s", page)
203 }
204 bobID := ""
205 if i := strings.Index(page, `name="user_id" value="`); i >= 0 {
206 rest := page[i+len(`name="user_id" value="`):]
207 bobID = rest[:strings.Index(rest, `"`)]
208 }
209 if bobID == "" {
210 t.Fatalf("dismiss-knop:\n%s", page)
211 }
212 res, err = tim.PostForm(ts.URL+"/tim/gates/-/merge-requests/1/reviews/dismiss", url.Values{
213 "csrf": {csrfOf(t, page)}, "user_id": {bobID},
214 })
215 if err != nil {
216 t.Fatal(err)
217 }
218 body = read(t, res)
219 if strings.Contains(body, "bob requested changes.") || strings.Contains(body, "Merge anyway") {
220 t.Fatalf("na ongeldig verklaren:\n%s", body)
221 }
222 if !strings.Contains(body, "Invalidated") {
223 t.Fatalf("status:\n%s", body)
224 }
225
226 res, err = adaC.PostForm(ts.URL+"/tim/gates/-/merge-requests/1/reviews", url.Values{"csrf": {csrfOf(t, body)}, "status": {"rejected"}})
227 if err != nil {
228 t.Fatal(err)
229 }
230 // ada's csrf from an old page may fail. Use a fresh page.
231 _ = read(t, res)
232 res, err = adaC.Get(ts.URL + "/tim/gates/-/merge-requests/1")
233 if err != nil {
234 t.Fatal(err)
235 }
236 adaPage = read(t, res)
237 res, err = adaC.PostForm(ts.URL+"/tim/gates/-/merge-requests/1/reviews", url.Values{"csrf": {csrfOf(t, adaPage)}, "status": {"rejected"}})
238 if err != nil {
239 t.Fatal(err)
240 }
241 body = read(t, res)
242 if !strings.Contains(body, "ada rejected this merge request.") {
243 t.Fatalf("veto:\n%s", body)
244 }
245
246 res, err = tim.PostForm(ts.URL+"/tim/gates/-/merge-requests/1/close", url.Values{"csrf": {csrfOf(t, page)}})
247 if err != nil {
248 t.Fatal(err)
249 }
250 body = read(t, res)
251 if !strings.Contains(body, ">closed<") && !strings.Contains(body, "closed") {
252 t.Fatalf("sluiten:\n%s", body)
253 }
254 if !strings.Contains(body, "Reopen") {
255 t.Fatalf("heropenen:\n%s", body)
256 }
257 res, err = tim.Get(ts.URL + "/tim/gates/-/merge-requests/1")
258 if err != nil {
259 t.Fatal(err)
260 }
261 page = read(t, res)
262 res, err = tim.PostForm(ts.URL+"/tim/gates/-/merge-requests/1/reopen", url.Values{"csrf": {csrfOf(t, page)}})
263 if err != nil {
264 t.Fatal(err)
265 }
266 body = read(t, res)
267 if !strings.Contains(body, ">open<") && !strings.Contains(body, "pill\">open") {
268 t.Fatalf("heropend:\n%s", body)
269 }
270}