BlueGit

timfa bluegit

Files

bluegit / internal / server / server_test.go

server_test.go

feat: vrije tekst wordt een repository- of groepsslug
timfa project_87923614_bot_3aff574f6f98414b945a8799374f9092 · pushed by timfa · 3 weeks ago
Failed f9225546 History
server_test.go 13.3 KiB Download Raw
1package server
2
3import (
4 "context"
5 "encoding/json"
6 "io"
7 "net/http"
8 "net/http/cookiejar"
9 "net/http/httptest"
10 "net/url"
11 "os"
12 "os/exec"
13 "path/filepath"
14 "strings"
15 "testing"
16 "time"
17
18 "gitlab.com/Timfa/bluegit/internal/auth"
19 "gitlab.com/Timfa/bluegit/internal/config"
20 "gitlab.com/Timfa/bluegit/internal/store"
21)
22
23func TestWebRepoPushAndSecretBoundary(t *testing.T) {
24 if _, err := exec.LookPath("git"); err != nil {
25 t.Skip("git ontbreekt")
26 }
27 storage := t.TempDir()
28 key := bytes32()
29 st, err := store.Open(filepath.Join(storage, "bluegit.db"), key)
30 if err != nil {
31 t.Fatal(err)
32 }
33 t.Cleanup(func() { _ = st.Close() })
34 cfg := config.Config{
35 BaseURL: "http://127.0.0.1:9", Listen: "127.0.0.1:0", StoragePath: storage,
36 Auth: config.Auth{Mode: "dev", DevUser: "tim", DevAuthID: 1, UserAgent: "test"},
37 Git: config.Git{Binary: "git", DefaultBranch: "master"},
38 SSH: config.SSH{Enabled: true, Listen: "0.0.0.0:2222", PublicHost: "git.timfalken.com", PublicPort: 22},
39 CI: config.CI{Enabled: false},
40 }
41 cfg.Auth.BaseURL = "https://auth.timfalken.com"
42 srv := &Server{Cfg: cfg, Store: st, Auth: auth.Dev{Username: "tim", AuthID: 1}, Dev: true, Git: "git", HookBin: "/bin/true"}
43 ts := httptest.NewServer(srv.Handler())
44 t.Cleanup(ts.Close)
45
46 jar, _ := cookiejar.New(nil)
47 client := &http.Client{Jar: jar}
48 res, err := client.Get(ts.URL + "/login")
49 if err != nil {
50 t.Fatal(err)
51 }
52 body := read(t, res)
53 if res.StatusCode != 200 || !strings.Contains(body, "Overzicht") {
54 t.Fatalf("login %d %s", res.StatusCode, body)
55 }
56 logo, err := client.Get(ts.URL + "/assets/logo.svg")
57 if err != nil {
58 t.Fatal(err)
59 }
60 wantLogo, err := os.ReadFile("../../assets/logo.svg")
61 if err != nil {
62 t.Fatal(err)
63 }
64 if logo.StatusCode != 200 || read(t, logo) != string(wantLogo) {
65 t.Fatalf("logo %d wijkt af van assets/logo.svg", logo.StatusCode)
66 }
67 if ct := logo.Header.Get("Content-Type"); !strings.Contains(ct, "image/svg+xml") {
68 t.Fatalf("favicon-type %s", ct)
69 }
70 csrf := csrfOf(t, body)
71 form := url.Values{"csrf": {csrf}, "name": {"demo"}, "description": {"eerste"}, "visibility": {"private"}}
72 res, err = client.PostForm(ts.URL+"/new/repo", form)
73 if err != nil {
74 t.Fatal(err)
75 }
76 body = read(t, res)
77 if !strings.Contains(body, "tim/demo") {
78 t.Fatalf("repo pagina:\n%s", body)
79 }
80 if !strings.Contains(body, "ssh://git@git.timfalken.com:22/tim/demo.git") {
81 t.Fatalf("clone-URL hoort de publieke SSH-poort te tonen:\n%s", body)
82 }
83 if strings.Contains(body, ":2222/") {
84 t.Fatalf("clone-URL toont de bindpoort:\n%s", body)
85 }
86
87 res, err = client.PostForm(ts.URL+"/settings/tokens", url.Values{"csrf": {csrfOf(t, body)}, "name": {"test"}})
88 if err != nil {
89 t.Fatal(err)
90 }
91 body = read(t, res)
92 token := between(body, `<p class="code">`, "</p>")
93 if !strings.HasPrefix(token, "bg_") {
94 t.Fatalf("token pagina:\n%s", body)
95 }
96
97 work := t.TempDir()
98 git(t, work, "init", "-b", "master")
99 git(t, work, "config", "user.email", "tim@users.git.timfalken.com")
100 git(t, work, "config", "user.name", "tim")
101 if err := os.WriteFile(filepath.Join(work, "README.md"), []byte("hallo bluegit\n"), 0o644); err != nil {
102 t.Fatal(err)
103 }
104 git(t, work, "add", "README.md")
105 git(t, work, "commit", "-m", "eerste commit")
106 remote := strings.Replace(ts.URL, "http://", "http://tim:"+token+"@", 1) + "/tim/demo.git"
107 git(t, work, "remote", "add", "origin", remote)
108 git(t, work, "push", "-u", "origin", "master")
109
110 res, err = client.Get(ts.URL + "/tim/demo")
111 if err != nil {
112 t.Fatal(err)
113 }
114 body = read(t, res)
115 if !strings.Contains(body, "eerste commit") || !strings.Contains(body, "README.md") {
116 t.Fatalf("na push:\n%s", body)
117 }
118 res, err = client.Get(ts.URL + "/tim/demo/-/blob/README.md")
119 if err != nil {
120 t.Fatal(err)
121 }
122 body = read(t, res)
123 if !strings.Contains(body, "hallo bluegit") {
124 t.Fatalf("blob:\n%s", body)
125 }
126
127 ctx := context.Background()
128 ada, err := st.UpsertUser(ctx, 2, "ada", "", false)
129 if err != nil {
130 t.Fatal(err)
131 }
132 repo, err := st.RepoByPath(ctx, "tim", "demo")
133 if err != nil {
134 t.Fatal(err)
135 }
136 if err := st.SetMember(ctx, "repo", repo.ID, "ada", "developer"); err != nil {
137 t.Fatal(err)
138 }
139 sess, err := st.CreateSession(ctx, ada.ID, "dev", time.Now().Add(time.Hour))
140 if err != nil {
141 t.Fatal(err)
142 }
143 adaJar, _ := cookiejar.New(nil)
144 adaClient := &http.Client{Jar: adaJar}
145 u, _ := url.Parse(ts.URL)
146 adaJar.SetCookies(u, []*http.Cookie{{Name: "bluegit_session", Value: sess.ID, Path: "/"}})
147 res, err = adaClient.Get(ts.URL + "/")
148 if err != nil {
149 t.Fatal(err)
150 }
151 adaCSRF := csrfOf(t, read(t, res))
152 res, err = adaClient.PostForm(ts.URL+"/tim/demo/-/secrets", url.Values{
153 "csrf": {adaCSRF}, "name": {"TOKEN"}, "value": {"super-geheim-waarde"},
154 })
155 if err != nil {
156 t.Fatal(err)
157 }
158 if res.StatusCode != http.StatusForbidden {
159 t.Fatalf("ontwikkelaar mocht een geheim schrijven: %d", res.StatusCode)
160 }
161 _ = res.Body.Close()
162
163 res, err = client.Get(ts.URL + "/tim/demo/-/settings?tab=geheimen")
164 if err != nil {
165 t.Fatal(err)
166 }
167 ownerPage := read(t, res)
168 res, err = client.PostForm(ts.URL+"/tim/demo/-/secrets", url.Values{
169 "csrf": {csrfOf(t, ownerPage)}, "name": {"TOKEN"}, "value": {"super-geheim-waarde"},
170 })
171 if err != nil {
172 t.Fatal(err)
173 }
174 saved := read(t, res)
175 if strings.Contains(saved, "super-geheim-waarde") {
176 t.Fatal("geheimwaarde staat op de pagina")
177 }
178 if !strings.Contains(saved, "TOKEN") {
179 t.Fatalf("naam ontbreekt:\n%s", saved)
180 }
181
182 res, err = client.PostForm(ts.URL+"/tim/demo/-/webhooks", url.Values{
183 "csrf": {csrfOf(t, saved)}, "name": {"kapot"}, "preset": {"generic"},
184 "url": {"https://example.test/hook"}, "branch_filter": {"re:("}, "event_push": {"1"},
185 })
186 if err != nil {
187 t.Fatal(err)
188 }
189 hookPage := read(t, res)
190 if !strings.Contains(hookPage, "branchfilter") && !strings.Contains(hookPage, "error") && !strings.Contains(strings.ToLower(hookPage), "regex") {
191 t.Fatalf("kapot filter:\n%s", hookPage)
192 }
193}
194
195func TestSetupChoosesStorage(t *testing.T) {
196 storage := t.TempDir()
197 stateDir := t.TempDir()
198 key := bytes32()
199 st, err := store.Open(filepath.Join(stateDir, "bluegit.db"), key)
200 if err != nil {
201 t.Fatal(err)
202 }
203 t.Cleanup(func() { _ = st.Close() })
204 cfg := config.Config{
205 BaseURL: "http://127.0.0.1:9", Listen: "127.0.0.1:0",
206 Auth: config.Auth{Mode: "dev", DevUser: "tim", DevAuthID: 1, UserAgent: "test"},
207 Git: config.Git{Binary: "git", DefaultBranch: "master"},
208 }
209 srv := &Server{Cfg: cfg, Store: st, Auth: auth.Dev{Username: "tim", AuthID: 1}, Dev: true, Git: "git", HookBin: "/bin/true", StateDir: stateDir}
210 ts := httptest.NewServer(srv.Handler())
211 t.Cleanup(ts.Close)
212
213 res, err := http.Get(ts.URL + "/tim/demo.git/info/refs?service=git-upload-pack")
214 if err != nil {
215 t.Fatal(err)
216 }
217 body := read(t, res)
218 if res.StatusCode != http.StatusServiceUnavailable || !strings.Contains(body, "nog niet ingesteld") {
219 t.Fatalf("git zonder opslag: %d %s", res.StatusCode, body)
220 }
221
222 jar, _ := cookiejar.New(nil)
223 client := &http.Client{Jar: jar}
224 res, err = client.Get(ts.URL + "/login")
225 if err != nil {
226 t.Fatal(err)
227 }
228 page := read(t, res)
229 if res.StatusCode != 200 || !strings.Contains(page, "Opslag kiezen") {
230 t.Fatalf("setup:\n%s", page)
231 }
232 res, err = client.PostForm(ts.URL+"/setup", url.Values{"csrf": {csrfOf(t, page)}, "path": {"relatief"}})
233 if err != nil {
234 t.Fatal(err)
235 }
236 page = read(t, res)
237 if !strings.Contains(page, "absoluut") {
238 t.Fatalf("relatief pad:\n%s", page)
239 }
240 res, err = client.PostForm(ts.URL+"/setup", url.Values{"csrf": {csrfOf(t, page)}, "path": {storage}})
241 if err != nil {
242 t.Fatal(err)
243 }
244 page = read(t, res)
245 if !strings.Contains(page, "Overzicht") || !strings.Contains(page, "vrij") {
246 t.Fatalf("na opslaan:\n%s", page)
247 }
248 if srv.StoragePath() != storage {
249 t.Fatalf("pad %s", srv.StoragePath())
250 }
251 saved, err := os.ReadFile(filepath.Join(stateDir, "storage_path"))
252 if err != nil || strings.TrimSpace(string(saved)) != storage {
253 t.Fatalf("bestand %q %v", saved, err)
254 }
255 res, err = client.Get(ts.URL + "/setup")
256 if err != nil {
257 t.Fatal(err)
258 }
259 page = read(t, res)
260 if !strings.Contains(page, "verplaatst geen") || !strings.Contains(page, "Vrije ruimte") {
261 t.Fatalf("wijzigen:\n%s", page)
262 }
263 res, err = http.Get(ts.URL + "/tim/demo.git/info/refs?service=git-upload-pack")
264 if err != nil {
265 t.Fatal(err)
266 }
267 body = read(t, res)
268 if res.StatusCode == http.StatusServiceUnavailable {
269 t.Fatalf("git blijft geblokkeerd: %s", body)
270 }
271
272 ada, err := st.UpsertUser(context.Background(), 2, "ada", "", true)
273 if err != nil {
274 t.Fatal(err)
275 }
276 if ada.InstanceAdmin {
277 t.Fatal("is_admin werd installatiebeheerder")
278 }
279 sess, err := st.CreateSession(context.Background(), ada.ID, "dev", time.Now().Add(time.Hour))
280 if err != nil {
281 t.Fatal(err)
282 }
283 adaJar, _ := cookiejar.New(nil)
284 adaClient := &http.Client{Jar: adaJar}
285 u, _ := url.Parse(ts.URL)
286 adaJar.SetCookies(u, []*http.Cookie{{Name: "bluegit_session", Value: sess.ID, Path: "/"}})
287 res, err = adaClient.Get(ts.URL + "/setup")
288 if err != nil {
289 t.Fatal(err)
290 }
291 if res.StatusCode != http.StatusForbidden {
292 t.Fatalf("ada setup %d %s", res.StatusCode, read(t, res))
293 }
294 _ = res.Body.Close()
295}
296
297func TestNameBecomesSlug(t *testing.T) {
298 if _, err := exec.LookPath("git"); err != nil {
299 t.Skip("git ontbreekt")
300 }
301 storage := t.TempDir()
302 st, err := store.Open(filepath.Join(t.TempDir(), "bluegit.db"), bytes32())
303 if err != nil {
304 t.Fatal(err)
305 }
306 t.Cleanup(func() { _ = st.Close() })
307 cfg := config.Config{
308 BaseURL: "http://git.timfalken.com", Listen: "127.0.0.1:0", StoragePath: storage,
309 Auth: config.Auth{Mode: "dev", DevUser: "tim", DevAuthID: 1, UserAgent: "test"},
310 Git: config.Git{Binary: "git", DefaultBranch: "master"},
311 }
312 srv := &Server{Cfg: cfg, Store: st, Auth: auth.Dev{Username: "tim", AuthID: 1}, Dev: true, Git: "git", HookBin: "/bin/true"}
313 ts := httptest.NewServer(srv.Handler())
314 t.Cleanup(ts.Close)
315 jar, _ := cookiejar.New(nil)
316 client := &http.Client{Jar: jar}
317 res, err := client.Get(ts.URL + "/login")
318 if err != nil {
319 t.Fatal(err)
320 }
321 _ = read(t, res)
322 res, err = client.Get(ts.URL + "/new")
323 if err != nil {
324 t.Fatal(err)
325 }
326 page := read(t, res)
327 if !strings.Contains(page, `data-kind="repo"`) || !strings.Contains(page, "/assets/slug.js") {
328 t.Fatalf("formulier:\n%s", page)
329 }
330 if strings.Contains(page, `pattern=`) {
331 t.Fatalf("het naamveld blokkeert spaties in de browser:\n%s", page)
332 }
333
334 prev, err := client.Get(ts.URL + "/new/slug?kind=repo&name=test+repo")
335 if err != nil {
336 t.Fatal(err)
337 }
338 var body struct {
339 Name string `json:"name"`
340 URL string `json:"url"`
341 }
342 if err := json.NewDecoder(prev.Body).Decode(&body); err != nil {
343 t.Fatal(err)
344 }
345 prev.Body.Close()
346 if body.Name != "test-repo" || body.URL != "git.timfalken.com/tim/test-repo" {
347 t.Fatalf("preview %+v", body)
348 }
349 prev, err = client.Get(ts.URL + "/new/slug?kind=group&name=Test+Groep")
350 if err != nil {
351 t.Fatal(err)
352 }
353 if err := json.NewDecoder(prev.Body).Decode(&body); err != nil {
354 t.Fatal(err)
355 }
356 prev.Body.Close()
357 if body.Name != "test-groep" || body.URL != "git.timfalken.com/groups/test-groep" {
358 t.Fatalf("groep-preview %+v", body)
359 }
360 prev, err = client.Get(ts.URL + "/new/slug?kind=repo&name=foo.git")
361 if err != nil {
362 t.Fatal(err)
363 }
364 if err := json.NewDecoder(prev.Body).Decode(&body); err != nil {
365 t.Fatal(err)
366 }
367 prev.Body.Close()
368 if body.Name != "" || body.URL != "" {
369 t.Fatalf("ongeldige preview %+v", body)
370 }
371
372 csrf := csrfOf(t, page)
373 res, err = client.PostForm(ts.URL+"/new/repo", url.Values{"csrf": {csrf}, "name": {"test repo"}, "visibility": {"private"}})
374 if err != nil {
375 t.Fatal(err)
376 }
377 page = read(t, res)
378 if !strings.Contains(page, "tim/test-repo") || strings.Contains(page, "test repo") {
379 t.Fatalf("repository:\n%s", page)
380 }
381 res, err = client.PostForm(ts.URL+"/new/group", url.Values{"csrf": {csrfOf(t, page)}, "name": {"Test Groep"}})
382 if err != nil {
383 t.Fatal(err)
384 }
385 page = read(t, res)
386 if !strings.Contains(page, ">Test Groep<") || !strings.Contains(page, "test-groep") {
387 t.Fatalf("groep:\n%s", page)
388 }
389 prev, err = client.Get(ts.URL + "/new/slug?kind=repo&name=test+repo&owner=test-groep")
390 if err != nil {
391 t.Fatal(err)
392 }
393 if err := json.NewDecoder(prev.Body).Decode(&body); err != nil {
394 t.Fatal(err)
395 }
396 prev.Body.Close()
397 if body.URL != "git.timfalken.com/test-groep/test-repo" {
398 t.Fatalf("preview met groep %+v", body)
399 }
400 res, err = client.PostForm(ts.URL+"/new/repo", url.Values{"csrf": {csrfOf(t, page)}, "name": {"foo.git"}})
401 if err != nil {
402 t.Fatal(err)
403 }
404 page = read(t, res)
405 if !strings.Contains(page, "Deze naam kan niet.") {
406 t.Fatalf("weigering:\n%s", page)
407 }
408}
409
410func csrfOf(t *testing.T, body string) string {
411 t.Helper()
412 const needle = `name="csrf" value="`
413 i := strings.Index(body, needle)
414 if i < 0 {
415 t.Fatalf("geen csrf in\n%s", body)
416 }
417 rest := body[i+len(needle):]
418 j := strings.Index(rest, `"`)
419 return rest[:j]
420}
421
422func between(s, a, b string) string {
423 i := strings.Index(s, a)
424 if i < 0 {
425 return ""
426 }
427 rest := s[i+len(a):]
428 j := strings.Index(rest, b)
429 if j < 0 {
430 return ""
431 }
432 return rest[:j]
433}
434
435func read(t *testing.T, res *http.Response) string {
436 t.Helper()
437 defer res.Body.Close()
438 b, err := io.ReadAll(res.Body)
439 if err != nil {
440 t.Fatal(err)
441 }
442 return string(b)
443}
444
445func git(t *testing.T, dir string, args ...string) {
446 t.Helper()
447 cmd := exec.Command("git", args...)
448 cmd.Dir = dir
449 out, err := cmd.CombinedOutput()
450 if err != nil {
451 t.Fatalf("git %s: %v\n%s", strings.Join(args, " "), err, out)
452 }
453}
454
455func bytes32() []byte {
456 b := make([]byte, 32)
457 for i := range b {
458 b[i] = byte(i + 3)
459 }
460 return b
461}