BlueGit

timfa bluegit

Files

bluegit / internal / server / templates_test.go

templates_test.go

test: leeg formulier als sjabloonmappen ontbreken
timfa project_87923614_bot_3aff574f6f98414b945a8799374f9092 · pushed by timfa · 3 weeks ago
a0e47f35 History
templates_test.go 12.6 KiB Download Raw
1package server
2
3import (
4 "context"
5 "encoding/json"
6 "net/http"
7 "net/http/cookiejar"
8 "net/http/httptest"
9 "net/url"
10 "path/filepath"
11 "strings"
12 "testing"
13
14 "gitlab.com/Timfa/bluegit/internal/access"
15 "gitlab.com/Timfa/bluegit/internal/auth"
16 "gitlab.com/Timfa/bluegit/internal/config"
17 "gitlab.com/Timfa/bluegit/internal/store"
18)
19
20func TestMissingTemplateDirs(t *testing.T) {
21 storage := t.TempDir()
22 st, err := store.Open(filepath.Join(storage, "bluegit.db"), bytes32())
23 if err != nil {
24 t.Fatal(err)
25 }
26 t.Cleanup(func() { _ = st.Close() })
27 cfg := config.Config{
28 BaseURL: "http://git.example", Listen: "127.0.0.1:0", StoragePath: storage,
29 Auth: config.Auth{Mode: "dev", DevUser: "tim", DevAuthID: 1, UserAgent: "test", BaseURL: "https://auth.timfalken.com"},
30 Git: config.Git{Binary: "git", DefaultBranch: "master"},
31 }
32 srv := &Server{Cfg: cfg, Store: st, Auth: auth.Dev{Username: "tim", AuthID: 1}, Dev: true, Git: "git", HookBin: "/bin/true"}
33 ts := httptest.NewServer(srv.Handler())
34 t.Cleanup(ts.Close)
35
36 jar, _ := cookiejar.New(nil)
37 tim := &http.Client{Jar: jar}
38 page := read(t, mustGet(t, tim, ts.URL+"/login"))
39 page = read(t, mustPost(t, tim, ts.URL+"/new/repo", url.Values{
40 "csrf": {csrfOf(t, page)}, "name": {"kaal"}, "visibility": {"public"},
41 }))
42 page = read(t, mustPost(t, tim, ts.URL+"/settings/tokens", url.Values{"csrf": {csrfOf(t, page)}, "name": {"tim"}}))
43 token := between(page, `<p class="code">`, "</p>")
44
45 empty := read(t, mustGet(t, tim, ts.URL+"/tim/kaal/-/issues/new"))
46 assertBareForm(t, empty, "issue")
47
48 work := t.TempDir()
49 git(t, work, "init", "-b", "master")
50 git(t, work, "config", "user.email", "tim@example")
51 git(t, work, "config", "user.name", "tim")
52 writeFile(t, filepath.Join(work, "README.md"), "start\n")
53 git(t, work, "add", ".")
54 git(t, work, "commit", "-m", "start")
55 remote := strings.Replace(ts.URL, "http://", "http://tim:"+token+"@", 1) + "/tim/kaal.git"
56 git(t, work, "remote", "add", "origin", remote)
57 git(t, work, "push", "-u", "origin", "master")
58 git(t, work, "checkout", "-b", "feature")
59 writeFile(t, filepath.Join(work, "extra.txt"), "meer\n")
60 git(t, work, "add", "extra.txt")
61 git(t, work, "commit", "-m", "meer")
62 git(t, work, "push", "-u", "origin", "feature")
63
64 issue := read(t, mustGet(t, tim, ts.URL+"/tim/kaal/-/issues/new"))
65 assertBareForm(t, issue, "issue")
66 mr := read(t, mustGet(t, tim, ts.URL+"/tim/kaal/-/merge-requests/new?source=feature&target=master"))
67 assertBareForm(t, mr, "mr")
68
69 bare := filepath.Join(storage, "repos", "tim", "kaal.git")
70 out, err := gitOut(bare, "ls-tree", "-r", "--name-only", "master")
71 if err != nil {
72 t.Fatal(err)
73 }
74 if strings.Contains(out, ".bluegit") || strings.Contains(out, ".gitlab") {
75 t.Fatalf("mappen aangemaakt:\n%s", out)
76 }
77}
78
79func assertBareForm(t *testing.T, page, kind string) {
80 t.Helper()
81 if strings.Contains(page, `name="template"`) || strings.Contains(page, "Apply template") {
82 t.Fatalf("%s toont een sjabloonmenu:\n%s", kind, page)
83 }
84 if strings.Contains(page, `class="flash"`) || strings.Contains(page, "fatal:") || strings.Contains(page, "Not a valid object") {
85 t.Fatalf("%s toont een melding:\n%s", kind, page)
86 }
87 if !strings.Contains(page, `<textarea name="description"></textarea>`) {
88 t.Fatalf("%s beschrijving is niet leeg:\n%s", kind, page)
89 }
90}
91
92func TestTemplatesAndTasks(t *testing.T) {
93 storage := t.TempDir()
94 st, err := store.Open(filepath.Join(storage, "bluegit.db"), bytes32())
95 if err != nil {
96 t.Fatal(err)
97 }
98 t.Cleanup(func() { _ = st.Close() })
99 cfg := config.Config{
100 BaseURL: "http://git.example", Listen: "127.0.0.1:0", StoragePath: storage,
101 Auth: config.Auth{Mode: "dev", DevUser: "tim", DevAuthID: 1, UserAgent: "test", BaseURL: "https://auth.timfalken.com"},
102 Git: config.Git{Binary: "git", DefaultBranch: "master"},
103 }
104 srv := &Server{Cfg: cfg, Store: st, Auth: auth.Dev{Username: "tim", AuthID: 1}, Dev: true, Git: "git", HookBin: "/bin/true"}
105 ts := httptest.NewServer(srv.Handler())
106 t.Cleanup(ts.Close)
107
108 jar, _ := cookiejar.New(nil)
109 tim := &http.Client{Jar: jar}
110 page := read(t, mustGet(t, tim, ts.URL+"/login"))
111 page = read(t, mustPost(t, tim, ts.URL+"/new/repo", url.Values{
112 "csrf": {csrfOf(t, page)}, "name": {"sjablonen"}, "visibility": {"public"},
113 }))
114 page = read(t, mustPost(t, tim, ts.URL+"/settings/tokens", url.Values{"csrf": {csrfOf(t, page)}, "name": {"tim"}}))
115 token := between(page, `<p class="code">`, "</p>")
116 ctx := context.Background()
117 repo, err := st.RepoByPath(ctx, "tim", "sjablonen")
118 if err != nil {
119 t.Fatal(err)
120 }
121 rep, err := st.UpsertUser(ctx, 4, "rep", "", false)
122 if err != nil {
123 t.Fatal(err)
124 }
125 ro, err := st.UpsertUser(ctx, 3, "ro", "", false)
126 if err != nil {
127 t.Fatal(err)
128 }
129 if err := st.SetMember(ctx, "repo", repo.ID, "rep", access.RoleReporter); err != nil {
130 t.Fatal(err)
131 }
132 if err := st.SetMember(ctx, "repo", repo.ID, "ro", access.RoleReadonly); err != nil {
133 t.Fatal(err)
134 }
135 repToken, err := st.CreateToken(ctx, rep.ID, "rep")
136 if err != nil {
137 t.Fatal(err)
138 }
139 roToken, err := st.CreateToken(ctx, ro.ID, "ro")
140 if err != nil {
141 t.Fatal(err)
142 }
143
144 work := t.TempDir()
145 git(t, work, "init", "-b", "master")
146 git(t, work, "config", "user.email", "tim@example")
147 git(t, work, "config", "user.name", "tim")
148 writeFile(t, filepath.Join(work, ".bluegit", "issue_templates", "Default.md"), "Standaard issue-tekst\n")
149 writeFile(t, filepath.Join(work, ".bluegit", "issue_templates", "Bug.md"), "Bluegit bugtekst\n")
150 writeFile(t, filepath.Join(work, ".gitlab", "issue_templates", "Bug.md"), "Gitlab bugtekst\n")
151 writeFile(t, filepath.Join(work, ".gitlab", "issue_templates", "Legacy.md"), "Oude gitlab-tekst\n")
152 writeFile(t, filepath.Join(work, ".bluegit", "merge_request_templates", "Default.md"), "- [ ] controle\nBron %{source_branch}\nDoel %{target_branch}\n%{closes_issue}\n\n%{first_commit}\n")
153 writeFile(t, filepath.Join(work, ".gitlab", "merge_request_templates", "Default.md"), "GITLAB MR\n")
154 writeFile(t, filepath.Join(work, "README.md"), "start\n")
155 git(t, work, "add", ".")
156 git(t, work, "commit", "-m", "sjablonen")
157 remote := strings.Replace(ts.URL, "http://", "http://tim:"+token+"@", 1) + "/tim/sjablonen.git"
158 git(t, work, "remote", "add", "origin", remote)
159 git(t, work, "push", "-u", "origin", "master")
160 git(t, work, "checkout", "-b", "12-fix")
161 writeFile(t, filepath.Join(work, "fix.txt"), "ok\n")
162 git(t, work, "add", "fix.txt")
163 git(t, work, "commit", "-m", "Fix login", "-m", "Details here")
164 git(t, work, "push", "-u", "origin", "12-fix")
165
166 page = read(t, mustGet(t, tim, ts.URL+"/tim/sjablonen/-/issues/new"))
167 for _, want := range []string{"Standaard issue-tekst", `value="Bug"`, `value="Legacy"`, `value="Default" selected`} {
168 if !strings.Contains(page, want) {
169 t.Fatalf("nieuw issue mist %q\n%s", want, page)
170 }
171 }
172 if strings.Contains(page, "Gitlab bugtekst") {
173 t.Fatal("gitlab-bug hoort niet de standaard te zijn")
174 }
175 bug := read(t, mustGet(t, tim, ts.URL+"/tim/sjablonen/-/issues/new?template=Bug"))
176 if !strings.Contains(bug, "Bluegit bugtekst") || strings.Contains(bug, "Gitlab bugtekst") {
177 t.Fatalf("bug-sjabloon:\n%s", bug)
178 }
179 legacy := read(t, mustGet(t, tim, ts.URL+"/tim/sjablonen/-/issues/new?template=Legacy"))
180 if !strings.Contains(legacy, "Oude gitlab-tekst") {
181 t.Fatalf("terugval:\n%s", legacy)
182 }
183
184 res := postJSON(t, http.MethodPost, ts.URL+"/api/v1/repos/tim/sjablonen/labels", token, map[string]any{"name": "bug", "color": "#428fdc"})
185 if res.StatusCode != http.StatusCreated {
186 t.Fatalf("label %d %s", res.StatusCode, read(t, res))
187 }
188 res.Body.Close()
189
190 res = postJSON(t, http.MethodPost, ts.URL+"/api/v1/repos/tim/sjablonen/issues", repToken, map[string]any{
191 "title": "Gelabeld", "description": "/label ~bug\n\n- [ ] een\n- [x] twee\n",
192 })
193 body := read(t, res)
194 if res.StatusCode != http.StatusCreated || strings.Contains(body, "/label") || !strings.Contains(body, "- [ ] een") {
195 t.Fatalf("reporter %d %s", res.StatusCode, body)
196 }
197 var created map[string]any
198 if err := json.Unmarshal([]byte(body), &created); err != nil {
199 t.Fatal(err)
200 }
201 labels, _ := created["labels"].([]any)
202 if len(labels) != 1 || labels[0] != "bug" {
203 t.Fatalf("labels %#v", created["labels"])
204 }
205
206 res = postJSON(t, http.MethodPost, ts.URL+"/api/v1/repos/tim/sjablonen/issues", roToken, map[string]any{
207 "title": "Blijft", "description": "/label ~bug\n/confidential\n\nTekst\n",
208 })
209 body = read(t, res)
210 if res.StatusCode != http.StatusCreated || !strings.Contains(body, "/label ~bug") || strings.Contains(body, "/confidential") {
211 t.Fatalf("readonly %d %s", res.StatusCode, body)
212 }
213 if err := json.Unmarshal([]byte(body), &created); err != nil {
214 t.Fatal(err)
215 }
216 if created["confidential"] != true {
217 t.Fatalf("confidential %#v", created["confidential"])
218 }
219 if labs, _ := created["labels"].([]any); len(labs) != 0 {
220 t.Fatalf("readonly labels %#v", created["labels"])
221 }
222
223 res = postJSON(t, http.MethodPost, ts.URL+"/api/v1/repos/tim/sjablonen/issues", repToken, map[string]any{
224 "title": "Hek", "description": "```\n/label ~bug\n```\nBlijft\n",
225 })
226 body = read(t, res)
227 if res.StatusCode != http.StatusCreated || !strings.Contains(body, "/label ~bug") {
228 t.Fatalf("hek %d %s", res.StatusCode, body)
229 }
230 if err := json.Unmarshal([]byte(body), &created); err != nil {
231 t.Fatal(err)
232 }
233 if labs, _ := created["labels"].([]any); len(labs) != 0 {
234 t.Fatalf("hek labels %#v", created["labels"])
235 }
236
237 page = read(t, mustGet(t, tim, ts.URL+"/tim/sjablonen/-/issues/1"))
238 if !strings.Contains(page, "1 of 2 tasks completed") || !strings.Contains(page, `name="kind" value="issue"`) {
239 t.Fatalf("taken:\n%s", page)
240 }
241 page = read(t, mustPost(t, tim, ts.URL+"/tim/sjablonen/-/tasks", url.Values{
242 "csrf": {csrfOf(t, page)}, "kind": {"issue"}, "id": {"1"}, "index": {"0"}, "checked": {"1"},
243 }))
244 if !strings.Contains(page, "2 of 2 tasks completed") || !strings.Contains(page, "- [x] een") {
245 t.Fatalf("na klik:\n%s", page)
246 }
247 page = read(t, mustPost(t, tim, ts.URL+"/tim/sjablonen/-/issues/1", url.Values{
248 "csrf": {csrfOf(t, page)}, "action": {"note"}, "body": {"- [ ] reactie"},
249 }))
250 if !strings.Contains(page, `name="kind" value="issue-note"`) {
251 t.Fatalf("reactie:\n%s", page)
252 }
253 noteID := between(page[strings.Index(page, `name="kind" value="issue-note"`):], `name="id" value="`, `"`)
254 page = read(t, mustPost(t, tim, ts.URL+"/tim/sjablonen/-/tasks", url.Values{
255 "csrf": {csrfOf(t, page)}, "kind": {"issue-note"}, "id": {noteID}, "index": {"0"}, "checked": {"1"},
256 }))
257 if !strings.Contains(page, "reactie") {
258 t.Fatalf("reactie na klik:\n%s", page)
259 }
260 res = postJSON(t, http.MethodGet, ts.URL+"/api/v1/repos/tim/sjablonen/issues/1", token, nil)
261 body = read(t, res)
262 if !strings.Contains(body, "- [x] reactie") {
263 t.Fatalf("bron van de reactie:\n%s", body)
264 }
265
266 res = postJSON(t, http.MethodPost, ts.URL+"/api/v1/repos/tim/sjablonen/issues/1/notes", repToken, map[string]any{"body": "/assign @tim\n\nZie dit"})
267 body = read(t, res)
268 if res.StatusCode != http.StatusCreated || strings.Contains(body, "/assign") || !strings.Contains(body, "Zie dit") {
269 t.Fatalf("toewijzen %d %s", res.StatusCode, body)
270 }
271 res = postJSON(t, http.MethodGet, ts.URL+"/api/v1/repos/tim/sjablonen/issues/1", repToken, nil)
272 body = read(t, res)
273 if !strings.Contains(body, `"assignees":["tim"]`) {
274 t.Fatalf("assignee:\n%s", body)
275 }
276
277 mrPage := read(t, mustGet(t, tim, ts.URL+"/tim/sjablonen/-/merge-requests/new?source=12-fix&target=master"))
278 for _, want := range []string{"%{source_branch}", "- [ ] controle", `value="Default" selected`} {
279 if !strings.Contains(mrPage, want) {
280 t.Fatalf("mr-formulier mist %q\n%s", want, mrPage)
281 }
282 }
283 if strings.Contains(mrPage, "GITLAB MR") {
284 t.Fatal("gitlab-default wint niet")
285 }
286 made := read(t, mustPost(t, tim, ts.URL+"/tim/sjablonen/-/merge-requests", url.Values{
287 "csrf": {csrfOf(t, mrPage)}, "source": {"12-fix"}, "target": {"master"}, "title": {"Fix"},
288 "description": {"- [ ] controle\nBron %{source_branch}\nDoel %{target_branch}\n%{closes_issue}\n\n%{first_commit}\n"},
289 }))
290 for _, want := range []string{"Bron 12-fix", "Doel master", "Closes #12", "Fix login", "Details here", "0 of 1 tasks completed"} {
291 if !strings.Contains(made, want) {
292 t.Fatalf("mr mist %q\n%s", want, made)
293 }
294 }
295 if strings.Contains(made, "%{source_branch}") || strings.Contains(made, "GITLAB MR") {
296 t.Fatalf("variabelen bleven staan:\n%s", made)
297 }
298 made = read(t, mustPost(t, tim, ts.URL+"/tim/sjablonen/-/tasks", url.Values{
299 "csrf": {csrfOf(t, made)}, "kind": {"mr"}, "id": {"1"}, "index": {"0"}, "checked": {"1"},
300 }))
301 if !strings.Contains(made, "1 of 1 tasks completed") || !strings.Contains(made, "- [x] controle") {
302 t.Fatalf("mr-taak:\n%s", made)
303 }
304
305 info := read(t, mustGet(t, tim, ts.URL+"/-/info"))
306 for _, want := range []string{`id="templates"`, "Default.md", ".gitlab/", "tasks completed", "/label"} {
307 if !strings.Contains(info, want) {
308 t.Fatalf("info mist %q", want)
309 }
310 }
311}