Merged
Bestandsweergave: Download, Raw, Kopiëren en SVG-voorbeeld
timfa
wants to merge
1 commit
from
cursor/file-actions
into
stage
Overview Commits 1 Pipelines 1 Changes 11
Activity
- timfa opened this merge request 25 October 2026
- timfa Pipeline #272 is Passed 25 October 2026
- timfa merged this merge request 25 October 2026
Commits
Pipelines
- #272 Passed
Changes
@@ -160,6 +160,11 @@ API onder `/api/v1/admin/runners` (zelfde vorm als `/api/v1/user/runners`), alle
160
160
161
161
Jobs op beschermde branches draaien alleen op de ingebouwde runner, globale runners, groepsrunners en account-runners van maintainers/admins van de repo. Opt-in-runners van developers krijgen ze niet; het joblog noemt overgeslagen runners. Zie /help/runners.
162
162
163
## Bestanden: raw, download, kopiëren
164
165
- `GET /{owner}/{repo}/-/raw/{pad}?rev=REF` geeft alleen de inhoud, met dezelfde toegang als de bestandsweergave (privé: inloggen). Tekst komt als `text/plain` (ook HTML/SVG, zodat er nooit code van een repo op BlueGit draait), afbeeldingen als afbeelding, binair als `application/octet-stream` met header `X-BlueGit-Binary: 1`. `&download=1` geeft een bijlage met de bestandsnaam. Max. 50 MB.
166
- In de bestandsweergave staan rechtsboven **Download**, **Raw** (nieuw tabblad) en **Kopiëren** (tekst naar het klembord; binair is uitgeschakeld, fouten komen in een eigen venster). Bij `.svg` staat een voorbeeld in een wit vlak, geladen als `<img>` (`&as=img`), dus scripts in de SVG draaien niet.
167
163
168
## Releases en assets verwijderen
164
169
165
170
```sh
@@ -160,6 +160,11 @@ API onder `/api/v1/admin/runners` (zelfde vorm als `/api/v1/user/runners`), alle160
160
161
Jobs op beschermde branches draaien alleen op de ingebouwde runner, globale runners, groepsrunners en account-runners van maintainers/admins van de repo. Opt-in-runners van developers krijgen ze niet; het joblog noemt overgeslagen runners. Zie /help/runners.161
Jobs op beschermde branches draaien alleen op de ingebouwde runner, globale runners, groepsrunners en account-runners van maintainers/admins van de repo. Opt-in-runners van developers krijgen ze niet; het joblog noemt overgeslagen runners. Zie /help/runners.162
162
163
## Bestanden: raw, download, kopiëren164
165
- `GET /{owner}/{repo}/-/raw/{pad}?rev=REF` geeft alleen de inhoud, met dezelfde toegang als de bestandsweergave (privé: inloggen). Tekst komt als `text/plain` (ook HTML/SVG, zodat er nooit code van een repo op BlueGit draait), afbeeldingen als afbeelding, binair als `application/octet-stream` met header `X-BlueGit-Binary: 1`. `&download=1` geeft een bijlage met de bestandsnaam. Max. 50 MB.166
- In de bestandsweergave staan rechtsboven **Download**, **Raw** (nieuw tabblad) en **Kopiëren** (tekst naar het klembord; binair is uitgeschakeld, fouten komen in een eigen venster). Bij `.svg` staat een voorbeeld in een wit vlak, geladen als `<img>` (`&as=img`), dus scripts in de SVG draaien niet.167
163
## Releases en assets verwijderen168
## Releases en assets verwijderen164
169
165
```sh170
```sh@@ -285,6 +285,19 @@ var en = map[string]string{
285
285
"mail.fail.open": "Open the pipeline",
286
286
287
287
"rel.none": "No releases yet.",
288
"file.download": "Download",
289
"file.raw": "Raw",
290
"file.copy": "Copy",
291
"file.copied": "Copied",
292
"file.tip.download": "Download %s",
293
"file.tip.raw": "Open only the file contents in a new tab",
294
"file.tip.copy": "Copy the file contents to your clipboard",
295
"file.tip.copyBinary": "Binary files cannot be copied as text; use Download",
296
"file.copyFail": "The file contents could not be copied. The file may be binary or too large, you may lack access, or your browser blocked the clipboard.",
297
"file.copyFailTitle": "Copy failed",
298
"file.svgPreview": "SVG preview",
299
"file.svgEmpty": "No preview: this SVG is empty or invalid.",
300
"raw.tooBig": "This file is too large to show raw; use Download from git.",
288
301
"rel.delete": "Delete release",
289
302
"rel.deleteAsset": "Delete",
290
303
"rel.deleteAsk": "Delete release %s and all its files? The source code stays.",
@@ -285,6 +285,19 @@ var en = map[string]string{285
"mail.fail.open": "Open the pipeline",285
"mail.fail.open": "Open the pipeline",286
286
287
"rel.none": "No releases yet.",287
"rel.none": "No releases yet.",288
"file.download": "Download",289
"file.raw": "Raw",290
"file.copy": "Copy",291
"file.copied": "Copied",292
"file.tip.download": "Download %s",293
"file.tip.raw": "Open only the file contents in a new tab",294
"file.tip.copy": "Copy the file contents to your clipboard",295
"file.tip.copyBinary": "Binary files cannot be copied as text; use Download",296
"file.copyFail": "The file contents could not be copied. The file may be binary or too large, you may lack access, or your browser blocked the clipboard.",297
"file.copyFailTitle": "Copy failed",298
"file.svgPreview": "SVG preview",299
"file.svgEmpty": "No preview: this SVG is empty or invalid.",300
"raw.tooBig": "This file is too large to show raw; use Download from git.",288
"rel.delete": "Delete release",301
"rel.delete": "Delete release",289
"rel.deleteAsset": "Delete",302
"rel.deleteAsset": "Delete",290
"rel.deleteAsk": "Delete release %s and all its files? The source code stays.",303
"rel.deleteAsk": "Delete release %s and all its files? The source code stays.",@@ -290,6 +290,19 @@ var nl = map[string]string{
290
290
"mail.fail.jobs": "Mislukte jobs",
291
291
"mail.fail.open": "Open de pipeline",
292
292
"rel.none": "Nog geen releases.",
293
"file.download": "Download",
294
"file.raw": "Raw",
295
"file.copy": "Kopiëren",
296
"file.copied": "Gekopieerd",
297
"file.tip.download": "%s downloaden",
298
"file.tip.raw": "Alleen de bestandsinhoud openen in een nieuw tabblad",
299
"file.tip.copy": "De bestandsinhoud naar je klembord kopiëren",
300
"file.tip.copyBinary": "Binaire bestanden kun je niet als tekst kopiëren; gebruik Download",
301
"file.copyFail": "De bestandsinhoud kon niet gekopieerd worden. Het bestand is misschien binair of te groot, je hebt geen toegang, of je browser blokkeerde het klembord.",
302
"file.copyFailTitle": "Kopiëren mislukt",
303
"file.svgPreview": "Voorbeeld van de SVG",
304
"file.svgEmpty": "Geen voorbeeld: deze SVG is leeg of ongeldig.",
305
"raw.tooBig": "Dit bestand is te groot om raw te tonen; haal het via git op.",
293
306
"rel.delete": "Release verwijderen",
294
307
"rel.deleteAsset": "Verwijderen",
295
308
"rel.deleteAsk": "Release %s met alle bestanden verwijderen? De broncode blijft.",
@@ -921,6 +934,19 @@ var de = map[string]string{
921
934
"mail.fail.jobs": "Fehlgeschlagene Jobs",
922
935
"mail.fail.open": "Pipeline öffnen",
923
936
"rel.none": "Noch keine Releases.",
937
"file.download": "Download",
938
"file.raw": "Raw",
939
"file.copy": "Kopieren",
940
"file.copied": "Kopiert",
941
"file.tip.download": "%s herunterladen",
942
"file.tip.raw": "Nur den Dateiinhalt in einem neuen Tab öffnen",
943
"file.tip.copy": "Dateiinhalt in die Zwischenablage kopieren",
944
"file.tip.copyBinary": "Binärdateien lassen sich nicht als Text kopieren; nutze Download",
945
"file.copyFail": "Der Dateiinhalt konnte nicht kopiert werden. Die Datei ist vielleicht binär oder zu groß, dir fehlt der Zugriff, oder der Browser hat die Zwischenablage blockiert.",
946
"file.copyFailTitle": "Kopieren fehlgeschlagen",
947
"file.svgPreview": "SVG-Vorschau",
948
"file.svgEmpty": "Keine Vorschau: dieses SVG ist leer oder ungültig.",
949
"raw.tooBig": "Diese Datei ist zu groß für die Raw-Ansicht; hole sie per git.",
924
950
"rel.delete": "Release löschen",
925
951
"rel.deleteAsset": "Löschen",
926
952
"rel.deleteAsk": "Release %s mit allen Dateien löschen? Der Quellcode bleibt.",
@@ -1552,6 +1578,19 @@ var fr = map[string]string{
1552
1578
"mail.fail.jobs": "Jobs échoués",
1553
1579
"mail.fail.open": "Ouvrir le pipeline",
1554
1580
"rel.none": "Pas encore de versions.",
1581
"file.download": "Télécharger",
1582
"file.raw": "Brut",
1583
"file.copy": "Copier",
1584
"file.copied": "Copié",
1585
"file.tip.download": "Télécharger %s",
1586
"file.tip.raw": "Ouvrir uniquement le contenu du fichier dans un nouvel onglet",
1587
"file.tip.copy": "Copier le contenu du fichier dans le presse-papiers",
1588
"file.tip.copyBinary": "Les fichiers binaires ne peuvent pas être copiés comme texte ; utilise Télécharger",
1589
"file.copyFail": "Le contenu du fichier n'a pas pu être copié. Le fichier est peut-être binaire ou trop gros, tu n'as pas l'accès, ou le navigateur a bloqué le presse-papiers.",
1590
"file.copyFailTitle": "Échec de la copie",
1591
"file.svgPreview": "Aperçu du SVG",
1592
"file.svgEmpty": "Pas d’aperçu : ce SVG est vide ou invalide.",
1593
"raw.tooBig": "Ce fichier est trop gros pour l’affichage brut ; récupère-le avec git.",
1555
1594
"rel.delete": "Supprimer la version",
1556
1595
"rel.deleteAsset": "Supprimer",
1557
1596
"rel.deleteAsk": "Supprimer la version %s et tous ses fichiers ? Le code source reste.",
@@ -290,6 +290,19 @@ var nl = map[string]string{290
"mail.fail.jobs": "Mislukte jobs",290
"mail.fail.jobs": "Mislukte jobs",291
"mail.fail.open": "Open de pipeline",291
"mail.fail.open": "Open de pipeline",292
"rel.none": "Nog geen releases.",292
"rel.none": "Nog geen releases.",293
"file.download": "Download",294
"file.raw": "Raw",295
"file.copy": "Kopiëren",296
"file.copied": "Gekopieerd",297
"file.tip.download": "%s downloaden",298
"file.tip.raw": "Alleen de bestandsinhoud openen in een nieuw tabblad",299
"file.tip.copy": "De bestandsinhoud naar je klembord kopiëren",300
"file.tip.copyBinary": "Binaire bestanden kun je niet als tekst kopiëren; gebruik Download",301
"file.copyFail": "De bestandsinhoud kon niet gekopieerd worden. Het bestand is misschien binair of te groot, je hebt geen toegang, of je browser blokkeerde het klembord.",302
"file.copyFailTitle": "Kopiëren mislukt",303
"file.svgPreview": "Voorbeeld van de SVG",304
"file.svgEmpty": "Geen voorbeeld: deze SVG is leeg of ongeldig.",305
"raw.tooBig": "Dit bestand is te groot om raw te tonen; haal het via git op.",293
"rel.delete": "Release verwijderen",306
"rel.delete": "Release verwijderen",294
"rel.deleteAsset": "Verwijderen",307
"rel.deleteAsset": "Verwijderen",295
"rel.deleteAsk": "Release %s met alle bestanden verwijderen? De broncode blijft.",308
"rel.deleteAsk": "Release %s met alle bestanden verwijderen? De broncode blijft.",@@ -921,6 +934,19 @@ var de = map[string]string{921
"mail.fail.jobs": "Fehlgeschlagene Jobs",934
"mail.fail.jobs": "Fehlgeschlagene Jobs",922
"mail.fail.open": "Pipeline öffnen",935
"mail.fail.open": "Pipeline öffnen",923
"rel.none": "Noch keine Releases.",936
"rel.none": "Noch keine Releases.",937
"file.download": "Download",938
"file.raw": "Raw",939
"file.copy": "Kopieren",940
"file.copied": "Kopiert",941
"file.tip.download": "%s herunterladen",942
"file.tip.raw": "Nur den Dateiinhalt in einem neuen Tab öffnen",943
"file.tip.copy": "Dateiinhalt in die Zwischenablage kopieren",944
"file.tip.copyBinary": "Binärdateien lassen sich nicht als Text kopieren; nutze Download",945
"file.copyFail": "Der Dateiinhalt konnte nicht kopiert werden. Die Datei ist vielleicht binär oder zu groß, dir fehlt der Zugriff, oder der Browser hat die Zwischenablage blockiert.",946
"file.copyFailTitle": "Kopieren fehlgeschlagen",947
"file.svgPreview": "SVG-Vorschau",948
"file.svgEmpty": "Keine Vorschau: dieses SVG ist leer oder ungültig.",949
"raw.tooBig": "Diese Datei ist zu groß für die Raw-Ansicht; hole sie per git.",924
"rel.delete": "Release löschen",950
"rel.delete": "Release löschen",925
"rel.deleteAsset": "Löschen",951
"rel.deleteAsset": "Löschen",926
"rel.deleteAsk": "Release %s mit allen Dateien löschen? Der Quellcode bleibt.",952
"rel.deleteAsk": "Release %s mit allen Dateien löschen? Der Quellcode bleibt.",@@ -1552,6 +1578,19 @@ var fr = map[string]string{1552
"mail.fail.jobs": "Jobs échoués",1578
"mail.fail.jobs": "Jobs échoués",1553
"mail.fail.open": "Ouvrir le pipeline",1579
"mail.fail.open": "Ouvrir le pipeline",1554
"rel.none": "Pas encore de versions.",1580
"rel.none": "Pas encore de versions.",1581
"file.download": "Télécharger",1582
"file.raw": "Brut",1583
"file.copy": "Copier",1584
"file.copied": "Copié",1585
"file.tip.download": "Télécharger %s",1586
"file.tip.raw": "Ouvrir uniquement le contenu du fichier dans un nouvel onglet",1587
"file.tip.copy": "Copier le contenu du fichier dans le presse-papiers",1588
"file.tip.copyBinary": "Les fichiers binaires ne peuvent pas être copiés comme texte ; utilise Télécharger",1589
"file.copyFail": "Le contenu du fichier n'a pas pu être copié. Le fichier est peut-être binaire ou trop gros, tu n'as pas l'accès, ou le navigateur a bloqué le presse-papiers.",1590
"file.copyFailTitle": "Échec de la copie",1591
"file.svgPreview": "Aperçu du SVG",1592
"file.svgEmpty": "Pas d’aperçu : ce SVG est vide ou invalide.",1593
"raw.tooBig": "Ce fichier est trop gros pour l’affichage brut ; récupère-le avec git.",1555
"rel.delete": "Supprimer la version",1594
"rel.delete": "Supprimer la version",1556
"rel.deleteAsset": "Supprimer",1595
"rel.deleteAsset": "Supprimer",1557
"rel.deleteAsk": "Supprimer la version %s et tous ses fichiers ? Le code source reste.",1596
"rel.deleteAsk": "Supprimer la version %s et tous ses fichiers ? Le code source reste.",@@ -73,6 +73,7 @@ func (s *Server) fillFiles(r *http.Request, v *View, repo store.Repo, rel string
73
73
return
74
74
}
75
75
v.Binary = binary
76
v.IsSVG = strings.EqualFold(path.Ext(rel), ".svg")
76
77
if !binary {
77
78
for i, line := range highlight.Lines(rel, text) {
78
79
v.Lines = append(v.Lines, CodeLine{N: i + 1, HTML: template.HTML(line)})
@@ -73,6 +73,7 @@ func (s *Server) fillFiles(r *http.Request, v *View, repo store.Repo, rel string73
return73
return74
}74
}75
v.Binary = binary75
v.Binary = binary76
v.IsSVG = strings.EqualFold(path.Ext(rel), ".svg")76
if !binary {77
if !binary {77
for i, line := range highlight.Lines(rel, text) {78
for i, line := range highlight.Lines(rel, text) {78
v.Lines = append(v.Lines, CodeLine{N: i + 1, HTML: template.HTML(line)})79
v.Lines = append(v.Lines, CodeLine{N: i + 1, HTML: template.HTML(line)})@@ -0,0 +1,84 @@
1
package server
2
3
import (
4
"mime"
5
"net/http"
6
"path"
7
"strings"
8
9
"gitlab.com/Timfa/bluegit/internal/access"
10
"gitlab.com/Timfa/bluegit/internal/gitrepo"
11
)
12
13
// rawMax: groter dan dit levert raw niet (geheugen van de server).
14
const rawMax = 50 << 20
15
16
// rawImageTypes worden als afbeelding geserveerd; al het andere als tekst
17
// of octet-stream, zodat HTML/JS uit een repo nooit op ons domein draait.
18
var rawImageTypes = map[string]string{
19
".png": "image/png", ".jpg": "image/jpeg", ".jpeg": "image/jpeg", ".gif": "image/gif",
20
".webp": "image/webp", ".ico": "image/x-icon", ".bmp": "image/bmp", ".avif": "image/avif",
21
}
22
23
// raw toont alleen de inhoud van een bestand, met dezelfde toegang als de
24
// bestandsweergave. ?download=1 geeft een bijlage met de bestandsnaam;
25
// ?as=img levert een .svg als image/svg+xml voor <img> (in een sandbox).
26
func (s *Server) raw(w http.ResponseWriter, r *http.Request) {
27
_, repo, _, ok := s.guard(w, r, access.RoleReadonly)
28
if !ok {
29
return
30
}
31
rel, err := cleanRel(r.PathValue("path"))
32
if err != nil || rel == "" {
33
http.NotFound(w, r)
34
return
35
}
36
rev := strings.TrimSpace(r.URL.Query().Get("rev"))
37
if rev == "" {
38
rev = repo.DefaultBranch
39
}
40
if strings.HasPrefix(rev, "-") {
41
http.NotFound(w, r)
42
return
43
}
44
dir := gitrepo.Dir(s.StoragePath(), repo.OwnerPath, repo.Name)
45
size, err := gitrepo.BlobSize(r.Context(), s.Git, dir, rev, rel)
46
if err != nil {
47
http.NotFound(w, r)
48
return
49
}
50
if size > rawMax {
51
http.Error(w, s.tr(r, "raw.tooBig"), http.StatusRequestEntityTooLarge)
52
return
53
}
54
data, err := gitrepo.BlobText(r.Context(), s.Git, dir, rev, rel)
55
if err != nil {
56
http.NotFound(w, r)
57
return
58
}
59
name := path.Base(rel)
60
ext := strings.ToLower(path.Ext(name))
61
binary := strings.Contains(data, "\x00")
62
h := w.Header()
63
h.Set("X-Content-Type-Options", "nosniff")
64
h.Set("Content-Security-Policy", "default-src 'none'; img-src 'self' data:; style-src 'unsafe-inline'; sandbox")
65
h.Set("Cache-Control", "private, no-cache")
66
if binary {
67
h.Set("X-BlueGit-Binary", "1")
68
}
69
switch {
70
case r.URL.Query().Get("download") == "1":
71
h.Set("Content-Type", "application/octet-stream")
72
h.Set("Content-Disposition", mime.FormatMediaType("attachment", map[string]string{"filename": name}))
73
case ext == ".svg" && r.URL.Query().Get("as") == "img":
74
h.Set("Content-Type", "image/svg+xml")
75
case rawImageTypes[ext] != "":
76
h.Set("Content-Type", rawImageTypes[ext])
77
case binary:
78
h.Set("Content-Type", "application/octet-stream")
79
h.Set("Content-Disposition", mime.FormatMediaType("inline", map[string]string{"filename": name}))
80
default:
81
h.Set("Content-Type", "text/plain; charset=utf-8")
82
}
83
_, _ = w.Write([]byte(data))
84
}
@@ -0,0 +1,84 @@1
package server2
3
import (4
"mime"5
"net/http"6
"path"7
"strings"8
9
"gitlab.com/Timfa/bluegit/internal/access"10
"gitlab.com/Timfa/bluegit/internal/gitrepo"11
)12
13
// rawMax: groter dan dit levert raw niet (geheugen van de server).14
const rawMax = 50 << 2015
16
// rawImageTypes worden als afbeelding geserveerd; al het andere als tekst17
// of octet-stream, zodat HTML/JS uit een repo nooit op ons domein draait.18
var rawImageTypes = map[string]string{19
".png": "image/png", ".jpg": "image/jpeg", ".jpeg": "image/jpeg", ".gif": "image/gif",20
".webp": "image/webp", ".ico": "image/x-icon", ".bmp": "image/bmp", ".avif": "image/avif",21
}22
23
// raw toont alleen de inhoud van een bestand, met dezelfde toegang als de24
// bestandsweergave. ?download=1 geeft een bijlage met de bestandsnaam;25
// ?as=img levert een .svg als image/svg+xml voor <img> (in een sandbox).26
func (s *Server) raw(w http.ResponseWriter, r *http.Request) {27
_, repo, _, ok := s.guard(w, r, access.RoleReadonly)28
if !ok {29
return30
}31
rel, err := cleanRel(r.PathValue("path"))32
if err != nil || rel == "" {33
http.NotFound(w, r)34
return35
}36
rev := strings.TrimSpace(r.URL.Query().Get("rev"))37
if rev == "" {38
rev = repo.DefaultBranch39
}40
if strings.HasPrefix(rev, "-") {41
http.NotFound(w, r)42
return43
}44
dir := gitrepo.Dir(s.StoragePath(), repo.OwnerPath, repo.Name)45
size, err := gitrepo.BlobSize(r.Context(), s.Git, dir, rev, rel)46
if err != nil {47
http.NotFound(w, r)48
return49
}50
if size > rawMax {51
http.Error(w, s.tr(r, "raw.tooBig"), http.StatusRequestEntityTooLarge)52
return53
}54
data, err := gitrepo.BlobText(r.Context(), s.Git, dir, rev, rel)55
if err != nil {56
http.NotFound(w, r)57
return58
}59
name := path.Base(rel)60
ext := strings.ToLower(path.Ext(name))61
binary := strings.Contains(data, "\x00")62
h := w.Header()63
h.Set("X-Content-Type-Options", "nosniff")64
h.Set("Content-Security-Policy", "default-src 'none'; img-src 'self' data:; style-src 'unsafe-inline'; sandbox")65
h.Set("Cache-Control", "private, no-cache")66
if binary {67
h.Set("X-BlueGit-Binary", "1")68
}69
switch {70
case r.URL.Query().Get("download") == "1":71
h.Set("Content-Type", "application/octet-stream")72
h.Set("Content-Disposition", mime.FormatMediaType("attachment", map[string]string{"filename": name}))73
case ext == ".svg" && r.URL.Query().Get("as") == "img":74
h.Set("Content-Type", "image/svg+xml")75
case rawImageTypes[ext] != "":76
h.Set("Content-Type", rawImageTypes[ext])77
case binary:78
h.Set("Content-Type", "application/octet-stream")79
h.Set("Content-Disposition", mime.FormatMediaType("inline", map[string]string{"filename": name}))80
default:81
h.Set("Content-Type", "text/plain; charset=utf-8")82
}83
_, _ = w.Write([]byte(data))84
}@@ -0,0 +1,101 @@
1
package server
2
3
import (
4
"io"
5
"net/http"
6
"os"
7
"os/exec"
8
"path/filepath"
9
"strings"
10
"testing"
11
12
"gitlab.com/Timfa/bluegit/internal/gitrepo"
13
)
14
15
func TestRawAndFileActions(t *testing.T) {
16
e := newCIEnv(t)
17
bare := gitrepo.Dir(e.srv.StoragePath(), e.repo.OwnerPath, e.repo.Name)
18
src := t.TempDir()
19
git := func(args ...string) {
20
cmd := exec.Command("git", args...)
21
cmd.Dir = src
22
cmd.Env = append(os.Environ(), "GIT_AUTHOR_NAME=t", "GIT_AUTHOR_EMAIL=t@x", "GIT_COMMITTER_NAME=t", "GIT_COMMITTER_EMAIL=t@x")
23
if out, err := cmd.CombinedOutput(); err != nil {
24
t.Fatalf("git %v: %v %s", args, err, out)
25
}
26
}
27
git("clone", "-q", bare, ".")
28
_ = os.MkdirAll(filepath.Join(src, "web"), 0o755)
29
_ = os.WriteFile(filepath.Join(src, "web", "icon.svg"), []byte(`<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 8 8"><script>alert(1)</script><rect width="8" height="8"/></svg>`), 0o644)
30
_ = os.WriteFile(filepath.Join(src, "page.html"), []byte("<script>alert(1)</script>"), 0o644)
31
_ = os.WriteFile(filepath.Join(src, "blob.bin"), []byte{0, 1, 2, 3}, 0o644)
32
git("add", ".")
33
git("commit", "-qm", "files")
34
git("push", "-q", "origin", "master")
35
c := loginClient(t, e.ts)
36
anon, err := http.Get(e.ts.URL + "/tim/app/-/raw/page.html?rev=master")
37
if err != nil {
38
t.Fatal(err)
39
}
40
anon.Body.Close()
41
if anon.StatusCode == 200 {
42
t.Fatal("private repo raw must not be anonymous")
43
}
44
get := func(p string) (*http.Response, string) {
45
res, err := c.Get(e.ts.URL + p)
46
if err != nil {
47
t.Fatal(err)
48
}
49
b, _ := io.ReadAll(res.Body)
50
res.Body.Close()
51
return res, string(b)
52
}
53
// HTML uit de repo komt als platte tekst, nooit als HTML.
54
res, body := get("/tim/app/-/raw/page.html?rev=master")
55
if res.StatusCode != 200 || !strings.HasPrefix(res.Header.Get("Content-Type"), "text/plain") || body != "<script>alert(1)</script>" || res.Header.Get("X-Content-Type-Options") != "nosniff" {
56
t.Fatalf("raw html: %d %q %q", res.StatusCode, res.Header.Get("Content-Type"), body)
57
}
58
if !strings.Contains(res.Header.Get("Content-Security-Policy"), "sandbox") {
59
t.Fatal("raw needs sandbox CSP")
60
}
61
res, _ = get("/tim/app/-/raw/web/icon.svg?rev=master")
62
if !strings.HasPrefix(res.Header.Get("Content-Type"), "text/plain") {
63
t.Fatalf("svg raw as text: %q", res.Header.Get("Content-Type"))
64
}
65
res, _ = get("/tim/app/-/raw/web/icon.svg?rev=master&as=img")
66
if res.Header.Get("Content-Type") != "image/svg+xml" {
67
t.Fatalf("svg img: %q", res.Header.Get("Content-Type"))
68
}
69
res, _ = get("/tim/app/-/raw/web/icon.svg?rev=master&download=1")
70
if cd := res.Header.Get("Content-Disposition"); !strings.Contains(cd, "attachment") || !strings.Contains(cd, "icon.svg") {
71
t.Fatalf("download: %q", cd)
72
}
73
res, _ = get("/tim/app/-/raw/blob.bin?rev=master")
74
if res.Header.Get("X-BlueGit-Binary") != "1" || res.Header.Get("Content-Type") != "application/octet-stream" {
75
t.Fatalf("binary: %v", res.Header)
76
}
77
if res, _ = get("/tim/app/-/raw/nope.txt?rev=master"); res.StatusCode != 404 {
78
t.Fatalf("missing: %d", res.StatusCode)
79
}
80
if res, _ = get("/tim/app/-/raw/../etc/passwd"); res.StatusCode == 200 {
81
t.Fatal("path escape")
82
}
83
// Bestandsweergave: knoppen altijd, SVG-voorbeeld alleen bij .svg (via <img>).
84
_, page := get("/tim/app/-/blob/web/icon.svg?rev=master")
85
for _, want := range []string{"data-copy-file=", "download=\"icon.svg\"", "target=\"_blank\"", "class=\"svgpreview\"", "as=img"} {
86
if !strings.Contains(page, want) {
87
t.Fatalf("svg page lacks %s", want)
88
}
89
}
90
if strings.Contains(page, "<svg xmlns=\"http://www.w3.org/2000/svg\" viewBox=\"0 0 8 8\"><script>") {
91
t.Fatal("svg must never be inlined")
92
}
93
_, page = get("/tim/app/-/blob/README.md?rev=master")
94
if strings.Contains(page, "class=\"svgpreview\"") || !strings.Contains(page, "data-copy-file=") {
95
t.Fatal("readme: buttons yes, preview no")
96
}
97
_, page = get("/tim/app/-/blob/blob.bin?rev=master")
98
if !strings.Contains(page, "disabled aria-disabled=\"true\"") {
99
t.Fatal("binary copy must be disabled")
100
}
101
}
@@ -0,0 +1,101 @@1
package server2
3
import (4
"io"5
"net/http"6
"os"7
"os/exec"8
"path/filepath"9
"strings"10
"testing"11
12
"gitlab.com/Timfa/bluegit/internal/gitrepo"13
)14
15
func TestRawAndFileActions(t *testing.T) {16
e := newCIEnv(t)17
bare := gitrepo.Dir(e.srv.StoragePath(), e.repo.OwnerPath, e.repo.Name)18
src := t.TempDir()19
git := func(args ...string) {20
cmd := exec.Command("git", args...)21
cmd.Dir = src22
cmd.Env = append(os.Environ(), "GIT_AUTHOR_NAME=t", "GIT_AUTHOR_EMAIL=t@x", "GIT_COMMITTER_NAME=t", "GIT_COMMITTER_EMAIL=t@x")23
if out, err := cmd.CombinedOutput(); err != nil {24
t.Fatalf("git %v: %v %s", args, err, out)25
}26
}27
git("clone", "-q", bare, ".")28
_ = os.MkdirAll(filepath.Join(src, "web"), 0o755)29
_ = os.WriteFile(filepath.Join(src, "web", "icon.svg"), []byte(`<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 8 8"><script>alert(1)</script><rect width="8" height="8"/></svg>`), 0o644)30
_ = os.WriteFile(filepath.Join(src, "page.html"), []byte("<script>alert(1)</script>"), 0o644)31
_ = os.WriteFile(filepath.Join(src, "blob.bin"), []byte{0, 1, 2, 3}, 0o644)32
git("add", ".")33
git("commit", "-qm", "files")34
git("push", "-q", "origin", "master")35
c := loginClient(t, e.ts)36
anon, err := http.Get(e.ts.URL + "/tim/app/-/raw/page.html?rev=master")37
if err != nil {38
t.Fatal(err)39
}40
anon.Body.Close()41
if anon.StatusCode == 200 {42
t.Fatal("private repo raw must not be anonymous")43
}44
get := func(p string) (*http.Response, string) {45
res, err := c.Get(e.ts.URL + p)46
if err != nil {47
t.Fatal(err)48
}49
b, _ := io.ReadAll(res.Body)50
res.Body.Close()51
return res, string(b)52
}53
// HTML uit de repo komt als platte tekst, nooit als HTML.54
res, body := get("/tim/app/-/raw/page.html?rev=master")55
if res.StatusCode != 200 || !strings.HasPrefix(res.Header.Get("Content-Type"), "text/plain") || body != "<script>alert(1)</script>" || res.Header.Get("X-Content-Type-Options") != "nosniff" {56
t.Fatalf("raw html: %d %q %q", res.StatusCode, res.Header.Get("Content-Type"), body)57
}58
if !strings.Contains(res.Header.Get("Content-Security-Policy"), "sandbox") {59
t.Fatal("raw needs sandbox CSP")60
}61
res, _ = get("/tim/app/-/raw/web/icon.svg?rev=master")62
if !strings.HasPrefix(res.Header.Get("Content-Type"), "text/plain") {63
t.Fatalf("svg raw as text: %q", res.Header.Get("Content-Type"))64
}65
res, _ = get("/tim/app/-/raw/web/icon.svg?rev=master&as=img")66
if res.Header.Get("Content-Type") != "image/svg+xml" {67
t.Fatalf("svg img: %q", res.Header.Get("Content-Type"))68
}69
res, _ = get("/tim/app/-/raw/web/icon.svg?rev=master&download=1")70
if cd := res.Header.Get("Content-Disposition"); !strings.Contains(cd, "attachment") || !strings.Contains(cd, "icon.svg") {71
t.Fatalf("download: %q", cd)72
}73
res, _ = get("/tim/app/-/raw/blob.bin?rev=master")74
if res.Header.Get("X-BlueGit-Binary") != "1" || res.Header.Get("Content-Type") != "application/octet-stream" {75
t.Fatalf("binary: %v", res.Header)76
}77
if res, _ = get("/tim/app/-/raw/nope.txt?rev=master"); res.StatusCode != 404 {78
t.Fatalf("missing: %d", res.StatusCode)79
}80
if res, _ = get("/tim/app/-/raw/../etc/passwd"); res.StatusCode == 200 {81
t.Fatal("path escape")82
}83
// Bestandsweergave: knoppen altijd, SVG-voorbeeld alleen bij .svg (via <img>).84
_, page := get("/tim/app/-/blob/web/icon.svg?rev=master")85
for _, want := range []string{"data-copy-file=", "download=\"icon.svg\"", "target=\"_blank\"", "class=\"svgpreview\"", "as=img"} {86
if !strings.Contains(page, want) {87
t.Fatalf("svg page lacks %s", want)88
}89
}90
if strings.Contains(page, "<svg xmlns=\"http://www.w3.org/2000/svg\" viewBox=\"0 0 8 8\"><script>") {91
t.Fatal("svg must never be inlined")92
}93
_, page = get("/tim/app/-/blob/README.md?rev=master")94
if strings.Contains(page, "class=\"svgpreview\"") || !strings.Contains(page, "data-copy-file=") {95
t.Fatal("readme: buttons yes, preview no")96
}97
_, page = get("/tim/app/-/blob/blob.bin?rev=master")98
if !strings.Contains(page, "disabled aria-disabled=\"true\"") {99
t.Fatal("binary copy must be disabled")100
}101
}@@ -178,6 +178,7 @@ func (s *Server) Handler() http.Handler {
178
178
mux.HandleFunc("GET /{owner}/{repo}/-/tree", s.treeRoot)
179
179
mux.HandleFunc("GET /{owner}/{repo}/-/tree/{path...}", s.tree)
180
180
mux.HandleFunc("GET /{owner}/{repo}/-/blob/{path...}", s.blob)
181
mux.HandleFunc("GET /{owner}/{repo}/-/raw/{path...}", s.raw)
181
182
mux.HandleFunc("GET /{owner}/{repo}/-/commits", s.commits)
182
183
mux.HandleFunc("GET /{owner}/{repo}/-/tags", s.tags)
183
184
mux.HandleFunc("POST /{owner}/{repo}/-/tags", s.createTag)
@@ -707,6 +708,7 @@ type View struct {
707
708
Created string
708
709
Lines []CodeLine
709
710
BlobSize string
711
IsSVG bool
710
712
FileName string
711
713
RevProtected bool
712
714
Heat *activity.Calendar
@@ -178,6 +178,7 @@ func (s *Server) Handler() http.Handler {178
mux.HandleFunc("GET /{owner}/{repo}/-/tree", s.treeRoot)178
mux.HandleFunc("GET /{owner}/{repo}/-/tree", s.treeRoot)179
mux.HandleFunc("GET /{owner}/{repo}/-/tree/{path...}", s.tree)179
mux.HandleFunc("GET /{owner}/{repo}/-/tree/{path...}", s.tree)180
mux.HandleFunc("GET /{owner}/{repo}/-/blob/{path...}", s.blob)180
mux.HandleFunc("GET /{owner}/{repo}/-/blob/{path...}", s.blob)181
mux.HandleFunc("GET /{owner}/{repo}/-/raw/{path...}", s.raw)181
mux.HandleFunc("GET /{owner}/{repo}/-/commits", s.commits)182
mux.HandleFunc("GET /{owner}/{repo}/-/commits", s.commits)182
mux.HandleFunc("GET /{owner}/{repo}/-/tags", s.tags)183
mux.HandleFunc("GET /{owner}/{repo}/-/tags", s.tags)183
mux.HandleFunc("POST /{owner}/{repo}/-/tags", s.createTag)184
mux.HandleFunc("POST /{owner}/{repo}/-/tags", s.createTag)@@ -707,6 +708,7 @@ type View struct {707
Created string708
Created string708
Lines []CodeLine709
Lines []CodeLine709
BlobSize string710
BlobSize string711
IsSVG bool710
FileName string712
FileName string711
RevProtected bool713
RevProtected bool712
Heat *activity.Calendar714
Heat *activity.Calendar@@ -58,7 +58,14 @@
58
58
okBtn.focus({ preventScroll: true });
59
59
return new Promise(function (res) { resolveFn = res; });
60
60
}
61
window.BGModal = { confirm: ask };
61
// BGModal.alert(tekst, {title, ok}) → Promise: alleen een OK-knop.
62
function alertBox(text, opt) {
63
opt = opt || {};
64
var p = ask(text, { title: opt.title, ok: opt.ok || txt("close", "OK") });
65
cancelBtn.style.display = "none";
66
return p.then(function (v) { cancelBtn.style.display = ""; return v; });
67
}
68
window.BGModal = { confirm: ask, alert: alertBox };
62
69
document.addEventListener("submit", function (ev) {
63
70
var form = ev.target;
64
71
if (!form || !form.getAttribute) { return; }
@@ -58,7 +58,14 @@58
okBtn.focus({ preventScroll: true });58
okBtn.focus({ preventScroll: true });59
return new Promise(function (res) { resolveFn = res; });59
return new Promise(function (res) { resolveFn = res; });60
}60
}61
window.BGModal = { confirm: ask };61
// BGModal.alert(tekst, {title, ok}) → Promise: alleen een OK-knop.62
function alertBox(text, opt) {63
opt = opt || {};64
var p = ask(text, { title: opt.title, ok: opt.ok || txt("close", "OK") });65
cancelBtn.style.display = "none";66
return p.then(function (v) { cancelBtn.style.display = ""; return v; });67
}68
window.BGModal = { confirm: ask, alert: alertBox };62
document.addEventListener("submit", function (ev) {69
document.addEventListener("submit", function (ev) {63
var form = ev.target;70
var form = ev.target;64
if (!form || !form.getAttribute) { return; }71
if (!form || !form.getAttribute) { return; }@@ -151,3 +151,36 @@
151
151
}
152
152
}
153
153
})();
154
155
// Bestandskaart: Copy zet de inhoud in het klembord; fouten in een eigen
156
// modal. SVG-voorbeeld: lege/ongeldige SVG toont een lege staat.
157
(function () {
158
document.querySelectorAll("[data-copy-file]").forEach(function (btn) {
159
btn.addEventListener("click", function () {
160
if (btn.disabled) { return; }
161
var fail = function () {
162
var m = window.BGModal;
163
if (m && m.alert) { m.alert(btn.getAttribute("data-copy-fail"), { title: btn.getAttribute("data-copy-title"), ok: btn.getAttribute("data-copy-close") }); }
164
};
165
fetch(btn.getAttribute("data-copy-file"), { credentials: "same-origin" }).then(function (res) {
166
if (!res.ok || res.headers.get("X-BlueGit-Binary") === "1") { throw new Error("raw"); }
167
return res.text();
168
}).then(function (text) {
169
if (!navigator.clipboard || !window.isSecureContext) { throw new Error("clipboard"); }
170
return navigator.clipboard.writeText(text);
171
}).then(function () {
172
var old = btn.textContent;
173
btn.textContent = btn.getAttribute("data-copy-ok");
174
setTimeout(function () { btn.textContent = old; }, 2000);
175
}).catch(fail);
176
});
177
});
178
document.querySelectorAll("[data-svg-preview]").forEach(function (img) {
179
var empty = function () {
180
img.hidden = true;
181
var c = img.parentNode.querySelector("[data-svg-empty]");
182
if (c) { c.hidden = false; }
183
};
184
img.addEventListener("error", empty);
185
});
186
})();
@@ -151,3 +151,36 @@151
}151
}152
}152
}153
})();153
})();154
155
// Bestandskaart: Copy zet de inhoud in het klembord; fouten in een eigen156
// modal. SVG-voorbeeld: lege/ongeldige SVG toont een lege staat.157
(function () {158
document.querySelectorAll("[data-copy-file]").forEach(function (btn) {159
btn.addEventListener("click", function () {160
if (btn.disabled) { return; }161
var fail = function () {162
var m = window.BGModal;163
if (m && m.alert) { m.alert(btn.getAttribute("data-copy-fail"), { title: btn.getAttribute("data-copy-title"), ok: btn.getAttribute("data-copy-close") }); }164
};165
fetch(btn.getAttribute("data-copy-file"), { credentials: "same-origin" }).then(function (res) {166
if (!res.ok || res.headers.get("X-BlueGit-Binary") === "1") { throw new Error("raw"); }167
return res.text();168
}).then(function (text) {169
if (!navigator.clipboard || !window.isSecureContext) { throw new Error("clipboard"); }170
return navigator.clipboard.writeText(text);171
}).then(function () {172
var old = btn.textContent;173
btn.textContent = btn.getAttribute("data-copy-ok");174
setTimeout(function () { btn.textContent = old; }, 2000);175
}).catch(fail);176
});177
});178
document.querySelectorAll("[data-svg-preview]").forEach(function (img) {179
var empty = function () {180
img.hidden = true;181
var c = img.parentNode.querySelector("[data-svg-empty]");182
if (c) { c.hidden = false; }183
};184
img.addEventListener("error", empty);185
});186
})();@@ -1474,3 +1474,15 @@ table.kv td, table.kv th { overflow-wrap: anywhere; word-break: break-word; }
1474
1474
table.adminusers td.act, table.adminusers td.act form { display: block; width: 100%; }
1475
1475
}
1476
1476
.piperetry[hidden], details.piperetry[hidden] { display: none !important; }
1477
1478
/* Bestandskaart: acties en SVG-voorbeeld */
1479
.codebox header.codehead { display: flex; align-items: center; justify-content: space-between; gap: 0.6rem; flex-wrap: wrap; }
1480
.codehead .fileacts { display: inline-flex; gap: 0.4rem; font-weight: 400; }
1481
.codebox { position: relative; }
1482
.svgpreview { position: absolute; top: 3.4rem; right: 1rem; z-index: 2; margin: 0; width: 12rem; height: 12rem; background: #fff; border: 1px solid var(--line); border-radius: 6px; display: flex; align-items: center; justify-content: center; padding: 0.5rem; box-shadow: 0 2px 8px rgba(0,0,0,.25); }
1483
.svgpreview img { max-width: 100%; max-height: 100%; object-fit: contain; }
1484
.svgpreview figcaption { color: #555; font-size: 0.85rem; text-align: center; }
1485
@media (max-width: 760px) {
1486
.svgpreview { position: static; margin: 0.6rem 1rem; width: auto; height: 10rem; }
1487
}
1488
.codehead .fileacts button:disabled { opacity: 0.45; cursor: not-allowed; }
@@ -1474,3 +1474,15 @@ table.kv td, table.kv th { overflow-wrap: anywhere; word-break: break-word; }1474
table.adminusers td.act, table.adminusers td.act form { display: block; width: 100%; }1474
table.adminusers td.act, table.adminusers td.act form { display: block; width: 100%; }1475
}1475
}1476
.piperetry[hidden], details.piperetry[hidden] { display: none !important; }1476
.piperetry[hidden], details.piperetry[hidden] { display: none !important; }1477
1478
/* Bestandskaart: acties en SVG-voorbeeld */1479
.codebox header.codehead { display: flex; align-items: center; justify-content: space-between; gap: 0.6rem; flex-wrap: wrap; }1480
.codehead .fileacts { display: inline-flex; gap: 0.4rem; font-weight: 400; }1481
.codebox { position: relative; }1482
.svgpreview { position: absolute; top: 3.4rem; right: 1rem; z-index: 2; margin: 0; width: 12rem; height: 12rem; background: #fff; border: 1px solid var(--line); border-radius: 6px; display: flex; align-items: center; justify-content: center; padding: 0.5rem; box-shadow: 0 2px 8px rgba(0,0,0,.25); }1483
.svgpreview img { max-width: 100%; max-height: 100%; object-fit: contain; }1484
.svgpreview figcaption { color: #555; font-size: 0.85rem; text-align: center; }1485
@media (max-width: 760px) {1486
.svgpreview { position: static; margin: 0.6rem 1rem; width: auto; height: 10rem; }1487
}1488
.codehead .fileacts button:disabled { opacity: 0.45; cursor: not-allowed; }@@ -550,7 +550,15 @@
550
550
<h2 class="filename">{{template "ficon" (iconOf .FileName)}} {{.FileName}}</h2>
551
551
{{template "commitbar" .}}
552
552
<article class="codebox">
553
<header>{{template "ficon" (iconOf .FileName)}} {{.FileName}} <span class="muted">{{.BlobSize}}</span></header>
553
{{$raw := printf "/%s/-/raw/%s?rev=%s" .Repo.FullPath .BlobPath .Rev}}
554
<header class="codehead"><span class="codename">{{template "ficon" (iconOf .FileName)}} {{.FileName}} <span class="muted">{{.BlobSize}}</span></span>
555
<span class="fileacts">
556
<a class="btn ghost small" href="{{$raw}}&download=1" download="{{.FileName}}" title="{{t "file.tip.download" .FileName}}">{{t "file.download"}}</a>
557
<a class="btn ghost small" href="{{$raw}}" target="_blank" rel="noopener" title="{{t "file.tip.raw"}}">{{t "file.raw"}}</a>
558
<button type="button" class="ghost small" data-copy-file="{{$raw}}"{{if .Binary}} disabled aria-disabled="true" title="{{t "file.tip.copyBinary"}}"{{else}} title="{{t "file.tip.copy"}}"{{end}} data-copy-ok="{{t "file.copied"}}" data-copy-fail="{{t "file.copyFail"}}" data-copy-title="{{t "file.copyFailTitle"}}" data-copy-close="{{t "action.close"}}">{{t "file.copy"}}</button>
559
</span>
560
</header>
561
{{if .IsSVG}}<figure class="svgpreview" aria-label="{{t "file.svgPreview"}}"><img src="{{$raw}}&as=img" alt="{{.FileName}}" data-svg-preview><figcaption class="muted" hidden data-svg-empty>{{t "file.svgEmpty"}}</figcaption></figure>{{end}}
554
562
{{if .Binary}}<p>{{t "repo.binary"}}</p>{{else}}
555
563
<table class="code">
556
564
{{range .Lines}}<tr><td class="ln">{{.N}}</td><td class="src">{{.HTML}}</td></tr>{{end}}
@@ -550,7 +550,15 @@550
<h2 class="filename">{{template "ficon" (iconOf .FileName)}} {{.FileName}}</h2>550
<h2 class="filename">{{template "ficon" (iconOf .FileName)}} {{.FileName}}</h2>551
{{template "commitbar" .}}551
{{template "commitbar" .}}552
<article class="codebox">552
<article class="codebox">553
<header>{{template "ficon" (iconOf .FileName)}} {{.FileName}} <span class="muted">{{.BlobSize}}</span></header>553
{{$raw := printf "/%s/-/raw/%s?rev=%s" .Repo.FullPath .BlobPath .Rev}}554
<header class="codehead"><span class="codename">{{template "ficon" (iconOf .FileName)}} {{.FileName}} <span class="muted">{{.BlobSize}}</span></span>555
<span class="fileacts">556
<a class="btn ghost small" href="{{$raw}}&download=1" download="{{.FileName}}" title="{{t "file.tip.download" .FileName}}">{{t "file.download"}}</a>557
<a class="btn ghost small" href="{{$raw}}" target="_blank" rel="noopener" title="{{t "file.tip.raw"}}">{{t "file.raw"}}</a>558
<button type="button" class="ghost small" data-copy-file="{{$raw}}"{{if .Binary}} disabled aria-disabled="true" title="{{t "file.tip.copyBinary"}}"{{else}} title="{{t "file.tip.copy"}}"{{end}} data-copy-ok="{{t "file.copied"}}" data-copy-fail="{{t "file.copyFail"}}" data-copy-title="{{t "file.copyFailTitle"}}" data-copy-close="{{t "action.close"}}">{{t "file.copy"}}</button>559
</span>560
</header>561
{{if .IsSVG}}<figure class="svgpreview" aria-label="{{t "file.svgPreview"}}"><img src="{{$raw}}&as=img" alt="{{.FileName}}" data-svg-preview><figcaption class="muted" hidden data-svg-empty>{{t "file.svgEmpty"}}</figcaption></figure>{{end}}554
{{if .Binary}}<p>{{t "repo.binary"}}</p>{{else}}562
{{if .Binary}}<p>{{t "repo.binary"}}</p>{{else}}555
<table class="code">563
<table class="code">556
{{range .Lines}}<tr><td class="ln">{{.N}}</td><td class="src">{{.HTML}}</td></tr>{{end}}564
{{range .Lines}}<tr><td class="ln">{{.N}}</td><td class="src">{{.HTML}}</td></tr>{{end}}