| 1 | package runner |
| 2 | |
| 3 | import ( |
| 4 | "context" |
| 5 | "path/filepath" |
| 6 | "testing" |
| 7 | |
| 8 | "gitlab.com/Timfa/bluegit/internal/access" |
| 9 | "gitlab.com/Timfa/bluegit/internal/store" |
| 10 | ) |
| 11 | |
| 12 | // Jobs op beschermde refs: alleen ingebouwd, globaal, groepsrunner en |
| 13 | // account-runners van maintainers/admins. Niet-beschermd: zoals voorheen. |
| 14 | func TestProtectedRefRunners(t *testing.T) { |
| 15 | s, err := store.Open(filepath.Join(t.TempDir(), "b.db"), make([]byte, 32)) |
| 16 | if err != nil { |
| 17 | t.Fatal(err) |
| 18 | } |
| 19 | defer s.Close() |
| 20 | ctx := context.Background() |
| 21 | tim, _ := s.UpsertUser(ctx, 1, "tim", "", false) |
| 22 | _, _ = s.UpsertUser(ctx, 2, "dev", "", false) |
| 23 | _, _ = s.UpsertUser(ctx, 3, "boss", "", false) |
| 24 | adm, _ := s.UpsertUser(ctx, 4, "adm", "", false) |
| 25 | if _, err := s.SetInstanceAdmin(ctx, tim.ID, adm.ID, true); err != nil { |
| 26 | t.Fatal(err) |
| 27 | } |
| 28 | g, _ := s.CreateGroup(ctx, tim.ID, "Team", "team", "", access.RoleReadonly) |
| 29 | _ = s.SetMember(ctx, "group", g.ID, "dev", access.RoleDeveloper) |
| 30 | _ = s.SetMember(ctx, "group", g.ID, "boss", access.RoleMaintainer) |
| 31 | _ = s.SetMember(ctx, "group", g.ID, "adm", access.RoleReadonly) |
| 32 | repo, _ := s.CreateRepo(ctx, "group", g.ID, "app", "", "master", "private") |
| 33 | reg := func(kind string, id int64, name string) store.Runner { |
| 34 | tok, _ := s.CreateRunnerRegToken(ctx, kind, id, tim.ID) |
| 35 | rn, _, err := s.RegisterRunner(ctx, tok, name, "test") |
| 36 | if err != nil { |
| 37 | t.Fatal(err) |
| 38 | } |
| 39 | return rn |
| 40 | } |
| 41 | u := func(n string) int64 { x, _ := s.UserByUsername(ctx, n); return x.ID } |
| 42 | reg("group", g.ID, "grp") |
| 43 | reg(store.RunnerGlobal, 0, "glob") |
| 44 | devRn := reg("user", u("dev"), "dev-pc") |
| 45 | bossRn := reg("user", u("boss"), "boss-pc") |
| 46 | admRn := reg("user", adm.ID, "adm-pc") |
| 47 | for _, n := range []string{"dev", "boss", "adm"} { |
| 48 | _ = s.SetRunnerOptIn(ctx, g.ID, u(n), true) |
| 49 | } |
| 50 | tiers, _ := Tiers(ctx, s, repo, false) |
| 51 | eq(t, names(tiers), "glob", "grp", "dev-pc+boss-pc+adm-pc", "builtin") |
| 52 | tiers, _ = Tiers(ctx, s, repo, true) |
| 53 | eq(t, names(tiers), "glob", "grp", "boss-pc+adm-pc", "builtin") |
| 54 | if ex := ExcludedForProtected(ctx, s, repo); len(ex) != 1 || ex[0] != "dev-pc" { |
| 55 | t.Fatalf("excluded: %v", ex) |
| 56 | } |
| 57 | r := &Runner{Store: s} |
| 58 | if r.mayRun(ctx, devRn, repo, true) || !r.mayRun(ctx, devRn, repo, false) { |
| 59 | t.Fatal("dev runner: protected no, unprotected yes") |
| 60 | } |
| 61 | if !r.mayRun(ctx, bossRn, repo, true) || !r.mayRun(ctx, admRn, repo, true) { |
| 62 | t.Fatal("maintainer/admin runner must run protected") |
| 63 | } |
| 64 | // Ingetrokken: boss wordt developer → meteen niet meer voor beschermd. |
| 65 | if err := s.SetMember(ctx, "group", g.ID, "boss", access.RoleDeveloper); err != nil { |
| 66 | t.Fatal(err) |
| 67 | } |
| 68 | // Een nieuwe groepsrepo kan expliciete repo-rollen hebben; die ook omlaag. |
| 69 | _ = s.SetMember(ctx, "repo", repo.ID, "boss", access.RoleDeveloper) |
| 70 | if role, _ := s.EffectiveRole(ctx, u("boss"), repo.ID); role.AtLeast(access.RoleMaintainer) { |
| 71 | t.Fatalf("boss role %s", role) |
| 72 | } |
| 73 | if r.mayRun(ctx, bossRn, repo, true) { |
| 74 | t.Fatal("demoted boss still runs protected") |
| 75 | } |
| 76 | tiers, _ = Tiers(ctx, s, repo, true) |
| 77 | eq(t, names(tiers), "glob", "grp", "adm-pc", "builtin") |
| 78 | // Alleen opt-in-runners van developers: de beschermde job valt door |
| 79 | // naar groep/ingebouwd, nooit naar dev-pc. |
| 80 | _ = s.SetRunnerOptIn(ctx, g.ID, adm.ID, false) |
| 81 | tiers, _ = Tiers(ctx, s, repo, true) |
| 82 | eq(t, names(tiers), "glob", "grp", "builtin") |
| 83 | } |