BlueGit

timfa bluegit

Files

bluegit / internal / server / suggest_test.go

suggest_test.go

feat: suggesties op merge requests
timfa project_87923614_bot_3aff574f6f98414b945a8799374f9092 · pushed by timfa · 3 weeks ago
Failed 3902d232 History
suggest_test.go 9.9 KiB Download Raw
1package server
2
3import (
4 "context"
5 "net/http"
6 "net/http/cookiejar"
7 "net/http/httptest"
8 "net/url"
9 "os/exec"
10 "path/filepath"
11 "strings"
12 "testing"
13 "time"
14
15 "gitlab.com/Timfa/bluegit/internal/auth"
16 "gitlab.com/Timfa/bluegit/internal/config"
17 "gitlab.com/Timfa/bluegit/internal/gitrepo"
18 "gitlab.com/Timfa/bluegit/internal/store"
19)
20
21func TestSuggestionsAndReadonlyComments(t *testing.T) {
22 if _, err := exec.LookPath("git"); err != nil {
23 t.Skip("git ontbreekt")
24 }
25 storage := t.TempDir()
26 st, err := store.Open(filepath.Join(storage, "bluegit.db"), bytes32())
27 if err != nil {
28 t.Fatal(err)
29 }
30 t.Cleanup(func() { _ = st.Close() })
31 cfg := config.Config{
32 BaseURL: "http://127.0.0.1:9", Listen: "127.0.0.1:0", StoragePath: storage,
33 Auth: config.Auth{Mode: "dev", DevUser: "tim", DevAuthID: 1, UserAgent: "test"},
34 Git: config.Git{Binary: "git", DefaultBranch: "master"},
35 }
36 srv := &Server{Cfg: cfg, Store: st, Auth: auth.Dev{Username: "tim", AuthID: 1}, Dev: true, Git: "git", HookBin: "/bin/true"}
37 ts := httptest.NewServer(srv.Handler())
38 t.Cleanup(ts.Close)
39
40 jar, _ := cookiejar.New(nil)
41 tim := &http.Client{Jar: jar}
42 res, err := tim.Get(ts.URL + "/login")
43 if err != nil {
44 t.Fatal(err)
45 }
46 page := read(t, res)
47 res, err = tim.PostForm(ts.URL+"/new/repo", url.Values{
48 "csrf": {csrfOf(t, page)}, "name": {"review"}, "visibility": {"public"},
49 })
50 if err != nil {
51 t.Fatal(err)
52 }
53 page = read(t, res)
54 res, err = tim.PostForm(ts.URL+"/settings/tokens", url.Values{"csrf": {csrfOf(t, page)}, "name": {"laptop"}})
55 if err != nil {
56 t.Fatal(err)
57 }
58 token := between(read(t, res), `<p class="code">`, "</p>")
59 remote := strings.Replace(ts.URL, "http://", "http://tim:"+token+"@", 1) + "/tim/review.git"
60 work := t.TempDir()
61 git(t, work, "init", "-b", "master")
62 git(t, work, "config", "user.email", "tim@users.git.timfalken.com")
63 git(t, work, "config", "user.name", "tim")
64 writeFile(t, filepath.Join(work, "hello.txt"), "alpha\nbeta\ngamma\n")
65 git(t, work, "add", "hello.txt")
66 git(t, work, "commit", "-m", "start")
67 git(t, work, "remote", "add", "origin", remote)
68 git(t, work, "push", "-u", "origin", "master")
69 git(t, work, "checkout", "-b", "feature")
70 writeFile(t, filepath.Join(work, "hello.txt"), "alpha\nBETA\ngamma\n")
71 git(t, work, "add", "hello.txt")
72 git(t, work, "commit", "-m", "hoofdletters")
73 git(t, work, "push", "-u", "origin", "feature")
74
75 res, err = tim.Get(ts.URL + "/tim/review/-/merge-requests")
76 if err != nil {
77 t.Fatal(err)
78 }
79 page = read(t, res)
80 res, err = tim.PostForm(ts.URL+"/tim/review/-/merge-requests", url.Values{
81 "csrf": {csrfOf(t, page)}, "title": {"Hoofdletters"}, "source": {"feature"}, "target": {"master"},
82 })
83 if err != nil {
84 t.Fatal(err)
85 }
86 opened := read(t, res)
87 if !strings.Contains(opened, "BETA") || !strings.Contains(opened, `data-line="2"`) || !strings.Contains(opened, "Apply suggestions") {
88 t.Fatalf("diff of toepassen:\n%s", opened)
89 }
90
91 ctx := context.Background()
92 repo, err := st.RepoByPath(ctx, "tim", "review")
93 if err != nil {
94 t.Fatal(err)
95 }
96 bob, err := st.UpsertUser(ctx, 2, "bob", "", false)
97 if err != nil {
98 t.Fatal(err)
99 }
100 ada, err := st.UpsertUser(ctx, 3, "ada", "", false)
101 if err != nil {
102 t.Fatal(err)
103 }
104 sam, err := st.UpsertUser(ctx, 4, "sam", "", false)
105 if err != nil {
106 t.Fatal(err)
107 }
108 if err := st.SetMember(ctx, "repo", repo.ID, "bob", "readonly"); err != nil {
109 t.Fatal(err)
110 }
111 if err := st.SetMember(ctx, "repo", repo.ID, "ada", "developer"); err != nil {
112 t.Fatal(err)
113 }
114 bobC := clientAs(t, ts.URL, st, bob.ID)
115 adaC := clientAs(t, ts.URL, st, ada.ID)
116 samC := clientAs(t, ts.URL, st, sam.ID)
117
118 res, err = samC.Get(ts.URL + "/tim/review/-/merge-requests/1")
119 if err != nil {
120 t.Fatal(err)
121 }
122 samPage := read(t, res)
123 if strings.Contains(samPage, `name="body"`) || strings.Contains(samPage, "data-can-comment") {
124 t.Fatal("zonder rol is er een reactieformulier")
125 }
126 res, err = samC.PostForm(ts.URL+"/tim/review/-/merge-requests/1/notes", url.Values{
127 "csrf": {csrfOf(t, samPage)}, "body": {"hoort niet"},
128 })
129 if err != nil {
130 t.Fatal(err)
131 }
132 if res.StatusCode != http.StatusForbidden {
133 t.Fatalf("sam status %d", res.StatusCode)
134 }
135 _ = read(t, res)
136
137 res, err = bobC.Get(ts.URL + "/tim/review/-/merge-requests/1")
138 if err != nil {
139 t.Fatal(err)
140 }
141 bobPage := read(t, res)
142 if !strings.Contains(bobPage, `data-can-comment="1"`) || !strings.Contains(bobPage, `class="gutter"`) {
143 t.Fatal("readonly mist de diffbalk")
144 }
145 if strings.Contains(bobPage, "data-suggestion") || strings.Contains(bobPage, "Apply suggestions") {
146 t.Fatal("readonly kan suggesties aanvinken")
147 }
148 res, err = bobC.PostForm(ts.URL+"/tim/review/-/merge-requests/1/notes", url.Values{
149 "csrf": {csrfOf(t, bobPage)}, "body": {"algemeen"},
150 })
151 if err != nil {
152 t.Fatal(err)
153 }
154 bobPage = read(t, res)
155 if !strings.Contains(bobPage, "algemeen") {
156 t.Fatal("algemene reactie ontbreekt")
157 }
158 res, err = bobC.PostForm(ts.URL+"/tim/review/-/merge-requests/1/notes", url.Values{
159 "csrf": {csrfOf(t, bobPage)}, "path": {"hello.txt"}, "line_start": {"2"}, "line_end": {"2"},
160 "body": {"```suggestion\nfixed\n```"},
161 })
162 if err != nil {
163 t.Fatal(err)
164 }
165 bobPage = read(t, res)
166 if !strings.Contains(bobPage, "fixed") || strings.Contains(bobPage, "data-suggestion") {
167 t.Fatalf("regelreactie:\n%s", bobPage)
168 }
169 res, err = bobC.PostForm(ts.URL+"/tim/review/-/merge-requests/1/suggestions", url.Values{
170 "csrf": {csrfOf(t, bobPage)}, "id": {"2"}, "title": {"mag niet"},
171 })
172 if err != nil {
173 t.Fatal(err)
174 }
175 if res.StatusCode != http.StatusForbidden {
176 t.Fatalf("readonly toepassen %d", res.StatusCode)
177 }
178 _ = read(t, res)
179
180 writeFile(t, filepath.Join(work, "hello.txt"), "alpha\nBETA2\ngamma\n")
181 git(t, work, "add", "hello.txt")
182 git(t, work, "commit", "-m", "intussen")
183 git(t, work, "push", "origin", "feature")
184
185 res, err = adaC.Get(ts.URL + "/tim/review/-/merge-requests/1")
186 if err != nil {
187 t.Fatal(err)
188 }
189 adaPage := read(t, res)
190 ids := suggestionIDs(adaPage)
191 if len(ids) != 1 {
192 t.Fatalf("suggesties %v\n%s", ids, adaPage)
193 }
194 res, err = adaC.PostForm(ts.URL+"/tim/review/-/merge-requests/1/suggestions", url.Values{
195 "csrf": {csrfOf(t, adaPage)}, "id": {ids[0]}, "title": {"te laat"},
196 })
197 if err != nil {
198 t.Fatal(err)
199 }
200 conflict := read(t, res)
201 if !strings.Contains(conflict, "hello.txt:2-2 has changed") {
202 t.Fatalf("conflict:\n%s", conflict)
203 }
204
205 res, err = bobC.Get(ts.URL + "/tim/review/-/merge-requests/1")
206 if err != nil {
207 t.Fatal(err)
208 }
209 bobPage = read(t, res)
210 res, err = bobC.PostForm(ts.URL+"/tim/review/-/merge-requests/1/notes", url.Values{
211 "csrf": {csrfOf(t, bobPage)}, "path": {"hello.txt"}, "line_start": {"2"}, "line_end": {"3"},
212 "body": {"```suggestion\nfixed\nGAMMA\n```"},
213 })
214 if err != nil {
215 t.Fatal(err)
216 }
217 _ = read(t, res)
218
219 if err := st.AddProtected(ctx, repo.ID, "feature"); err != nil {
220 t.Fatal(err)
221 }
222 res, err = adaC.Get(ts.URL + "/tim/review/-/merge-requests/1")
223 if err != nil {
224 t.Fatal(err)
225 }
226 adaPage = read(t, res)
227 if strings.Contains(adaPage, "data-suggestion") {
228 t.Fatal("ontwikkelaar ziet een vakje op een beschermde bronbranch")
229 }
230 fresh := suggestionIDs(read(t, mustGet(t, tim, ts.URL+"/tim/review/-/merge-requests/1")))
231 if len(fresh) != 2 {
232 t.Fatalf("beheerder ziet %v", fresh)
233 }
234 res, err = adaC.PostForm(ts.URL+"/tim/review/-/merge-requests/1/suggestions", url.Values{
235 "csrf": {csrfOf(t, adaPage)}, "id": {fresh[1]}, "title": {"van ada"},
236 })
237 if err != nil {
238 t.Fatal(err)
239 }
240 denied := read(t, res)
241 if !strings.Contains(denied, "you cannot push to feature") {
242 t.Fatalf("beschermd:\n%s", denied)
243 }
244
245 bare := gitrepo.Dir(storage, "tim", "review")
246 before := strings.TrimSpace(mustGit(t, bare, "rev-list", "--count", "feature"))
247 res, err = tim.Get(ts.URL + "/tim/review/-/merge-requests/1")
248 if err != nil {
249 t.Fatal(err)
250 }
251 timPage := read(t, res)
252 res, err = tim.PostForm(ts.URL+"/tim/review/-/merge-requests/1/suggestions", url.Values{
253 "csrf": {csrfOf(t, timPage)}, "id": {fresh[1]}, "title": {"Suggestie van bob"}, "description": {"twee regels"},
254 })
255 if err != nil {
256 t.Fatal(err)
257 }
258 applied := read(t, res)
259 if !strings.Contains(applied, "Suggestions applied") {
260 t.Fatalf("toepassen:\n%s", applied)
261 }
262 body := mustGit(t, bare, "show", "feature:hello.txt")
263 if body != "alpha\nfixed\nGAMMA\n" {
264 t.Fatalf("bestand %q", body)
265 }
266 after := strings.TrimSpace(mustGit(t, bare, "rev-list", "--count", "feature"))
267 msg := mustGit(t, bare, "log", "-1", "--format=%s%n%b", "feature")
268 who := mustGit(t, bare, "log", "-1", "--format=%ae", "feature")
269 if after != bumpCount(before) || !strings.Contains(msg, "Suggestie van bob") || !strings.Contains(msg, "twee regels") || strings.TrimSpace(who) != "tim@users.git.timfalken.com" {
270 t.Fatalf("voor %s na %s\n%s", before, after, msg)
271 }
272}
273
274func bumpCount(n string) string {
275 i := 0
276 for _, c := range n {
277 i = i*10 + int(c-'0')
278 }
279 return strconvItoa(i + 1)
280}
281
282func strconvItoa(n int) string {
283 if n == 0 {
284 return "0"
285 }
286 var b [16]byte
287 i := len(b)
288 for n > 0 {
289 i--
290 b[i] = byte('0' + n%10)
291 n /= 10
292 }
293 return string(b[i:])
294}
295
296func clientAs(t *testing.T, base string, st *store.Store, userID int64) *http.Client {
297 t.Helper()
298 sess, err := st.CreateSession(context.Background(), userID, "dev", time.Now().Add(time.Hour))
299 if err != nil {
300 t.Fatal(err)
301 }
302 jar, _ := cookiejar.New(nil)
303 u, _ := url.Parse(base)
304 jar.SetCookies(u, []*http.Cookie{{Name: "bluegit_session", Value: sess.ID, Path: "/"}})
305 return &http.Client{Jar: jar}
306}
307
308func mustGit(t *testing.T, dir string, args ...string) string {
309 t.Helper()
310 out, err := gitOut(dir, args...)
311 if err != nil {
312 t.Fatalf("git %s: %v\n%s", strings.Join(args, " "), err, out)
313 }
314 return out
315}
316
317func mustGet(t *testing.T, c *http.Client, raw string) *http.Response {
318 t.Helper()
319 res, err := c.Get(raw)
320 if err != nil {
321 t.Fatal(err)
322 }
323 return res
324}
325
326func suggestionIDs(html string) []string {
327 var out []string
328 const needle = `data-suggestion="`
329 for {
330 i := strings.Index(html, needle)
331 if i < 0 {
332 break
333 }
334 html = html[i+len(needle):]
335 j := strings.Index(html, `"`)
336 out = append(out, html[:j])
337 html = html[j:]
338 }
339 return out
340}