| 1 | package server |
| 2 | |
| 3 | import ( |
| 4 | "bytes" |
| 5 | "encoding/json" |
| 6 | "net/http" |
| 7 | "net/http/httptest" |
| 8 | "net/url" |
| 9 | "os" |
| 10 | "path/filepath" |
| 11 | "regexp" |
| 12 | "strings" |
| 13 | "testing" |
| 14 | "time" |
| 15 | |
| 16 | "gitlab.com/Timfa/bluegit/internal/backupserver/config" |
| 17 | "gitlab.com/Timfa/bluegit/internal/backupserver/protocol" |
| 18 | ) |
| 19 | |
| 20 | // uiClient is een browser met een cookie. |
| 21 | type uiClient struct { |
| 22 | t *testing.T |
| 23 | h http.Handler |
| 24 | cookie *http.Cookie |
| 25 | } |
| 26 | |
| 27 | func (c *uiClient) do(method, p string, form url.Values) *httptest.ResponseRecorder { |
| 28 | var body *strings.Reader |
| 29 | if form != nil { |
| 30 | body = strings.NewReader(form.Encode()) |
| 31 | } else { |
| 32 | body = strings.NewReader("") |
| 33 | } |
| 34 | r := httptest.NewRequest(method, p, body) |
| 35 | if form != nil { |
| 36 | r.Header.Set("Content-Type", "application/x-www-form-urlencoded") |
| 37 | } |
| 38 | if c.cookie != nil { |
| 39 | r.AddCookie(c.cookie) |
| 40 | } |
| 41 | w := httptest.NewRecorder() |
| 42 | c.h.ServeHTTP(w, r) |
| 43 | for _, ck := range w.Result().Cookies() { |
| 44 | if ck.Name == sessionCookie { |
| 45 | c.cookie = ck |
| 46 | } |
| 47 | } |
| 48 | return w |
| 49 | } |
| 50 | |
| 51 | var csrfRE = regexp.MustCompile(`name="csrf" value="([0-9a-f]+)"`) |
| 52 | |
| 53 | func login(t *testing.T, s *Server) (*uiClient, string) { |
| 54 | c := &uiClient{t: t, h: s.Handler()} |
| 55 | if w := c.do("GET", "/", nil); w.Code != 303 || w.Header().Get("Location") != "/login" { |
| 56 | t.Fatalf("zonder sessie: %d %s", w.Code, w.Header().Get("Location")) |
| 57 | } |
| 58 | if w := c.do("POST", "/login", url.Values{"token": {"fout"}}); w.Header().Get("Location") != "/login?fout=1" { |
| 59 | t.Fatalf("fout token: %s", w.Header().Get("Location")) |
| 60 | } |
| 61 | if w := c.do("POST", "/login", url.Values{"token": {s.AdminToken()}}); w.Code != 303 || c.cookie == nil { |
| 62 | t.Fatalf("login %d", w.Code) |
| 63 | } |
| 64 | if !c.cookie.HttpOnly || c.cookie.SameSite != http.SameSiteStrictMode { |
| 65 | t.Fatalf("cookie %+v", c.cookie) |
| 66 | } |
| 67 | w := c.do("GET", "/", nil) |
| 68 | if w.Code != 200 { |
| 69 | t.Fatalf("index %d", w.Code) |
| 70 | } |
| 71 | m := csrfRE.FindStringSubmatch(w.Body.String()) |
| 72 | if m == nil { |
| 73 | t.Fatal("geen csrf") |
| 74 | } |
| 75 | return c, m[1] |
| 76 | } |
| 77 | |
| 78 | // Elke wijzigende actie heeft een formulier in de webinterface, elke |
| 79 | // beheerroute zit in Actions, en elk formulier hoort bij een actie. |
| 80 | func TestUIAndAPIParity(t *testing.T) { |
| 81 | f := newFake(t) |
| 82 | s := newTestServer(t) |
| 83 | if w := adminReq(s, "POST", "/api/v1/admin/connect", `{"url":"`+f.ts.URL+`","key":"bgbk_test"}`); w.Code != 200 { |
| 84 | t.Fatal(w.Body) |
| 85 | } |
| 86 | if _, err := s.SyncNow(t.Context()); err != nil { |
| 87 | t.Fatal(err) |
| 88 | } |
| 89 | if _, err := s.ArchiveNow(); err != nil { |
| 90 | t.Fatal(err) |
| 91 | } |
| 92 | c, _ := login(t, s) |
| 93 | page := c.do("GET", "/", nil).Body.String() |
| 94 | // Het koppelformulier staat in een uitklapper zodra er gekoppeld is; het |
| 95 | // moet er nog steeds zijn. |
| 96 | forms := map[string]bool{} |
| 97 | for _, m := range regexp.MustCompile(`action="/ui/act/([a-z.]+)"`).FindAllStringSubmatch(page, -1) { |
| 98 | forms[m[1]] = true |
| 99 | } |
| 100 | for _, a := range s.Actions() { |
| 101 | switch a.Method { |
| 102 | case "GET": |
| 103 | // Getoond op de pagina; download als link. |
| 104 | if a.Name == "archive.download" && !strings.Contains(page, "/download\">Downloaden") { |
| 105 | t.Errorf("geen downloadlink") |
| 106 | } |
| 107 | default: |
| 108 | if !forms[a.Name] { |
| 109 | t.Errorf("actie %s (%s %s) heeft geen formulier in de webinterface", a.Name, a.Method, a.Path) |
| 110 | } |
| 111 | delete(forms, a.Name) |
| 112 | } |
| 113 | } |
| 114 | for f := range forms { |
| 115 | t.Errorf("formulier %s hoort bij geen API-actie", f) |
| 116 | } |
| 117 | // Alle GET-acties geven hun gegevens ook op de pagina. |
| 118 | for _, want := range []string{"Overzicht", "Gesynchroniseerd", "cfg-archive_interval", "cfg-listen", "cfg-data_dir", "bluegit-", "/api/v1/admin/config"} { |
| 119 | if !strings.Contains(page, want) { |
| 120 | t.Errorf("pagina mist %q", want) |
| 121 | } |
| 122 | } |
| 123 | // De API geeft dezelfde actielijst. |
| 124 | w := adminReq(s, "GET", "/api/v1/admin/actions", "") |
| 125 | var al struct { |
| 126 | Actions []Action `json:"actions"` |
| 127 | } |
| 128 | _ = json.Unmarshal(w.Body.Bytes(), &al) |
| 129 | if len(al.Actions) != len(s.Actions()) { |
| 130 | t.Fatalf("actions %d", len(al.Actions)) |
| 131 | } |
| 132 | } |
| 133 | |
| 134 | func TestUISettingsAndCSRF(t *testing.T) { |
| 135 | s := newTestServer(t) |
| 136 | c, csrf := login(t, s) |
| 137 | form := url.Values{"csrf": {csrf}, "retention_days": {"9"}, "archive_interval": {"12h"}, "rate_limit_kib": {"300"}, "listen": {"127.0.0.1:9999"}} |
| 138 | if w := c.do("POST", "/ui/act/config.update", form); w.Code != 303 { |
| 139 | t.Fatalf("opslaan %d %s", w.Code, w.Body) |
| 140 | } |
| 141 | page := c.do("GET", "/", nil).Body.String() |
| 142 | if !strings.Contains(page, "Instellingen opgeslagen") { |
| 143 | t.Fatalf("melding ontbreekt") |
| 144 | } |
| 145 | if strings.Contains(page, "pas na een herstart") { |
| 146 | t.Fatalf("herstart-melding hoort weg te zijn: %s", page) |
| 147 | } |
| 148 | cv := s.ConfigView() |
| 149 | get := func(k string) string { |
| 150 | for _, f := range cv.Fields { |
| 151 | if f.Key == k { |
| 152 | return f.Value |
| 153 | } |
| 154 | } |
| 155 | return "" |
| 156 | } |
| 157 | if get("retention_days") != "9" || get("archive_interval") != "12h" || get("listen") != "127.0.0.1:9999" || cv.Restart { |
| 158 | t.Fatalf("%+v", cv) |
| 159 | } |
| 160 | if s.limiter.Rate() != 300<<10 { |
| 161 | t.Fatalf("rate %d", s.limiter.Rate()) |
| 162 | } |
| 163 | if s.cfg().Listen != "127.0.0.1:9999" { |
| 164 | t.Fatal("listen hoort meteen te gelden") |
| 165 | } |
| 166 | if !strings.Contains(page, "cfg-data_dir") || !strings.Contains(page, "Gegevensmap") { |
| 167 | t.Fatalf("data_dir niet zichtbaar") |
| 168 | } |
| 169 | if !strings.Contains(page, s.AdminToken()) { |
| 170 | t.Fatal("beheertoken ontbreekt op de pagina") |
| 171 | } |
| 172 | if !strings.Contains(page, `placeholder="http://192.168.1.50:8080"`) { |
| 173 | t.Fatal("IP-voorbeeld ontbreekt bij public_url") |
| 174 | } |
| 175 | if !strings.Contains(page, `name="on_conflict" value="wipe"`) || !strings.Contains(page, `name="on_conflict" value="restore"`) || !strings.Contains(page, `name="url"`) || !strings.Contains(page, `name="key"`) { |
| 176 | t.Fatal("koppelingsformulier incompleet") |
| 177 | } |
| 178 | // Bewaard: een nieuwe server leest het. |
| 179 | s2, err := New(s.Cfg, nil) |
| 180 | if err != nil { |
| 181 | t.Fatal(err) |
| 182 | } |
| 183 | if s2.cfg().RetentionDays != 9 || s2.cfg().Listen != "127.0.0.1:9999" { |
| 184 | t.Fatalf("na herstart %+v", s2.cfg()) |
| 185 | } |
| 186 | // Zonder of met fout CSRF-token: geweigerd. |
| 187 | if w := c.do("POST", "/ui/act/config.update", url.Values{"retention_days": {"1"}}); w.Code != 403 { |
| 188 | t.Fatalf("zonder csrf %d", w.Code) |
| 189 | } |
| 190 | // Ongeldige waarde: foutmelding, niets veranderd. |
| 191 | c.do("POST", "/ui/act/config.update", url.Values{"csrf": {csrf}, "retention_days": {"-1"}}) |
| 192 | if !strings.Contains(c.do("GET", "/", nil).Body.String(), "mislukt") || s.cfg().RetentionDays != 9 { |
| 193 | t.Fatal("ongeldige waarde") |
| 194 | } |
| 195 | // API met sessiecookie vraagt X-CSRF-Token. |
| 196 | r := httptest.NewRequest("PUT", "/api/v1/admin/config", strings.NewReader(`{"retention_days":3}`)) |
| 197 | r.AddCookie(c.cookie) |
| 198 | w := httptest.NewRecorder() |
| 199 | s.Handler().ServeHTTP(w, r) |
| 200 | if w.Code != 403 { |
| 201 | t.Fatalf("cookie zonder csrf-header %d", w.Code) |
| 202 | } |
| 203 | r = httptest.NewRequest("PUT", "/api/v1/admin/config", strings.NewReader(`{"retention_days":3}`)) |
| 204 | r.AddCookie(c.cookie) |
| 205 | r.Header.Set("X-CSRF-Token", csrf) |
| 206 | w = httptest.NewRecorder() |
| 207 | s.Handler().ServeHTTP(w, r) |
| 208 | if w.Code != 200 || s.cfg().RetentionDays != 3 { |
| 209 | t.Fatalf("cookie met csrf-header %d %s", w.Code, w.Body) |
| 210 | } |
| 211 | // Uitloggen. |
| 212 | c.do("POST", "/logout", url.Values{"csrf": {csrf}}) |
| 213 | if w := c.do("GET", "/", nil); w.Code != 303 { |
| 214 | t.Fatalf("na uitloggen %d", w.Code) |
| 215 | } |
| 216 | // Webinterface mag niet in een iframe van een ander. |
| 217 | if h := c.do("GET", "/login", nil).Header(); h.Get("X-Frame-Options") != "DENY" { |
| 218 | t.Fatal("frame") |
| 219 | } |
| 220 | } |
| 221 | |
| 222 | func TestLoginRateLimit(t *testing.T) { |
| 223 | s := newTestServer(t) |
| 224 | c := &uiClient{t: t, h: s.Handler()} |
| 225 | for i := 0; i < 5; i++ { |
| 226 | c.do("POST", "/login", url.Values{"token": {"fout"}}) |
| 227 | } |
| 228 | if w := c.do("POST", "/login", url.Values{"token": {s.AdminToken()}}); w.Code != 429 { |
| 229 | t.Fatalf("na 5 fouten %d", w.Code) |
| 230 | } |
| 231 | } |
| 232 | |
| 233 | func TestAPIConfig(t *testing.T) { |
| 234 | s := newTestServer(t) |
| 235 | w := adminReq(s, "PUT", "/api/v1/admin/config", `{"min_free_mb":2048,"full_sync_interval":"30m"}`) |
| 236 | if w.Code != 200 { |
| 237 | t.Fatalf("%d %s", w.Code, w.Body) |
| 238 | } |
| 239 | if s.cfg().MinFreeMB != 2048 || s.cfg().FullSyncInterval.Duration != 30*time.Minute { |
| 240 | t.Fatalf("%+v", s.cfg()) |
| 241 | } |
| 242 | if _, err := os.Stat(filepath.Join(s.Cfg.DataDir, config.SettingsFile)); err != nil { |
| 243 | t.Fatal(err) |
| 244 | } |
| 245 | for _, body := range []string{`{"data_dir":"/tmp"}`, `{"onbekend":1}`, `{"archive_interval":"0s"}`, `{}`, `[1]`} { |
| 246 | if w := adminReq(s, "PUT", "/api/v1/admin/config", body); w.Code != 400 { |
| 247 | t.Errorf("%s: %d", body, w.Code) |
| 248 | } |
| 249 | } |
| 250 | w = adminReq(s, "GET", "/api/v1/admin/config", "") |
| 251 | var cv ConfigView |
| 252 | _ = json.Unmarshal(w.Body.Bytes(), &cv) |
| 253 | if len(cv.Fields) != len(config.Fields) { |
| 254 | t.Fatalf("%s", w.Body) |
| 255 | } |
| 256 | } |
| 257 | |
| 258 | func TestSignedAdminActions(t *testing.T) { |
| 259 | f := newFake(t) |
| 260 | s := newTestServer(t) |
| 261 | if w := adminReq(s, "POST", "/api/v1/admin/connect", `{"url":"`+f.ts.URL+`","key":"bgbk_test"}`); w.Code != 200 { |
| 262 | t.Fatal(w.Body) |
| 263 | } |
| 264 | good := protocol.SigningSecret("bgbk_test") |
| 265 | call := func(method, p, body string) *httptest.ResponseRecorder { |
| 266 | r := httptest.NewRequest(method, p, bytes.NewReader([]byte(body))) |
| 267 | protocol.Sign(r, good, "inst-1", []byte(body), time.Now()) |
| 268 | w := httptest.NewRecorder() |
| 269 | s.Handler().ServeHTTP(w, r) |
| 270 | return w |
| 271 | } |
| 272 | if w := call("PUT", "/api/v1/admin/config", `{"retention_days":"4"}`); w.Code != 200 || s.cfg().RetentionDays != 4 { |
| 273 | t.Fatalf("config via BlueGit %d %s", w.Code, w.Body) |
| 274 | } |
| 275 | if w := call("GET", "/api/v1/admin/config", ""); w.Code != 200 { |
| 276 | t.Fatalf("config lezen %d", w.Code) |
| 277 | } |
| 278 | if w := call("POST", "/api/v1/admin/connect", `{}`); w.Code != 403 { |
| 279 | t.Fatalf("connect via BlueGit %d", w.Code) |
| 280 | } |
| 281 | if w := call("POST", "/api/v1/admin/rollback", `{"archive":"bluegit-20261115-120000.tar.gz"}`); w.Code != 400 { |
| 282 | t.Fatalf("rollback zonder confirm %d", w.Code) |
| 283 | } |
| 284 | // Handtekening over een ander pad: geweigerd. |
| 285 | r := httptest.NewRequest("POST", "/api/v1/admin/sync", nil) |
| 286 | protocol.Sign(r, good, "inst-1", nil, time.Now()) |
| 287 | r.URL.Path = "/api/v1/admin/disconnect" |
| 288 | w := httptest.NewRecorder() |
| 289 | s.Handler().ServeHTTP(w, r) |
| 290 | if w.Code != 401 { |
| 291 | t.Fatalf("ander pad %d", w.Code) |
| 292 | } |
| 293 | if w := call("POST", "/api/v1/admin/disconnect", ``); w.Code != 200 || s.getState().Connected() { |
| 294 | t.Fatalf("disconnect %d", w.Code) |
| 295 | } |
| 296 | // Ontkoppeld: BlueGit kan niets meer. |
| 297 | if w := call("GET", "/api/v1/admin/status", ""); w.Code != 401 { |
| 298 | t.Fatalf("na ontkoppelen %d", w.Code) |
| 299 | } |
| 300 | } |