BlueGit

timfa bluegit

Files

bluegit / internal / config / runtime_test.go

runtime_test.go

runtime_test.go 7.8 KiB Download Raw
1package config
2
3import (
4 "bytes"
5 "io"
6 "log/slog"
7 "os"
8 "path/filepath"
9 "strings"
10 "testing"
11)
12
13func writeUpgradeFixture(t *testing.T) (configPath, stateDir, secretPath string, raw []byte) {
14 t.Helper()
15 root := t.TempDir()
16 stateDir = filepath.Join(root, "state")
17 if err := os.MkdirAll(stateDir, 0o750); err != nil {
18 t.Fatal(err)
19 }
20 secretPath = filepath.Join(root, "client_secret")
21 if err := os.WriteFile(secretPath, []byte("het-geheim\n"), 0o600); err != nil {
22 t.Fatal(err)
23 }
24 configPath = filepath.Join(root, "etc", "config.yml")
25 if err := os.MkdirAll(filepath.Dir(configPath), 0o755); err != nil {
26 t.Fatal(err)
27 }
28 raw = []byte(`base_url: https://git.example.test
29listen: 127.0.0.1:9090
30state_path: ` + stateDir + `
31trusted_proxies:
32 - 10.0.0.2
33auth:
34 mode: oauth
35 client_id: git.example.test
36 client_secret: ""
37 client_secret_file: ` + secretPath + `
38ssh:
39 enabled: true
40 listen: 127.0.0.1:2222
41 public_host: git.example.test
42 public_port: 22
43ci:
44 enabled: true
45 concurrency: 2
46`)
47 if err := os.WriteFile(configPath, raw, 0o644); err != nil {
48 t.Fatal(err)
49 }
50 return configPath, stateDir, secretPath, raw
51}
52
53func TestUpgradePathLeavesConfigYmlUnchanged(t *testing.T) {
54 configPath, stateDir, _, raw := writeUpgradeFixture(t)
55 silent := slog.New(slog.NewTextHandler(io.Discard, nil))
56
57 rt, err := LoadRuntime(configPath, silent)
58 if err != nil {
59 t.Fatal(err)
60 }
61 if !rt.Imported {
62 t.Fatal("eerste start hoort config.yml te importeren")
63 }
64 if rt.Config.Auth.ClientSecret != "het-geheim" {
65 t.Fatalf("geheim: %q", rt.Config.Auth.ClientSecret)
66 }
67 if rt.Config.Listen != "127.0.0.1:9090" || rt.Config.CI.Concurrency != 2 {
68 t.Fatalf("waarden: %+v", rt.Config)
69 }
70 after, err := os.ReadFile(configPath)
71 if err != nil {
72 t.Fatal(err)
73 }
74 if !bytes.Equal(after, raw) {
75 t.Fatalf("config.yml is gewijzigd:\n%s", after)
76 }
77 if _, err := os.Stat(filepath.Join(stateDir, SettingsFile)); err != nil {
78 t.Fatal("settings.yml ontbreekt")
79 }
80 if _, err := os.Stat(filepath.Join(stateDir, ImportMarker)); err != nil {
81 t.Fatal("marker ontbreekt")
82 }
83
84 // Tweede start: geen tweede import, ook niet als config.yml verandert.
85 changed := bytes.Replace(raw, []byte("127.0.0.1:9090"), []byte("127.0.0.1:9191"), 1)
86 if err := os.WriteFile(configPath, changed, 0o644); err != nil {
87 t.Fatal(err)
88 }
89 rt2, err := LoadRuntime(configPath, silent)
90 if err != nil {
91 t.Fatal(err)
92 }
93 if rt2.Imported {
94 t.Fatal("tweede start mag niet opnieuw importeren")
95 }
96 if rt2.Config.Listen != "127.0.0.1:9090" {
97 t.Fatalf("settings moeten winnen, got %s", rt2.Config.Listen)
98 }
99 after, _ = os.ReadFile(configPath)
100 if !bytes.Equal(after, changed) {
101 t.Fatal("tweede start mag config.yml niet terugschrijven")
102 }
103}
104
105func TestSettingsOverlayWinsAndEnvWinsLast(t *testing.T) {
106 configPath, stateDir, _, _ := writeUpgradeFixture(t)
107 silent := slog.New(slog.NewTextHandler(io.Discard, nil))
108 if _, err := LoadRuntime(configPath, silent); err != nil {
109 t.Fatal(err)
110 }
111 st, err := LoadSettings(stateDir)
112 if err != nil || st == nil {
113 t.Fatal(err)
114 }
115 st.Listen = ptr("127.0.0.1:9400")
116 st.BaseURL = ptr("https://over.example.test")
117 if err := SaveSettings(stateDir, *st); err != nil {
118 t.Fatal(err)
119 }
120 t.Setenv("BLUEGIT_LISTEN", "127.0.0.1:9500")
121 rt, err := LoadRuntime(configPath, silent)
122 if err != nil {
123 t.Fatal(err)
124 }
125 if rt.Config.BaseURL != "https://over.example.test" {
126 t.Fatalf("overlay base_url: %s", rt.Config.BaseURL)
127 }
128 if rt.Config.Listen != "127.0.0.1:9500" {
129 t.Fatalf("env moet winnen: %s", rt.Config.Listen)
130 }
131}
132
133func TestCorruptSettingsFallBackToConfigYml(t *testing.T) {
134 configPath, stateDir, _, _ := writeUpgradeFixture(t)
135 silent := slog.New(slog.NewTextHandler(io.Discard, nil))
136 if _, err := LoadRuntime(configPath, silent); err != nil {
137 t.Fatal(err)
138 }
139 bad := filepath.Join(stateDir, SettingsFile)
140 if err := os.WriteFile(bad, []byte(":::: geen yaml"), 0o600); err != nil {
141 t.Fatal(err)
142 }
143 rt, err := LoadRuntime(configPath, silent)
144 if err != nil {
145 t.Fatalf("moet starten op config.yml: %v", err)
146 }
147 if rt.Config.Listen != "127.0.0.1:9090" || rt.Config.Auth.ClientSecret != "het-geheim" {
148 t.Fatalf("terugval mislukt: %+v", rt.Config)
149 }
150}
151
152func TestInvalidSettingsValuesFallBack(t *testing.T) {
153 configPath, stateDir, _, _ := writeUpgradeFixture(t)
154 silent := slog.New(slog.NewTextHandler(io.Discard, nil))
155 if _, err := LoadRuntime(configPath, silent); err != nil {
156 t.Fatal(err)
157 }
158 st, err := LoadSettings(stateDir)
159 if err != nil {
160 t.Fatal(err)
161 }
162 st.BaseURL = ptr("niet-een-url")
163 if err := SaveSettings(stateDir, *st); err != nil {
164 t.Fatal(err)
165 }
166 rt, err := LoadRuntime(configPath, silent)
167 if err != nil {
168 t.Fatalf("ongeldige settings mogen de start niet breken: %v", err)
169 }
170 if rt.Config.BaseURL != "https://git.example.test" {
171 t.Fatalf("terugval base_url: %s", rt.Config.BaseURL)
172 }
173}
174
175func TestSecretFileFallbackWhenSettingsHaveNoSecret(t *testing.T) {
176 configPath, stateDir, secretPath, _ := writeUpgradeFixture(t)
177 silent := slog.New(slog.NewTextHandler(io.Discard, nil))
178 if _, err := LoadRuntime(configPath, silent); err != nil {
179 t.Fatal(err)
180 }
181 st, err := LoadSettings(stateDir)
182 if err != nil {
183 t.Fatal(err)
184 }
185 st.Auth.ClientSecret = nil
186 if err := SaveSettings(stateDir, *st); err != nil {
187 t.Fatal(err)
188 }
189 if err := os.WriteFile(secretPath, []byte("nieuw-geheim\n"), 0o600); err != nil {
190 t.Fatal(err)
191 }
192 rt, err := LoadRuntime(configPath, silent)
193 if err != nil {
194 t.Fatal(err)
195 }
196 if rt.Config.Auth.ClientSecret != "nieuw-geheim" {
197 t.Fatalf("bestand als terugval: %q", rt.Config.Auth.ClientSecret)
198 }
199}
200
201func TestLoadRuntimeSameAsLoadWhenNoSettingsYet(t *testing.T) {
202 // Zonder schrijfrechten op state_path kan import falen; LoadRuntime
203 // moet dan nog steeds hetzelfde resultaat geven als Load.
204 configPath, stateDir, _, _ := writeUpgradeFixture(t)
205 // Maak state_path alleen-lezen nádat hij bestaat, zodat import faalt.
206 if err := os.Chmod(stateDir, 0o500); err != nil {
207 t.Fatal(err)
208 }
209 t.Cleanup(func() { _ = os.Chmod(stateDir, 0o750) })
210 silent := slog.New(slog.NewTextHandler(io.Discard, nil))
211 want, err := Load(configPath)
212 if err != nil {
213 t.Fatal(err)
214 }
215 rt, err := LoadRuntime(configPath, silent)
216 if err != nil {
217 t.Fatal(err)
218 }
219 if rt.Imported {
220 t.Fatal("import hoort te falen op een alleen-lezen state_path")
221 }
222 if rt.Config.Listen != want.Listen || rt.Config.Auth.ClientSecret != want.Auth.ClientSecret || rt.Config.BaseURL != want.BaseURL {
223 t.Fatalf("LoadRuntime != Load: %+v vs %+v", rt.Config, want)
224 }
225}
226
227func TestMergeUpdateKeepsSecretWhenLeftBlank(t *testing.T) {
228 cur := Config{BaseURL: "https://git.example.test", Listen: "127.0.0.1:8080", StatePath: t.TempDir()}
229 cur.Auth = Auth{Mode: "oauth", ClientID: "id", ClientSecret: "old-secret", BaseURL: "https://auth.example"}
230 cur.applyDefaults()
231 next, saved := MergeUpdate(cur, Persisted{
232 Listen: ptr("127.0.0.1:8081"),
233 Auth: &PersistedAuth{ClientSecret: ptr("")},
234 })
235 if next.Listen != "127.0.0.1:8081" {
236 t.Fatal(next.Listen)
237 }
238 if next.Auth.ClientSecret != "old-secret" {
239 t.Fatalf("geheim gewist: %q", next.Auth.ClientSecret)
240 }
241 if saved.Auth == nil || saved.Auth.ClientSecret == nil || *saved.Auth.ClientSecret != "old-secret" {
242 t.Fatal("opgeslagen geheim ontbreekt")
243 }
244}
245
246func TestImportIsIdempotentWithMarkerOnly(t *testing.T) {
247 configPath, stateDir, _, _ := writeUpgradeFixture(t)
248 if err := os.WriteFile(filepath.Join(stateDir, ImportMarker), nil, 0o640); err != nil {
249 t.Fatal(err)
250 }
251 silent := slog.New(slog.NewTextHandler(io.Discard, nil))
252 rt, err := LoadRuntime(configPath, silent)
253 if err != nil {
254 t.Fatal(err)
255 }
256 if rt.Imported {
257 t.Fatal("marker zonder settings.yml: niet opnieuw importeren")
258 }
259 if _, err := os.Stat(filepath.Join(stateDir, SettingsFile)); err == nil {
260 t.Fatal("er had geen settings.yml mogen ontstaan")
261 }
262 if !strings.HasPrefix(rt.Config.Listen, "127.0.0.1:9090") {
263 t.Fatalf("config.yml als terugval: %s", rt.Config.Listen)
264 }
265}