| 1 | package server |
| 2 | |
| 3 | import ( |
| 4 | "encoding/json" |
| 5 | "net/http" |
| 6 | "net/url" |
| 7 | "os" |
| 8 | "path/filepath" |
| 9 | "strings" |
| 10 | "testing" |
| 11 | |
| 12 | "gitlab.com/Timfa/bluegit/internal/config" |
| 13 | ) |
| 14 | |
| 15 | func TestAdminSettingsRequiresAdminAndHidesSecret(t *testing.T) { |
| 16 | e := newCIEnv(t) |
| 17 | state := t.TempDir() |
| 18 | e.srv.StateDir = state |
| 19 | e.srv.Cfg.StatePath = state |
| 20 | e.srv.Cfg.Auth.ClientSecret = "supergeheim" |
| 21 | e.srv.Cfg.Auth.ClientID = "git.example.test" |
| 22 | e.srv.ConfigPath = "/etc/bluegit/config.yml" |
| 23 | |
| 24 | ctx := e.st |
| 25 | bob, _ := ctx.UpsertUser(t.Context(), 2, "bob", "", false) |
| 26 | bc, _ := sessionClient(t, ctx, e.ts.URL, bob.ID) |
| 27 | res, _ := bc.Get(e.ts.URL + "/admin/settings") |
| 28 | if res.StatusCode != http.StatusForbidden { |
| 29 | t.Fatalf("bob ui: %d", res.StatusCode) |
| 30 | } |
| 31 | res.Body.Close() |
| 32 | bobTok := issue(t, ctx, bob.ID, "api") |
| 33 | if code, _ := rapi(t, e.ts.URL, bobTok, "GET", "/admin/settings", nil); code != http.StatusForbidden { |
| 34 | t.Fatalf("bob api: %d", code) |
| 35 | } |
| 36 | |
| 37 | tc, tcsrf := sessionClient(t, ctx, e.ts.URL, e.user.ID) |
| 38 | res, _ = tc.Get(e.ts.URL + "/admin/settings") |
| 39 | page := body(t, res) |
| 40 | if res.StatusCode != 200 { |
| 41 | t.Fatalf("admin page %d: %.300s", res.StatusCode, page) |
| 42 | } |
| 43 | if !strings.Contains(page, `name="base_url"`) || !strings.Contains(page, `name="auth.client_secret"`) { |
| 44 | t.Fatalf("form ontbreekt: %.400s", page) |
| 45 | } |
| 46 | if strings.Contains(page, "supergeheim") { |
| 47 | t.Fatal("clientgeheim stond in de HTML") |
| 48 | } |
| 49 | if !strings.Contains(page, "admin.tab.settings") && !strings.Contains(page, "Instellingen") && !strings.Contains(page, "Settings") { |
| 50 | // tab label is vertaald |
| 51 | if !strings.Contains(page, `href="/admin/settings"`) { |
| 52 | t.Fatal("tab instellingen ontbreekt") |
| 53 | } |
| 54 | } |
| 55 | |
| 56 | adminTok := issue(t, ctx, e.user.ID, "api") |
| 57 | code, raw := rapi(t, e.ts.URL, adminTok, "GET", "/admin/settings", nil) |
| 58 | if code != 200 { |
| 59 | t.Fatalf("GET settings %d %s", code, raw) |
| 60 | } |
| 61 | if strings.Contains(string(raw), "supergeheim") { |
| 62 | t.Fatal("geheim in de API") |
| 63 | } |
| 64 | var got map[string]any |
| 65 | if err := json.Unmarshal([]byte(raw), &got); err != nil { |
| 66 | t.Fatal(err) |
| 67 | } |
| 68 | auth := got["auth"].(map[string]any) |
| 69 | if auth["client_secret_set"] != true { |
| 70 | t.Fatalf("secret_set: %v", auth) |
| 71 | } |
| 72 | if _, ok := auth["client_secret"]; ok { |
| 73 | t.Fatal("client_secret-veld hoort niet in de JSON") |
| 74 | } |
| 75 | |
| 76 | // Leeg geheim houdt het oude; andere velden wijzigen. |
| 77 | code, raw = rapi(t, e.ts.URL, adminTok, "PUT", "/admin/settings", map[string]any{ |
| 78 | "listen": "127.0.0.1:9199", |
| 79 | "auth": map[string]any{"client_secret": ""}, |
| 80 | }) |
| 81 | if code != 200 { |
| 82 | t.Fatalf("PUT %d %s", code, raw) |
| 83 | } |
| 84 | if e.srv.Cfg.Auth.ClientSecret != "supergeheim" { |
| 85 | t.Fatalf("geheim gewist: %q", e.srv.Cfg.Auth.ClientSecret) |
| 86 | } |
| 87 | if e.srv.Cfg.Listen != "127.0.0.1:9199" { |
| 88 | t.Fatalf("listen: %s", e.srv.Cfg.Listen) |
| 89 | } |
| 90 | saved, err := os.ReadFile(filepath.Join(state, config.SettingsFile)) |
| 91 | if err != nil { |
| 92 | t.Fatal(err) |
| 93 | } |
| 94 | if !strings.Contains(string(saved), "supergeheim") { |
| 95 | t.Fatal("settings.yml mist het geheim") |
| 96 | } |
| 97 | if strings.Contains(string(raw), "supergeheim") { |
| 98 | t.Fatal("PUT-antwoord lekte het geheim") |
| 99 | } |
| 100 | |
| 101 | // CSRF: POST zonder token wordt geweigerd. |
| 102 | res, _ = tc.PostForm(e.ts.URL+"/admin/settings", url.Values{"base_url": {e.srv.Cfg.BaseURL}}) |
| 103 | if res.StatusCode != http.StatusBadRequest && res.StatusCode != http.StatusForbidden { |
| 104 | t.Fatalf("zonder csrf: %d", res.StatusCode) |
| 105 | } |
| 106 | res.Body.Close() |
| 107 | res, _ = tc.PostForm(e.ts.URL+"/admin/settings", url.Values{ |
| 108 | "csrf": {tcsrf}, "base_url": {e.srv.Cfg.BaseURL}, "listen": {"127.0.0.1:9200"}, |
| 109 | "auth.mode": {"dev"}, "auth.client_id": {"git.example.test"}, "auth.client_secret": {""}, |
| 110 | }) |
| 111 | loc := res.Header.Get("Location") |
| 112 | res.Body.Close() |
| 113 | if res.StatusCode/100 != 3 { |
| 114 | t.Fatalf("POST settings %d %s", res.StatusCode, loc) |
| 115 | } |
| 116 | if e.srv.Cfg.Listen != "127.0.0.1:9200" { |
| 117 | t.Fatalf("na POST listen %s", e.srv.Cfg.Listen) |
| 118 | } |
| 119 | } |
| 120 | |
| 121 | func TestAdminCreatesUserTokenOnce(t *testing.T) { |
| 122 | e := newCIEnv(t) |
| 123 | bob, _ := e.st.UpsertUser(t.Context(), 2, "bob", "", false) |
| 124 | tc, tcsrf := sessionClient(t, e.st, e.ts.URL, e.user.ID) |
| 125 | res, _ := tc.PostForm(e.ts.URL+"/admin/users/token", url.Values{ |
| 126 | "csrf": {tcsrf}, "id": {itoa(bob.ID)}, "name": {"laptop"}, |
| 127 | }) |
| 128 | res.Body.Close() |
| 129 | if res.StatusCode/100 != 3 { |
| 130 | t.Fatalf("token post %d", res.StatusCode) |
| 131 | } |
| 132 | res, _ = tc.Get(e.ts.URL + "/admin/users") |
| 133 | page := body(t, res) |
| 134 | if !strings.Contains(page, "class=\"code\"") && !strings.Contains(page, "bgpat_") && !strings.Contains(page, "bgt_") { |
| 135 | // token prefix may vary; at least the once-block or a long token-like string |
| 136 | if !strings.Contains(page, "token") && !strings.Contains(page, "Token") && !strings.Contains(page, "een keer") && !strings.Contains(page, "only once") && !strings.Contains(page, "einmal") { |
| 137 | t.Fatalf("token niet getoond: %.500s", page) |
| 138 | } |
| 139 | } |
| 140 | |
| 141 | adminTok := issue(t, e.st, e.user.ID, "api") |
| 142 | code, raw := rapi(t, e.ts.URL, adminTok, "POST", "/admin/users/bob/tokens", map[string]any{"name": "ci"}) |
| 143 | if code != http.StatusCreated { |
| 144 | t.Fatalf("api token %d %s", code, raw) |
| 145 | } |
| 146 | var out map[string]any |
| 147 | if err := json.Unmarshal([]byte(raw), &out); err != nil { |
| 148 | t.Fatal(err) |
| 149 | } |
| 150 | tok, _ := out["token"].(string) |
| 151 | if tok == "" { |
| 152 | t.Fatalf("geen token in antwoord: %s", raw) |
| 153 | } |
| 154 | bobTok := issue(t, e.st, bob.ID, "nope") |
| 155 | if code, _ = rapi(t, e.ts.URL, bobTok, "POST", "/admin/users/tim/tokens", map[string]any{"name": "x"}); code != http.StatusForbidden { |
| 156 | t.Fatalf("bob maakt token: %d", code) |
| 157 | } |
| 158 | } |
| 159 | |
| 160 | func TestDevModeRejectedForProductionHost(t *testing.T) { |
| 161 | e := newCIEnv(t) |
| 162 | e.srv.StateDir = t.TempDir() |
| 163 | e.srv.Cfg.StatePath = e.srv.StateDir |
| 164 | e.srv.Cfg.BaseURL = "https://git.timfalken.com" |
| 165 | adminTok := issue(t, e.st, e.user.ID, "api") |
| 166 | code, raw := rapi(t, e.ts.URL, adminTok, "PUT", "/admin/settings", map[string]any{ |
| 167 | "auth": map[string]any{"mode": "dev"}, |
| 168 | }) |
| 169 | if code == 200 { |
| 170 | t.Fatalf("dev op git.timfalken.com moest falen: %s", raw) |
| 171 | } |
| 172 | } |